[INFO] crate gluon_codegen 0.9.4 is already in cache [INFO] extracting crate gluon_codegen 0.9.4 into work/ex/clippy-test-run/sources/stable/reg/gluon_codegen/0.9.4 [INFO] extracting crate gluon_codegen 0.9.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gluon_codegen/0.9.4 [INFO] validating manifest of gluon_codegen-0.9.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gluon_codegen-0.9.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gluon_codegen-0.9.4 [INFO] finished frobbing gluon_codegen-0.9.4 [INFO] frobbed toml for gluon_codegen-0.9.4 written to work/ex/clippy-test-run/sources/stable/reg/gluon_codegen/0.9.4/Cargo.toml [INFO] started frobbing gluon_codegen-0.9.4 [INFO] finished frobbing gluon_codegen-0.9.4 [INFO] frobbed toml for gluon_codegen-0.9.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gluon_codegen/0.9.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded gluon v0.10.1 [INFO] [stderr] Downloaded gluon_check v0.10.1 [INFO] [stderr] Downloaded gluon_base v0.10.1 [INFO] [stderr] Downloaded gluon_parser v0.10.1 [INFO] [stderr] Downloaded gluon_vm v0.10.1 [INFO] [stderr] Downloaded gluon_codegen v0.10.1 [INFO] [stderr] Downloaded gluon_format v0.10.1 [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gluon_codegen-0.9.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gluon_codegen/0.9.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5382afbdad215e359d570948becb0d39908a7c46ee18e428deaddcd7e2a654b9 [INFO] running `"docker" "start" "-a" "5382afbdad215e359d570948becb0d39908a7c46ee18e428deaddcd7e2a654b9"` [INFO] [stderr] Compiling byte-tools v0.3.1 [INFO] [stderr] Compiling either v1.5.0 [INFO] [stderr] Compiling opaque-debug v0.2.2 [INFO] [stderr] Compiling lalrpop-util v0.16.3 [INFO] [stderr] Compiling typed-arena v1.4.1 [INFO] [stderr] Checking anymap v0.12.1 [INFO] [stderr] Checking collect-mac v0.1.0 [INFO] [stderr] Compiling gluon_vm v0.10.1 [INFO] [stderr] Checking union-find v0.3.2 [INFO] [stderr] Checking frunk_core v0.2.2 [INFO] [stderr] Checking itertools v0.8.0 [INFO] [stderr] Checking pretty v0.5.2 [INFO] [stderr] Compiling block-padding v0.1.3 [INFO] [stderr] Compiling itertools v0.7.11 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling ena v0.11.0 [INFO] [stderr] Compiling serde v1.0.85 [INFO] [stderr] Checking serde_state v0.4.4 [INFO] [stderr] Compiling ordered-float v1.0.1 [INFO] [stderr] Checking serde_json v1.0.37 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling block-buffer v0.7.2 [INFO] [stderr] Compiling gluon_codegen v0.10.1 [INFO] [stderr] Compiling gluon_codegen v0.9.4 (/opt/crater/workdir) [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/getable.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | tokens.into() [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `tokens` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/getable.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / match (&first, &second) { [INFO] [stderr] 88 | | (Some(field_ty), None) => { [INFO] [stderr] 89 | | return quote! { [INFO] [stderr] 90 | | #ident ( [INFO] [stderr] ... | [INFO] [stderr] 95 | | _ => (), [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 87 | if let (Some(field_ty), None) = (&first, &second) { [INFO] [stderr] 88 | return quote! { [INFO] [stderr] 89 | #ident ( [INFO] [stderr] 90 | <#field_ty as _gluon_api::Getable<'__vm, '__value>>::from_value(vm, variants) [INFO] [stderr] 91 | ) [INFO] [stderr] 92 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/pushable.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | tokens.into() [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/shared.rs:61:10 [INFO] [stderr] | [INFO] [stderr] 61 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/userdata.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | tokens.into() [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/vm_type.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | tokens.into() [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Compiling sha2 v0.8.0 [INFO] [stderr] Checking codespan v0.2.0 [INFO] [stderr] Checking codespan-reporting v0.2.0 [INFO] [stderr] Compiling serde_derive_state v0.4.4 [INFO] [stderr] Compiling docopt v1.0.2 [INFO] [stderr] Compiling string_cache v0.7.3 [INFO] [stderr] Compiling lalrpop v0.16.3 [INFO] [stderr] Checking gluon_base v0.10.1 [INFO] [stderr] Checking gluon_check v0.10.1 [INFO] [stderr] Checking gluon_format v0.10.1 [INFO] [stderr] Compiling gluon v0.10.1 [INFO] [stderr] Compiling gluon_parser v0.10.1 [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/getable.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | tokens.into() [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `tokens` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/getable.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / match (&first, &second) { [INFO] [stderr] 88 | | (Some(field_ty), None) => { [INFO] [stderr] 89 | | return quote! { [INFO] [stderr] 90 | | #ident ( [INFO] [stderr] ... | [INFO] [stderr] 95 | | _ => (), [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 87 | if let (Some(field_ty), None) = (&first, &second) { [INFO] [stderr] 88 | return quote! { [INFO] [stderr] 89 | #ident ( [INFO] [stderr] 90 | <#field_ty as _gluon_api::Getable<'__vm, '__value>>::from_value(vm, variants) [INFO] [stderr] 91 | ) [INFO] [stderr] 92 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/pushable.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | tokens.into() [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/shared.rs:61:10 [INFO] [stderr] | [INFO] [stderr] 61 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/userdata.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | tokens.into() [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/vm_type.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | tokens.into() [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 29s [INFO] running `"docker" "inspect" "5382afbdad215e359d570948becb0d39908a7c46ee18e428deaddcd7e2a654b9"` [INFO] running `"docker" "rm" "-f" "5382afbdad215e359d570948becb0d39908a7c46ee18e428deaddcd7e2a654b9"` [INFO] [stdout] 5382afbdad215e359d570948becb0d39908a7c46ee18e428deaddcd7e2a654b9