[INFO] crate gltile 0.0.5 is already in cache [INFO] extracting crate gltile 0.0.5 into work/ex/clippy-test-run/sources/stable/reg/gltile/0.0.5 [INFO] extracting crate gltile 0.0.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gltile/0.0.5 [INFO] validating manifest of gltile-0.0.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gltile-0.0.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gltile-0.0.5 [INFO] finished frobbing gltile-0.0.5 [INFO] frobbed toml for gltile-0.0.5 written to work/ex/clippy-test-run/sources/stable/reg/gltile/0.0.5/Cargo.toml [INFO] started frobbing gltile-0.0.5 [INFO] finished frobbing gltile-0.0.5 [INFO] frobbed toml for gltile-0.0.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gltile/0.0.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gltile-0.0.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gltile/0.0.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2362bd1da0d4d3a2f7e73c381f737f4e079edc4beaa408b40f7be170e1a1e605 [INFO] running `"docker" "start" "-a" "2362bd1da0d4d3a2f7e73c381f737f4e079edc4beaa408b40f7be170e1a1e605"` [INFO] [stderr] Checking looper v0.0.2 [INFO] [stderr] Compiling pixset_derive v0.0.5 [INFO] [stderr] Compiling glutin v0.9.2 [INFO] [stderr] Compiling glium v0.17.1 [INFO] [stderr] Compiling palette v0.2.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking pixset v0.0.6 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.7.0 [INFO] [stderr] Checking winit v0.7.6 [INFO] [stderr] Checking gltile v0.0.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | fg: fg, [INFO] [stderr] | ^^^^^^ help: replace it with: `fg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | bg: bg, [INFO] [stderr] | ^^^^^^ help: replace it with: `bg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | fg: fg, [INFO] [stderr] | ^^^^^^ help: replace it with: `fg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | bg: bg, [INFO] [stderr] | ^^^^^^ help: replace it with: `bg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | cursor_loc: cursor_loc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cursor_loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | fg: fg, [INFO] [stderr] | ^^^^^^ help: replace it with: `fg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | bg: bg, [INFO] [stderr] | ^^^^^^ help: replace it with: `bg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | cursor_loc: cursor_loc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cursor_loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | fg: fg, [INFO] [stderr] | ^^^^^^ help: replace it with: `fg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | bg: bg, [INFO] [stderr] | ^^^^^^ help: replace it with: `bg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/tile.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | fg: fg, [INFO] [stderr] | ^^^^^^ help: replace it with: `fg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/tile.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | bg: bg, [INFO] [stderr] | ^^^^^^ help: replace it with: `bg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/tile.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | pix: pix, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/tiles.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/tiles.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | tiles: tiles, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tiles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | fg: fg, [INFO] [stderr] | ^^^^^^ help: replace it with: `fg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | bg: bg, [INFO] [stderr] | ^^^^^^ help: replace it with: `bg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | fg: fg, [INFO] [stderr] | ^^^^^^ help: replace it with: `fg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | bg: bg, [INFO] [stderr] | ^^^^^^ help: replace it with: `bg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | cursor_loc: cursor_loc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cursor_loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | fg: fg, [INFO] [stderr] | ^^^^^^ help: replace it with: `fg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | bg: bg, [INFO] [stderr] | ^^^^^^ help: replace it with: `bg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | cursor_loc: cursor_loc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cursor_loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | fg: fg, [INFO] [stderr] | ^^^^^^ help: replace it with: `fg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/console.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | bg: bg, [INFO] [stderr] | ^^^^^^ help: replace it with: `bg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/tile.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | fg: fg, [INFO] [stderr] | ^^^^^^ help: replace it with: `fg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/tile.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | bg: bg, [INFO] [stderr] | ^^^^^^ help: replace it with: `bg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/tile.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | pix: pix, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/tiles.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console/tiles.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | tiles: tiles, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tiles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vertex/vertex.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vertex/vertex.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | screen_loc: screen_loc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `screen_loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vertex/vertex.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | tileset_coords: tileset_coords, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tileset_coords` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vertex/vertex_data.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vertex/vertex_data.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vertex/vertex.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vertex/vertex.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | screen_loc: screen_loc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `screen_loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vertex/vertex.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | tileset_coords: tileset_coords, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tileset_coords` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vertex/vertex_data.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vertex/vertex_data.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/console/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod console; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/renderer.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | (screen_size.width / tile_width as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/renderer.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | (screen_size.height / tile_height as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/vertex/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod vertex; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/console/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod console; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/renderer.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | (screen_size.width / tile_width as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/renderer.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | (screen_size.height / tile_height as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/vertex/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod vertex; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/colors.rs:19:10 [INFO] [stderr] | [INFO] [stderr] 19 | .expect(&format!("unknown color: {}", color)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("unknown color: {}", color))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/console/console.rs:122:20 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn set_pix<'a>(&mut self, pix: P) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/console/console.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | let pen = self.pen.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.pen` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/console/console.rs:127:25 [INFO] [stderr] | [INFO] [stderr] 127 | pub fn set_with_pen<'a>(&mut self, pix: P, pen: Pen) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `console::pen::Pen` [INFO] [stderr] --> src/console/pen.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | Pen { [INFO] [stderr] 14 | | cursor_loc: units::ScreenTile2D::zero(), [INFO] [stderr] 15 | | fg: [0.0, 0.0, 0.0], [INFO] [stderr] 16 | | bg: [0.0, 0.0, 0.0], [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/utils.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / (0..length) [INFO] [stderr] 45 | | .into_iter() [INFO] [stderr] | |____________________^ help: consider removing `.into_iter()`: `(0..length)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/vertex/vertex.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / implement_vertex!( [INFO] [stderr] 13 | | Vertex, [INFO] [stderr] 14 | | position, [INFO] [stderr] 15 | | tileset_coords, [INFO] [stderr] ... | [INFO] [stderr] 18 | | background_color [INFO] [stderr] 19 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::forget_copy)] on by default [INFO] [stderr] note: argument has type vertex::vertex::Vertex [INFO] [stderr] --> src/vertex/vertex.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / implement_vertex!( [INFO] [stderr] 13 | | Vertex, [INFO] [stderr] 14 | | position, [INFO] [stderr] 15 | | tileset_coords, [INFO] [stderr] ... | [INFO] [stderr] 18 | | background_color [INFO] [stderr] 19 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/vertex/vertex.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / implement_vertex!( [INFO] [stderr] 13 | | Vertex, [INFO] [stderr] 14 | | position, [INFO] [stderr] 15 | | tileset_coords, [INFO] [stderr] ... | [INFO] [stderr] 18 | | background_color [INFO] [stderr] 19 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] note: argument has type vertex::vertex::Vertex [INFO] [stderr] --> src/vertex/vertex.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / implement_vertex!( [INFO] [stderr] 13 | | Vertex, [INFO] [stderr] 14 | | position, [INFO] [stderr] 15 | | tileset_coords, [INFO] [stderr] ... | [INFO] [stderr] 18 | | background_color [INFO] [stderr] 19 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `gltile`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/colors.rs:19:10 [INFO] [stderr] | [INFO] [stderr] 19 | .expect(&format!("unknown color: {}", color)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("unknown color: {}", color))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/console/console.rs:122:20 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn set_pix<'a>(&mut self, pix: P) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/console/console.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | let pen = self.pen.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.pen` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/console/console.rs:127:25 [INFO] [stderr] | [INFO] [stderr] 127 | pub fn set_with_pen<'a>(&mut self, pix: P, pen: Pen) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `console::pen::Pen` [INFO] [stderr] --> src/console/pen.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | Pen { [INFO] [stderr] 14 | | cursor_loc: units::ScreenTile2D::zero(), [INFO] [stderr] 15 | | fg: [0.0, 0.0, 0.0], [INFO] [stderr] 16 | | bg: [0.0, 0.0, 0.0], [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/utils.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / (0..length) [INFO] [stderr] 45 | | .into_iter() [INFO] [stderr] | |____________________^ help: consider removing `.into_iter()`: `(0..length)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/vertex/vertex.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / implement_vertex!( [INFO] [stderr] 13 | | Vertex, [INFO] [stderr] 14 | | position, [INFO] [stderr] 15 | | tileset_coords, [INFO] [stderr] ... | [INFO] [stderr] 18 | | background_color [INFO] [stderr] 19 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::forget_copy)] on by default [INFO] [stderr] note: argument has type vertex::vertex::Vertex [INFO] [stderr] --> src/vertex/vertex.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / implement_vertex!( [INFO] [stderr] 13 | | Vertex, [INFO] [stderr] 14 | | position, [INFO] [stderr] 15 | | tileset_coords, [INFO] [stderr] ... | [INFO] [stderr] 18 | | background_color [INFO] [stderr] 19 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::forget` with a value that implements Copy. Forgetting a copy leaves the original intact. [INFO] [stderr] --> src/vertex/vertex.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / implement_vertex!( [INFO] [stderr] 13 | | Vertex, [INFO] [stderr] 14 | | position, [INFO] [stderr] 15 | | tileset_coords, [INFO] [stderr] ... | [INFO] [stderr] 18 | | background_color [INFO] [stderr] 19 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] note: argument has type vertex::vertex::Vertex [INFO] [stderr] --> src/vertex/vertex.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / implement_vertex!( [INFO] [stderr] 13 | | Vertex, [INFO] [stderr] 14 | | position, [INFO] [stderr] 15 | | tileset_coords, [INFO] [stderr] ... | [INFO] [stderr] 18 | | background_color [INFO] [stderr] 19 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `gltile`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2362bd1da0d4d3a2f7e73c381f737f4e079edc4beaa408b40f7be170e1a1e605"` [INFO] running `"docker" "rm" "-f" "2362bd1da0d4d3a2f7e73c381f737f4e079edc4beaa408b40f7be170e1a1e605"` [INFO] [stdout] 2362bd1da0d4d3a2f7e73c381f737f4e079edc4beaa408b40f7be170e1a1e605