[INFO] crate gltf_unlit_generator 0.4.0 is already in cache [INFO] extracting crate gltf_unlit_generator 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/gltf_unlit_generator/0.4.0 [INFO] extracting crate gltf_unlit_generator 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gltf_unlit_generator/0.4.0 [INFO] validating manifest of gltf_unlit_generator-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gltf_unlit_generator-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gltf_unlit_generator-0.4.0 [INFO] finished frobbing gltf_unlit_generator-0.4.0 [INFO] frobbed toml for gltf_unlit_generator-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/gltf_unlit_generator/0.4.0/Cargo.toml [INFO] started frobbing gltf_unlit_generator-0.4.0 [INFO] finished frobbing gltf_unlit_generator-0.4.0 [INFO] frobbed toml for gltf_unlit_generator-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gltf_unlit_generator/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gltf_unlit_generator-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gltf_unlit_generator/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] af7fbc0b09c44f40968820f5b6894132a93931f9f2d358a768a315aecd531382 [INFO] running `"docker" "start" "-a" "af7fbc0b09c44f40968820f5b6894132a93931f9f2d358a768a315aecd531382"` [INFO] [stderr] Compiling gltf-derive v0.10.1 [INFO] [stderr] Checking cgmath v0.15.0 [INFO] [stderr] Checking gltf-json v0.10.1 [INFO] [stderr] Checking gltf v0.10.1 [INFO] [stderr] Checking gltf_unlit_generator v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:114:15 [INFO] [stderr] | [INFO] [stderr] 114 | candidate.ok_or(From::from("No input maps were provided.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| From::from("No input maps were provided."))` [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:114:15 [INFO] [stderr] | [INFO] [stderr] 114 | candidate.ok_or(From::from("No input maps were provided.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| From::from("No input maps were provided."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:121:32 [INFO] [stderr] | [INFO] [stderr] 121 | let occlusion_factor = occ[0] as f32 * multiplier; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(occ[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:122:26 [INFO] [stderr] | [INFO] [stderr] 122 | pixel.data[0] = (pixel.data[0] as f32 * occlusion_factor) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:123:26 [INFO] [stderr] | [INFO] [stderr] 123 | pixel.data[1] = (pixel.data[1] as f32 * occlusion_factor) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:124:26 [INFO] [stderr] | [INFO] [stderr] 124 | pixel.data[2] = (pixel.data[2] as f32 * occlusion_factor) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:130:27 [INFO] [stderr] | [INFO] [stderr] 130 | let emissive_r = ((em.data[0] as f32) * color[0]) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(em.data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:131:27 [INFO] [stderr] | [INFO] [stderr] 131 | let emissive_g = ((em.data[1] as f32) * color[1]) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(em.data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:132:27 [INFO] [stderr] | [INFO] [stderr] 132 | let emissive_b = ((em.data[2] as f32) * color[2]) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(em.data[2])` [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:121:32 [INFO] [stderr] | [INFO] [stderr] 121 | let occlusion_factor = occ[0] as f32 * multiplier; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(occ[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:122:26 [INFO] [stderr] | [INFO] [stderr] 122 | pixel.data[0] = (pixel.data[0] as f32 * occlusion_factor) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/main.rs:168:49 [INFO] [stderr] | [INFO] [stderr] 168 | let (w, h) = validate_dimensions(dimensions.into_iter().filter_map(|&m| m))?; [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:123:26 [INFO] [stderr] | [INFO] [stderr] 123 | pixel.data[1] = (pixel.data[1] as f32 * occlusion_factor) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:124:26 [INFO] [stderr] | [INFO] [stderr] 124 | pixel.data[2] = (pixel.data[2] as f32 * occlusion_factor) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:130:27 [INFO] [stderr] | [INFO] [stderr] 130 | let emissive_r = ((em.data[0] as f32) * color[0]) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(em.data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:131:27 [INFO] [stderr] | [INFO] [stderr] 131 | let emissive_g = ((em.data[1] as f32) * color[1]) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(em.data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:132:27 [INFO] [stderr] | [INFO] [stderr] 132 | let emissive_b = ((em.data[2] as f32) * color[2]) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(em.data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/main.rs:168:49 [INFO] [stderr] | [INFO] [stderr] 168 | let (w, h) = validate_dimensions(dimensions.into_iter().filter_map(|&m| m))?; [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:175:31 [INFO] [stderr] | [INFO] [stderr] 175 | pixel.data[0] = ((pixel.data[0] as f32 * base_color_factor[0]) as u8).saturating_add(lighten); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[0])` [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:175:31 [INFO] [stderr] | [INFO] [stderr] 175 | pixel.data[0] = ((pixel.data[0] as f32 * base_color_factor[0]) as u8).saturating_add(lighten); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:176:31 [INFO] [stderr] | [INFO] [stderr] 176 | pixel.data[1] = ((pixel.data[1] as f32 * base_color_factor[1]) as u8).saturating_add(lighten); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:177:31 [INFO] [stderr] | [INFO] [stderr] 177 | pixel.data[2] = ((pixel.data[2] as f32 * base_color_factor[2]) as u8).saturating_add(lighten); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:178:30 [INFO] [stderr] | [INFO] [stderr] 178 | pixel.data[3] = (pixel.data[3] as f32 * base_color_factor[3]) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:176:31 [INFO] [stderr] | [INFO] [stderr] 176 | pixel.data[1] = ((pixel.data[1] as f32 * base_color_factor[1]) as u8).saturating_add(lighten); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:177:31 [INFO] [stderr] | [INFO] [stderr] 177 | pixel.data[2] = ((pixel.data[2] as f32 * base_color_factor[2]) as u8).saturating_add(lighten); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:178:30 [INFO] [stderr] | [INFO] [stderr] 178 | pixel.data[3] = (pixel.data[3] as f32 * base_color_factor[3]) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel.data[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] error: Could not compile `gltf_unlit_generator`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `gltf_unlit_generator`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "af7fbc0b09c44f40968820f5b6894132a93931f9f2d358a768a315aecd531382"` [INFO] running `"docker" "rm" "-f" "af7fbc0b09c44f40968820f5b6894132a93931f9f2d358a768a315aecd531382"` [INFO] [stdout] af7fbc0b09c44f40968820f5b6894132a93931f9f2d358a768a315aecd531382