[INFO] crate glsl 0.13.5 is already in cache [INFO] extracting crate glsl 0.13.5 into work/ex/clippy-test-run/sources/stable/reg/glsl/0.13.5 [INFO] extracting crate glsl 0.13.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/glsl/0.13.5 [INFO] validating manifest of glsl-0.13.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of glsl-0.13.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing glsl-0.13.5 [INFO] finished frobbing glsl-0.13.5 [INFO] frobbed toml for glsl-0.13.5 written to work/ex/clippy-test-run/sources/stable/reg/glsl/0.13.5/Cargo.toml [INFO] started frobbing glsl-0.13.5 [INFO] finished frobbing glsl-0.13.5 [INFO] frobbed toml for glsl-0.13.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/glsl/0.13.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting glsl-0.13.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/glsl/0.13.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8849ef33f001e7407a4d5e01e257c745d875204f546cc675882ae1f4302a99dc [INFO] running `"docker" "start" "-a" "8849ef33f001e7407a4d5e01e257c745d875204f546cc675882ae1f4302a99dc"` [INFO] [stderr] Checking glsl v0.13.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsers.rs:2790:7 [INFO] [stderr] | [INFO] [stderr] 2790 | rest: rest [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rest` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsers.rs:2811:7 [INFO] [stderr] | [INFO] [stderr] 2811 | rest: rest [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsers.rs:2822:7 [INFO] [stderr] | [INFO] [stderr] 2822 | head: head, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `head` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsers.rs:2865:7 [INFO] [stderr] | [INFO] [stderr] 2865 | head: head, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `head` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsers.rs:2790:7 [INFO] [stderr] | [INFO] [stderr] 2790 | rest: rest [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rest` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsers.rs:2811:7 [INFO] [stderr] | [INFO] [stderr] 2811 | rest: rest [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsers.rs:2822:7 [INFO] [stderr] | [INFO] [stderr] 2822 | head: head, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `head` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsers.rs:2865:7 [INFO] [stderr] | [INFO] [stderr] 2865 | head: head, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `head` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers.rs:1614:74 [INFO] [stderr] | [INFO] [stderr] 1614 | assert_eq!(decimal_lit(&b"123456 "[..]), IResult::Done(&b" "[..], Ok(123456))); [INFO] [stderr] | ^^^^^^ help: consider: `123_456` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers.rs:1622:74 [INFO] [stderr] | [INFO] [stderr] 1622 | assert_eq!(octal_lit(&b"07654321 "[..]), IResult::Done(&b" "[..], Ok(0o7654321))); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0o7_654_321` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers.rs:1628:79 [INFO] [stderr] | [INFO] [stderr] 1628 | assert_eq!(hexadecimal_lit(&b"0x0123789"[..]), IResult::Done(&b""[..], Ok(0x0123789))); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0012_3789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers.rs:1629:78 [INFO] [stderr] | [INFO] [stderr] 1629 | assert_eq!(hexadecimal_lit(&b"0xABCDEF"[..]), IResult::Done(&b""[..], Ok(0xabcdef))); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers.rs:1630:78 [INFO] [stderr] | [INFO] [stderr] 1630 | assert_eq!(hexadecimal_lit(&b"0xabcdef"[..]), IResult::Done(&b""[..], Ok(0xabcdef))); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers.rs:1642:73 [INFO] [stderr] | [INFO] [stderr] 1642 | assert_eq!(integral_lit(&b"0x9ABCDEF"[..]), IResult::Done(&b""[..], 0x9ABCDEF)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x09AB_CDEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers.rs:1643:73 [INFO] [stderr] | [INFO] [stderr] 1643 | assert_eq!(integral_lit(&b"0x9ABCDEF"[..]), IResult::Done(&b""[..], 0x9ABCDEF)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x09AB_CDEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers.rs:1644:73 [INFO] [stderr] | [INFO] [stderr] 1644 | assert_eq!(integral_lit(&b"0x9abcdef"[..]), IResult::Done(&b""[..], 0x9abcdef)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x09ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers.rs:1645:73 [INFO] [stderr] | [INFO] [stderr] 1645 | assert_eq!(integral_lit(&b"0x9abcdef"[..]), IResult::Done(&b""[..], 0x9abcdef)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x09ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers.rs:1650:74 [INFO] [stderr] | [INFO] [stderr] 1650 | assert_eq!(integral_lit(&b"0xffffffff"[..]), IResult::Done(&b""[..], 0xffffffffu32 as i32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xffff_ffffu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers.rs:1661:75 [INFO] [stderr] | [INFO] [stderr] 1661 | assert_eq!(integral_lit(&b"-0x9ABCDEF"[..]), IResult::Done(&b""[..], -0x9ABCDEF)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x09AB_CDEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers.rs:1662:75 [INFO] [stderr] | [INFO] [stderr] 1662 | assert_eq!(integral_lit(&b"-0x9ABCDEF"[..]), IResult::Done(&b""[..], -0x9ABCDEF)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x09AB_CDEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers.rs:1663:75 [INFO] [stderr] | [INFO] [stderr] 1663 | assert_eq!(integral_lit(&b"-0x9abcdef"[..]), IResult::Done(&b""[..], -0x9abcdef)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x09ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers.rs:1664:75 [INFO] [stderr] | [INFO] [stderr] 1664 | assert_eq!(integral_lit(&b"-0x9abcdef"[..]), IResult::Done(&b""[..], -0x9abcdef)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x09ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers.rs:1669:75 [INFO] [stderr] | [INFO] [stderr] 1669 | assert_eq!(unsigned_lit(&b"0xffffffffU"[..]), IResult::Done(&b""[..], 0xffffffff as u32)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parsers.rs:1670:67 [INFO] [stderr] | [INFO] [stderr] 1670 | assert_eq!(unsigned_lit(&b"-1u"[..]), IResult::Done(&b""[..], 0xffffffff as u32)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_iter` on this type; consider implementing the `std::iter::FromIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/syntax.rs:35:3 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn from_iter(iter: I) -> Option where I: IntoIterator { [INFO] [stderr] 36 | | let vec: Vec<_> = iter.into_iter().collect(); [INFO] [stderr] 37 | | [INFO] [stderr] 38 | | if vec.is_empty() { [INFO] [stderr] ... | [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_iter` on this type; consider implementing the `std::iter::FromIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/syntax.rs:769:3 [INFO] [stderr] | [INFO] [stderr] 769 | / pub fn from_iter(iter: I) -> Option where I: IntoIterator { [INFO] [stderr] 770 | | NonEmpty::from_iter(iter).map(TranslationUnit) [INFO] [stderr] 771 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/syntax.rs:976:3 [INFO] [stderr] | [INFO] [stderr] 976 | Iteration(IterationStatement), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 976 | Iteration(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/syntax.rs:1097:3 [INFO] [stderr] | [INFO] [stderr] 1097 | For(ForInitStatement, ForRestStatement, Box) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/syntax.rs:1097:3 [INFO] [stderr] | [INFO] [stderr] 1097 | For(ForInitStatement, ForRestStatement, Box) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/transpiler/glsl.rs:289:45 [INFO] [stderr] | [INFO] [stderr] 289 | pub fn show_subroutine(f: &mut F, types: &Vec) where F: Write { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[syntax::TypeName]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 120 [INFO] [stderr] --> src/parsers.rs:2044:3 [INFO] [stderr] | [INFO] [stderr] 2044 | / fn parse_type_specifier_non_array() { [INFO] [stderr] 2045 | | assert_eq!(type_specifier_non_array(&b"bool"[..]), IResult::Done(&b""[..], syntax::TypeSpecifierNonArray::Bool)); [INFO] [stderr] 2046 | | assert_eq!(type_specifier_non_array(&b"int"[..]), IResult::Done(&b""[..], syntax::TypeSpecifierNonArray::Int)); [INFO] [stderr] 2047 | | assert_eq!(type_specifier_non_array(&b"uint"[..]), IResult::Done(&b""[..], syntax::TypeSpecifierNonArray::UInt)); [INFO] [stderr] ... | [INFO] [stderr] 2166 | | ); [INFO] [stderr] 2167 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/parsers.rs:2300:9 [INFO] [stderr] | [INFO] [stderr] 2300 | let foo = Box::new(syntax::Expr::Variable("foo".into())); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/parsers.rs:2309:9 [INFO] [stderr] | [INFO] [stderr] 2309 | let foo = Box::new(syntax::Expr::Variable("foo".into())); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/parsers.rs:2319:9 [INFO] [stderr] | [INFO] [stderr] 2319 | let foo = syntax::Expr::Variable("foo".into()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/parsers.rs:2327:9 [INFO] [stderr] | [INFO] [stderr] 2327 | let foo = syntax::Expr::Variable("foo".into()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/parsers.rs:2335:9 [INFO] [stderr] | [INFO] [stderr] 2335 | let foo = syntax::Expr::Variable("foo".into()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/parsers.rs:2343:9 [INFO] [stderr] | [INFO] [stderr] 2343 | let foo = syntax::Expr::Variable("foo".into()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/parsers.rs:2351:9 [INFO] [stderr] | [INFO] [stderr] 2351 | let foo = syntax::Expr::Variable("foo".into()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/parsers.rs:2359:9 [INFO] [stderr] | [INFO] [stderr] 2359 | let foo = syntax::Expr::Variable("foo".into()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/parsers.rs:2367:9 [INFO] [stderr] | [INFO] [stderr] 2367 | let foo = syntax::Expr::Variable("foo".into()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/parsers.rs:2375:9 [INFO] [stderr] | [INFO] [stderr] 2375 | let foo = syntax::Expr::Variable("foo".into()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_iter` on this type; consider implementing the `std::iter::FromIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/syntax.rs:35:3 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn from_iter(iter: I) -> Option where I: IntoIterator { [INFO] [stderr] 36 | | let vec: Vec<_> = iter.into_iter().collect(); [INFO] [stderr] 37 | | [INFO] [stderr] 38 | | if vec.is_empty() { [INFO] [stderr] ... | [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_iter` on this type; consider implementing the `std::iter::FromIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/syntax.rs:769:3 [INFO] [stderr] | [INFO] [stderr] 769 | / pub fn from_iter(iter: I) -> Option where I: IntoIterator { [INFO] [stderr] 770 | | NonEmpty::from_iter(iter).map(TranslationUnit) [INFO] [stderr] 771 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/syntax.rs:976:3 [INFO] [stderr] | [INFO] [stderr] 976 | Iteration(IterationStatement), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 976 | Iteration(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/syntax.rs:1097:3 [INFO] [stderr] | [INFO] [stderr] 1097 | For(ForInitStatement, ForRestStatement, Box) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/syntax.rs:1097:3 [INFO] [stderr] | [INFO] [stderr] 1097 | For(ForInitStatement, ForRestStatement, Box) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/transpiler/glsl.rs:289:45 [INFO] [stderr] | [INFO] [stderr] 289 | pub fn show_subroutine(f: &mut F, types: &Vec) where F: Write { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[syntax::TypeName]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/visitor.rs:1053:31 [INFO] [stderr] | [INFO] [stderr] 1053 | Some(syntax::Expr::from(3.14).into()) [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `glsl`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8849ef33f001e7407a4d5e01e257c745d875204f546cc675882ae1f4302a99dc"` [INFO] running `"docker" "rm" "-f" "8849ef33f001e7407a4d5e01e257c745d875204f546cc675882ae1f4302a99dc"` [INFO] [stdout] 8849ef33f001e7407a4d5e01e257c745d875204f546cc675882ae1f4302a99dc