[INFO] crate glowygraph 0.8.0 is already in cache [INFO] extracting crate glowygraph 0.8.0 into work/ex/clippy-test-run/sources/stable/reg/glowygraph/0.8.0 [INFO] extracting crate glowygraph 0.8.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/glowygraph/0.8.0 [INFO] validating manifest of glowygraph-0.8.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of glowygraph-0.8.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing glowygraph-0.8.0 [INFO] finished frobbing glowygraph-0.8.0 [INFO] frobbed toml for glowygraph-0.8.0 written to work/ex/clippy-test-run/sources/stable/reg/glowygraph/0.8.0/Cargo.toml [INFO] started frobbing glowygraph-0.8.0 [INFO] finished frobbing glowygraph-0.8.0 [INFO] frobbed toml for glowygraph-0.8.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/glowygraph/0.8.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting glowygraph-0.8.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/glowygraph/0.8.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 81e1731a4c52ebc6bcc488591aaaf2633c4ece9213876dfef93d927c1267cd3f [INFO] running `"docker" "start" "-a" "81e1731a4c52ebc6bcc488591aaaf2633c4ece9213876dfef93d927c1267cd3f"` [INFO] [stderr] Compiling gl_generator v0.8.0 [INFO] [stderr] Checking winit v0.10.0 [INFO] [stderr] Compiling glutin v0.12.2 [INFO] [stderr] Compiling glium v0.20.0 [INFO] [stderr] Checking glowygraph v0.8.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render2/mod.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render3/mod.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render2/mod.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render3/mod.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/render_basic3.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | [0.198476, -0.19746, 6.9781234], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.198_476` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/render_basic3.rs:30:34 [INFO] [stderr] | [INFO] [stderr] 30 | [0.198476, -0.19746, 6.9781234], [INFO] [stderr] | ^^^^^^^^^ help: consider: `6.978_123_4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/render_basic3.rs:31:15 [INFO] [stderr] | [INFO] [stderr] 31 | [-0.198476, -0.19746, 2.9781234], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.198_476` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/render_basic3.rs:31:35 [INFO] [stderr] | [INFO] [stderr] 31 | [-0.198476, -0.19746, 2.9781234], [INFO] [stderr] | ^^^^^^^^^ help: consider: `2.978_123_4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/render_basic3.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | [0.715482, 0.1784692, 5.7615471], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.715_482` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/render_basic3.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | [0.715482, 0.1784692, 5.7615471], [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.178_469_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/render_basic3.rs:34:35 [INFO] [stderr] | [INFO] [stderr] 34 | [0.715482, 0.1784692, 5.7615471], [INFO] [stderr] | ^^^^^^^^^ help: consider: `5.761_547_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/render_basic3.rs:35:15 [INFO] [stderr] | [INFO] [stderr] 35 | [-0.1824612, -0.7813652, 3.825643], [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.182_461_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/render_basic3.rs:35:27 [INFO] [stderr] | [INFO] [stderr] 35 | [-0.1824612, -0.7813652, 3.825643], [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.781_365_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/render_basic3.rs:35:38 [INFO] [stderr] | [INFO] [stderr] 35 | [-0.1824612, -0.7813652, 3.825643], [INFO] [stderr] | ^^^^^^^^ help: consider: `3.825_643` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> examples/render_basic3.rs:30:34 [INFO] [stderr] | [INFO] [stderr] 30 | [0.198476, -0.19746, 6.9781234], [INFO] [stderr] | ^^^^^^^^^ help: consider changing the type or truncating it to: `6.978_123` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> examples/render_basic3.rs:34:35 [INFO] [stderr] | [INFO] [stderr] 34 | [0.715482, 0.1784692, 5.7615471], [INFO] [stderr] | ^^^^^^^^^ help: consider changing the type or truncating it to: `5.761_547` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> examples/render_basic3.rs:51:50 [INFO] [stderr] | [INFO] [stderr] 51 | let mut movement = Matrix4::from_angle_y(Rad(3.14)); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> examples/render_basic3.rs:71:23 [INFO] [stderr] | [INFO] [stderr] 71 | fovy: Rad(3.14 / 2.0), [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> examples/render_basic3.rs:91:31 [INFO] [stderr] | [INFO] [stderr] 91 | position: n.clone(), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `glowygraph`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/render_beziers2.rs:90:41 [INFO] [stderr] | [INFO] [stderr] 90 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 91 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 92 | | glutin::WindowEvent::Closed => ::std::process::exit(0), [INFO] [stderr] 93 | | _ => (), [INFO] [stderr] 94 | | }, [INFO] [stderr] 95 | | _ => (), [INFO] [stderr] 96 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 90 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 91 | glutin::WindowEvent::Closed => ::std::process::exit(0), [INFO] [stderr] 92 | _ => (), [INFO] [stderr] 93 | } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/render_beziers2.rs:91:57 [INFO] [stderr] | [INFO] [stderr] 91 | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 92 | | glutin::WindowEvent::Closed => ::std::process::exit(0), [INFO] [stderr] 93 | | _ => (), [INFO] [stderr] 94 | | }, [INFO] [stderr] | |_____________^ help: try this: `if let glutin::WindowEvent::Closed = event { ::std::process::exit(0) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/render_basic2.rs:25:40 [INFO] [stderr] | [INFO] [stderr] 25 | ([-0.19375, -0.5146], [0.1497, 0.981274]), [INFO] [stderr] | ^^^^^^^^ help: consider: `0.981_274` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/render_basic2.rs:120:41 [INFO] [stderr] | [INFO] [stderr] 120 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 121 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 122 | | glutin::WindowEvent::Closed => ::std::process::exit(0), [INFO] [stderr] 123 | | _ => (), [INFO] [stderr] 124 | | }, [INFO] [stderr] 125 | | _ => (), [INFO] [stderr] 126 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 120 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 121 | glutin::WindowEvent::Closed => ::std::process::exit(0), [INFO] [stderr] 122 | _ => (), [INFO] [stderr] 123 | } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/render_basic2.rs:121:57 [INFO] [stderr] | [INFO] [stderr] 121 | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 122 | | glutin::WindowEvent::Closed => ::std::process::exit(0), [INFO] [stderr] 123 | | _ => (), [INFO] [stderr] 124 | | }, [INFO] [stderr] | |_____________^ help: try this: `if let glutin::WindowEvent::Closed = event { ::std::process::exit(0) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "81e1731a4c52ebc6bcc488591aaaf2633c4ece9213876dfef93d927c1267cd3f"` [INFO] running `"docker" "rm" "-f" "81e1731a4c52ebc6bcc488591aaaf2633c4ece9213876dfef93d927c1267cd3f"` [INFO] [stdout] 81e1731a4c52ebc6bcc488591aaaf2633c4ece9213876dfef93d927c1267cd3f