[INFO] crate glossy_codegen 0.2.0 is already in cache
[INFO] extracting crate glossy_codegen 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/glossy_codegen/0.2.0
[INFO] extracting crate glossy_codegen 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/glossy_codegen/0.2.0
[INFO] validating manifest of glossy_codegen-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of glossy_codegen-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing glossy_codegen-0.2.0
[INFO] removed path dependency glossy from glossy_codegen-0.2.0
[INFO] finished frobbing glossy_codegen-0.2.0
[INFO] frobbed toml for glossy_codegen-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/glossy_codegen/0.2.0/Cargo.toml
[INFO] started frobbing glossy_codegen-0.2.0
[INFO] removed path dependency glossy from glossy_codegen-0.2.0
[INFO] finished frobbing glossy_codegen-0.2.0
[INFO] frobbed toml for glossy_codegen-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/glossy_codegen/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting glossy_codegen-0.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/glossy_codegen/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ba7ad83e5f0876595e8fb94a16732fe3a5f9d20664122dab9e3928ffd266d350
[INFO] running `"docker" "start" "-a" "ba7ad83e5f0876595e8fb94a16732fe3a5f9d20664122dab9e3928ffd266d350"`
[INFO] [stderr]     Checking glossy v0.2.0
[INFO] [stderr]    Compiling glsl-optimizer-sys v0.1.0
[INFO] [stderr]     Checking glossy_codegen v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/optimize/optimizer.rs:54:18
[INFO] [stderr]    |
[INFO] [stderr] 54 |         Shader { shader: shader }
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^ help: replace it with: `shader`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |             lang: lang,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `lang`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:188:9
[INFO] [stderr]     |
[INFO] [stderr] 188 | /         write!(&mut file,
[INFO] [stderr] 189 | |                "|id: u32| -> Option<&'static str> {{ match id {{\n")
[INFO] [stderr]     | |____________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:194:13
[INFO] [stderr]     |
[INFO] [stderr] 194 |             write!(&mut file, "{} => Some({:?}),\n", id, name).unwrap();
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:241:29
[INFO] [stderr]     |
[INFO] [stderr] 241 |                             write!(&mut output, "{}\n", line).unwrap();
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:287:29
[INFO] [stderr]     |
[INFO] [stderr] 287 |                             write!(&mut output, "/*\n").unwrap();
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:289:29
[INFO] [stderr]     |
[INFO] [stderr] 289 |                             write!(&mut output, "\n").unwrap();
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:337:21
[INFO] [stderr]     |
[INFO] [stderr] 337 |                     write!(&mut output, "{}\n", line).unwrap();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:339:21
[INFO] [stderr]     |
[INFO] [stderr] 339 |                     write!(&mut output, "{}\n", line_no_comments).unwrap();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:378:21
[INFO] [stderr]     |
[INFO] [stderr] 378 |                     write!(&mut output, "/*\n").unwrap();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:382:21
[INFO] [stderr]     |
[INFO] [stderr] 382 |                     write!(&mut output, "{}\n", include_source).unwrap();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:438:13
[INFO] [stderr]     |
[INFO] [stderr] 438 |             path: path,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:439:13
[INFO] [stderr]     |
[INFO] [stderr] 439 |             kind: kind,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/optimize/optimizer.rs:54:18
[INFO] [stderr]    |
[INFO] [stderr] 54 |         Shader { shader: shader }
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^ help: replace it with: `shader`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |             lang: lang,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `lang`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:188:9
[INFO] [stderr]     |
[INFO] [stderr] 188 | /         write!(&mut file,
[INFO] [stderr] 189 | |                "|id: u32| -> Option<&'static str> {{ match id {{\n")
[INFO] [stderr]     | |____________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:194:13
[INFO] [stderr]     |
[INFO] [stderr] 194 |             write!(&mut file, "{} => Some({:?}),\n", id, name).unwrap();
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:241:29
[INFO] [stderr]     |
[INFO] [stderr] 241 |                             write!(&mut output, "{}\n", line).unwrap();
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:287:29
[INFO] [stderr]     |
[INFO] [stderr] 287 |                             write!(&mut output, "/*\n").unwrap();
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:289:29
[INFO] [stderr]     |
[INFO] [stderr] 289 |                             write!(&mut output, "\n").unwrap();
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:337:21
[INFO] [stderr]     |
[INFO] [stderr] 337 |                     write!(&mut output, "{}\n", line).unwrap();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:339:21
[INFO] [stderr]     |
[INFO] [stderr] 339 |                     write!(&mut output, "{}\n", line_no_comments).unwrap();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:378:21
[INFO] [stderr]     |
[INFO] [stderr] 378 |                     write!(&mut output, "/*\n").unwrap();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:382:21
[INFO] [stderr]     |
[INFO] [stderr] 382 |                     write!(&mut output, "{}\n", include_source).unwrap();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:438:13
[INFO] [stderr]     |
[INFO] [stderr] 438 |             path: path,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:439:13
[INFO] [stderr]     |
[INFO] [stderr] 439 |             kind: kind,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:380:20
[INFO] [stderr]     |
[INFO] [stderr] 380 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 381 | |                 if !include_source.is_empty() {
[INFO] [stderr] 382 | |                     write!(&mut output, "{}\n", include_source).unwrap();
[INFO] [stderr] 383 | |                 }
[INFO] [stderr] 384 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 380 |             } else if !include_source.is_empty() {
[INFO] [stderr] 381 |     write!(&mut output, "{}\n", include_source).unwrap();
[INFO] [stderr] 382 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:380:20
[INFO] [stderr]     |
[INFO] [stderr] 380 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 381 | |                 if !include_source.is_empty() {
[INFO] [stderr] 382 | |                     write!(&mut output, "{}\n", include_source).unwrap();
[INFO] [stderr] 383 | |                 }
[INFO] [stderr] 384 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 380 |             } else if !include_source.is_empty() {
[INFO] [stderr] 381 |     write!(&mut output, "{}\n", include_source).unwrap();
[INFO] [stderr] 382 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 28
[INFO] [stderr]    --> src/lib.rs:200:5
[INFO] [stderr]     |
[INFO] [stderr] 200 | /     fn process(&self,
[INFO] [stderr] 201 | |                include_map: &mut HashMap<String, usize>,
[INFO] [stderr] 202 | |                name: &str,
[INFO] [stderr] 203 | |                source: &str,
[INFO] [stderr] ...   |
[INFO] [stderr] 400 | |         }
[INFO] [stderr] 401 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 28
[INFO] [stderr]    --> src/lib.rs:200:5
[INFO] [stderr]     |
[INFO] [stderr] 200 | /     fn process(&self,
[INFO] [stderr] 201 | |                include_map: &mut HashMap<String, usize>,
[INFO] [stderr] 202 | |                name: &str,
[INFO] [stderr] 203 | |                source: &str,
[INFO] [stderr] ...   |
[INFO] [stderr] 400 | |         }
[INFO] [stderr] 401 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 25.86s
[INFO] running `"docker" "inspect" "ba7ad83e5f0876595e8fb94a16732fe3a5f9d20664122dab9e3928ffd266d350"`
[INFO] running `"docker" "rm" "-f" "ba7ad83e5f0876595e8fb94a16732fe3a5f9d20664122dab9e3928ffd266d350"`
[INFO] [stdout] ba7ad83e5f0876595e8fb94a16732fe3a5f9d20664122dab9e3928ffd266d350