[INFO] crate glium_text 0.13.0 is already in cache [INFO] extracting crate glium_text 0.13.0 into work/ex/clippy-test-run/sources/stable/reg/glium_text/0.13.0 [INFO] extracting crate glium_text 0.13.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/glium_text/0.13.0 [INFO] validating manifest of glium_text-0.13.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of glium_text-0.13.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing glium_text-0.13.0 [INFO] finished frobbing glium_text-0.13.0 [INFO] frobbed toml for glium_text-0.13.0 written to work/ex/clippy-test-run/sources/stable/reg/glium_text/0.13.0/Cargo.toml [INFO] started frobbing glium_text-0.13.0 [INFO] finished frobbing glium_text-0.13.0 [INFO] frobbed toml for glium_text-0.13.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/glium_text/0.13.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting glium_text-0.13.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/glium_text/0.13.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7fbe5c6c5313fc6a22bd36d94f7cb33c3d6544ab0910bccf5ce5781ee2724545 [INFO] running `"docker" "start" "-a" "7fbe5c6c5313fc6a22bd36d94f7cb33c3d6544ab0910bccf5ce5781ee2724545"` [INFO] [stderr] Checking smithay-client-toolkit v0.2.6 [INFO] [stderr] Checking winit v0.16.2 [INFO] [stderr] Checking glutin v0.17.0 [INFO] [stderr] Checking glium v0.22.0 [INFO] [stderr] Checking glium_text v0.13.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:461:13 [INFO] [stderr] | [INFO] [stderr] 461 | blend: blend, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `blend` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:461:13 [INFO] [stderr] | [INFO] [stderr] 461 | blend: blend, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `blend` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `char` [INFO] [stderr] --> src/lib.rs:193:29 [INFO] [stderr] | [INFO] [stderr] 193 | result.push(std::mem::transmute(c as u32)); // TODO: better solution? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::char::from_u32(c as u32).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_char)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_char [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:226:22 [INFO] [stderr] | [INFO] [stderr] 226 | program: program!(facade, [INFO] [stderr] | ______________________^ [INFO] [stderr] 227 | | 140 => { [INFO] [stderr] 228 | | vertex: " [INFO] [stderr] 229 | | #version 140 [INFO] [stderr] ... | [INFO] [stderr] 288 | | [INFO] [stderr] 289 | | ).unwrap() [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:226:22 [INFO] [stderr] | [INFO] [stderr] 226 | program: program!(facade, [INFO] [stderr] | ______________________^ [INFO] [stderr] 227 | | 140 => { [INFO] [stderr] 228 | | vertex: " [INFO] [stderr] 229 | | #version 140 [INFO] [stderr] ... | [INFO] [stderr] 288 | | [INFO] [stderr] 289 | | ).unwrap() [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:324:12 [INFO] [stderr] | [INFO] [stderr] 324 | if text.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/lib.rs:538:26 [INFO] [stderr] | [INFO] [stderr] 538 | let source = std::mem::transmute(bitmap.buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bitmap.buffer as *const u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:547:36 [INFO] [stderr] | [INFO] [stderr] 547 | let val: u8 = *source.get(x as usize).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `source[x as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:548:31 [INFO] [stderr] | [INFO] [stderr] 548 | let val = (val as f32) / (std::u8::MAX as f32); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:548:46 [INFO] [stderr] | [INFO] [stderr] 548 | let val = (val as f32) / (std::u8::MAX as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:549:32 [INFO] [stderr] | [INFO] [stderr] 549 | let dest = destination.get_mut(x as usize).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `destination[x as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `char` [INFO] [stderr] --> src/lib.rs:193:29 [INFO] [stderr] | [INFO] [stderr] 193 | result.push(std::mem::transmute(c as u32)); // TODO: better solution? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::char::from_u32(c as u32).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_char)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_char [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:226:22 [INFO] [stderr] | [INFO] [stderr] 226 | program: program!(facade, [INFO] [stderr] | ______________________^ [INFO] [stderr] 227 | | 140 => { [INFO] [stderr] 228 | | vertex: " [INFO] [stderr] 229 | | #version 140 [INFO] [stderr] ... | [INFO] [stderr] 288 | | [INFO] [stderr] 289 | | ).unwrap() [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:226:22 [INFO] [stderr] | [INFO] [stderr] 226 | program: program!(facade, [INFO] [stderr] | ______________________^ [INFO] [stderr] 227 | | 140 => { [INFO] [stderr] 228 | | vertex: " [INFO] [stderr] 229 | | #version 140 [INFO] [stderr] ... | [INFO] [stderr] 288 | | [INFO] [stderr] 289 | | ).unwrap() [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:324:12 [INFO] [stderr] | [INFO] [stderr] 324 | if text.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/lib.rs:538:26 [INFO] [stderr] | [INFO] [stderr] 538 | let source = std::mem::transmute(bitmap.buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bitmap.buffer as *const u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:547:36 [INFO] [stderr] | [INFO] [stderr] 547 | let val: u8 = *source.get(x as usize).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `source[x as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:548:31 [INFO] [stderr] | [INFO] [stderr] 548 | let val = (val as f32) / (std::u8::MAX as f32); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:548:46 [INFO] [stderr] | [INFO] [stderr] 548 | let val = (val as f32) / (std::u8::MAX as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:549:32 [INFO] [stderr] | [INFO] [stderr] 549 | let dest = destination.get_mut(x as usize).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `destination[x as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 43.87s [INFO] running `"docker" "inspect" "7fbe5c6c5313fc6a22bd36d94f7cb33c3d6544ab0910bccf5ce5781ee2724545"` [INFO] running `"docker" "rm" "-f" "7fbe5c6c5313fc6a22bd36d94f7cb33c3d6544ab0910bccf5ce5781ee2724545"` [INFO] [stdout] 7fbe5c6c5313fc6a22bd36d94f7cb33c3d6544ab0910bccf5ce5781ee2724545