[INFO] crate glium_pib 0.1.0 is already in cache [INFO] extracting crate glium_pib 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/glium_pib/0.1.0 [INFO] extracting crate glium_pib 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/glium_pib/0.1.0 [INFO] validating manifest of glium_pib-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of glium_pib-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing glium_pib-0.1.0 [INFO] finished frobbing glium_pib-0.1.0 [INFO] frobbed toml for glium_pib-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/glium_pib/0.1.0/Cargo.toml [INFO] started frobbing glium_pib-0.1.0 [INFO] finished frobbing glium_pib-0.1.0 [INFO] frobbed toml for glium_pib-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/glium_pib/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting glium_pib-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/glium_pib/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8dc1c75b36136b58f814587c2e7453080b1298800a8ed179ffa96c01112804c2 [INFO] running `"docker" "start" "-a" "8dc1c75b36136b58f814587c2e7453080b1298800a8ed179ffa96c01112804c2"` [INFO] [stderr] Checking glium_pib v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:196:4 [INFO] [stderr] | [INFO] [stderr] 196 | lib_dir: lib_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `lib_dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:197:4 [INFO] [stderr] | [INFO] [stderr] 197 | lib_bcm_host: lib_bcm_host, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lib_bcm_host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:198:4 [INFO] [stderr] | [INFO] [stderr] 198 | lib_glesv2: lib_glesv2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lib_glesv2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:199:4 [INFO] [stderr] | [INFO] [stderr] 199 | dlib_glesv2: dlib_glesv2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dlib_glesv2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:200:4 [INFO] [stderr] | [INFO] [stderr] 200 | lib_egl: lib_egl, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `lib_egl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:201:4 [INFO] [stderr] | [INFO] [stderr] 201 | egl_display: egl_display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `egl_display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:202:4 [INFO] [stderr] | [INFO] [stderr] 202 | mutex: mutex, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `mutex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:263:5 [INFO] [stderr] | [INFO] [stderr] 263 | system: system, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `system` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:196:4 [INFO] [stderr] | [INFO] [stderr] 196 | lib_dir: lib_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `lib_dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:197:4 [INFO] [stderr] | [INFO] [stderr] 197 | lib_bcm_host: lib_bcm_host, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lib_bcm_host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:198:4 [INFO] [stderr] | [INFO] [stderr] 198 | lib_glesv2: lib_glesv2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lib_glesv2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:199:4 [INFO] [stderr] | [INFO] [stderr] 199 | dlib_glesv2: dlib_glesv2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dlib_glesv2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:200:4 [INFO] [stderr] | [INFO] [stderr] 200 | lib_egl: lib_egl, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `lib_egl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:201:4 [INFO] [stderr] | [INFO] [stderr] 201 | egl_display: egl_display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `egl_display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:202:4 [INFO] [stderr] | [INFO] [stderr] 202 | mutex: mutex, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `mutex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:263:5 [INFO] [stderr] | [INFO] [stderr] 263 | system: system, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `system` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:111:1 [INFO] [stderr] | [INFO] [stderr] 111 | #[macro_use] extern crate glium; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:111:1 [INFO] [stderr] | [INFO] [stderr] 111 | #[macro_use] extern crate glium; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:28:15 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn index(&self) -> libc::uint16_t { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:173:11 [INFO] [stderr] | [INFO] [stderr] 173 | assert!(SYSTEM_SINGLETON_GUARD.swap(true, Ordering::AcqRel) == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!SYSTEM_SINGLETON_GUARD.swap(true, Ordering::AcqRel)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:188:44 [INFO] [stderr] | [INFO] [stderr] 188 | if (lib_egl.eglInitialize)(egl_display, 0 as *mut ffi::EGLint, 0 as *mut ffi::EGLint) == 0 { return Err(Error::Fn("eglInitialize")); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:188:67 [INFO] [stderr] | [INFO] [stderr] 188 | if (lib_egl.eglInitialize)(egl_display, 0 as *mut ffi::EGLint, 0 as *mut ffi::EGLint) == 0 { return Err(Error::Fn("eglInitialize")); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:290:6 [INFO] [stderr] | [INFO] [stderr] 290 | match config.alpha.as_ref() { [INFO] [stderr] | _____________________^ [INFO] [stderr] 291 | | Some(alpha) => { [INFO] [stderr] 292 | | attribute_list[attribute_list_size + 0] = ffi::EGL_ALPHA_SIZE as ffi::EGLint; [INFO] [stderr] 293 | | attribute_list[attribute_list_size + 1] = alpha.0 as ffi::EGLint; [INFO] [stderr] ... | [INFO] [stderr] 296 | | None => {}, [INFO] [stderr] 297 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 290 | if let Some(alpha) = config.alpha.as_ref() { [INFO] [stderr] 291 | attribute_list[attribute_list_size + 0] = ffi::EGL_ALPHA_SIZE as ffi::EGLint; [INFO] [stderr] 292 | attribute_list[attribute_list_size + 1] = alpha.0 as ffi::EGLint; [INFO] [stderr] 293 | attribute_list_size += 2; [INFO] [stderr] 294 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `attribute_list_size` [INFO] [stderr] --> src/lib.rs:292:23 [INFO] [stderr] | [INFO] [stderr] 292 | attribute_list[attribute_list_size + 0] = ffi::EGL_ALPHA_SIZE as ffi::EGLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:298:6 [INFO] [stderr] | [INFO] [stderr] 298 | match config.depth.as_ref() { [INFO] [stderr] | _____________________^ [INFO] [stderr] 299 | | Some(depth) => { [INFO] [stderr] 300 | | attribute_list[attribute_list_size + 0] = ffi::EGL_DEPTH_SIZE as ffi::EGLint; [INFO] [stderr] 301 | | attribute_list[attribute_list_size + 1] = depth.0 as ffi::EGLint; [INFO] [stderr] 302 | | }, [INFO] [stderr] 303 | | None => {}, [INFO] [stderr] 304 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 298 | if let Some(depth) = config.depth.as_ref() { [INFO] [stderr] 299 | attribute_list[attribute_list_size + 0] = ffi::EGL_DEPTH_SIZE as ffi::EGLint; [INFO] [stderr] 300 | attribute_list[attribute_list_size + 1] = depth.0 as ffi::EGLint; [INFO] [stderr] 301 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `attribute_list_size` [INFO] [stderr] --> src/lib.rs:300:23 [INFO] [stderr] | [INFO] [stderr] 300 | attribute_list[attribute_list_size + 0] = ffi::EGL_DEPTH_SIZE as ffi::EGLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:354:7 [INFO] [stderr] | [INFO] [stderr] 354 | 0 as *mut ffi::VcDispmanxAlpha, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:355:7 [INFO] [stderr] | [INFO] [stderr] 355 | 0 as *mut ffi::DispmanxClamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/lib.rs:367:177 [INFO] [stderr] | [INFO] [stderr] 367 | window.egl_surface = (window.system.lib_egl.eglCreateWindowSurface)(window.system.egl_display, egl_config, window.egl_dispmanx_window.as_ref() as ffi::EGLNativeWindowType, 0 as *const ffi::EGLint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:28:15 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn index(&self) -> libc::uint16_t { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:173:11 [INFO] [stderr] | [INFO] [stderr] 173 | assert!(SYSTEM_SINGLETON_GUARD.swap(true, Ordering::AcqRel) == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!SYSTEM_SINGLETON_GUARD.swap(true, Ordering::AcqRel)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:188:44 [INFO] [stderr] | [INFO] [stderr] 188 | if (lib_egl.eglInitialize)(egl_display, 0 as *mut ffi::EGLint, 0 as *mut ffi::EGLint) == 0 { return Err(Error::Fn("eglInitialize")); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:188:67 [INFO] [stderr] | [INFO] [stderr] 188 | if (lib_egl.eglInitialize)(egl_display, 0 as *mut ffi::EGLint, 0 as *mut ffi::EGLint) == 0 { return Err(Error::Fn("eglInitialize")); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:290:6 [INFO] [stderr] | [INFO] [stderr] 290 | match config.alpha.as_ref() { [INFO] [stderr] | _____________________^ [INFO] [stderr] 291 | | Some(alpha) => { [INFO] [stderr] 292 | | attribute_list[attribute_list_size + 0] = ffi::EGL_ALPHA_SIZE as ffi::EGLint; [INFO] [stderr] 293 | | attribute_list[attribute_list_size + 1] = alpha.0 as ffi::EGLint; [INFO] [stderr] ... | [INFO] [stderr] 296 | | None => {}, [INFO] [stderr] 297 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 290 | if let Some(alpha) = config.alpha.as_ref() { [INFO] [stderr] 291 | attribute_list[attribute_list_size + 0] = ffi::EGL_ALPHA_SIZE as ffi::EGLint; [INFO] [stderr] 292 | attribute_list[attribute_list_size + 1] = alpha.0 as ffi::EGLint; [INFO] [stderr] 293 | attribute_list_size += 2; [INFO] [stderr] 294 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `attribute_list_size` [INFO] [stderr] --> src/lib.rs:292:23 [INFO] [stderr] | [INFO] [stderr] 292 | attribute_list[attribute_list_size + 0] = ffi::EGL_ALPHA_SIZE as ffi::EGLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:298:6 [INFO] [stderr] | [INFO] [stderr] 298 | match config.depth.as_ref() { [INFO] [stderr] | _____________________^ [INFO] [stderr] 299 | | Some(depth) => { [INFO] [stderr] 300 | | attribute_list[attribute_list_size + 0] = ffi::EGL_DEPTH_SIZE as ffi::EGLint; [INFO] [stderr] 301 | | attribute_list[attribute_list_size + 1] = depth.0 as ffi::EGLint; [INFO] [stderr] 302 | | }, [INFO] [stderr] 303 | | None => {}, [INFO] [stderr] 304 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 298 | if let Some(depth) = config.depth.as_ref() { [INFO] [stderr] 299 | attribute_list[attribute_list_size + 0] = ffi::EGL_DEPTH_SIZE as ffi::EGLint; [INFO] [stderr] 300 | attribute_list[attribute_list_size + 1] = depth.0 as ffi::EGLint; [INFO] [stderr] 301 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `attribute_list_size` [INFO] [stderr] --> src/lib.rs:300:23 [INFO] [stderr] | [INFO] [stderr] 300 | attribute_list[attribute_list_size + 0] = ffi::EGL_DEPTH_SIZE as ffi::EGLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:354:7 [INFO] [stderr] | [INFO] [stderr] 354 | 0 as *mut ffi::VcDispmanxAlpha, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:355:7 [INFO] [stderr] | [INFO] [stderr] 355 | 0 as *mut ffi::DispmanxClamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/lib.rs:367:177 [INFO] [stderr] | [INFO] [stderr] 367 | window.egl_surface = (window.system.lib_egl.eglCreateWindowSurface)(window.system.egl_display, egl_config, window.egl_dispmanx_window.as_ref() as ffi::EGLNativeWindowType, 0 as *const ffi::EGLint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.57s [INFO] running `"docker" "inspect" "8dc1c75b36136b58f814587c2e7453080b1298800a8ed179ffa96c01112804c2"` [INFO] running `"docker" "rm" "-f" "8dc1c75b36136b58f814587c2e7453080b1298800a8ed179ffa96c01112804c2"` [INFO] [stdout] 8dc1c75b36136b58f814587c2e7453080b1298800a8ed179ffa96c01112804c2