[INFO] crate glitchcat 0.3.2 is already in cache [INFO] extracting crate glitchcat 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/glitchcat/0.3.2 [INFO] extracting crate glitchcat 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/glitchcat/0.3.2 [INFO] validating manifest of glitchcat-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of glitchcat-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing glitchcat-0.3.2 [INFO] finished frobbing glitchcat-0.3.2 [INFO] frobbed toml for glitchcat-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/glitchcat/0.3.2/Cargo.toml [INFO] started frobbing glitchcat-0.3.2 [INFO] finished frobbing glitchcat-0.3.2 [INFO] frobbed toml for glitchcat-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/glitchcat/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting glitchcat-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/glitchcat/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d0f74d582eafd9efcd234974b2b383b48ae62d7988b44511cc30a22e9a1c99ae [INFO] running `"docker" "start" "-a" "d0f74d582eafd9efcd234974b2b383b48ae62d7988b44511cc30a22e9a1c99ae"` [INFO] [stderr] Checking strum v0.10.0 [INFO] [stderr] Compiling strum_macros v0.10.0 [INFO] [stderr] Checking console v0.6.2 [INFO] [stderr] Checking glitchcat v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/duration.rs:24:33 [INFO] [stderr] | [INFO] [stderr] 24 | duration.as_secs() * 1000 + duration.subsec_millis() as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/homoglyph.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | / if !groups.contains_key(&c_in) { [INFO] [stderr] 19 | | groups.insert(c_in, HashSet::new()); [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________________________^ help: consider using: `groups.entry(c_in).or_insert(HashSet::new())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/percent.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn as_u8(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/duration.rs:24:33 [INFO] [stderr] | [INFO] [stderr] 24 | duration.as_secs() * 1000 + duration.subsec_millis() as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/homoglyph.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | / if !groups.contains_key(&c_in) { [INFO] [stderr] 19 | | groups.insert(c_in, HashSet::new()); [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________________________^ help: consider using: `groups.entry(c_in).or_insert(HashSet::new())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/percent.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn as_u8(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.27s [INFO] running `"docker" "inspect" "d0f74d582eafd9efcd234974b2b383b48ae62d7988b44511cc30a22e9a1c99ae"` [INFO] running `"docker" "rm" "-f" "d0f74d582eafd9efcd234974b2b383b48ae62d7988b44511cc30a22e9a1c99ae"` [INFO] [stdout] d0f74d582eafd9efcd234974b2b383b48ae62d7988b44511cc30a22e9a1c99ae