[INFO] crate glitch-in-the-matrix 0.13.0 is already in cache [INFO] extracting crate glitch-in-the-matrix 0.13.0 into work/ex/clippy-test-run/sources/stable/reg/glitch-in-the-matrix/0.13.0 [INFO] extracting crate glitch-in-the-matrix 0.13.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/glitch-in-the-matrix/0.13.0 [INFO] validating manifest of glitch-in-the-matrix-0.13.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of glitch-in-the-matrix-0.13.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing glitch-in-the-matrix-0.13.0 [INFO] finished frobbing glitch-in-the-matrix-0.13.0 [INFO] frobbed toml for glitch-in-the-matrix-0.13.0 written to work/ex/clippy-test-run/sources/stable/reg/glitch-in-the-matrix/0.13.0/Cargo.toml [INFO] started frobbing glitch-in-the-matrix-0.13.0 [INFO] finished frobbing glitch-in-the-matrix-0.13.0 [INFO] frobbed toml for glitch-in-the-matrix-0.13.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/glitch-in-the-matrix/0.13.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting glitch-in-the-matrix-0.13.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/glitch-in-the-matrix/0.13.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6921638dde9fa3e6aee2b12c855bdecf18ee3325477aa84c9d51bbb6378e9722 [INFO] running `"docker" "start" "-a" "6921638dde9fa3e6aee2b12c855bdecf18ee3325477aa84c9d51bbb6378e9722"` [INFO] [stderr] Checking rpassword v0.4.2 [INFO] [stderr] Checking gm-types v0.3.0 [INFO] [stderr] Checking tokio-openssl v0.1.4 [INFO] [stderr] Checking hyper-openssl v0.3.1 [INFO] [stderr] Checking glitch-in-the-matrix v0.13.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint `unused_doc_comment` has been renamed to `unused_doc_comments` [INFO] [stderr] --> src/lib.rs:24:14 [INFO] [stderr] | [INFO] [stderr] 24 | #![allow(unused_doc_comment)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use the new name: `unused_doc_comments` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | hdl: hdl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `hdl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint `unused_doc_comment` has been renamed to `unused_doc_comments` [INFO] [stderr] --> src/lib.rs:24:14 [INFO] [stderr] | [INFO] [stderr] 24 | #![allow(unused_doc_comment)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use the new name: `unused_doc_comments` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | hdl: hdl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `hdl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | #[macro_use] extern crate futures; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | #[macro_use] extern crate futures; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/room.rs:82:38 [INFO] [stderr] | [INFO] [stderr] 82 | body: unformatted.into().unwrap_or(m.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| m.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/room.rs:267:13 [INFO] [stderr] | [INFO] [stderr] 267 | / if let &MatrixErrorKind::BadRequest(ref brk) = e.kind() { [INFO] [stderr] 268 | | if brk.errcode == "M_NOT_FOUND" { [INFO] [stderr] 269 | | return Ok(0) [INFO] [stderr] 270 | | } [INFO] [stderr] 271 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 267 | if let MatrixErrorKind::BadRequest(ref brk) = *e.kind() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/request.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | fn get_path<'a>(&'a self) -> Cow<'a, str>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/request.rs:94:36 [INFO] [stderr] | [INFO] [stderr] 94 | impl<'a, 'b, 'c> MatrixRequest<'a, HashMap, Cow<'c, str>>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 94 | impl<'a, 'b, 'c, S: ::std::hash::BuildHasher + Default> MatrixRequest<'a, HashMap, Cow<'c, str>, S>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 105| params: HashMap::default(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/request.rs:164:60 [INFO] [stderr] | [INFO] [stderr] 164 | Err(e) => return Box::new(futures::future::err(e.into())) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/request.rs:172:60 [INFO] [stderr] | [INFO] [stderr] 172 | Err(e) => return Box::new(futures::future::err(e.into())) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/util.rs:35:32 [INFO] [stderr] | [INFO] [stderr] 35 | bail!(HttpCode(self.sc.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.sc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:165:60 [INFO] [stderr] | [INFO] [stderr] 165 | Err(e) => return Box::new(futures::future::err(e.into())) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/room.rs:82:38 [INFO] [stderr] | [INFO] [stderr] 82 | body: unformatted.into().unwrap_or(m.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| m.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/room.rs:267:13 [INFO] [stderr] | [INFO] [stderr] 267 | / if let &MatrixErrorKind::BadRequest(ref brk) = e.kind() { [INFO] [stderr] 268 | | if brk.errcode == "M_NOT_FOUND" { [INFO] [stderr] 269 | | return Ok(0) [INFO] [stderr] 270 | | } [INFO] [stderr] 271 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 267 | if let MatrixErrorKind::BadRequest(ref brk) = *e.kind() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/request.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | fn get_path<'a>(&'a self) -> Cow<'a, str>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/request.rs:94:36 [INFO] [stderr] | [INFO] [stderr] 94 | impl<'a, 'b, 'c> MatrixRequest<'a, HashMap, Cow<'c, str>>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 94 | impl<'a, 'b, 'c, S: ::std::hash::BuildHasher + Default> MatrixRequest<'a, HashMap, Cow<'c, str>, S>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 105| params: HashMap::default(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/request.rs:164:60 [INFO] [stderr] | [INFO] [stderr] 164 | Err(e) => return Box::new(futures::future::err(e.into())) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/request.rs:172:60 [INFO] [stderr] | [INFO] [stderr] 172 | Err(e) => return Box::new(futures::future::err(e.into())) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/util.rs:35:32 [INFO] [stderr] | [INFO] [stderr] 35 | bail!(HttpCode(self.sc.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.sc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:165:60 [INFO] [stderr] | [INFO] [stderr] 165 | Err(e) => return Box::new(futures::future::err(e.into())) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/main.rs:14:10 [INFO] [stderr] | [INFO] [stderr] 14 | .expect(&format!("File not found: '{}'!",file)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("File not found: '{}'!", file))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 29.01s [INFO] running `"docker" "inspect" "6921638dde9fa3e6aee2b12c855bdecf18ee3325477aa84c9d51bbb6378e9722"` [INFO] running `"docker" "rm" "-f" "6921638dde9fa3e6aee2b12c855bdecf18ee3325477aa84c9d51bbb6378e9722"` [INFO] [stdout] 6921638dde9fa3e6aee2b12c855bdecf18ee3325477aa84c9d51bbb6378e9722