[INFO] crate glerminal 0.1.8 is already in cache [INFO] extracting crate glerminal 0.1.8 into work/ex/clippy-test-run/sources/stable/reg/glerminal/0.1.8 [INFO] extracting crate glerminal 0.1.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/glerminal/0.1.8 [INFO] validating manifest of glerminal-0.1.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of glerminal-0.1.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing glerminal-0.1.8 [INFO] finished frobbing glerminal-0.1.8 [INFO] frobbed toml for glerminal-0.1.8 written to work/ex/clippy-test-run/sources/stable/reg/glerminal/0.1.8/Cargo.toml [INFO] started frobbing glerminal-0.1.8 [INFO] finished frobbing glerminal-0.1.8 [INFO] frobbed toml for glerminal-0.1.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/glerminal/0.1.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting glerminal-0.1.8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/glerminal/0.1.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d8731f51b9bd0e7305977eb4073ba9ee12b08a65ccc424beb158cc7e724c2637 [INFO] running `"docker" "start" "-a" "d8731f51b9bd0e7305977eb4073ba9ee12b08a65ccc424beb158cc7e724c2637"` [INFO] [stderr] Checking sfl_parser v1.3.1 [INFO] [stderr] Compiling glutin v0.13.1 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.11.3 [INFO] [stderr] Checking glerminal v0.1.8 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/display.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/textbuffermesh.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | vao: vao, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/textbuffermesh.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | vbo_pos: vbo_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `vbo_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/textbuffermesh.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | vbo_col: vbo_col, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `vbo_col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/textbuffermesh.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | vbo_tex: vbo_tex, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `vbo_tex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/textbuffermesh.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | vbo_shakiness: vbo_shakiness, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vbo_shakiness` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/backgroundmesh.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/backgroundmesh.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/backgroundmesh.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | vbo_pos: vbo_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `vbo_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/backgroundmesh.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | vbo_col: vbo_col, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `vbo_col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/backgroundmesh.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | vao: vao, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/font.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | image_buffer: image_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/font.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | characters: characters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `characters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/display.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/textbuffermesh.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | vao: vao, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/textbuffermesh.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | vbo_pos: vbo_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `vbo_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/textbuffermesh.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | vbo_col: vbo_col, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `vbo_col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/textbuffermesh.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | vbo_tex: vbo_tex, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `vbo_tex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/textbuffermesh.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | vbo_shakiness: vbo_shakiness, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vbo_shakiness` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/backgroundmesh.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/backgroundmesh.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/backgroundmesh.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | vbo_pos: vbo_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `vbo_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/backgroundmesh.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | vbo_col: vbo_col, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `vbo_col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/backgroundmesh.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | vao: vao, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/font.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | image_buffer: image_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/font.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | characters: characters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `characters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/text_buffer/parser.rs:87:28 [INFO] [stderr] | [INFO] [stderr] 87 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 88 | | if let Some(color) = self.colors.get(value.as_str()) { [INFO] [stderr] 89 | | if target.as_str() == "fg" { [INFO] [stderr] 90 | | text_buffer.change_cursor_fg_color(*color); [INFO] [stderr] ... | [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 87 | } else if let Some(color) = self.colors.get(value.as_str()) { [INFO] [stderr] 88 | if target.as_str() == "fg" { [INFO] [stderr] 89 | text_buffer.change_cursor_fg_color(*color); [INFO] [stderr] 90 | } else { [INFO] [stderr] 91 | text_buffer.change_cursor_bg_color(*color); [INFO] [stderr] 92 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/text_buffer/parser.rs:87:28 [INFO] [stderr] | [INFO] [stderr] 87 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 88 | | if let Some(color) = self.colors.get(value.as_str()) { [INFO] [stderr] 89 | | if target.as_str() == "fg" { [INFO] [stderr] 90 | | text_buffer.change_cursor_fg_color(*color); [INFO] [stderr] ... | [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 87 | } else if let Some(color) = self.colors.get(value.as_str()) { [INFO] [stderr] 88 | if target.as_str() == "fg" { [INFO] [stderr] 89 | text_buffer.change_cursor_fg_color(*color); [INFO] [stderr] 90 | } else { [INFO] [stderr] 91 | text_buffer.change_cursor_bg_color(*color); [INFO] [stderr] 92 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let input =` [INFO] [stderr] --> src/display.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | let input = self.input.borrow_mut().clear_just_lists(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/display.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | drop(input); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_copy)] on by default [INFO] [stderr] note: argument has type () [INFO] [stderr] --> src/display.rs:80:14 [INFO] [stderr] | [INFO] [stderr] 80 | drop(input); [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/display.rs:80:14 [INFO] [stderr] | [INFO] [stderr] 80 | drop(input); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 80 | drop(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/display.rs:86:34 [INFO] [stderr] | [INFO] [stderr] 86 | .poll_events(|event| match event { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 87 | | Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 88 | | WindowEvent::Closed => { [INFO] [stderr] 89 | | running = false; [INFO] [stderr] ... | [INFO] [stderr] 103 | | _ => (), [INFO] [stderr] 104 | | }); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 86 | .poll_events(|event| if let Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 87 | WindowEvent::Closed => { [INFO] [stderr] 88 | running = false; [INFO] [stderr] 89 | } [INFO] [stderr] 90 | WindowEvent::Resized(width, height) => { [INFO] [stderr] 91 | dimensions = Some((width, height)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/renderer/mod.rs:266:14 [INFO] [stderr] | [INFO] [stderr] 266 | [CString::new(shader_text).unwrap().as_ptr() as *const i8].as_ptr(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/renderer/mod.rs:266:14 [INFO] [stderr] | [INFO] [stderr] 266 | [CString::new(shader_text).unwrap().as_ptr() as *const i8].as_ptr(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/renderer/mod.rs:285:48 [INFO] [stderr] | [INFO] [stderr] 285 | let log = from_utf8(CStr::from_ptr(mem::transmute(&log)).to_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&log as *const [u8; 1024] as *const i8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/renderer/mod.rs:297:9 [INFO] [stderr] | [INFO] [stderr] 297 | CString::new(attribute).unwrap().as_ptr() as *const i8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/renderer/mod.rs:297:9 [INFO] [stderr] | [INFO] [stderr] 297 | CString::new(attribute).unwrap().as_ptr() as *const i8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/renderer/mod.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | CString::new(uniform.to_string()).unwrap().as_ptr() as *const i8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/renderer/mod.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | CString::new(uniform.to_string()).unwrap().as_ptr() as *const i8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `text_buffer::parser::Parser` [INFO] [stderr] --> src/text_buffer/parser.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Parser { [INFO] [stderr] 18 | | Parser { [INFO] [stderr] 19 | | colors: HashMap::::new(), [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/text_buffer/parser.rs:71:24 [INFO] [stderr] | [INFO] [stderr] 71 | if let Some(_) = capture.get(1) { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 72 | | if target.as_str() == "shake" { [INFO] [stderr] 73 | | text_buffer.change_cursor_shakiness(default_shakiness); [INFO] [stderr] 74 | | } else if target.as_str() == "fg" { [INFO] [stderr] ... | [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________________- help: try this: `if capture.get(1).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/text_buffer/parser.rs:84:29 [INFO] [stderr] | [INFO] [stderr] 84 | Err(_) => panic!("Failed to parse shake-number"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/text_buffer/mod.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | / let background_mesh; [INFO] [stderr] 163 | | if terminal.headless { [INFO] [stderr] 164 | | mesh = None; [INFO] [stderr] 165 | | background_mesh = None; [INFO] [stderr] ... | [INFO] [stderr] 168 | | background_mesh = Some(BackgroundMesh::new(terminal.get_background_program(), dimensions)); [INFO] [stderr] 169 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let background_mesh = if terminal.headless { ..; None } else { ..; Some(BackgroundMesh::new(terminal.get_background_program(), dimensions)) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `terminal::TerminalBuilder` [INFO] [stderr] --> src/terminal.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | / pub fn new() -> TerminalBuilder { [INFO] [stderr] 67 | | TerminalBuilder { [INFO] [stderr] 68 | | title: "Hello, World ! ".to_owned(), [INFO] [stderr] 69 | | dimensions: (1280, 720), [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 64 | impl Default for terminal::TerminalBuilder { [INFO] [stderr] 65 | fn default() -> Self { [INFO] [stderr] 66 | Self::new() [INFO] [stderr] 67 | } [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/terminal.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | / let debug_program; [INFO] [stderr] 171 | | if headless { [INFO] [stderr] 172 | | display = None; [INFO] [stderr] 173 | | program = 0; [INFO] [stderr] ... | [INFO] [stderr] 187 | | renderer::create_program(renderer::VERT_SHADER, renderer::DEBUG_FRAG_SHADER); [INFO] [stderr] 188 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let debug_program = if headless { ..; 0 } else { ..; renderer::create_program(renderer::VERT_SHADER, renderer::DEBUG_FRAG_SHADER) };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/terminal.rs:259:49 [INFO] [stderr] | [INFO] [stderr] 259 | if self.text_buffer_aspect_ratio && text_buffer.aspect_ratio != display.get_aspect_ratio() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(text_buffer.aspect_ratio - display.get_aspect_ratio()).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/terminal.rs:259:49 [INFO] [stderr] | [INFO] [stderr] 259 | if self.text_buffer_aspect_ratio && text_buffer.aspect_ratio != display.get_aspect_ratio() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `glerminal`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/tests/terminal.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | assert_eq!(frame_counter.get_fps(), target_fps as f32 + 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/tests/terminal.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | assert_eq!(frame_counter.get_fps(), target_fps as f32 + 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/tests/text_buffer.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | assert_eq!(text_buffer.aspect_ratio, ar); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/tests/text_buffer.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | assert_eq!(text_buffer.aspect_ratio, ar); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/tests/text_buffer.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | assert_eq!(character.get_shakiness(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/tests/text_buffer.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | assert_eq!(character.get_shakiness(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/tests/text_buffer.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | assert_eq!(character.get_shakiness(), shakiness); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/tests/text_buffer.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | assert_eq!(character.get_shakiness(), shakiness); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/tests/text_buffer.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | assert_eq!(text_buffer.get_cursor_shakiness(), shakiness); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/tests/text_buffer.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | assert_eq!(text_buffer.get_cursor_shakiness(), shakiness); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/tests/parser.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | assert_eq!(character.get_shakiness(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/tests/parser.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | assert_eq!(character.get_shakiness(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/tests/parser.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!(character.get_shakiness(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/tests/parser.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!(character.get_shakiness(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/tests/parser.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | assert_eq!(character.get_shakiness(), shake); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/tests/parser.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | assert_eq!(character.get_shakiness(), shake); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: The function/method `draw` doesn't need a mutable reference [INFO] [stderr] --> src/tests/mod.rs:22:23 [INFO] [stderr] | [INFO] [stderr] 22 | terminal.draw(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let input =` [INFO] [stderr] --> src/display.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | let input = self.input.borrow_mut().clear_just_lists(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/display.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | drop(input); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_copy)] on by default [INFO] [stderr] note: argument has type () [INFO] [stderr] --> src/display.rs:80:14 [INFO] [stderr] | [INFO] [stderr] 80 | drop(input); [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/display.rs:80:14 [INFO] [stderr] | [INFO] [stderr] 80 | drop(input); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 80 | drop(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/display.rs:86:34 [INFO] [stderr] | [INFO] [stderr] 86 | .poll_events(|event| match event { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 87 | | Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 88 | | WindowEvent::Closed => { [INFO] [stderr] 89 | | running = false; [INFO] [stderr] ... | [INFO] [stderr] 103 | | _ => (), [INFO] [stderr] 104 | | }); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 86 | .poll_events(|event| if let Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 87 | WindowEvent::Closed => { [INFO] [stderr] 88 | running = false; [INFO] [stderr] 89 | } [INFO] [stderr] 90 | WindowEvent::Resized(width, height) => { [INFO] [stderr] 91 | dimensions = Some((width, height)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/renderer/mod.rs:266:14 [INFO] [stderr] | [INFO] [stderr] 266 | [CString::new(shader_text).unwrap().as_ptr() as *const i8].as_ptr(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/renderer/mod.rs:266:14 [INFO] [stderr] | [INFO] [stderr] 266 | [CString::new(shader_text).unwrap().as_ptr() as *const i8].as_ptr(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/renderer/mod.rs:285:48 [INFO] [stderr] | [INFO] [stderr] 285 | let log = from_utf8(CStr::from_ptr(mem::transmute(&log)).to_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&log as *const [u8; 1024] as *const i8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/renderer/mod.rs:297:9 [INFO] [stderr] | [INFO] [stderr] 297 | CString::new(attribute).unwrap().as_ptr() as *const i8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/renderer/mod.rs:297:9 [INFO] [stderr] | [INFO] [stderr] 297 | CString::new(attribute).unwrap().as_ptr() as *const i8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/renderer/mod.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | CString::new(uniform.to_string()).unwrap().as_ptr() as *const i8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/renderer/mod.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | CString::new(uniform.to_string()).unwrap().as_ptr() as *const i8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `text_buffer::parser::Parser` [INFO] [stderr] --> src/text_buffer/parser.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Parser { [INFO] [stderr] 18 | | Parser { [INFO] [stderr] 19 | | colors: HashMap::::new(), [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/text_buffer/parser.rs:71:24 [INFO] [stderr] | [INFO] [stderr] 71 | if let Some(_) = capture.get(1) { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 72 | | if target.as_str() == "shake" { [INFO] [stderr] 73 | | text_buffer.change_cursor_shakiness(default_shakiness); [INFO] [stderr] 74 | | } else if target.as_str() == "fg" { [INFO] [stderr] ... | [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________________- help: try this: `if capture.get(1).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/text_buffer/parser.rs:84:29 [INFO] [stderr] | [INFO] [stderr] 84 | Err(_) => panic!("Failed to parse shake-number"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/text_buffer/mod.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | / let background_mesh; [INFO] [stderr] 163 | | if terminal.headless { [INFO] [stderr] 164 | | mesh = None; [INFO] [stderr] 165 | | background_mesh = None; [INFO] [stderr] ... | [INFO] [stderr] 168 | | background_mesh = Some(BackgroundMesh::new(terminal.get_background_program(), dimensions)); [INFO] [stderr] 169 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let background_mesh = if terminal.headless { ..; None } else { ..; Some(BackgroundMesh::new(terminal.get_background_program(), dimensions)) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `terminal::TerminalBuilder` [INFO] [stderr] --> src/terminal.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | / pub fn new() -> TerminalBuilder { [INFO] [stderr] 67 | | TerminalBuilder { [INFO] [stderr] 68 | | title: "Hello, World ! ".to_owned(), [INFO] [stderr] 69 | | dimensions: (1280, 720), [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 64 | impl Default for terminal::TerminalBuilder { [INFO] [stderr] 65 | fn default() -> Self { [INFO] [stderr] 66 | Self::new() [INFO] [stderr] 67 | } [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/terminal.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | / let debug_program; [INFO] [stderr] 171 | | if headless { [INFO] [stderr] 172 | | display = None; [INFO] [stderr] 173 | | program = 0; [INFO] [stderr] ... | [INFO] [stderr] 187 | | renderer::create_program(renderer::VERT_SHADER, renderer::DEBUG_FRAG_SHADER); [INFO] [stderr] 188 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let debug_program = if headless { ..; 0 } else { ..; renderer::create_program(renderer::VERT_SHADER, renderer::DEBUG_FRAG_SHADER) };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/terminal.rs:259:49 [INFO] [stderr] | [INFO] [stderr] 259 | if self.text_buffer_aspect_ratio && text_buffer.aspect_ratio != display.get_aspect_ratio() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(text_buffer.aspect_ratio - display.get_aspect_ratio()).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/terminal.rs:259:49 [INFO] [stderr] | [INFO] [stderr] 259 | if self.text_buffer_aspect_ratio && text_buffer.aspect_ratio != display.get_aspect_ratio() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 13 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `glerminal`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d8731f51b9bd0e7305977eb4073ba9ee12b08a65ccc424beb158cc7e724c2637"` [INFO] running `"docker" "rm" "-f" "d8731f51b9bd0e7305977eb4073ba9ee12b08a65ccc424beb158cc7e724c2637"` [INFO] [stdout] d8731f51b9bd0e7305977eb4073ba9ee12b08a65ccc424beb158cc7e724c2637