[INFO] crate glass 0.1.0 is already in cache [INFO] extracting crate glass 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/glass/0.1.0 [INFO] extracting crate glass 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/glass/0.1.0 [INFO] validating manifest of glass-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of glass-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing glass-0.1.0 [INFO] finished frobbing glass-0.1.0 [INFO] frobbed toml for glass-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/glass/0.1.0/Cargo.toml [INFO] started frobbing glass-0.1.0 [INFO] finished frobbing glass-0.1.0 [INFO] frobbed toml for glass-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/glass/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting glass-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/glass/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 14f7f0c75b2a92d71e07a2613fce5fd0065169090b3120277ef6d5fa664e4c48 [INFO] running `"docker" "start" "-a" "14f7f0c75b2a92d71e07a2613fce5fd0065169090b3120277ef6d5fa664e4c48"` [INFO] [stderr] Checking glass v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/parser.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn parse(tokens: &[Token]) -> AST { [INFO] [stderr] 12 | | let mut ast: AST = vec! { }; [INFO] [stderr] 13 | | let mut stack: Vec = vec! { }; [INFO] [stderr] 14 | | [INFO] [stderr] ... | [INFO] [stderr] 222 | | ast [INFO] [stderr] 223 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parser.rs:115:20 [INFO] [stderr] | [INFO] [stderr] 115 | if stack.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parser.rs:185:20 [INFO] [stderr] | [INFO] [stderr] 185 | if stack.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parser.rs:196:20 [INFO] [stderr] | [INFO] [stderr] 196 | if stack.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/generator/javascript/mod.rs:42:30 [INFO] [stderr] | [INFO] [stderr] 42 | JSName(ref x) => format!("{}", x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `x.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/generator/javascript/mod.rs:306:40 [INFO] [stderr] | [INFO] [stderr] 306 | pub fn generate_without_library(jsast: &JSAST, to_optimize: bool) -> Code { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/generator/javascript/mod.rs:317:37 [INFO] [stderr] | [INFO] [stderr] 317 | pub fn generate_with_library(jsast: &JSAST) -> Code { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/parser.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn parse(tokens: &[Token]) -> AST { [INFO] [stderr] 12 | | let mut ast: AST = vec! { }; [INFO] [stderr] 13 | | let mut stack: Vec = vec! { }; [INFO] [stderr] 14 | | [INFO] [stderr] ... | [INFO] [stderr] 222 | | ast [INFO] [stderr] 223 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parser.rs:115:20 [INFO] [stderr] | [INFO] [stderr] 115 | if stack.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parser.rs:185:20 [INFO] [stderr] | [INFO] [stderr] 185 | if stack.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parser.rs:196:20 [INFO] [stderr] | [INFO] [stderr] 196 | if stack.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/generator/javascript/mod.rs:42:30 [INFO] [stderr] | [INFO] [stderr] 42 | JSName(ref x) => format!("{}", x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `x.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/generator/javascript/mod.rs:306:40 [INFO] [stderr] | [INFO] [stderr] 306 | pub fn generate_without_library(jsast: &JSAST, to_optimize: bool) -> Code { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/generator/javascript/mod.rs:317:37 [INFO] [stderr] | [INFO] [stderr] 317 | pub fn generate_with_library(jsast: &JSAST) -> Code { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `filename` [INFO] [stderr] --> src/main.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let filename = match argv.next() { [INFO] [stderr] | ^^^^^^^^ help: consider using `_filename` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `filename` [INFO] [stderr] --> src/main.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let filename = match argv.next() { [INFO] [stderr] | ^^^^^^^^ help: consider using `_filename` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.24s [INFO] running `"docker" "inspect" "14f7f0c75b2a92d71e07a2613fce5fd0065169090b3120277ef6d5fa664e4c48"` [INFO] running `"docker" "rm" "-f" "14f7f0c75b2a92d71e07a2613fce5fd0065169090b3120277ef6d5fa664e4c48"` [INFO] [stdout] 14f7f0c75b2a92d71e07a2613fce5fd0065169090b3120277ef6d5fa664e4c48