[INFO] crate gl_generator_profiling_struct 0.1.2 is already in cache [INFO] extracting crate gl_generator_profiling_struct 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/gl_generator_profiling_struct/0.1.2 [INFO] extracting crate gl_generator_profiling_struct 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gl_generator_profiling_struct/0.1.2 [INFO] validating manifest of gl_generator_profiling_struct-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gl_generator_profiling_struct-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gl_generator_profiling_struct-0.1.2 [INFO] finished frobbing gl_generator_profiling_struct-0.1.2 [INFO] frobbed toml for gl_generator_profiling_struct-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/gl_generator_profiling_struct/0.1.2/Cargo.toml [INFO] started frobbing gl_generator_profiling_struct-0.1.2 [INFO] finished frobbing gl_generator_profiling_struct-0.1.2 [INFO] frobbed toml for gl_generator_profiling_struct-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gl_generator_profiling_struct/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gl_generator_profiling_struct-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gl_generator_profiling_struct/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 25cccfb04cd3e7f68833ff1cb79fe8ded990e22ff9435620408113b1cf2fc1db [INFO] running `"docker" "start" "-a" "25cccfb04cd3e7f68833ff1cb79fe8ded990e22ff9435620408113b1cf2fc1db"` [INFO] [stderr] Checking khronos_api v2.2.0 [INFO] [stderr] Checking gl_generator v0.9.0 [INFO] [stderr] Checking gl_generator_profiling_struct v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lib.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / r##" [INFO] [stderr] 97 | | static CALL_COUNT: ::std::sync::atomic::AtomicUsize = ::std::sync::atomic::AtomicUsize::new(0); [INFO] [stderr] 98 | | static ERR_COUNT: ::std::sync::atomic::AtomicUsize = ::std::sync::atomic::AtomicUsize::new(0); [INFO] [stderr] 99 | | [INFO] [stderr] ... | [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | "## [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lib.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / r##" [INFO] [stderr] 97 | | static CALL_COUNT: ::std::sync::atomic::AtomicUsize = ::std::sync::atomic::AtomicUsize::new(0); [INFO] [stderr] 98 | | static ERR_COUNT: ::std::sync::atomic::AtomicUsize = ::std::sync::atomic::AtomicUsize::new(0); [INFO] [stderr] 99 | | [INFO] [stderr] ... | [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | "## [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:356:25 [INFO] [stderr] | [INFO] [stderr] 356 | None => format!(""), [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:382:21 [INFO] [stderr] | [INFO] [stderr] 382 | format!(", \"\"") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `", \"\"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/lib.rs:404:27 [INFO] [stderr] | [INFO] [stderr] 404 | / registry [INFO] [stderr] 405 | | .cmds [INFO] [stderr] 406 | | .iter() [INFO] [stderr] 407 | | .find(|cmd| cmd.proto.ident == "GetError") [INFO] [stderr] 408 | | .is_some() { [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|cmd| cmd.proto.ident == "GetError").is_some()` with `any(|cmd| cmd.proto.ident == "GetError")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:412:27 [INFO] [stderr] | [INFO] [stderr] 412 | format!("") [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:356:25 [INFO] [stderr] | [INFO] [stderr] 356 | None => format!(""), [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:382:21 [INFO] [stderr] | [INFO] [stderr] 382 | format!(", \"\"") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `", \"\"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/lib.rs:404:27 [INFO] [stderr] | [INFO] [stderr] 404 | / registry [INFO] [stderr] 405 | | .cmds [INFO] [stderr] 406 | | .iter() [INFO] [stderr] 407 | | .find(|cmd| cmd.proto.ident == "GetError") [INFO] [stderr] 408 | | .is_some() { [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|cmd| cmd.proto.ident == "GetError").is_some()` with `any(|cmd| cmd.proto.ident == "GetError")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:412:27 [INFO] [stderr] | [INFO] [stderr] 412 | format!("") [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.59s [INFO] running `"docker" "inspect" "25cccfb04cd3e7f68833ff1cb79fe8ded990e22ff9435620408113b1cf2fc1db"` [INFO] running `"docker" "rm" "-f" "25cccfb04cd3e7f68833ff1cb79fe8ded990e22ff9435620408113b1cf2fc1db"` [INFO] [stdout] 25cccfb04cd3e7f68833ff1cb79fe8ded990e22ff9435620408113b1cf2fc1db