[INFO] crate gl_generator 0.10.0 is already in cache [INFO] extracting crate gl_generator 0.10.0 into work/ex/clippy-test-run/sources/stable/reg/gl_generator/0.10.0 [INFO] extracting crate gl_generator 0.10.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gl_generator/0.10.0 [INFO] validating manifest of gl_generator-0.10.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gl_generator-0.10.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gl_generator-0.10.0 [INFO] finished frobbing gl_generator-0.10.0 [INFO] frobbed toml for gl_generator-0.10.0 written to work/ex/clippy-test-run/sources/stable/reg/gl_generator/0.10.0/Cargo.toml [INFO] started frobbing gl_generator-0.10.0 [INFO] finished frobbing gl_generator-0.10.0 [INFO] frobbed toml for gl_generator-0.10.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gl_generator/0.10.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gl_generator-0.10.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gl_generator/0.10.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d33a946477ea2ab448b7444e77a9b82a7a8a90bcd2ff269c9b81e31d63a08902 [INFO] running `"docker" "start" "-a" "d33a946477ea2ab448b7444e77a9b82a7a8a90bcd2ff269c9b81e31d63a08902"` [INFO] [stderr] Checking khronos_api v3.0.0 [INFO] [stderr] Checking gl_generator v0.10.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | cast: cast, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cast` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | alias: alias, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alias` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:217:9 [INFO] [stderr] | [INFO] [stderr] 217 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | cast: cast, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cast` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | alias: alias, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alias` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:220:9 [INFO] [stderr] | [INFO] [stderr] 220 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:610:13 [INFO] [stderr] | [INFO] [stderr] 610 | proto: proto, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proto` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:611:13 [INFO] [stderr] | [INFO] [stderr] 611 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:612:13 [INFO] [stderr] | [INFO] [stderr] 612 | alias: alias, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alias` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:613:13 [INFO] [stderr] | [INFO] [stderr] 613 | vecequiv: vecequiv, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vecequiv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:614:13 [INFO] [stderr] | [INFO] [stderr] 614 | glx: glx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `glx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:645:13 [INFO] [stderr] | [INFO] [stderr] 645 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:669:13 [INFO] [stderr] | [INFO] [stderr] 669 | enums: enums, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `enums` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:670:13 [INFO] [stderr] | [INFO] [stderr] 670 | commands: commands, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `commands` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:683:13 [INFO] [stderr] | [INFO] [stderr] 683 | profile: profile, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `profile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:684:13 [INFO] [stderr] | [INFO] [stderr] 684 | enums: enums, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `enums` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:685:13 [INFO] [stderr] | [INFO] [stderr] 685 | commands: commands, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `commands` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:703:13 [INFO] [stderr] | [INFO] [stderr] 703 | api: api, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `api` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:704:13 [INFO] [stderr] | [INFO] [stderr] 704 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:705:13 [INFO] [stderr] | [INFO] [stderr] 705 | number: number, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:735:13 [INFO] [stderr] | [INFO] [stderr] 735 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:736:13 [INFO] [stderr] | [INFO] [stderr] 736 | supported: supported, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `supported` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/mod.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | api: api, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `api` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/mod.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | fallbacks: fallbacks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fallbacks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/mod.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | extensions: extensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/mod.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | profile: profile, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `profile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | cast: cast, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cast` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | alias: alias, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alias` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:217:9 [INFO] [stderr] | [INFO] [stderr] 217 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | cast: cast, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cast` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | alias: alias, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alias` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:220:9 [INFO] [stderr] | [INFO] [stderr] 220 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:610:13 [INFO] [stderr] | [INFO] [stderr] 610 | proto: proto, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proto` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:611:13 [INFO] [stderr] | [INFO] [stderr] 611 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:612:13 [INFO] [stderr] | [INFO] [stderr] 612 | alias: alias, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alias` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:613:13 [INFO] [stderr] | [INFO] [stderr] 613 | vecequiv: vecequiv, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vecequiv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:614:13 [INFO] [stderr] | [INFO] [stderr] 614 | glx: glx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `glx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:645:13 [INFO] [stderr] | [INFO] [stderr] 645 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:669:13 [INFO] [stderr] | [INFO] [stderr] 669 | enums: enums, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `enums` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:670:13 [INFO] [stderr] | [INFO] [stderr] 670 | commands: commands, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `commands` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:683:13 [INFO] [stderr] | [INFO] [stderr] 683 | profile: profile, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `profile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:684:13 [INFO] [stderr] | [INFO] [stderr] 684 | enums: enums, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `enums` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:685:13 [INFO] [stderr] | [INFO] [stderr] 685 | commands: commands, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `commands` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:703:13 [INFO] [stderr] | [INFO] [stderr] 703 | api: api, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `api` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:704:13 [INFO] [stderr] | [INFO] [stderr] 704 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:705:13 [INFO] [stderr] | [INFO] [stderr] 705 | number: number, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:735:13 [INFO] [stderr] | [INFO] [stderr] 735 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/parse.rs:736:13 [INFO] [stderr] | [INFO] [stderr] 736 | supported: supported, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `supported` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/mod.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | api: api, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `api` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/mod.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | fallbacks: fallbacks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fallbacks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/mod.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | extensions: extensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> registry/mod.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | profile: profile, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `profile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> generators/debug_struct_gen.rs:221:25 [INFO] [stderr] | [INFO] [stderr] 221 | None => format!(""), [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> generators/debug_struct_gen.rs:247:21 [INFO] [stderr] | [INFO] [stderr] 247 | format!(", \"\"") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `", \"\"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> generators/debug_struct_gen.rs:270:38 [INFO] [stderr] | [INFO] [stderr] 270 | / registry [INFO] [stderr] 271 | | .cmds [INFO] [stderr] 272 | | .iter() [INFO] [stderr] 273 | | .find(|cmd| cmd.proto.ident == "GetError") [INFO] [stderr] 274 | | .is_some() { [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|cmd| cmd.proto.ident == "GetError").is_some()` with `any(|cmd| cmd.proto.ident == "GetError")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> generators/debug_struct_gen.rs:275:27 [INFO] [stderr] | [INFO] [stderr] 275 | / format!(r#"match __gl_imports::mem::transmute::<_, extern "system" fn() -> u32> [INFO] [stderr] 276 | | (self.GetError.f)() {{ 0 => (), r => println!("[OpenGL] ^ GL error triggered: {{}}", r) }}"#) [INFO] [stderr] | |_________________________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 275 | r#"match __gl_imports::mem::transmute::<_, extern "system" fn() -> u32> [INFO] [stderr] 276 | (self.GetError.f)() {{ 0 => (), r => println!("[OpenGL] ^ GL error triggered: {{}}", r) }}"#.to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> generators/debug_struct_gen.rs:278:27 [INFO] [stderr] | [INFO] [stderr] 278 | format!("") [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> generators/struct_gen.rs:221:25 [INFO] [stderr] | [INFO] [stderr] 221 | None => format!(""), [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> generators/mod.rs:59:23 [INFO] [stderr] | [INFO] [stderr] 59 | cast_suffix = match enm.cast { [INFO] [stderr] | _______________________^ [INFO] [stderr] 60 | | true => format!(" as {}{}", types_prefix, enm.ty), [INFO] [stderr] 61 | | false => String::new(), [INFO] [stderr] 62 | | }, [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if enm.cast { format!(" as {}{}", types_prefix, enm.ty) } else { String::new() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> generators/mod.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | format!("{}", binding.ident) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `binding.ident.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> registry/parse.rs:148:55 [INFO] [stderr] | [INFO] [stderr] 148 | if value.starts_with("((") && value.ends_with(")") { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> registry/parse.rs:154:57 [INFO] [stderr] | [INFO] [stderr] 154 | if let Some((i, _)) = working.match_indices(")").next() { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> registry/parse.rs:167:43 [INFO] [stderr] | [INFO] [stderr] 167 | None if value.starts_with("\"") => "&'static str", [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> registry/parse.rs:186:62 [INFO] [stderr] | [INFO] [stderr] 186 | if value.starts_with("EGL_CAST(") && value.ends_with(")") { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> registry/parse.rs:190:57 [INFO] [stderr] | [INFO] [stderr] 190 | if let Some((i, _)) = working.match_indices(",").next() { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> registry/parse.rs:290:5 [INFO] [stderr] | [INFO] [stderr] 290 | / fn parse(mut self, filter: Filter) -> Registry { [INFO] [stderr] 291 | | self.consume_start_element("registry"); [INFO] [stderr] 292 | | [INFO] [stderr] 293 | | let mut enums = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 415 | | } [INFO] [stderr] 416 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> registry/parse.rs:299:33 [INFO] [stderr] | [INFO] [stderr] 299 | while let Some(event) = self.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for event in self { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> registry/parse.rs:351:42 [INFO] [stderr] | [INFO] [stderr] 351 | desired_enums.extend(require.enums.iter().map(|x| x.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `require.enums.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> registry/parse.rs:352:41 [INFO] [stderr] | [INFO] [stderr] 352 | desired_cmds.extend(require.commands.iter().map(|x| x.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `require.commands.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> registry/parse.rs:386:42 [INFO] [stderr] | [INFO] [stderr] 386 | desired_enums.extend(require.enums.iter().map(|x| x.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `require.enums.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> registry/parse.rs:387:41 [INFO] [stderr] | [INFO] [stderr] 387 | desired_cmds.extend(require.commands.iter().map(|x| x.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `require.commands.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> registry/mod.rs:76:1 [INFO] [stderr] | [INFO] [stderr] 76 | / impl Hash for Enum { [INFO] [stderr] 77 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 78 | | self.ident.hash(state); [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> registry/mod.rs:67:24 [INFO] [stderr] | [INFO] [stderr] 67 | #[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> registry/mod.rs:97:1 [INFO] [stderr] | [INFO] [stderr] 97 | / impl Hash for Cmd { [INFO] [stderr] 98 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 99 | | self.proto.ident.hash(state); [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> registry/mod.rs:88:24 [INFO] [stderr] | [INFO] [stderr] 88 | #[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `gl_generator`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> generators/debug_struct_gen.rs:221:25 [INFO] [stderr] | [INFO] [stderr] 221 | None => format!(""), [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> generators/debug_struct_gen.rs:247:21 [INFO] [stderr] | [INFO] [stderr] 247 | format!(", \"\"") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `", \"\"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> generators/debug_struct_gen.rs:270:38 [INFO] [stderr] | [INFO] [stderr] 270 | / registry [INFO] [stderr] 271 | | .cmds [INFO] [stderr] 272 | | .iter() [INFO] [stderr] 273 | | .find(|cmd| cmd.proto.ident == "GetError") [INFO] [stderr] 274 | | .is_some() { [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|cmd| cmd.proto.ident == "GetError").is_some()` with `any(|cmd| cmd.proto.ident == "GetError")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> generators/debug_struct_gen.rs:275:27 [INFO] [stderr] | [INFO] [stderr] 275 | / format!(r#"match __gl_imports::mem::transmute::<_, extern "system" fn() -> u32> [INFO] [stderr] 276 | | (self.GetError.f)() {{ 0 => (), r => println!("[OpenGL] ^ GL error triggered: {{}}", r) }}"#) [INFO] [stderr] | |_________________________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 275 | r#"match __gl_imports::mem::transmute::<_, extern "system" fn() -> u32> [INFO] [stderr] 276 | (self.GetError.f)() {{ 0 => (), r => println!("[OpenGL] ^ GL error triggered: {{}}", r) }}"#.to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> generators/debug_struct_gen.rs:278:27 [INFO] [stderr] | [INFO] [stderr] 278 | format!("") [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> generators/struct_gen.rs:221:25 [INFO] [stderr] | [INFO] [stderr] 221 | None => format!(""), [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> generators/mod.rs:59:23 [INFO] [stderr] | [INFO] [stderr] 59 | cast_suffix = match enm.cast { [INFO] [stderr] | _______________________^ [INFO] [stderr] 60 | | true => format!(" as {}{}", types_prefix, enm.ty), [INFO] [stderr] 61 | | false => String::new(), [INFO] [stderr] 62 | | }, [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if enm.cast { format!(" as {}{}", types_prefix, enm.ty) } else { String::new() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> generators/mod.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | format!("{}", binding.ident) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `binding.ident.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> registry/parse.rs:148:55 [INFO] [stderr] | [INFO] [stderr] 148 | if value.starts_with("((") && value.ends_with(")") { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> registry/parse.rs:154:57 [INFO] [stderr] | [INFO] [stderr] 154 | if let Some((i, _)) = working.match_indices(")").next() { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> registry/parse.rs:167:43 [INFO] [stderr] | [INFO] [stderr] 167 | None if value.starts_with("\"") => "&'static str", [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> registry/parse.rs:186:62 [INFO] [stderr] | [INFO] [stderr] 186 | if value.starts_with("EGL_CAST(") && value.ends_with(")") { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> registry/parse.rs:190:57 [INFO] [stderr] | [INFO] [stderr] 190 | if let Some((i, _)) = working.match_indices(",").next() { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> registry/parse.rs:290:5 [INFO] [stderr] | [INFO] [stderr] 290 | / fn parse(mut self, filter: Filter) -> Registry { [INFO] [stderr] 291 | | self.consume_start_element("registry"); [INFO] [stderr] 292 | | [INFO] [stderr] 293 | | let mut enums = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 415 | | } [INFO] [stderr] 416 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> registry/parse.rs:299:33 [INFO] [stderr] | [INFO] [stderr] 299 | while let Some(event) = self.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for event in self { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> registry/parse.rs:351:42 [INFO] [stderr] | [INFO] [stderr] 351 | desired_enums.extend(require.enums.iter().map(|x| x.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `require.enums.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> registry/parse.rs:352:41 [INFO] [stderr] | [INFO] [stderr] 352 | desired_cmds.extend(require.commands.iter().map(|x| x.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `require.commands.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> registry/parse.rs:386:42 [INFO] [stderr] | [INFO] [stderr] 386 | desired_enums.extend(require.enums.iter().map(|x| x.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `require.enums.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> registry/parse.rs:387:41 [INFO] [stderr] | [INFO] [stderr] 387 | desired_cmds.extend(require.commands.iter().map(|x| x.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `require.commands.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> registry/mod.rs:76:1 [INFO] [stderr] | [INFO] [stderr] 76 | / impl Hash for Enum { [INFO] [stderr] 77 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 78 | | self.ident.hash(state); [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> registry/mod.rs:67:24 [INFO] [stderr] | [INFO] [stderr] 67 | #[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> registry/mod.rs:97:1 [INFO] [stderr] | [INFO] [stderr] 97 | / impl Hash for Cmd { [INFO] [stderr] 98 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 99 | | self.proto.ident.hash(state); [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> registry/mod.rs:88:24 [INFO] [stderr] | [INFO] [stderr] 88 | #[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `gl_generator`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d33a946477ea2ab448b7444e77a9b82a7a8a90bcd2ff269c9b81e31d63a08902"` [INFO] running `"docker" "rm" "-f" "d33a946477ea2ab448b7444e77a9b82a7a8a90bcd2ff269c9b81e31d63a08902"` [INFO] [stdout] d33a946477ea2ab448b7444e77a9b82a7a8a90bcd2ff269c9b81e31d63a08902