[INFO] crate gj 0.2.0 is already in cache [INFO] extracting crate gj 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/gj/0.2.0 [INFO] extracting crate gj 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gj/0.2.0 [INFO] validating manifest of gj-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gj-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gj-0.2.0 [INFO] finished frobbing gj-0.2.0 [INFO] frobbed toml for gj-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/gj/0.2.0/Cargo.toml [INFO] started frobbing gj-0.2.0 [INFO] finished frobbing gj-0.2.0 [INFO] frobbed toml for gj-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gj/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gj-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gj/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 86573efe68c8f975cf6a681f9f6f900c4279f1534624c3efee1eea4d14ccd179 [INFO] running `"docker" "start" "-a" "86573efe68c8f975cf6a681f9f6f900c4279f1534624c3efee1eea4d14ccd179"` [INFO] [stderr] Checking gj v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/promise_node.rs:43:21 [INFO] [stderr] | [INFO] [stderr] 43 | Transform { dependency: dependency, func: func} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dependency` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/promise_node.rs:43:45 [INFO] [stderr] | [INFO] [stderr] 43 | Transform { dependency: dependency, func: func} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `func` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/promise_node.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | Immediate { result: result } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/promise_node.rs:185:17 [INFO] [stderr] | [INFO] [stderr] 185 | Chain { state: state, dropper: dropper } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/promise_node.rs:185:31 [INFO] [stderr] | [INFO] [stderr] 185 | Chain { state: state, dropper: dropper } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dropper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/promise_node.rs:321:20 [INFO] [stderr] | [INFO] [stderr] 321 | ArrayJoin {state: state} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/promise_node.rs:410:32 [INFO] [stderr] | [INFO] [stderr] 410 | return ExclusiveJoin { state: state }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/promise_node.rs:463:19 [INFO] [stderr] | [INFO] [stderr] 463 | ForkHub { state: state, dropper: dropper } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/promise_node.rs:463:33 [INFO] [stderr] | [INFO] [stderr] 463 | ForkHub { state: state, dropper: dropper } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dropper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/promise_node.rs:488:13 [INFO] [stderr] | [INFO] [stderr] 488 | on_ready_event: on_ready_event, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `on_ready_event` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/mod.rs:174:21 [INFO] [stderr] | [INFO] [stderr] 174 | BoolEvent { fired: fired } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `fired` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/mod.rs:258:38 [INFO] [stderr] | [INFO] [stderr] 258 | PromiseAndFulfillerWrapper { hub: hub } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `hub` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/promise_node.rs:43:21 [INFO] [stderr] | [INFO] [stderr] 43 | Transform { dependency: dependency, func: func} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dependency` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/promise_node.rs:43:45 [INFO] [stderr] | [INFO] [stderr] 43 | Transform { dependency: dependency, func: func} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `func` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/promise_node.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | Immediate { result: result } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/promise_node.rs:185:17 [INFO] [stderr] | [INFO] [stderr] 185 | Chain { state: state, dropper: dropper } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/promise_node.rs:185:31 [INFO] [stderr] | [INFO] [stderr] 185 | Chain { state: state, dropper: dropper } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dropper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/promise_node.rs:321:20 [INFO] [stderr] | [INFO] [stderr] 321 | ArrayJoin {state: state} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/promise_node.rs:410:32 [INFO] [stderr] | [INFO] [stderr] 410 | return ExclusiveJoin { state: state }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/promise_node.rs:463:19 [INFO] [stderr] | [INFO] [stderr] 463 | ForkHub { state: state, dropper: dropper } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/promise_node.rs:463:33 [INFO] [stderr] | [INFO] [stderr] 463 | ForkHub { state: state, dropper: dropper } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dropper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/promise_node.rs:488:13 [INFO] [stderr] | [INFO] [stderr] 488 | on_ready_event: on_ready_event, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `on_ready_event` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/mod.rs:174:21 [INFO] [stderr] | [INFO] [stderr] 174 | BoolEvent { fired: fired } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `fired` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/private/mod.rs:258:38 [INFO] [stderr] | [INFO] [stderr] 258 | PromiseAndFulfillerWrapper { hub: hub } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `hub` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/private/promise_node.rs:410:9 [INFO] [stderr] | [INFO] [stderr] 410 | return ExclusiveJoin { state: state }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ExclusiveJoin { state: state }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/private/promise_node.rs:424:17 [INFO] [stderr] | [INFO] [stderr] 424 | return node.get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `node.get()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/private/promise_node.rs:427:17 [INFO] [stderr] | [INFO] [stderr] 427 | return node.get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `node.get()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/private/promise_node.rs:478:13 [INFO] [stderr] | [INFO] [stderr] 478 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/private/promise_node.rs:536:9 [INFO] [stderr] | [INFO] [stderr] 536 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/private/promise_node.rs:531:22 [INFO] [stderr] | [INFO] [stderr] 531 | let result = match state.borrow().stage { [INFO] [stderr] | ______________________^ [INFO] [stderr] 532 | | ForkHubStage::Done(Ok(ref v)) => Ok(v.clone()), [INFO] [stderr] 533 | | ForkHubStage::Done(Err(ref e)) => Err(e.clone()), [INFO] [stderr] 534 | | _ => unreachable!(), [INFO] [stderr] 535 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handle_table.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handle_table.rs:92:29 [INFO] [stderr] | [INFO] [stderr] 92 | &Some(ref v) => return v, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handle_table.rs:101:37 [INFO] [stderr] | [INFO] [stderr] 101 | &mut Some(ref mut v) => return v, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:451:28 [INFO] [stderr] | [INFO] [stderr] 451 | fn fulfiller_dropped() -> () { () } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/lib.rs:451:36 [INFO] [stderr] | [INFO] [stderr] 451 | fn fulfiller_dropped() -> () { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/private/promise_node.rs:410:9 [INFO] [stderr] | [INFO] [stderr] 410 | return ExclusiveJoin { state: state }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ExclusiveJoin { state: state }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/private/promise_node.rs:424:17 [INFO] [stderr] | [INFO] [stderr] 424 | return node.get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `node.get()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/private/promise_node.rs:427:17 [INFO] [stderr] | [INFO] [stderr] 427 | return node.get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `node.get()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/private/promise_node.rs:478:13 [INFO] [stderr] | [INFO] [stderr] 478 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/private/promise_node.rs:536:9 [INFO] [stderr] | [INFO] [stderr] 536 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/private/promise_node.rs:531:22 [INFO] [stderr] | [INFO] [stderr] 531 | let result = match state.borrow().stage { [INFO] [stderr] | ______________________^ [INFO] [stderr] 532 | | ForkHubStage::Done(Ok(ref v)) => Ok(v.clone()), [INFO] [stderr] 533 | | ForkHubStage::Done(Err(ref e)) => Err(e.clone()), [INFO] [stderr] 534 | | _ => unreachable!(), [INFO] [stderr] 535 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handle_table.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handle_table.rs:92:29 [INFO] [stderr] | [INFO] [stderr] 92 | &Some(ref v) => return v, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handle_table.rs:101:37 [INFO] [stderr] | [INFO] [stderr] 101 | &mut Some(ref mut v) => return v, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:451:28 [INFO] [stderr] | [INFO] [stderr] 451 | fn fulfiller_dropped() -> () { () } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/lib.rs:451:36 [INFO] [stderr] | [INFO] [stderr] 451 | fn fulfiller_dropped() -> () { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `Event` [INFO] [stderr] --> src/lib.rs:54:29 [INFO] [stderr] | [INFO] [stderr] 54 | use private::{promise_node, Event, BoolEvent, PromiseAndFulfillerHub, PromiseAndFulfillerWrapper, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Event` [INFO] [stderr] --> src/lib.rs:54:29 [INFO] [stderr] | [INFO] [stderr] 54 | use private::{promise_node, Event, BoolEvent, PromiseAndFulfillerHub, PromiseAndFulfillerWrapper, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/private/promise_node.rs:117:25 [INFO] [stderr] | [INFO] [stderr] 117 | / match on_ready_event { [INFO] [stderr] 118 | | Some(event) => { [INFO] [stderr] 119 | | intermediate.node.on_ready(event); [INFO] [stderr] 120 | | } [INFO] [stderr] 121 | | None => {} [INFO] [stderr] 122 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 117 | if let Some(event) = on_ready_event { [INFO] [stderr] 118 | intermediate.node.on_ready(event); [INFO] [stderr] 119 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/private/promise_node.rs:128:25 [INFO] [stderr] | [INFO] [stderr] 128 | / match on_ready_event { [INFO] [stderr] 129 | | Some(event) => { [INFO] [stderr] 130 | | node.on_ready(event); [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | None => {} [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 128 | if let Some(event) = on_ready_event { [INFO] [stderr] 129 | node.on_ready(event); [INFO] [stderr] 130 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/private/promise_node.rs:304:13 [INFO] [stderr] | [INFO] [stderr] 304 | promises.into_iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `promises` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/private/promise_node.rs:316:12 [INFO] [stderr] | [INFO] [stderr] 316 | if branches.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `branches.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/private/promise_node.rs:117:25 [INFO] [stderr] | [INFO] [stderr] 117 | / match on_ready_event { [INFO] [stderr] 118 | | Some(event) => { [INFO] [stderr] 119 | | intermediate.node.on_ready(event); [INFO] [stderr] 120 | | } [INFO] [stderr] 121 | | None => {} [INFO] [stderr] 122 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 117 | if let Some(event) = on_ready_event { [INFO] [stderr] 118 | intermediate.node.on_ready(event); [INFO] [stderr] 119 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/private/promise_node.rs:128:25 [INFO] [stderr] | [INFO] [stderr] 128 | / match on_ready_event { [INFO] [stderr] 129 | | Some(event) => { [INFO] [stderr] 130 | | node.on_ready(event); [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | None => {} [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 128 | if let Some(event) = on_ready_event { [INFO] [stderr] 129 | node.on_ready(event); [INFO] [stderr] 130 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/private/promise_node.rs:304:13 [INFO] [stderr] | [INFO] [stderr] 304 | promises.into_iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `promises` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/private/promise_node.rs:316:12 [INFO] [stderr] | [INFO] [stderr] 316 | if branches.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `branches.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/private/promise_node.rs:468:17 [INFO] [stderr] | [INFO] [stderr] 468 | let ref state = &hub.borrow().state; [INFO] [stderr] | ----^^^^^^^^^----------------------- help: try: `let state = &(&hub.borrow().state);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/private/promise_node.rs:468:17 [INFO] [stderr] | [INFO] [stderr] 468 | let ref state = &hub.borrow().state; [INFO] [stderr] | ----^^^^^^^^^----------------------- help: try: `let state = &(&hub.borrow().state);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/private/mod.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | / match self { [INFO] [stderr] 193 | | &OnReadyEvent::AlreadyReady => true, [INFO] [stderr] 194 | | _ => false, [INFO] [stderr] 195 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/private/mod.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | / match self { [INFO] [stderr] 193 | | &OnReadyEvent::AlreadyReady => true, [INFO] [stderr] 194 | | _ => false, [INFO] [stderr] 195 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 192 | match *self { [INFO] [stderr] 193 | OnReadyEvent::AlreadyReady => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/private/mod.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | / match self { [INFO] [stderr] 200 | | &OnReadyEvent::Empty => true, [INFO] [stderr] 201 | | _ => false, [INFO] [stderr] 202 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 199 | match *self { [INFO] [stderr] 200 | OnReadyEvent::Empty => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 192 | match *self { [INFO] [stderr] 193 | OnReadyEvent::AlreadyReady => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/private/mod.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | / match self { [INFO] [stderr] 200 | | &OnReadyEvent::Empty => true, [INFO] [stderr] 201 | | _ => false, [INFO] [stderr] 202 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 199 | match *self { [INFO] [stderr] 200 | OnReadyEvent::Empty => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/handle_table.rs:59:12 [INFO] [stderr] | [INFO] [stderr] 59 | if !result.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `result.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/handle_table.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | / fn index<'a>(&'a self, idx: Handle) -> &'a T { [INFO] [stderr] 91 | | match &self.slots[idx.val] { [INFO] [stderr] 92 | | &Some(ref v) => return v, [INFO] [stderr] 93 | | &None => panic!("invalid handle idx: {}", idx.val), [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/handle_table.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / match &self.slots[idx.val] { [INFO] [stderr] 92 | | &Some(ref v) => return v, [INFO] [stderr] 93 | | &None => panic!("invalid handle idx: {}", idx.val), [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 91 | match self.slots[idx.val] { [INFO] [stderr] 92 | Some(ref v) => return v, [INFO] [stderr] 93 | None => panic!("invalid handle idx: {}", idx.val), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/handle_table.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / fn index_mut<'a>(&'a mut self, idx: Handle) -> &'a mut T { [INFO] [stderr] 100 | | match &mut self.slots[idx.val] { [INFO] [stderr] 101 | | &mut Some(ref mut v) => return v, [INFO] [stderr] 102 | | &mut None => panic!("invalid handle idx: {}", idx.val), [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/handle_table.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | / match &mut self.slots[idx.val] { [INFO] [stderr] 101 | | &mut Some(ref mut v) => return v, [INFO] [stderr] 102 | | &mut None => panic!("invalid handle idx: {}", idx.val), [INFO] [stderr] 103 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 100 | match *(&mut self.slots[idx.val]) { [INFO] [stderr] 101 | Some(ref mut v) => return v, [INFO] [stderr] 102 | None => panic!("invalid handle idx: {}", idx.val), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/handle_table.rs:59:12 [INFO] [stderr] | [INFO] [stderr] 59 | if !result.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `result.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/handle_table.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | / fn index<'a>(&'a self, idx: Handle) -> &'a T { [INFO] [stderr] 91 | | match &self.slots[idx.val] { [INFO] [stderr] 92 | | &Some(ref v) => return v, [INFO] [stderr] 93 | | &None => panic!("invalid handle idx: {}", idx.val), [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/handle_table.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / match &self.slots[idx.val] { [INFO] [stderr] 92 | | &Some(ref v) => return v, [INFO] [stderr] 93 | | &None => panic!("invalid handle idx: {}", idx.val), [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 91 | match self.slots[idx.val] { [INFO] [stderr] 92 | Some(ref v) => return v, [INFO] [stderr] 93 | None => panic!("invalid handle idx: {}", idx.val), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/handle_table.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / fn index_mut<'a>(&'a mut self, idx: Handle) -> &'a mut T { [INFO] [stderr] 100 | | match &mut self.slots[idx.val] { [INFO] [stderr] 101 | | &mut Some(ref mut v) => return v, [INFO] [stderr] 102 | | &mut None => panic!("invalid handle idx: {}", idx.val), [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/handle_table.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | / match &mut self.slots[idx.val] { [INFO] [stderr] 101 | | &mut Some(ref mut v) => return v, [INFO] [stderr] 102 | | &mut None => panic!("invalid handle idx: {}", idx.val), [INFO] [stderr] 103 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 100 | match *(&mut self.slots[idx.val]) { [INFO] [stderr] 101 | Some(ref mut v) => return v, [INFO] [stderr] 102 | None => panic!("invalid handle idx: {}", idx.val), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/lib.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | drop(wait_scope); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_ref)] on by default [INFO] [stderr] note: argument has type &WaitScope [INFO] [stderr] --> src/lib.rs:207:14 [INFO] [stderr] | [INFO] [stderr] 207 | drop(wait_scope); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/lib.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | drop(wait_scope); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_ref)] on by default [INFO] [stderr] note: argument has type &WaitScope [INFO] [stderr] --> src/lib.rs:207:14 [INFO] [stderr] | [INFO] [stderr] 207 | drop(wait_scope); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `gj`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `gj`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "86573efe68c8f975cf6a681f9f6f900c4279f1534624c3efee1eea4d14ccd179"` [INFO] running `"docker" "rm" "-f" "86573efe68c8f975cf6a681f9f6f900c4279f1534624c3efee1eea4d14ccd179"` [INFO] [stdout] 86573efe68c8f975cf6a681f9f6f900c4279f1534624c3efee1eea4d14ccd179