[INFO] crate github_auth 0.7.1 is already in cache [INFO] extracting crate github_auth 0.7.1 into work/ex/clippy-test-run/sources/stable/reg/github_auth/0.7.1 [INFO] extracting crate github_auth 0.7.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/github_auth/0.7.1 [INFO] validating manifest of github_auth-0.7.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of github_auth-0.7.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing github_auth-0.7.1 [INFO] finished frobbing github_auth-0.7.1 [INFO] frobbed toml for github_auth-0.7.1 written to work/ex/clippy-test-run/sources/stable/reg/github_auth/0.7.1/Cargo.toml [INFO] started frobbing github_auth-0.7.1 [INFO] finished frobbing github_auth-0.7.1 [INFO] frobbed toml for github_auth-0.7.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/github_auth/0.7.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting github_auth-0.7.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/github_auth/0.7.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ad12fefe04bd095f64ccb738498f89f1407645f87247d78141768df76a2afaad [INFO] running `"docker" "start" "-a" "ad12fefe04bd095f64ccb738498f89f1407645f87247d78141768df76a2afaad"` [INFO] [stderr] Checking mkdirp v0.1.0 [INFO] [stderr] Checking dialoguer v0.1.0 [INFO] [stderr] Checking github_auth v0.7.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | pub const GITHUB_AUTH_URL: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | pub const GITHUB_AUTH_URL: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::const_static_lifetime)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `github_auth`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/authenticator.rs:70:8 [INFO] [stderr] | [INFO] [stderr] 70 | Ok(remove_file(self.location()?)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 70 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/builder.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if let None = self.scopes { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 33 | | self.scopes = Some(vec![]); [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____- help: try this: `if self.scopes.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "ad12fefe04bd095f64ccb738498f89f1407645f87247d78141768df76a2afaad"` [INFO] running `"docker" "rm" "-f" "ad12fefe04bd095f64ccb738498f89f1407645f87247d78141768df76a2afaad"` [INFO] [stdout] ad12fefe04bd095f64ccb738498f89f1407645f87247d78141768df76a2afaad