[INFO] crate github 0.1.2 is already in cache
[INFO] extracting crate github 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/github/0.1.2
[INFO] extracting crate github 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/github/0.1.2
[INFO] validating manifest of github-0.1.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of github-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing github-0.1.2
[INFO] finished frobbing github-0.1.2
[INFO] frobbed toml for github-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/github/0.1.2/Cargo.toml
[INFO] started frobbing github-0.1.2
[INFO] finished frobbing github-0.1.2
[INFO] frobbed toml for github-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/github/0.1.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting github-0.1.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/github/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 66a8c0cf1eb3adb7b8f2468a525add595fd062e2cba1c6705d8b9cb3ebebd9d8
[INFO] running `"docker" "start" "-a" "66a8c0cf1eb3adb7b8f2468a525add595fd062e2cba1c6705d8b9cb3ebebd9d8"`
[INFO] [stderr]    Compiling curl-sys v0.1.35
[INFO] [stderr]     Checking curl v0.2.19
[INFO] [stderr]     Checking github v0.1.2 (/opt/crater/workdir)
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]    --> src/error.rs:150:5
[INFO] [stderr]     |
[INFO] [stderr] 150 | /     pub fn new<T>(code: u32, buffer: &[u8]) -> Result<T, ClientError> {
[INFO] [stderr] 151 | |         Err(ClientError::Http(RequestError {
[INFO] [stderr] 152 | |             code: ErrorStatus::new(code),
[INFO] [stderr] 153 | |             errors: match str::from_utf8(buffer) {
[INFO] [stderr] ...   |
[INFO] [stderr] 157 | |         }))
[INFO] [stderr] 158 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/error.rs:155:29
[INFO] [stderr]     |
[INFO] [stderr] 155 |                 Ok(body) => json::decode(body).unwrap_or(Vec::new()),
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `json::decode(body).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]    --> src/error.rs:183:5
[INFO] [stderr]     |
[INFO] [stderr] 183 | /     pub fn new<T>(msg: &str) -> Result<T, ClientError> {
[INFO] [stderr] 184 | |         Err(ClientError::Internal(InternalError { msg: msg.to_string() }))
[INFO] [stderr] 185 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/error.rs:210:9
[INFO] [stderr]     |
[INFO] [stderr] 210 | /         match self {
[INFO] [stderr] 211 | |             &ClientError::Http(ref e) => write!(f, "{}", e),
[INFO] [stderr] 212 | |             &ClientError::Internal(ref e) => write!(f, "{}", e),
[INFO] [stderr] 213 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 210 |         match *self {
[INFO] [stderr] 211 |             ClientError::Http(ref e) => write!(f, "{}", e),
[INFO] [stderr] 212 |             ClientError::Internal(ref e) => write!(f, "{}", e),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]    --> src/error.rs:150:5
[INFO] [stderr]     |
[INFO] [stderr] 150 | /     pub fn new<T>(code: u32, buffer: &[u8]) -> Result<T, ClientError> {
[INFO] [stderr] 151 | |         Err(ClientError::Http(RequestError {
[INFO] [stderr] 152 | |             code: ErrorStatus::new(code),
[INFO] [stderr] 153 | |             errors: match str::from_utf8(buffer) {
[INFO] [stderr] ...   |
[INFO] [stderr] 157 | |         }))
[INFO] [stderr] 158 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/error.rs:155:29
[INFO] [stderr]     |
[INFO] [stderr] 155 |                 Ok(body) => json::decode(body).unwrap_or(Vec::new()),
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `json::decode(body).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]    --> src/error.rs:183:5
[INFO] [stderr]     |
[INFO] [stderr] 183 | /     pub fn new<T>(msg: &str) -> Result<T, ClientError> {
[INFO] [stderr] 184 | |         Err(ClientError::Internal(InternalError { msg: msg.to_string() }))
[INFO] [stderr] 185 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/error.rs:210:9
[INFO] [stderr]     |
[INFO] [stderr] 210 | /         match self {
[INFO] [stderr] 211 | |             &ClientError::Http(ref e) => write!(f, "{}", e),
[INFO] [stderr] 212 | |             &ClientError::Internal(ref e) => write!(f, "{}", e),
[INFO] [stderr] 213 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 210 |         match *self {
[INFO] [stderr] 211 |             ClientError::Http(ref e) => write!(f, "{}", e),
[INFO] [stderr] 212 |             ClientError::Internal(ref e) => write!(f, "{}", e),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 20s
[INFO] running `"docker" "inspect" "66a8c0cf1eb3adb7b8f2468a525add595fd062e2cba1c6705d8b9cb3ebebd9d8"`
[INFO] running `"docker" "rm" "-f" "66a8c0cf1eb3adb7b8f2468a525add595fd062e2cba1c6705d8b9cb3ebebd9d8"`
[INFO] [stdout] 66a8c0cf1eb3adb7b8f2468a525add595fd062e2cba1c6705d8b9cb3ebebd9d8