[INFO] crate gitdb 0.1.1 is already in cache
[INFO] extracting crate gitdb 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/gitdb/0.1.1
[INFO] extracting crate gitdb 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gitdb/0.1.1
[INFO] validating manifest of gitdb-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of gitdb-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing gitdb-0.1.1
[INFO] finished frobbing gitdb-0.1.1
[INFO] frobbed toml for gitdb-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/gitdb/0.1.1/Cargo.toml
[INFO] started frobbing gitdb-0.1.1
[INFO] finished frobbing gitdb-0.1.1
[INFO] frobbed toml for gitdb-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gitdb/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting gitdb-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gitdb/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4f3b39f1aafd90045e469009407862cad7b694d1c8e400c2785c828ee0463bcf
[INFO] running `"docker" "start" "-a" "4f3b39f1aafd90045e469009407862cad7b694d1c8e400c2785c828ee0463bcf"`
[INFO] [stderr]     Checking gitdb v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/crypto.rs:66:13
[INFO] [stderr]    |
[INFO] [stderr] 66 |             data: data,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/crypto.rs:67:13
[INFO] [stderr]    |
[INFO] [stderr] 67 |             meta: meta
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `meta`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/git_db.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |             repo: repo,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `repo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/crypto.rs:66:13
[INFO] [stderr]    |
[INFO] [stderr] 66 |             data: data,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/crypto.rs:67:13
[INFO] [stderr]    |
[INFO] [stderr] 67 |             meta: meta
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `meta`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/git_db.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |             repo: repo,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `repo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/crypto.rs:116:5
[INFO] [stderr]     |
[INFO] [stderr] 116 | /     return [
[INFO] [stderr] 117 | |         ((i >> 24) & 0xff) as u8,
[INFO] [stderr] 118 | |         ((i >> 16) & 0xff) as u8,
[INFO] [stderr] 119 | |         ((i >> 8) & 0xff) as u8,
[INFO] [stderr] 120 | |         (i & 0xff) as u8
[INFO] [stderr] 121 | |     ]
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 116 |     [
[INFO] [stderr] 117 |         ((i >> 24) & 0xff) as u8,
[INFO] [stderr] 118 |         ((i >> 16) & 0xff) as u8,
[INFO] [stderr] 119 |         ((i >> 8) & 0xff) as u8,
[INFO] [stderr] 120 |         (i & 0xff) as u8
[INFO] [stderr] 121 |     ]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/crypto.rs:116:5
[INFO] [stderr]     |
[INFO] [stderr] 116 | /     return [
[INFO] [stderr] 117 | |         ((i >> 24) & 0xff) as u8,
[INFO] [stderr] 118 | |         ((i >> 16) & 0xff) as u8,
[INFO] [stderr] 119 | |         ((i >> 8) & 0xff) as u8,
[INFO] [stderr] 120 | |         (i & 0xff) as u8
[INFO] [stderr] 121 | |     ]
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 116 |     [
[INFO] [stderr] 117 |         ((i >> 24) & 0xff) as u8,
[INFO] [stderr] 118 |         ((i >> 16) & 0xff) as u8,
[INFO] [stderr] 119 |         ((i >> 8) & 0xff) as u8,
[INFO] [stderr] 120 |         (i & 0xff) as u8
[INFO] [stderr] 121 |     ]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `obscure_input`
[INFO] [stderr]    --> src/crypto.rs:203:33
[INFO] [stderr]     |
[INFO] [stderr] 203 | pub fn read_stdin(prompt: &str, obscure_input: bool) -> Result<String, String> {
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^ help: consider using `_obscure_input` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `obscure_input`
[INFO] [stderr]    --> src/crypto.rs:203:33
[INFO] [stderr]     |
[INFO] [stderr] 203 | pub fn read_stdin(prompt: &str, obscure_input: bool) -> Result<String, String> {
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^ help: consider using `_obscure_input` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `crypto::Session`
[INFO] [stderr]   --> src/crypto.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 | /     pub fn new() -> Session {
[INFO] [stderr] 27 | |         Session {
[INFO] [stderr] 28 | |             password: None
[INFO] [stderr] 29 | |         }
[INFO] [stderr] 30 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 11 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/crypto.rs:124:25
[INFO] [stderr]     |
[INFO] [stderr] 124 | pub fn bytes_to_u32(xs: &[u8; 4]) -> u32 {
[INFO] [stderr]     |                         ^^^^^^^^ help: consider passing by value instead: `[u8; 4]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/crypto.rs:126:6
[INFO] [stderr]     |
[INFO] [stderr] 126 |     ((xs[0] as u32) << 24)
[INFO] [stderr]     |      ^^^^^^^^^^^^^^ help: try: `u32::from(xs[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/crypto.rs:127:12
[INFO] [stderr]     |
[INFO] [stderr] 127 |         | ((xs[1] as u32) << 16)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: try: `u32::from(xs[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/crypto.rs:128:12
[INFO] [stderr]     |
[INFO] [stderr] 128 |         | ((xs[2] as u32) << 8)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: try: `u32::from(xs[2])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/crypto.rs:129:11
[INFO] [stderr]     |
[INFO] [stderr] 129 |         | (xs[3] as u32)
[INFO] [stderr]     |           ^^^^^^^^^^^^^^ help: try: `u32::from(xs[3])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/crypto.rs:146:21
[INFO] [stderr]     |
[INFO] [stderr] 146 |     let pad_bits = ((meta.plaintext.min_bits as i64) - (data.len() * 8) as i64).max(0) as u32;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(meta.plaintext.min_bits)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `crypto::Session`
[INFO] [stderr]   --> src/crypto.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 | /     pub fn new() -> Session {
[INFO] [stderr] 27 | |         Session {
[INFO] [stderr] 28 | |             password: None
[INFO] [stderr] 29 | |         }
[INFO] [stderr] 30 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 11 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/encoding.rs:3:24
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn decode(encoded: &String) -> Result<Vec<u8>, String> {
[INFO] [stderr]   |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/encoding.rs:8:21
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn encode(data: &Vec<u8>) -> String {
[INFO] [stderr]   |                     ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/crypto.rs:124:25
[INFO] [stderr]     |
[INFO] [stderr] 124 | pub fn bytes_to_u32(xs: &[u8; 4]) -> u32 {
[INFO] [stderr]     |                         ^^^^^^^^ help: consider passing by value instead: `[u8; 4]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/crypto.rs:126:6
[INFO] [stderr]     |
[INFO] [stderr] 126 |     ((xs[0] as u32) << 24)
[INFO] [stderr]     |      ^^^^^^^^^^^^^^ help: try: `u32::from(xs[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/crypto.rs:127:12
[INFO] [stderr]     |
[INFO] [stderr] 127 |         | ((xs[1] as u32) << 16)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: try: `u32::from(xs[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/crypto.rs:128:12
[INFO] [stderr]     |
[INFO] [stderr] 128 |         | ((xs[2] as u32) << 8)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: try: `u32::from(xs[2])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/crypto.rs:129:11
[INFO] [stderr]     |
[INFO] [stderr] 129 |         | (xs[3] as u32)
[INFO] [stderr]     |           ^^^^^^^^^^^^^^ help: try: `u32::from(xs[3])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/crypto.rs:146:21
[INFO] [stderr]     |
[INFO] [stderr] 146 |     let pad_bits = ((meta.plaintext.min_bits as i64) - (data.len() * 8) as i64).max(0) as u32;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(meta.plaintext.min_bits)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/git_creds.rs:37:35
[INFO] [stderr]    |
[INFO] [stderr] 37 |     pub fn from_toml_bytes(bytes: &Vec<u8>) -> Result<Remotes, String> {
[INFO] [stderr]    |                                   ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/encoding.rs:3:24
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn decode(encoded: &String) -> Result<Vec<u8>, String> {
[INFO] [stderr]   |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/encoding.rs:8:21
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn encode(data: &Vec<u8>) -> String {
[INFO] [stderr]   |                     ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/git_db.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 | /         let mut files_changed = false;
[INFO] [stderr] 42 | |         
[INFO] [stderr] 43 | |         // It's important to create the burnt_nonces file first since it is used
[INFO] [stderr] 44 | |         // by the encryption algorithm in the next few files
[INFO] [stderr] ...  |
[INFO] [stderr] 49 | |             files_changed = true;
[INFO] [stderr] 50 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> files_changed = if !root.join(&burnt_nonces).is_file() { ..; true } else { false };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/git_db.rs:138:29
[INFO] [stderr]     |
[INFO] [stderr] 138 |     pub fn get(&self, path: &String, mut sess: &mut crypto::Session) -> Result<crypto::Encrypted, String> {
[INFO] [stderr]     |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/git_db.rs:150:28
[INFO] [stderr]     |
[INFO] [stderr] 150 |     pub fn rm(&self, path: &String, mut sess: &mut crypto::Session) -> Result<(), String> {
[INFO] [stderr]     |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/git_db.rs:153:12
[INFO] [stderr]     |
[INFO] [stderr] 153 |         if matching_entries.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `matching_entries.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/git_creds.rs:37:35
[INFO] [stderr]    |
[INFO] [stderr] 37 |     pub fn from_toml_bytes(bytes: &Vec<u8>) -> Result<Remotes, String> {
[INFO] [stderr]    |                                   ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/git_db.rs:167:53
[INFO] [stderr]     |
[INFO] [stderr] 167 |           let updated_entries: Vec<manifest::Entry> = manifest.entries.iter()
[INFO] [stderr]     |  _____________________________________________________^
[INFO] [stderr] 168 | |             .filter(|e| &e.path != path)
[INFO] [stderr] 169 | |             .map(|e| e.clone())
[INFO] [stderr]     | |_______________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 167 |         let updated_entries: Vec<manifest::Entry> = manifest.entries.iter()
[INFO] [stderr] 168 |             .filter(|e| &e.path != path).cloned()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/git_db.rs:195:39
[INFO] [stderr]     |
[INFO] [stderr] 195 |     pub fn remove_remote(&self, name: &String, mut sess: &mut crypto::Session) -> Result<(), String> {
[INFO] [stderr]     |                                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/git_db.rs:197:39
[INFO] [stderr]     |
[INFO] [stderr] 197 |           let updated_remotes: Vec<_> = remotes
[INFO] [stderr]     |  _______________________________________^
[INFO] [stderr] 198 | |             .remotes
[INFO] [stderr] 199 | |             .iter()
[INFO] [stderr] 200 | |             .filter(|r| &r.name != name)
[INFO] [stderr] 201 | |             .map(|r| r.clone())
[INFO] [stderr]     | |_______________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 197 |         let updated_remotes: Vec<_> = remotes
[INFO] [stderr] 198 |             .remotes
[INFO] [stderr] 199 |             .iter()
[INFO] [stderr] 200 |             .filter(|r| &r.name != name).cloned()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/git_db.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 | /         let mut files_changed = false;
[INFO] [stderr] 42 | |         
[INFO] [stderr] 43 | |         // It's important to create the burnt_nonces file first since it is used
[INFO] [stderr] 44 | |         // by the encryption algorithm in the next few files
[INFO] [stderr] ...  |
[INFO] [stderr] 49 | |             files_changed = true;
[INFO] [stderr] 50 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> files_changed = if !root.join(&burnt_nonces).is_file() { ..; true } else { false };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/git_db.rs:231:34
[INFO] [stderr]     |
[INFO] [stderr] 231 |     fn commit(&self, commit_msg: &String, extra_parents: &Vec<&git2::Commit>) -> Result<(), String> {
[INFO] [stderr]     |                                  ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/git_db.rs:231:58
[INFO] [stderr]     |
[INFO] [stderr] 231 |     fn commit(&self, commit_msg: &String, extra_parents: &Vec<&git2::Commit>) -> Result<(), String> {
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[&git2::Commit]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/git_db.rs:244:22
[INFO] [stderr]     |
[INFO] [stderr] 244 |                     .ok_or(format!("Failed to find oid referenced by HEAD"))
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Failed to find oid referenced by HEAD"))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/git_db.rs:244:28
[INFO] [stderr]     |
[INFO] [stderr] 244 |                     .ok_or(format!("Failed to find oid referenced by HEAD"))
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Failed to find oid referenced by HEAD".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/git_db.rs:138:29
[INFO] [stderr]     |
[INFO] [stderr] 138 |     pub fn get(&self, path: &String, mut sess: &mut crypto::Session) -> Result<crypto::Encrypted, String> {
[INFO] [stderr]     |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/git_db.rs:150:28
[INFO] [stderr]     |
[INFO] [stderr] 150 |     pub fn rm(&self, path: &String, mut sess: &mut crypto::Session) -> Result<(), String> {
[INFO] [stderr]     |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/git_db.rs:288:14
[INFO] [stderr]     |
[INFO] [stderr] 288 |             .ok_or(format!("Failed to fetch remote oid: remote {}", remote.name))?;
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Failed to fetch remote oid: remote {}", remote.name))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/git_db.rs:153:12
[INFO] [stderr]     |
[INFO] [stderr] 153 |         if matching_entries.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `matching_entries.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/git_db.rs:167:53
[INFO] [stderr]     |
[INFO] [stderr] 167 |           let updated_entries: Vec<manifest::Entry> = manifest.entries.iter()
[INFO] [stderr]     |  _____________________________________________________^
[INFO] [stderr] 168 | |             .filter(|e| &e.path != path)
[INFO] [stderr] 169 | |             .map(|e| e.clone())
[INFO] [stderr]     | |_______________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 167 |         let updated_entries: Vec<manifest::Entry> = manifest.entries.iter()
[INFO] [stderr] 168 |             .filter(|e| &e.path != path).cloned()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/git_db.rs:195:39
[INFO] [stderr]     |
[INFO] [stderr] 195 |     pub fn remove_remote(&self, name: &String, mut sess: &mut crypto::Session) -> Result<(), String> {
[INFO] [stderr]     |                                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/git_db.rs:197:39
[INFO] [stderr]     |
[INFO] [stderr] 197 |           let updated_remotes: Vec<_> = remotes
[INFO] [stderr]     |  _______________________________________^
[INFO] [stderr] 198 | |             .remotes
[INFO] [stderr] 199 | |             .iter()
[INFO] [stderr] 200 | |             .filter(|r| &r.name != name)
[INFO] [stderr] 201 | |             .map(|r| r.clone())
[INFO] [stderr]     | |_______________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 197 |         let updated_remotes: Vec<_> = remotes
[INFO] [stderr] 198 |             .remotes
[INFO] [stderr] 199 |             .iter()
[INFO] [stderr] 200 |             .filter(|r| &r.name != name).cloned()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/git_db.rs:231:34
[INFO] [stderr]     |
[INFO] [stderr] 231 |     fn commit(&self, commit_msg: &String, extra_parents: &Vec<&git2::Commit>) -> Result<(), String> {
[INFO] [stderr]     |                                  ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/git_db.rs:231:58
[INFO] [stderr]     |
[INFO] [stderr] 231 |     fn commit(&self, commit_msg: &String, extra_parents: &Vec<&git2::Commit>) -> Result<(), String> {
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[&git2::Commit]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/git_db.rs:244:22
[INFO] [stderr]     |
[INFO] [stderr] 244 |                     .ok_or(format!("Failed to find oid referenced by HEAD"))
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Failed to find oid referenced by HEAD"))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/git_db.rs:244:28
[INFO] [stderr]     |
[INFO] [stderr] 244 |                     .ok_or(format!("Failed to find oid referenced by HEAD"))
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Failed to find oid referenced by HEAD".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: statement can be reduced
[INFO] [stderr]    --> src/git_db.rs:365:9
[INFO] [stderr]     |
[INFO] [stderr] 365 | /         &self.repo.checkout_head(None)
[INFO] [stderr] 366 | |             .map_err(|e| format!("Failed to checkout head: {:?}", e))?;
[INFO] [stderr]     | |_______________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_operation)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
[INFO] [stderr] help: replace it with
[INFO] [stderr]     |
[INFO] [stderr] 365 |         self.repo.checkout_head(None)
[INFO] [stderr] 366 |             .map_err(|e| format!("Failed to checkout head: {:?}", e))?;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/git_db.rs:376:29
[INFO] [stderr]     |
[INFO] [stderr] 376 |         self.repo.workdir().ok_or("Repo is bare, no working directory".to_string())
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Repo is bare, no working directory".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/git_db.rs:288:14
[INFO] [stderr]     |
[INFO] [stderr] 288 |             .ok_or(format!("Failed to fetch remote oid: remote {}", remote.name))?;
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Failed to fetch remote oid: remote {}", remote.name))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/git_db.rs:427:33
[INFO] [stderr]     |
[INFO] [stderr] 427 |     fn burn_nonce(&self, nonce: &Vec<u8>) -> Result<(), String> {
[INFO] [stderr]     |                                 ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: statement can be reduced
[INFO] [stderr]    --> src/git_db.rs:365:9
[INFO] [stderr]     |
[INFO] [stderr] 365 | /         &self.repo.checkout_head(None)
[INFO] [stderr] 366 | |             .map_err(|e| format!("Failed to checkout head: {:?}", e))?;
[INFO] [stderr]     | |_______________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_operation)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
[INFO] [stderr] help: replace it with
[INFO] [stderr]     |
[INFO] [stderr] 365 |         self.repo.checkout_head(None)
[INFO] [stderr] 366 |             .map_err(|e| format!("Failed to checkout head: {:?}", e))?;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/git_db.rs:376:29
[INFO] [stderr]     |
[INFO] [stderr] 376 |         self.repo.workdir().ok_or("Repo is bare, no working directory".to_string())
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Repo is bare, no working directory".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/git_db.rs:427:33
[INFO] [stderr]     |
[INFO] [stderr] 427 |     fn burn_nonce(&self, nonce: &Vec<u8>) -> Result<(), String> {
[INFO] [stderr]     |                                 ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/manifest.rs:41:35
[INFO] [stderr]    |
[INFO] [stderr] 41 |     pub fn from_toml_bytes(bytes: &Vec<u8>) -> Result<Manifest, String> {
[INFO] [stderr]    |                                   ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/manifest.rs:53:22
[INFO] [stderr]    |
[INFO] [stderr] 53 |     pub fn new(path: &String, tags: &Vec<String>) -> EntryRequest{
[INFO] [stderr]    |                      ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 53 |     pub fn new(path: &str, tags: &Vec<String>) -> EntryRequest{
[INFO] [stderr]    |                      ^^^^
[INFO] [stderr] help: change `path.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 55 |             path: path.to_string(),
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/manifest.rs:53:37
[INFO] [stderr]    |
[INFO] [stderr] 53 |     pub fn new(path: &String, tags: &Vec<String>) -> EntryRequest{
[INFO] [stderr]    |                                     ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 53 |     pub fn new(path: &String, tags: &[String]) -> EntryRequest{
[INFO] [stderr]    |                                     ^^^^^^^^^
[INFO] [stderr] help: change `tags.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 56 |             tags: tags.to_owned()
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/manifest.rs:61:37
[INFO] [stderr]    |
[INFO] [stderr] 61 |         for comp in self.path.split("/") {
[INFO] [stderr]    |                                     ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/manifest.rs:65:28
[INFO] [stderr]    |
[INFO] [stderr] 65 |                 return Err(format!("lookup path must not start or end in '/' or '\\'"))
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"lookup path must not start or end in '/' or '\\'".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/manifest.rs:67:16
[INFO] [stderr]    |
[INFO] [stderr] 67 |             if comp.len() == 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `comp.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/manifest.rs:41:35
[INFO] [stderr]    |
[INFO] [stderr] 41 |     pub fn from_toml_bytes(bytes: &Vec<u8>) -> Result<Manifest, String> {
[INFO] [stderr]    |                                   ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/manifest.rs:53:22
[INFO] [stderr]    |
[INFO] [stderr] 53 |     pub fn new(path: &String, tags: &Vec<String>) -> EntryRequest{
[INFO] [stderr]    |                      ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 53 |     pub fn new(path: &str, tags: &Vec<String>) -> EntryRequest{
[INFO] [stderr]    |                      ^^^^
[INFO] [stderr] help: change `path.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 55 |             path: path.to_string(),
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/manifest.rs:53:37
[INFO] [stderr]    |
[INFO] [stderr] 53 |     pub fn new(path: &String, tags: &Vec<String>) -> EntryRequest{
[INFO] [stderr]    |                                     ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 53 |     pub fn new(path: &String, tags: &[String]) -> EntryRequest{
[INFO] [stderr]    |                                     ^^^^^^^^^
[INFO] [stderr] help: change `tags.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 56 |             tags: tags.to_owned()
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/manifest.rs:61:37
[INFO] [stderr]    |
[INFO] [stderr] 61 |         for comp in self.path.split("/") {
[INFO] [stderr]    |                                     ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/manifest.rs:65:28
[INFO] [stderr]    |
[INFO] [stderr] 65 |                 return Err(format!("lookup path must not start or end in '/' or '\\'"))
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"lookup path must not start or end in '/' or '\\'".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/manifest.rs:67:16
[INFO] [stderr]    |
[INFO] [stderr] 67 |             if comp.len() == 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `comp.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.94s
[INFO] running `"docker" "inspect" "4f3b39f1aafd90045e469009407862cad7b694d1c8e400c2785c828ee0463bcf"`
[INFO] running `"docker" "rm" "-f" "4f3b39f1aafd90045e469009407862cad7b694d1c8e400c2785c828ee0463bcf"`
[INFO] [stdout] 4f3b39f1aafd90045e469009407862cad7b694d1c8e400c2785c828ee0463bcf