[INFO] crate gitcube 0.1.0 is already in cache [INFO] extracting crate gitcube 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/gitcube/0.1.0 [INFO] extracting crate gitcube 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gitcube/0.1.0 [INFO] validating manifest of gitcube-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gitcube-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gitcube-0.1.0 [INFO] finished frobbing gitcube-0.1.0 [INFO] frobbed toml for gitcube-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/gitcube/0.1.0/Cargo.toml [INFO] started frobbing gitcube-0.1.0 [INFO] finished frobbing gitcube-0.1.0 [INFO] frobbed toml for gitcube-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gitcube/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gitcube-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gitcube/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] de3345445564f70ca23700da595f6471afcbbf37686c3380700f0b55ce601652 [INFO] running `"docker" "start" "-a" "de3345445564f70ca23700da595f6471afcbbf37686c3380700f0b55ce601652"` [INFO] [stderr] Checking regex v1.0.6 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Compiling pest_generator v2.1.0 [INFO] [stderr] Checking dotenv v0.9.0 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Checking twox-hash v1.1.2 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking serde_urlencoded v0.5.4 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking crossbeam v0.6.0 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking mysql_common v0.12.0 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-signal v0.2.7 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking tera v0.11.20 [INFO] [stderr] Checking trust-dns-proto v0.6.3 [INFO] [stderr] Checking trust-dns-proto v0.5.0 [INFO] [stderr] Checking mysql v14.2.0 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking trust-dns-resolver v0.10.3 [INFO] [stderr] Checking actix v0.7.9 [INFO] [stderr] Checking actix-net v0.2.6 [INFO] [stderr] Checking actix-web v0.7.18 [INFO] [stderr] Checking gitcube v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Store` [INFO] [stderr] --> src/main.rs:6:43 [INFO] [stderr] | [INFO] [stderr] 6 | use argparse::{ArgumentParser, StoreTrue, Store}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `trace`, `warn` [INFO] [stderr] --> src/main.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | use log::{info, trace, warn}; [INFO] [stderr] | ^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `actix_web::middleware::csrf` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use actix_web::middleware::csrf; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `uuid::Uuid` [INFO] [stderr] --> src/controllers/git.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use uuid::Uuid; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Binary`, `http::Method` [INFO] [stderr] --> src/controllers/git.rs:5:17 [INFO] [stderr] | [INFO] [stderr] 5 | use actix_web::{http::Method, Path, Query, Binary, HttpRequest, HttpResponse, HttpMessage}; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `RequestSession` [INFO] [stderr] --> src/controllers/git.rs:6:38 [INFO] [stderr] | [INFO] [stderr] 6 | use actix_web::middleware::session::{RequestSession}; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `::git::repo::Repository` [INFO] [stderr] --> src/controllers/repo.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use ::git::repo::Repository; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Path` [INFO] [stderr] --> src/controllers/org.rs:5:23 [INFO] [stderr] | [INFO] [stderr] 5 | use actix_web::{Form, Path, HttpRequest, HttpResponse}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/controllers/status.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `uuid::Uuid` [INFO] [stderr] --> src/controllers/status.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use uuid::Uuid; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Form`, `Path`, `Query` [INFO] [stderr] --> src/controllers/status.rs:5:17 [INFO] [stderr] | [INFO] [stderr] 5 | use actix_web::{Path, Query, Form, HttpRequest, HttpResponse}; [INFO] [stderr] | ^^^^ ^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::process::Stdio` [INFO] [stderr] --> src/git/branch.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::process::Stdio; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/git/branch.rs:8:22 [INFO] [stderr] | [INFO] [stderr] 8 | const BRANCH_PREFIX:&'static str = "refs/heads/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::process::Stdio` [INFO] [stderr] --> src/git/repo.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::process::Stdio; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Write` [INFO] [stderr] --> src/git/repo.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::process::ExitStatus` [INFO] [stderr] --> src/git/repo.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::process::ExitStatus; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::process::Stdio` [INFO] [stderr] --> src/git/tree.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::process::Stdio; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/git/tree.rs:19:32 [INFO] [stderr] | [INFO] [stderr] 19 | EntryMode::Blob => 0100644, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 19 | EntryMode::Blob => 100644, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 19 | EntryMode::Blob => 0o100644, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/git/tree.rs:19:32 [INFO] [stderr] | [INFO] [stderr] 19 | EntryMode::Blob => 0100644, [INFO] [stderr] | ^^^^^^^ help: consider: `0_100_644` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/git/tree.rs:20:32 [INFO] [stderr] | [INFO] [stderr] 20 | EntryMode::Exec => 0100755, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 20 | EntryMode::Exec => 100755, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 20 | EntryMode::Exec => 0o100755, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/git/tree.rs:20:32 [INFO] [stderr] | [INFO] [stderr] 20 | EntryMode::Exec => 0100755, [INFO] [stderr] | ^^^^^^^ help: consider: `0_100_755` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/git/tree.rs:21:35 [INFO] [stderr] | [INFO] [stderr] 21 | EntryMode::Symlink => 0120000, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 21 | EntryMode::Symlink => 120000, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 21 | EntryMode::Symlink => 0o120000, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/git/tree.rs:21:35 [INFO] [stderr] | [INFO] [stderr] 21 | EntryMode::Symlink => 0120000, [INFO] [stderr] | ^^^^^^^ help: consider: `0_120_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/git/tree.rs:22:34 [INFO] [stderr] | [INFO] [stderr] 22 | EntryMode::Commit => 0160000, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 22 | EntryMode::Commit => 160000, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 22 | EntryMode::Commit => 0o160000, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/git/tree.rs:22:34 [INFO] [stderr] | [INFO] [stderr] 22 | EntryMode::Commit => 0160000, [INFO] [stderr] | ^^^^^^^ help: consider: `0_160_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/git/tree.rs:23:32 [INFO] [stderr] | [INFO] [stderr] 23 | EntryMode::Tree => 0040000, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 23 | EntryMode::Tree => 40000, [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 23 | EntryMode::Tree => 0o40000, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/git/tree.rs:23:32 [INFO] [stderr] | [INFO] [stderr] 23 | EntryMode::Tree => 0040000, [INFO] [stderr] | ^^^^^^^ help: consider: `0_040_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/git/tree.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | if code == 0100644{ [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 28 | if code == 100644{ [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 28 | if code == 0o100644{ [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/git/tree.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | if code == 0100644{ [INFO] [stderr] | ^^^^^^^ help: consider: `0_100_644` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/git/tree.rs:30:26 [INFO] [stderr] | [INFO] [stderr] 30 | }else if code == 0100755{ [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 30 | }else if code == 100755{ [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 30 | }else if code == 0o100755{ [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/git/tree.rs:30:26 [INFO] [stderr] | [INFO] [stderr] 30 | }else if code == 0100755{ [INFO] [stderr] | ^^^^^^^ help: consider: `0_100_755` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/git/tree.rs:32:26 [INFO] [stderr] | [INFO] [stderr] 32 | }else if code == 0120000{ [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 32 | }else if code == 120000{ [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 32 | }else if code == 0o120000{ [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/git/tree.rs:32:26 [INFO] [stderr] | [INFO] [stderr] 32 | }else if code == 0120000{ [INFO] [stderr] | ^^^^^^^ help: consider: `0_120_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/git/tree.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | }else if code == 0160000{ [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 34 | }else if code == 160000{ [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 34 | }else if code == 0o160000{ [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/git/tree.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | }else if code == 0160000{ [INFO] [stderr] | ^^^^^^^ help: consider: `0_160_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/git/tree.rs:36:26 [INFO] [stderr] | [INFO] [stderr] 36 | }else if code == 0040000{ [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 36 | }else if code == 40000{ [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 36 | }else if code == 0o40000{ [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/git/tree.rs:36:26 [INFO] [stderr] | [INFO] [stderr] 36 | }else if code == 0040000{ [INFO] [stderr] | ^^^^^^^ help: consider: `0_040_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git/tree.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return &self.name; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git/tree.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git/tree.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | return self.size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `HttpTryFrom`, `header` [INFO] [stderr] --> src/middleware/auth.rs:1:23 [INFO] [stderr] | [INFO] [stderr] 1 | use actix_web::http::{header, HttpTryFrom}; [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `App` [INFO] [stderr] --> src/middleware/auth.rs:2:17 [INFO] [stderr] | [INFO] [stderr] 2 | use actix_web::{App, HttpRequest, HttpResponse, Result}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Response` [INFO] [stderr] --> src/middleware/auth.rs:3:50 [INFO] [stderr] | [INFO] [stderr] 3 | use actix_web::middleware::{Middleware, Started, Response}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `::AppEnv` [INFO] [stderr] --> src/middleware/auth.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use ::AppEnv; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/middleware/auth.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return !set.is_match(req.path()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!set.is_match(req.path())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Store` [INFO] [stderr] --> src/main.rs:6:43 [INFO] [stderr] | [INFO] [stderr] 6 | use argparse::{ArgumentParser, StoreTrue, Store}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `trace`, `warn` [INFO] [stderr] --> src/main.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | use log::{info, trace, warn}; [INFO] [stderr] | ^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `actix_web::middleware::csrf` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use actix_web::middleware::csrf; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `uuid::Uuid` [INFO] [stderr] --> src/controllers/git.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use uuid::Uuid; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Binary`, `http::Method` [INFO] [stderr] --> src/controllers/git.rs:5:17 [INFO] [stderr] | [INFO] [stderr] 5 | use actix_web::{http::Method, Path, Query, Binary, HttpRequest, HttpResponse, HttpMessage}; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `RequestSession` [INFO] [stderr] --> src/controllers/git.rs:6:38 [INFO] [stderr] | [INFO] [stderr] 6 | use actix_web::middleware::session::{RequestSession}; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `::git::repo::Repository` [INFO] [stderr] --> src/controllers/repo.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use ::git::repo::Repository; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Path` [INFO] [stderr] --> src/controllers/org.rs:5:23 [INFO] [stderr] | [INFO] [stderr] 5 | use actix_web::{Form, Path, HttpRequest, HttpResponse}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/controllers/status.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `uuid::Uuid` [INFO] [stderr] --> src/controllers/status.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use uuid::Uuid; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Form`, `Path`, `Query` [INFO] [stderr] --> src/controllers/status.rs:5:17 [INFO] [stderr] | [INFO] [stderr] 5 | use actix_web::{Path, Query, Form, HttpRequest, HttpResponse}; [INFO] [stderr] | ^^^^ ^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::process::Stdio` [INFO] [stderr] --> src/git/branch.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::process::Stdio; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/git/branch.rs:8:22 [INFO] [stderr] | [INFO] [stderr] 8 | const BRANCH_PREFIX:&'static str = "refs/heads/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::process::Stdio` [INFO] [stderr] --> src/git/repo.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::process::Stdio; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Write` [INFO] [stderr] --> src/git/repo.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::process::ExitStatus` [INFO] [stderr] --> src/git/repo.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::process::ExitStatus; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::process::Stdio` [INFO] [stderr] --> src/git/tree.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::process::Stdio; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/git/tree.rs:19:32 [INFO] [stderr] | [INFO] [stderr] 19 | EntryMode::Blob => 0100644, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 19 | EntryMode::Blob => 100644, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 19 | EntryMode::Blob => 0o100644, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/git/tree.rs:19:32 [INFO] [stderr] | [INFO] [stderr] 19 | EntryMode::Blob => 0100644, [INFO] [stderr] | ^^^^^^^ help: consider: `0_100_644` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/git/tree.rs:20:32 [INFO] [stderr] | [INFO] [stderr] 20 | EntryMode::Exec => 0100755, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 20 | EntryMode::Exec => 100755, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 20 | EntryMode::Exec => 0o100755, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/git/tree.rs:20:32 [INFO] [stderr] | [INFO] [stderr] 20 | EntryMode::Exec => 0100755, [INFO] [stderr] | ^^^^^^^ help: consider: `0_100_755` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/git/tree.rs:21:35 [INFO] [stderr] | [INFO] [stderr] 21 | EntryMode::Symlink => 0120000, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 21 | EntryMode::Symlink => 120000, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 21 | EntryMode::Symlink => 0o120000, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/git/tree.rs:21:35 [INFO] [stderr] | [INFO] [stderr] 21 | EntryMode::Symlink => 0120000, [INFO] [stderr] | ^^^^^^^ help: consider: `0_120_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/git/tree.rs:22:34 [INFO] [stderr] | [INFO] [stderr] 22 | EntryMode::Commit => 0160000, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 22 | EntryMode::Commit => 160000, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 22 | EntryMode::Commit => 0o160000, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/git/tree.rs:22:34 [INFO] [stderr] | [INFO] [stderr] 22 | EntryMode::Commit => 0160000, [INFO] [stderr] | ^^^^^^^ help: consider: `0_160_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/git/tree.rs:23:32 [INFO] [stderr] | [INFO] [stderr] 23 | EntryMode::Tree => 0040000, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 23 | EntryMode::Tree => 40000, [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 23 | EntryMode::Tree => 0o40000, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/git/tree.rs:23:32 [INFO] [stderr] | [INFO] [stderr] 23 | EntryMode::Tree => 0040000, [INFO] [stderr] | ^^^^^^^ help: consider: `0_040_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/git/tree.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | if code == 0100644{ [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 28 | if code == 100644{ [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 28 | if code == 0o100644{ [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/git/tree.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | if code == 0100644{ [INFO] [stderr] | ^^^^^^^ help: consider: `0_100_644` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/git/tree.rs:30:26 [INFO] [stderr] | [INFO] [stderr] 30 | }else if code == 0100755{ [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 30 | }else if code == 100755{ [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 30 | }else if code == 0o100755{ [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/git/tree.rs:30:26 [INFO] [stderr] | [INFO] [stderr] 30 | }else if code == 0100755{ [INFO] [stderr] | ^^^^^^^ help: consider: `0_100_755` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/git/tree.rs:32:26 [INFO] [stderr] | [INFO] [stderr] 32 | }else if code == 0120000{ [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 32 | }else if code == 120000{ [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 32 | }else if code == 0o120000{ [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/git/tree.rs:32:26 [INFO] [stderr] | [INFO] [stderr] 32 | }else if code == 0120000{ [INFO] [stderr] | ^^^^^^^ help: consider: `0_120_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/git/tree.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | }else if code == 0160000{ [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 34 | }else if code == 160000{ [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 34 | }else if code == 0o160000{ [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/git/tree.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | }else if code == 0160000{ [INFO] [stderr] | ^^^^^^^ help: consider: `0_160_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/git/tree.rs:36:26 [INFO] [stderr] | [INFO] [stderr] 36 | }else if code == 0040000{ [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 36 | }else if code == 40000{ [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 36 | }else if code == 0o40000{ [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/git/tree.rs:36:26 [INFO] [stderr] | [INFO] [stderr] 36 | }else if code == 0040000{ [INFO] [stderr] | ^^^^^^^ help: consider: `0_040_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git/tree.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return &self.name; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git/tree.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git/tree.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | return self.size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `HttpTryFrom`, `header` [INFO] [stderr] --> src/middleware/auth.rs:1:23 [INFO] [stderr] | [INFO] [stderr] 1 | use actix_web::http::{header, HttpTryFrom}; [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `App` [INFO] [stderr] --> src/middleware/auth.rs:2:17 [INFO] [stderr] | [INFO] [stderr] 2 | use actix_web::{App, HttpRequest, HttpResponse, Result}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Response` [INFO] [stderr] --> src/middleware/auth.rs:3:50 [INFO] [stderr] | [INFO] [stderr] 3 | use actix_web::middleware::{Middleware, Started, Response}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `::AppEnv` [INFO] [stderr] --> src/middleware/auth.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use ::AppEnv; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/middleware/auth.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return !set.is_match(req.path()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!set.is_match(req.path())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `HttpMessage` [INFO] [stderr] --> src/controllers/git.rs:5:79 [INFO] [stderr] | [INFO] [stderr] 5 | use actix_web::{http::Method, Path, Query, Binary, HttpRequest, HttpResponse, HttpMessage}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/error.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | _ => None, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/controllers/user.rs:111:37 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn profile_user((cur_user, req, path, query):(&User, &HttpRequest, &Path<(String,)>, &Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/controllers/user.rs:144:36 [INFO] [stderr] | [INFO] [stderr] 144 | pub fn profile_org((cur_user, req, path, query):(&User, &HttpRequest, &Path<(String,)>, &Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/controllers/repo.rs:104:19 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn star_repo((req, path): (HttpRequest, Path<(String,String)>)) -> HttpResponse { [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/controllers/repo.rs:108:20 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn watch_repo((req, path): (HttpRequest, Path<(String,String)>)) -> HttpResponse { [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `uuid` [INFO] [stderr] --> src/controllers/org.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | let uuid = user.uuid; [INFO] [stderr] | ^^^^ help: consider using `_uuid` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `user_fullname` [INFO] [stderr] --> src/controllers/org.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let user_fullname = user.fullname; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_user_fullname` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tree_path` [INFO] [stderr] --> src/git/tree.rs:128:38 [INFO] [stderr] | [INFO] [stderr] 128 | fn get_tree(&self, commit: &str, tree_path:&str) -> Option{ [INFO] [stderr] | ^^^^^^^^^ help: consider using `_tree_path` instead [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/controllers/user.rs:32:62 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn signin_action((req, form): (HttpRequest, Form>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 32 | pub fn signin_action((req, form): (HttpRequest, Form>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/controllers/user.rs:86:62 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn signup_action((req, form): (HttpRequest, Form>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 86 | pub fn signup_action((req, form): (HttpRequest, Form>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/controllers/user.rs:111:105 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn profile_user((cur_user, req, path, query):(&User, &HttpRequest, &Path<(String,)>, &Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 111 | pub fn profile_user((cur_user, req, path, query):(&User, &HttpRequest, &Path<(String,)>, &Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/controllers/user.rs:111:50 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn profile_user((cur_user, req, path, query):(&User, &HttpRequest, &Path<(String,)>, &Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/controllers/user.rs:144:104 [INFO] [stderr] | [INFO] [stderr] 144 | pub fn profile_org((cur_user, req, path, query):(&User, &HttpRequest, &Path<(String,)>, &Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 144 | pub fn profile_org((cur_user, req, path, query):(&User, &HttpRequest, &Path<(String,)>, &Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/controllers/user.rs:144:49 [INFO] [stderr] | [INFO] [stderr] 144 | pub fn profile_org((cur_user, req, path, query):(&User, &HttpRequest, &Path<(String,)>, &Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/controllers/user.rs:157:18 [INFO] [stderr] | [INFO] [stderr] 157 | }else{ [INFO] [stderr] | __________________^ [INFO] [stderr] 158 | | "org/repositories.html" [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/controllers/user.rs:155:39 [INFO] [stderr] | [INFO] [stderr] 155 | if caps == "repositories" { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 156 | | "org/repositories.html" [INFO] [stderr] 157 | | }else{ [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/controllers/user.rs:172:80 [INFO] [stderr] | [INFO] [stderr] 172 | pub fn profile((req, path, query):(HttpRequest, Path<(String,)>, Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 172 | pub fn profile((req, path, query):(HttpRequest, Path<(String,)>, Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/controllers/user.rs:172:35 [INFO] [stderr] | [INFO] [stderr] 172 | pub fn profile((req, path, query):(HttpRequest, Path<(String,)>, Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/controllers/git.rs:16:97 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn git_advertise_refs((req, path, query):(HttpRequest, Path<(String,String)>, Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 16 | pub fn git_advertise_refs((req, path, query):(HttpRequest, Path<(String,String)>, Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/controllers/git.rs:16:46 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn git_advertise_refs((req, path, query):(HttpRequest, Path<(String,String)>, Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/controllers/repo.rs:36:70 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn new_repository_action((req, form): (HttpRequest, Form>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 36 | pub fn new_repository_action((req, form): (HttpRequest, Form>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/controllers/repo.rs:91:8 [INFO] [stderr] | [INFO] [stderr] 91 | if branches.len() != 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!branches.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/controllers/org.rs:22:72 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn new_organization_action((req, form): (HttpRequest, Form>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 22 | pub fn new_organization_action((req, form): (HttpRequest, Form>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/models/repo.rs:40:77 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn find_repo_by_username_reponame(connection:&Connection, user_fullname:&String, repo_name:&String) -> Option{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/models/repo.rs:40:96 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn find_repo_by_username_reponame(connection:&Connection, user_fullname:&String, repo_name:&String) -> Option{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/models/repo.rs:63:37 [INFO] [stderr] | [INFO] [stderr] 63 | create_time:NaiveDateTime::from(repo.get(4).unwrap()).format("%Y-%m-%d %H:%M:%S").to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `NaiveDateTime::from()`: `repo.get(4).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/models/repo.rs:75:60 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn find_repo_by_user_uuid(connection:&Connection, uuid:&String) -> Vec{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/models/repo.rs:93:37 [INFO] [stderr] | [INFO] [stderr] 93 | create_time:NaiveDateTime::from(repo.get(4).unwrap()).format("%Y-%m-%d %H:%M:%S").to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `NaiveDateTime::from()`: `repo.get(4).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/models/repo.rs:105:59 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn get_star_by_repo_uuid(connection:&Connection, uuid:&String) -> Result{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/models/repo.rs:128:60 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn get_watch_by_repo_uuid(connection:&Connection, uuid:&String) -> Result{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/models/user.rs:53:63 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn find_user_by_fullname(connection:&Connection, fullname:&String)->Option{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/models/user.rs:82:55 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn find_user_by_uuid(connection:&Connection, uuid:&String)->Option{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/models/user.rs:111:57 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn find_user_by_email(connection:&Connection, email:&String)->Option{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/models/mod.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | .expect(&format!("Error connecting to {}", url)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error connecting to {}", url))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/git/repo.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / match status.success(){ [INFO] [stderr] 20 | | true => Ok(Repository{path:path.to_string()}), [INFO] [stderr] 21 | | false => Err("failed to execute process") [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if status.success() { Ok(Repository{path:path.to_string()}) } else { Err("failed to execute process") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/error.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | MySqlError(mysql::error::Error), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 32 | MySqlError(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/middleware/auth.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | r"^/$", [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `==` on `str`s [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/middleware/auth.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | r"^/signin$", [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `==` on `str`s [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/middleware/auth.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | r"^/signup$", [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `==` on `str`s [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/middleware/auth.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | r"^/help$", [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `==` on `str`s [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `gitcube`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `HttpMessage` [INFO] [stderr] --> src/controllers/git.rs:5:79 [INFO] [stderr] | [INFO] [stderr] 5 | use actix_web::{http::Method, Path, Query, Binary, HttpRequest, HttpResponse, HttpMessage}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/error.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | _ => None, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/controllers/user.rs:111:37 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn profile_user((cur_user, req, path, query):(&User, &HttpRequest, &Path<(String,)>, &Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/controllers/user.rs:144:36 [INFO] [stderr] | [INFO] [stderr] 144 | pub fn profile_org((cur_user, req, path, query):(&User, &HttpRequest, &Path<(String,)>, &Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/controllers/repo.rs:104:19 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn star_repo((req, path): (HttpRequest, Path<(String,String)>)) -> HttpResponse { [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/controllers/repo.rs:108:20 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn watch_repo((req, path): (HttpRequest, Path<(String,String)>)) -> HttpResponse { [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `uuid` [INFO] [stderr] --> src/controllers/org.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | let uuid = user.uuid; [INFO] [stderr] | ^^^^ help: consider using `_uuid` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `user_fullname` [INFO] [stderr] --> src/controllers/org.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let user_fullname = user.fullname; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_user_fullname` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tree_path` [INFO] [stderr] --> src/git/tree.rs:128:38 [INFO] [stderr] | [INFO] [stderr] 128 | fn get_tree(&self, commit: &str, tree_path:&str) -> Option{ [INFO] [stderr] | ^^^^^^^^^ help: consider using `_tree_path` instead [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/controllers/user.rs:32:62 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn signin_action((req, form): (HttpRequest, Form>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 32 | pub fn signin_action((req, form): (HttpRequest, Form>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/controllers/user.rs:86:62 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn signup_action((req, form): (HttpRequest, Form>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 86 | pub fn signup_action((req, form): (HttpRequest, Form>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/controllers/user.rs:111:105 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn profile_user((cur_user, req, path, query):(&User, &HttpRequest, &Path<(String,)>, &Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 111 | pub fn profile_user((cur_user, req, path, query):(&User, &HttpRequest, &Path<(String,)>, &Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/controllers/user.rs:111:50 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn profile_user((cur_user, req, path, query):(&User, &HttpRequest, &Path<(String,)>, &Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/controllers/user.rs:144:104 [INFO] [stderr] | [INFO] [stderr] 144 | pub fn profile_org((cur_user, req, path, query):(&User, &HttpRequest, &Path<(String,)>, &Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 144 | pub fn profile_org((cur_user, req, path, query):(&User, &HttpRequest, &Path<(String,)>, &Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/controllers/user.rs:144:49 [INFO] [stderr] | [INFO] [stderr] 144 | pub fn profile_org((cur_user, req, path, query):(&User, &HttpRequest, &Path<(String,)>, &Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/controllers/user.rs:157:18 [INFO] [stderr] | [INFO] [stderr] 157 | }else{ [INFO] [stderr] | __________________^ [INFO] [stderr] 158 | | "org/repositories.html" [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/controllers/user.rs:155:39 [INFO] [stderr] | [INFO] [stderr] 155 | if caps == "repositories" { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 156 | | "org/repositories.html" [INFO] [stderr] 157 | | }else{ [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/controllers/user.rs:172:80 [INFO] [stderr] | [INFO] [stderr] 172 | pub fn profile((req, path, query):(HttpRequest, Path<(String,)>, Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 172 | pub fn profile((req, path, query):(HttpRequest, Path<(String,)>, Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/controllers/user.rs:172:35 [INFO] [stderr] | [INFO] [stderr] 172 | pub fn profile((req, path, query):(HttpRequest, Path<(String,)>, Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/controllers/git.rs:16:97 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn git_advertise_refs((req, path, query):(HttpRequest, Path<(String,String)>, Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 16 | pub fn git_advertise_refs((req, path, query):(HttpRequest, Path<(String,String)>, Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/controllers/git.rs:16:46 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn git_advertise_refs((req, path, query):(HttpRequest, Path<(String,String)>, Query>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/controllers/repo.rs:36:70 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn new_repository_action((req, form): (HttpRequest, Form>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 36 | pub fn new_repository_action((req, form): (HttpRequest, Form>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/controllers/repo.rs:91:8 [INFO] [stderr] | [INFO] [stderr] 91 | if branches.len() != 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!branches.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/controllers/org.rs:22:72 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn new_organization_action((req, form): (HttpRequest, Form>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 22 | pub fn new_organization_action((req, form): (HttpRequest, Form>)) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/models/repo.rs:40:77 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn find_repo_by_username_reponame(connection:&Connection, user_fullname:&String, repo_name:&String) -> Option{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/models/repo.rs:40:96 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn find_repo_by_username_reponame(connection:&Connection, user_fullname:&String, repo_name:&String) -> Option{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/models/repo.rs:63:37 [INFO] [stderr] | [INFO] [stderr] 63 | create_time:NaiveDateTime::from(repo.get(4).unwrap()).format("%Y-%m-%d %H:%M:%S").to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `NaiveDateTime::from()`: `repo.get(4).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/models/repo.rs:75:60 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn find_repo_by_user_uuid(connection:&Connection, uuid:&String) -> Vec{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/models/repo.rs:93:37 [INFO] [stderr] | [INFO] [stderr] 93 | create_time:NaiveDateTime::from(repo.get(4).unwrap()).format("%Y-%m-%d %H:%M:%S").to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `NaiveDateTime::from()`: `repo.get(4).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/models/repo.rs:105:59 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn get_star_by_repo_uuid(connection:&Connection, uuid:&String) -> Result{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/models/repo.rs:128:60 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn get_watch_by_repo_uuid(connection:&Connection, uuid:&String) -> Result{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/models/user.rs:53:63 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn find_user_by_fullname(connection:&Connection, fullname:&String)->Option{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/models/user.rs:82:55 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn find_user_by_uuid(connection:&Connection, uuid:&String)->Option{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/models/user.rs:111:57 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn find_user_by_email(connection:&Connection, email:&String)->Option{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/models/mod.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | .expect(&format!("Error connecting to {}", url)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error connecting to {}", url))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/git/repo.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / match status.success(){ [INFO] [stderr] 20 | | true => Ok(Repository{path:path.to_string()}), [INFO] [stderr] 21 | | false => Err("failed to execute process") [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if status.success() { Ok(Repository{path:path.to_string()}) } else { Err("failed to execute process") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/error.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | MySqlError(mysql::error::Error), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 32 | MySqlError(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/middleware/auth.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | r"^/$", [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `==` on `str`s [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/middleware/auth.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | r"^/signin$", [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `==` on `str`s [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/middleware/auth.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | r"^/signup$", [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `==` on `str`s [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/middleware/auth.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | r"^/help$", [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `==` on `str`s [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `gitcube`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "de3345445564f70ca23700da595f6471afcbbf37686c3380700f0b55ce601652"` [INFO] running `"docker" "rm" "-f" "de3345445564f70ca23700da595f6471afcbbf37686c3380700f0b55ce601652"` [INFO] [stdout] de3345445564f70ca23700da595f6471afcbbf37686c3380700f0b55ce601652