[INFO] crate gitclass 0.8.0 is already in cache [INFO] extracting crate gitclass 0.8.0 into work/ex/clippy-test-run/sources/stable/reg/gitclass/0.8.0 [INFO] extracting crate gitclass 0.8.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gitclass/0.8.0 [INFO] validating manifest of gitclass-0.8.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gitclass-0.8.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gitclass-0.8.0 [INFO] finished frobbing gitclass-0.8.0 [INFO] frobbed toml for gitclass-0.8.0 written to work/ex/clippy-test-run/sources/stable/reg/gitclass/0.8.0/Cargo.toml [INFO] started frobbing gitclass-0.8.0 [INFO] finished frobbing gitclass-0.8.0 [INFO] frobbed toml for gitclass-0.8.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gitclass/0.8.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gitclass-0.8.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gitclass/0.8.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 19fd4b51f68c6c4b137316406c2d24028df9bdf252290b7b1cf541a1e0a81fbf [INFO] running `"docker" "start" "-a" "19fd4b51f68c6c4b137316406c2d24028df9bdf252290b7b1cf541a1e0a81fbf"` [INFO] [stderr] Checking gitclass v0.8.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | class_name: class_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `class_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | master_repo: master_repo, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `master_repo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | description: description [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | repo: repo [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `repo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | class_name: class_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `class_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | master_repo: master_repo, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `master_repo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | description: description [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | repo: repo [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `repo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | / return Config { [INFO] [stderr] 137 | | class_name: class_name, [INFO] [stderr] 138 | | master_repo: master_repo, [INFO] [stderr] 139 | | description: description [INFO] [stderr] 140 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 136 | Config { [INFO] [stderr] 137 | class_name: class_name, [INFO] [stderr] 138 | master_repo: master_repo, [INFO] [stderr] 139 | description: description [INFO] [stderr] 140 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:156:5 [INFO] [stderr] | [INFO] [stderr] 156 | / return Student { [INFO] [stderr] 157 | | name: name, [INFO] [stderr] 158 | | repo: repo [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 156 | Student { [INFO] [stderr] 157 | name: name, [INFO] [stderr] 158 | repo: repo [INFO] [stderr] 159 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/lib.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | Err(e) => panic!("Couldn't open 'master' branch") [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `latest_obj` [INFO] [stderr] --> src/lib.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | let latest_obj = repo.revparse_single("HEAD").ok(); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_latest_obj` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/lib.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | Err(e) => panic!("Couldn't find the remote ref") [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | set_current_dir(name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:201:5 [INFO] [stderr] | [INFO] [stderr] 201 | / repo.reset(&remote_obj, [INFO] [stderr] 202 | | git2::ResetType::Hard, [INFO] [stderr] 203 | | Some(git2::build::CheckoutBuilder::new() [INFO] [stderr] 204 | | .force() [INFO] [stderr] 205 | | .remove_untracked(true) [INFO] [stderr] 206 | | )); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | / return Config { [INFO] [stderr] 137 | | class_name: class_name, [INFO] [stderr] 138 | | master_repo: master_repo, [INFO] [stderr] 139 | | description: description [INFO] [stderr] 140 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 136 | Config { [INFO] [stderr] 137 | class_name: class_name, [INFO] [stderr] 138 | master_repo: master_repo, [INFO] [stderr] 139 | description: description [INFO] [stderr] 140 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:156:5 [INFO] [stderr] | [INFO] [stderr] 156 | / return Student { [INFO] [stderr] 157 | | name: name, [INFO] [stderr] 158 | | repo: repo [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 156 | Student { [INFO] [stderr] 157 | name: name, [INFO] [stderr] 158 | repo: repo [INFO] [stderr] 159 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/lib.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | Err(e) => panic!("Couldn't open 'master' branch") [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `latest_obj` [INFO] [stderr] --> src/lib.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | let latest_obj = repo.revparse_single("HEAD").ok(); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_latest_obj` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/lib.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | Err(e) => panic!("Couldn't find the remote ref") [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | set_current_dir(name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:201:5 [INFO] [stderr] | [INFO] [stderr] 201 | / repo.reset(&remote_obj, [INFO] [stderr] 202 | | git2::ResetType::Hard, [INFO] [stderr] 203 | | Some(git2::build::CheckoutBuilder::new() [INFO] [stderr] 204 | | .force() [INFO] [stderr] 205 | | .remove_untracked(true) [INFO] [stderr] 206 | | )); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused variable: `init_m` [INFO] [stderr] --> src/main.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | if let Some(init_m) = matches.subcommand_matches("init") { [INFO] [stderr] | ^^^^^^ help: consider using `_init_m` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `add_m` [INFO] [stderr] --> src/main.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | if let Some(add_m) = matches.subcommand_matches("add") { [INFO] [stderr] | ^^^^^ help: consider using `_add_m` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `up_m` [INFO] [stderr] --> src/main.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | if let Some(up_m) = matches.subcommand_matches("update") { [INFO] [stderr] | ^^^^ help: consider using `_up_m` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `init_m` [INFO] [stderr] --> src/main.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | if let Some(init_m) = matches.subcommand_matches("init") { [INFO] [stderr] | ^^^^^^ help: consider using `_init_m` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `add_m` [INFO] [stderr] --> src/main.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | if let Some(add_m) = matches.subcommand_matches("add") { [INFO] [stderr] | ^^^^^ help: consider using `_add_m` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `up_m` [INFO] [stderr] --> src/main.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | if let Some(up_m) = matches.subcommand_matches("update") { [INFO] [stderr] | ^^^^ help: consider using `_up_m` instead [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.12s [INFO] running `"docker" "inspect" "19fd4b51f68c6c4b137316406c2d24028df9bdf252290b7b1cf541a1e0a81fbf"` [INFO] running `"docker" "rm" "-f" "19fd4b51f68c6c4b137316406c2d24028df9bdf252290b7b1cf541a1e0a81fbf"` [INFO] [stdout] 19fd4b51f68c6c4b137316406c2d24028df9bdf252290b7b1cf541a1e0a81fbf