[INFO] crate git-topic-stage 3.0.0 is already in cache [INFO] extracting crate git-topic-stage 3.0.0 into work/ex/clippy-test-run/sources/stable/reg/git-topic-stage/3.0.0 [INFO] extracting crate git-topic-stage 3.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/git-topic-stage/3.0.0 [INFO] validating manifest of git-topic-stage-3.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of git-topic-stage-3.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing git-topic-stage-3.0.0 [INFO] finished frobbing git-topic-stage-3.0.0 [INFO] frobbed toml for git-topic-stage-3.0.0 written to work/ex/clippy-test-run/sources/stable/reg/git-topic-stage/3.0.0/Cargo.toml [INFO] started frobbing git-topic-stage-3.0.0 [INFO] finished frobbing git-topic-stage-3.0.0 [INFO] frobbed toml for git-topic-stage-3.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/git-topic-stage/3.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting git-topic-stage-3.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/git-topic-stage/3.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b819fa1136823b8e7277e86ddbeb769c14437666188f5ebb672f6a37b1eb1226 [INFO] running `"docker" "start" "-a" "b819fa1136823b8e7277e86ddbeb769c14437666188f5ebb672f6a37b1eb1226"` [INFO] [stderr] Checking git-workarea v3.1.2 [INFO] [stderr] Checking git-topic-stage v3.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | commit: commit, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `commit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | author: author, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `author` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | stamp: stamp, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | identity: identity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `identity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:431:13 [INFO] [stderr] | [INFO] [stderr] 431 | topics: topics, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `topics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:432:13 [INFO] [stderr] | [INFO] [stderr] 432 | identity: identity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `identity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:588:13 [INFO] [stderr] | [INFO] [stderr] 588 | results: results, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:631:13 [INFO] [stderr] | [INFO] [stderr] 631 | results: results, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:645:17 [INFO] [stderr] | [INFO] [stderr] 645 | old_id: old_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `old_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:646:17 [INFO] [stderr] | [INFO] [stderr] 646 | new_id: new_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `new_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:696:13 [INFO] [stderr] | [INFO] [stderr] 696 | topic: topic, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `topic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | commit: commit, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `commit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | author: author, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `author` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | stamp: stamp, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | identity: identity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `identity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:431:13 [INFO] [stderr] | [INFO] [stderr] 431 | topics: topics, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `topics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:432:13 [INFO] [stderr] | [INFO] [stderr] 432 | identity: identity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `identity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:588:13 [INFO] [stderr] | [INFO] [stderr] 588 | results: results, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:631:13 [INFO] [stderr] | [INFO] [stderr] 631 | results: results, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:645:17 [INFO] [stderr] | [INFO] [stderr] 645 | old_id: old_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `old_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:646:17 [INFO] [stderr] | [INFO] [stderr] 646 | new_id: new_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `new_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stager.rs:696:13 [INFO] [stderr] | [INFO] [stderr] 696 | topic: topic, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `topic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/test.rs:174:30 [INFO] [stderr] | [INFO] [stderr] 174 | Utc.ymd(2016, 08, 01).and_hms(21, 28, 10)); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 174 | Utc.ymd(2016, 8, 01).and_hms(21, 28, 10)); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 174 | Utc.ymd(2016, 0o8, 01).and_hms(21, 28, 10)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/test.rs:174:34 [INFO] [stderr] | [INFO] [stderr] 174 | Utc.ymd(2016, 08, 01).and_hms(21, 28, 10)); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 174 | Utc.ymd(2016, 08, 1).and_hms(21, 28, 10)); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 174 | Utc.ymd(2016, 08, 0o1).and_hms(21, 28, 10)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/test.rs:186:30 [INFO] [stderr] | [INFO] [stderr] 186 | Utc.ymd(2016, 08, 01).and_hms(21, 28, 39)); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 186 | Utc.ymd(2016, 8, 01).and_hms(21, 28, 39)); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 186 | Utc.ymd(2016, 0o8, 01).and_hms(21, 28, 39)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/test.rs:186:34 [INFO] [stderr] | [INFO] [stderr] 186 | Utc.ymd(2016, 08, 01).and_hms(21, 28, 39)); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 186 | Utc.ymd(2016, 08, 1).and_hms(21, 28, 39)); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 186 | Utc.ymd(2016, 08, 0o1).and_hms(21, 28, 39)); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/stager.rs:551:17 [INFO] [stderr] | [INFO] [stderr] 551 | staged.map(|t| self.topics.push(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(t) = staged { self.topics.push(t) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/stager.rs:609:13 [INFO] [stderr] | [INFO] [stderr] 609 | staged.clone().map(|sb| self.topics.push(sb)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(sb) = staged.clone() { self.topics.push(sb) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/stager.rs:551:17 [INFO] [stderr] | [INFO] [stderr] 551 | staged.map(|t| self.topics.push(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(t) = staged { self.topics.push(t) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/stager.rs:609:13 [INFO] [stderr] | [INFO] [stderr] 609 | staged.clone().map(|sb| self.topics.push(sb)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(sb) = staged.clone() { self.topics.push(sb) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.28s [INFO] running `"docker" "inspect" "b819fa1136823b8e7277e86ddbeb769c14437666188f5ebb672f6a37b1eb1226"` [INFO] running `"docker" "rm" "-f" "b819fa1136823b8e7277e86ddbeb769c14437666188f5ebb672f6a37b1eb1226"` [INFO] [stdout] b819fa1136823b8e7277e86ddbeb769c14437666188f5ebb672f6a37b1eb1226