[INFO] crate git-summary 0.1.0 is already in cache [INFO] extracting crate git-summary 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/git-summary/0.1.0 [INFO] extracting crate git-summary 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/git-summary/0.1.0 [INFO] validating manifest of git-summary-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of git-summary-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing git-summary-0.1.0 [INFO] finished frobbing git-summary-0.1.0 [INFO] frobbed toml for git-summary-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/git-summary/0.1.0/Cargo.toml [INFO] started frobbing git-summary-0.1.0 [INFO] finished frobbing git-summary-0.1.0 [INFO] frobbed toml for git-summary-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/git-summary/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting git-summary-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/git-summary/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 15ca834f5afe642b454068bcba576ab56a6ad264c6f115b415f08361ee69d7ef [INFO] running `"docker" "start" "-a" "15ca834f5afe642b454068bcba576ab56a6ad264c6f115b415f08361ee69d7ef"` [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking git-summary v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/fs_util.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/fs_util.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/cache.rs:9:10 [INFO] [stderr] | [INFO] [stderr] 9 | map: Arc>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/fs_util.rs:27:46 [INFO] [stderr] | [INFO] [stderr] 27 | full.strip_prefix(base.as_ref().parent().unwrap_or(base.as_ref())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| base.as_ref())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/fs_util.rs:61:12 [INFO] [stderr] | [INFO] [stderr] 61 | } else if entry.depth() > 2 { [INFO] [stderr] | ____________^ [INFO] [stderr] 62 | | //trace!("Filtering {:?} d={}", entry.path().display(), entry.depth()); [INFO] [stderr] 63 | | true [INFO] [stderr] 64 | | } else { [INFO] [stderr] 65 | | //trace!("Keeping {:?} d={}", entry.path().display(), entry.depth()); [INFO] [stderr] 66 | | false [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `entry.depth() > 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/fs_util.rs:75:37 [INFO] [stderr] | [INFO] [stderr] 75 | check_entry_filename(entry, |s| s.starts_with(".") && !(s == GIT_DIR)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.starts_with(".") && s != GIT_DIR` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/fs_util.rs:75:51 [INFO] [stderr] | [INFO] [stderr] 75 | check_entry_filename(entry, |s| s.starts_with(".") && !(s == GIT_DIR)) [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/cache.rs:9:10 [INFO] [stderr] | [INFO] [stderr] 9 | map: Arc>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/git_util.rs:183:8 [INFO] [stderr] | [INFO] [stderr] 183 | Ok(fetch_result?) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 183 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/fs_util.rs:27:46 [INFO] [stderr] | [INFO] [stderr] 27 | full.strip_prefix(base.as_ref().parent().unwrap_or(base.as_ref())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| base.as_ref())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/fs_util.rs:61:12 [INFO] [stderr] | [INFO] [stderr] 61 | } else if entry.depth() > 2 { [INFO] [stderr] | ____________^ [INFO] [stderr] 62 | | //trace!("Filtering {:?} d={}", entry.path().display(), entry.depth()); [INFO] [stderr] 63 | | true [INFO] [stderr] 64 | | } else { [INFO] [stderr] 65 | | //trace!("Keeping {:?} d={}", entry.path().display(), entry.depth()); [INFO] [stderr] 66 | | false [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `entry.depth() > 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/fs_util.rs:75:37 [INFO] [stderr] | [INFO] [stderr] 75 | check_entry_filename(entry, |s| s.starts_with(".") && !(s == GIT_DIR)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.starts_with(".") && s != GIT_DIR` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/fs_util.rs:75:51 [INFO] [stderr] | [INFO] [stderr] 75 | check_entry_filename(entry, |s| s.starts_with(".") && !(s == GIT_DIR)) [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/net_util.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | / for addr in addrs { [INFO] [stderr] 50 | | trace!("Making connection to: {:?}", addr); [INFO] [stderr] 51 | | let _ = TcpStream::connect_timeout(&addr, TCP_TIMEOUT)?; [INFO] [stderr] 52 | | return Ok(true); [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/git_util.rs:183:8 [INFO] [stderr] | [INFO] [stderr] 183 | Ok(fetch_result?) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 183 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/net_util.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | / for addr in addrs { [INFO] [stderr] 50 | | trace!("Making connection to: {:?}", addr); [INFO] [stderr] 51 | | let _ = TcpStream::connect_timeout(&addr, TCP_TIMEOUT)?; [INFO] [stderr] 52 | | return Ok(true); [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `git-summary`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `git-summary`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "15ca834f5afe642b454068bcba576ab56a6ad264c6f115b415f08361ee69d7ef"` [INFO] running `"docker" "rm" "-f" "15ca834f5afe642b454068bcba576ab56a6ad264c6f115b415f08361ee69d7ef"` [INFO] [stdout] 15ca834f5afe642b454068bcba576ab56a6ad264c6f115b415f08361ee69d7ef