[INFO] crate git-release-name 0.2.0 is already in cache [INFO] extracting crate git-release-name 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/git-release-name/0.2.0 [INFO] extracting crate git-release-name 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/git-release-name/0.2.0 [INFO] validating manifest of git-release-name-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of git-release-name-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing git-release-name-0.2.0 [INFO] finished frobbing git-release-name-0.2.0 [INFO] frobbed toml for git-release-name-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/git-release-name/0.2.0/Cargo.toml [INFO] started frobbing git-release-name-0.2.0 [INFO] finished frobbing git-release-name-0.2.0 [INFO] frobbed toml for git-release-name-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/git-release-name/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting git-release-name-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/git-release-name/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5fbf5a15f1fc196f9ff125ebf3c6309e581c4d8ea95edf9e79ef4e78b209aecf [INFO] running `"docker" "start" "-a" "5fbf5a15f1fc196f9ff125ebf3c6309e581c4d8ea95edf9e79ef4e78b209aecf"` [INFO] [stderr] Checking Inflector v0.11.4 [INFO] [stderr] Checking git-release-name v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/adjectives.rs:1:20 [INFO] [stderr] | [INFO] [stderr] 1 | pub const WORDS: [&'static str; 256] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/adverbs.rs:1:20 [INFO] [stderr] | [INFO] [stderr] 1 | pub const WORDS: [&'static str; 4096] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/nouns.rs:1:20 [INFO] [stderr] | [INFO] [stderr] 1 | pub const WORDS: [&'static str; 4096] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha.rs:34:31 [INFO] [stderr] | [INFO] [stderr] 34 | const ADV_MASK: u32 = 0xfff00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfff0_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha.rs:40:31 [INFO] [stderr] | [INFO] [stderr] 40 | const ADJ_MASK: u32 = 0x000ff000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000f_f000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha.rs:46:32 [INFO] [stderr] | [INFO] [stderr] 46 | const NOUN_MASK: u32 = 0x00000fff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/phrase.rs:122:44 [INFO] [stderr] | [INFO] [stderr] 122 | let sha: Sha = sha.parse().map_err(|e| ParsePhraseError::Sha(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParsePhraseError::Sha` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sha.rs:33:19 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn adverb(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sha.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn adjective(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sha.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn noun(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/adjectives.rs:1:20 [INFO] [stderr] | [INFO] [stderr] 1 | pub const WORDS: [&'static str; 256] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/adverbs.rs:1:20 [INFO] [stderr] | [INFO] [stderr] 1 | pub const WORDS: [&'static str; 4096] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/nouns.rs:1:20 [INFO] [stderr] | [INFO] [stderr] 1 | pub const WORDS: [&'static str; 4096] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha.rs:34:31 [INFO] [stderr] | [INFO] [stderr] 34 | const ADV_MASK: u32 = 0xfff00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfff0_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha.rs:40:31 [INFO] [stderr] | [INFO] [stderr] 40 | const ADJ_MASK: u32 = 0x000ff000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000f_f000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha.rs:46:32 [INFO] [stderr] | [INFO] [stderr] 46 | const NOUN_MASK: u32 = 0x00000fff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha.rs:67:23 [INFO] [stderr] | [INFO] [stderr] 67 | let sha = Sha(0xffffffff); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha.rs:72:23 [INFO] [stderr] | [INFO] [stderr] 72 | let sha = Sha(0xfff00000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfff0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha.rs:77:23 [INFO] [stderr] | [INFO] [stderr] 77 | let sha = Sha(0x00ff000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x000f_f000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha.rs:82:23 [INFO] [stderr] | [INFO] [stderr] 82 | let sha = Sha(0x00000fff); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/phrase.rs:122:44 [INFO] [stderr] | [INFO] [stderr] 122 | let sha: Sha = sha.parse().map_err(|e| ParsePhraseError::Sha(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParsePhraseError::Sha` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sha.rs:33:19 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn adverb(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sha.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn adjective(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sha.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn noun(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.35s [INFO] running `"docker" "inspect" "5fbf5a15f1fc196f9ff125ebf3c6309e581c4d8ea95edf9e79ef4e78b209aecf"` [INFO] running `"docker" "rm" "-f" "5fbf5a15f1fc196f9ff125ebf3c6309e581c4d8ea95edf9e79ef4e78b209aecf"` [INFO] [stdout] 5fbf5a15f1fc196f9ff125ebf3c6309e581c4d8ea95edf9e79ef4e78b209aecf