[INFO] crate git-mix 0.1.5 is already in cache [INFO] extracting crate git-mix 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/git-mix/0.1.5 [INFO] extracting crate git-mix 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/git-mix/0.1.5 [INFO] validating manifest of git-mix-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of git-mix-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing git-mix-0.1.5 [INFO] finished frobbing git-mix-0.1.5 [INFO] frobbed toml for git-mix-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/git-mix/0.1.5/Cargo.toml [INFO] started frobbing git-mix-0.1.5 [INFO] finished frobbing git-mix-0.1.5 [INFO] frobbed toml for git-mix-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/git-mix/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting git-mix-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/git-mix/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 54fd5082d69377fbcda1674c42d9d111d6c865cd1127fa9f0102861fa5f08216 [INFO] running `"docker" "start" "-a" "54fd5082d69377fbcda1674c42d9d111d6c865cd1127fa9f0102861fa5f08216"` [INFO] [stderr] Checking git-mix v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | / write_buffer [INFO] [stderr] 30 | | .take_read_buffer() [INFO] [stderr] 31 | | .take_remaining() [INFO] [stderr] 32 | | .iter() [INFO] [stderr] 33 | | .map(|&i| i), [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 29 | write_buffer [INFO] [stderr] 30 | .take_read_buffer() [INFO] [stderr] 31 | .take_remaining() [INFO] [stderr] 32 | .iter().cloned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | / write_buffer [INFO] [stderr] 61 | | .take_read_buffer() [INFO] [stderr] 62 | | .take_remaining() [INFO] [stderr] 63 | | .iter() [INFO] [stderr] 64 | | .map(|&i| i), [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 60 | write_buffer [INFO] [stderr] 61 | .take_read_buffer() [INFO] [stderr] 62 | .take_remaining() [INFO] [stderr] 63 | .iter().cloned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / format!( [INFO] [stderr] 101 | | "\ [INFO] [stderr] 102 | | * filter=git-mix [INFO] [stderr] 103 | | .gitattributes !filter [INFO] [stderr] 104 | | " [INFO] [stderr] 105 | | ) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 100 | "\ [INFO] [stderr] 101 | * filter=git-mix [INFO] [stderr] 102 | .gitattributes !filter [INFO] [stderr] 103 | ".to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | / write_buffer [INFO] [stderr] 30 | | .take_read_buffer() [INFO] [stderr] 31 | | .take_remaining() [INFO] [stderr] 32 | | .iter() [INFO] [stderr] 33 | | .map(|&i| i), [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 29 | write_buffer [INFO] [stderr] 30 | .take_read_buffer() [INFO] [stderr] 31 | .take_remaining() [INFO] [stderr] 32 | .iter().cloned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | / write_buffer [INFO] [stderr] 61 | | .take_read_buffer() [INFO] [stderr] 62 | | .take_remaining() [INFO] [stderr] 63 | | .iter() [INFO] [stderr] 64 | | .map(|&i| i), [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 60 | write_buffer [INFO] [stderr] 61 | .take_read_buffer() [INFO] [stderr] 62 | .take_remaining() [INFO] [stderr] 63 | .iter().cloned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / format!( [INFO] [stderr] 101 | | "\ [INFO] [stderr] 102 | | * filter=git-mix [INFO] [stderr] 103 | | .gitattributes !filter [INFO] [stderr] 104 | | " [INFO] [stderr] 105 | | ) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 100 | "\ [INFO] [stderr] 101 | * filter=git-mix [INFO] [stderr] 102 | .gitattributes !filter [INFO] [stderr] 103 | ".to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/mix.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | let plain = "abcdefghijklmopqrs".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcdefghijklmopqrs"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/mix.rs:14:19 [INFO] [stderr] | [INFO] [stderr] 14 | let key = "EXHcE7JQDy8vSBDVTTsgg4NkCQUfgqDx".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"EXHcE7JQDy8vSBDVTTsgg4NkCQUfgqDx"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/mix.rs:38:19 [INFO] [stderr] | [INFO] [stderr] 38 | let key = "EXHcE7JQDy8vSBDVTTsgg4NkCQUfgqDx".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"EXHcE7JQDy8vSBDVTTsgg4NkCQUfgqDx"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/mix.rs:39:34 [INFO] [stderr] | [INFO] [stderr] 39 | let plain = mix::decrypt("abcd".as_bytes(), key); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/mix.rs:61:22 [INFO] [stderr] | [INFO] [stderr] 61 | let expect = format!( [INFO] [stderr] | ______________________^ [INFO] [stderr] 62 | | "\ [INFO] [stderr] 63 | | * filter=git-mix [INFO] [stderr] 64 | | .gitattributes !filter [INFO] [stderr] 65 | | " [INFO] [stderr] 66 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 61 | let expect = "\ [INFO] [stderr] 62 | * filter=git-mix [INFO] [stderr] 63 | .gitattributes !filter [INFO] [stderr] 64 | ".to_string(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:20:20 [INFO] [stderr] | [INFO] [stderr] 2 | | extern crate rand; [INFO] [stderr] | |_____________________________________________________- help: try this: `if $ dst . write_fmt ( format_args ! ( $ ( $ arg ) * ) ).is_err()` [INFO] [stderr] ... [INFO] [stderr] 20 | if let Err(_) = write!(&mut ::std::io::stderr(), "{}\n", format_args!($($arg)*)) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 94 | fatal!("{}", "key requires 32 bytes"); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:20:20 [INFO] [stderr] | [INFO] [stderr] 2 | | extern crate rand; [INFO] [stderr] | |_____________________________________________________- help: try this: `if $ dst . write_fmt ( format_args ! ( $ ( $ arg ) * ) ).is_err()` [INFO] [stderr] ... [INFO] [stderr] 20 | if let Err(_) = write!(&mut ::std::io::stderr(), "{}\n", format_args!($($arg)*)) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 99 | Err(e) => fatal!("{}", e), [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:20:20 [INFO] [stderr] | [INFO] [stderr] 2 | | extern crate rand; [INFO] [stderr] | |_____________________________________________________- help: try this: `if $ dst . write_fmt ( format_args ! ( $ ( $ arg ) * ) ).is_err()` [INFO] [stderr] ... [INFO] [stderr] 20 | if let Err(_) = write!(&mut ::std::io::stderr(), "{}\n", format_args!($($arg)*)) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 106 | fatal!("key requires 32 bytes"); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:20:20 [INFO] [stderr] | [INFO] [stderr] 2 | | extern crate rand; [INFO] [stderr] | |_____________________________________________________- help: try this: `if $ dst . write_fmt ( format_args ! ( $ ( $ arg ) * ) ).is_err()` [INFO] [stderr] ... [INFO] [stderr] 20 | if let Err(_) = write!(&mut ::std::io::stderr(), "{}\n", format_args!($($arg)*)) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 111 | Err(e) => fatal!("{}", e), [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:20:20 [INFO] [stderr] | [INFO] [stderr] 2 | | extern crate rand; [INFO] [stderr] | |_____________________________________________________- help: try this: `if $ dst . write_fmt ( format_args ! ( $ ( $ arg ) * ) ).is_err()` [INFO] [stderr] ... [INFO] [stderr] 20 | if let Err(_) = write!(&mut ::std::io::stderr(), "{}\n", format_args!($($arg)*)) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 94 | fatal!("{}", "key requires 32 bytes"); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:20:20 [INFO] [stderr] | [INFO] [stderr] 2 | | extern crate rand; [INFO] [stderr] | |_____________________________________________________- help: try this: `if $ dst . write_fmt ( format_args ! ( $ ( $ arg ) * ) ).is_err()` [INFO] [stderr] ... [INFO] [stderr] 20 | if let Err(_) = write!(&mut ::std::io::stderr(), "{}\n", format_args!($($arg)*)) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 99 | Err(e) => fatal!("{}", e), [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:20:20 [INFO] [stderr] | [INFO] [stderr] 2 | | extern crate rand; [INFO] [stderr] | |_____________________________________________________- help: try this: `if $ dst . write_fmt ( format_args ! ( $ ( $ arg ) * ) ).is_err()` [INFO] [stderr] ... [INFO] [stderr] 20 | if let Err(_) = write!(&mut ::std::io::stderr(), "{}\n", format_args!($($arg)*)) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 106 | fatal!("key requires 32 bytes"); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:20:20 [INFO] [stderr] | [INFO] [stderr] 2 | | extern crate rand; [INFO] [stderr] | |_____________________________________________________- help: try this: `if $ dst . write_fmt ( format_args ! ( $ ( $ arg ) * ) ).is_err()` [INFO] [stderr] ... [INFO] [stderr] 20 | if let Err(_) = write!(&mut ::std::io::stderr(), "{}\n", format_args!($($arg)*)) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 111 | Err(e) => fatal!("{}", e), [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.50s [INFO] running `"docker" "inspect" "54fd5082d69377fbcda1674c42d9d111d6c865cd1127fa9f0102861fa5f08216"` [INFO] running `"docker" "rm" "-f" "54fd5082d69377fbcda1674c42d9d111d6c865cd1127fa9f0102861fa5f08216"` [INFO] [stdout] 54fd5082d69377fbcda1674c42d9d111d6c865cd1127fa9f0102861fa5f08216