[INFO] crate git-global 0.1.0 is already in cache
[INFO] extracting crate git-global 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/git-global/0.1.0
[INFO] extracting crate git-global 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/git-global/0.1.0
[INFO] validating manifest of git-global-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of git-global-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing git-global-0.1.0
[INFO] finished frobbing git-global-0.1.0
[INFO] frobbed toml for git-global-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/git-global/0.1.0/Cargo.toml
[INFO] started frobbing git-global-0.1.0
[INFO] finished frobbing git-global-0.1.0
[INFO] frobbed toml for git-global-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/git-global/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting git-global-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/git-global/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8ee70bb52487d82f102b3372db7923af8c296353f3c4315312dd8ae8f1872645
[INFO] running `"docker" "start" "-a" "8ee70bb52487d82f102b3372db7923af8c296353f3c4315312dd8ae8f1872645"`
[INFO] [stderr]    Compiling libgit2-sys v0.6.19
[INFO] [stderr]     Checking git2 v0.6.11
[INFO] [stderr]     Checking git-global v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/core.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |             path: path,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/core.rs:64:13
[INFO] [stderr]    |
[INFO] [stderr] 64 |             repo_messages: repo_messages,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `repo_messages`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/core.rs:160:13
[INFO] [stderr]     |
[INFO] [stderr] 160 |             basedir: basedir,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `basedir`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/core.rs:162:13
[INFO] [stderr]     |
[INFO] [stderr] 162 |             cache_file: cache_file,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cache_file`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/core.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |             path: path,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/core.rs:64:13
[INFO] [stderr]    |
[INFO] [stderr] 64 |             repo_messages: repo_messages,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `repo_messages`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/core.rs:160:13
[INFO] [stderr]     |
[INFO] [stderr] 160 |             basedir: basedir,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `basedir`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/core.rs:162:13
[INFO] [stderr]     |
[INFO] [stderr] 162 |             cache_file: cache_file,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cache_file`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/core.rs:15:20
[INFO] [stderr]    |
[INFO] [stderr] 15 | const CACHE_FILE: &'static str = "repos.txt";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/core.rs:16:25
[INFO] [stderr]    |
[INFO] [stderr] 16 | const SETTING_BASEDIR: &'static str = "global.basedir";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/core.rs:17:25
[INFO] [stderr]    |
[INFO] [stderr] 17 | const SETTING_IGNORED: &'static str = "global.ignore";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/core.rs:136:24
[INFO] [stderr]     |
[INFO] [stderr] 136 |         let home_dir = env::home_dir()
[INFO] [stderr]     |                        ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/core.rs:15:20
[INFO] [stderr]    |
[INFO] [stderr] 15 | const CACHE_FILE: &'static str = "repos.txt";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/core.rs:16:25
[INFO] [stderr]    |
[INFO] [stderr] 16 | const SETTING_BASEDIR: &'static str = "global.basedir";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/core.rs:17:25
[INFO] [stderr]    |
[INFO] [stderr] 17 | const SETTING_IGNORED: &'static str = "global.ignore";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/core.rs:136:24
[INFO] [stderr]     |
[INFO] [stderr] 136 |         let home_dir = env::home_dir()
[INFO] [stderr]     |                        ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/core.rs:56:23
[INFO] [stderr]    |
[INFO] [stderr] 56 |     pub fn new(repos: &Vec<Repo>) -> GitGlobalResult {
[INFO] [stderr]    |                       ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 56 |     pub fn new(repos: &[Repo]) -> GitGlobalResult {
[INFO] [stderr]    |                       ^^^^^^^
[INFO] [stderr] help: change `repos.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 63 |             repos: repos.to_owned(),
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/core.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 | /         match self.repo_messages.get_mut(&repo) {
[INFO] [stderr] 79 | |             Some(item) => item.push(data_line),
[INFO] [stderr] 80 | |             None => (),
[INFO] [stderr] 81 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(item) = self.repo_messages.get_mut(&repo) { item.push(data_line) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/core.rs:89:28
[INFO] [stderr]    |
[INFO] [stderr] 89 |             let messages = self.repo_messages.get(&repo).unwrap();
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.repo_messages[&repo]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/core.rs:90:16
[INFO] [stderr]    |
[INFO] [stderr] 90 |             if messages.len() > 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!messages.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/core.rs:115:16
[INFO] [stderr]     |
[INFO] [stderr] 115 |             if messages.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!messages.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/core.rs:146:29
[INFO] [stderr]     |
[INFO] [stderr] 146 |                      .split(",")
[INFO] [stderr]     |                             ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/core.rs:144:18
[INFO] [stderr]     |
[INFO] [stderr] 144 | /                  config.get_string(SETTING_IGNORED)
[INFO] [stderr] 145 | |                      .unwrap_or(String::new())
[INFO] [stderr]     | |______________________________________________^ help: try this: `config.get_string(SETTING_IGNORED).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]    --> src/core.rs:157:13
[INFO] [stderr]     |
[INFO] [stderr] 157 |             Err(_) => panic!("TODO: work without XDG"),
[INFO] [stderr]     |             ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]     = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]    --> src/core.rs:169:20
[INFO] [stderr]     |
[INFO] [stderr] 169 |               .iter()
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 170 | |             .fold(true, |acc, pattern| acc && !entry_path.contains(pattern))
[INFO] [stderr]     | |____________________________________________________________________________^ help: try: `.all(|pattern| !entry_path.contains(pattern))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/core.rs:177:34
[INFO] [stderr]     |
[INFO] [stderr] 177 |     fn cache_repos(&self, repos: &Vec<Repo>) {
[INFO] [stderr]     |                                  ^^^^^^^^^^ help: change this to: `&[Repo]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/core.rs:201:17
[INFO] [stderr]     |
[INFO] [stderr] 201 | /                 match line {
[INFO] [stderr] 202 | |                     Ok(repo_path) => repos.push(Repo::new(repo_path)),
[INFO] [stderr] 203 | |                     Err(_) => (),  // TODO: handle errors
[INFO] [stderr] 204 | |                 }
[INFO] [stderr]     | |_________________^ help: try this: `if let Ok(repo_path) = line { repos.push(Repo::new(repo_path)) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/core.rs:220:9
[INFO] [stderr]     |
[INFO] [stderr] 220 | /         match entry {
[INFO] [stderr] 221 | |             Ok(entry) => {
[INFO] [stderr] 222 | |                 if entry.file_type().is_dir() && entry.file_name() == ".git" {
[INFO] [stderr] 223 | |                     let parent_path = entry.path().parent().expect("Could not determine parent.");
[INFO] [stderr] ...   |
[INFO] [stderr] 232 | |             Err(_) => (),
[INFO] [stderr] 233 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 220 |         if let Ok(entry) = entry {
[INFO] [stderr] 221 |     if entry.file_type().is_dir() && entry.file_name() == ".git" {
[INFO] [stderr] 222 |         let parent_path = entry.path().parent().expect("Could not determine parent.");
[INFO] [stderr] 223 |         match parent_path.to_str() {
[INFO] [stderr] 224 |             Some(path) => {
[INFO] [stderr] 225 |                 repos.push(Repo::new(path.to_string()));
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/core.rs:224:21
[INFO] [stderr]     |
[INFO] [stderr] 224 | /                     match parent_path.to_str() {
[INFO] [stderr] 225 | |                         Some(path) => {
[INFO] [stderr] 226 | |                             repos.push(Repo::new(path.to_string()));
[INFO] [stderr] 227 | |                         }
[INFO] [stderr] 228 | |                         None => (),
[INFO] [stderr] 229 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 224 |                     if let Some(path) = parent_path.to_str() {
[INFO] [stderr] 225 |     repos.push(Repo::new(path.to_string()));
[INFO] [stderr] 226 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/core.rs:240:27
[INFO] [stderr]     |
[INFO] [stderr] 240 | pub fn cache_repos(repos: &Vec<Repo>) {
[INFO] [stderr]     |                           ^^^^^^^^^^ help: change this to: `&[Repo]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/subcommands/info.rs:31:19
[INFO] [stderr]    |
[INFO] [stderr] 31 |     let version = format!("{}", crate_version!());
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `env ! ( "CARGO_PKG_VERSION" ).to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/subcommands/info.rs:33:25
[INFO] [stderr]    |
[INFO] [stderr] 33 |     let mut underline = format!("===========");
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"===========".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/subcommands/info.rs:45:24
[INFO] [stderr]    |
[INFO] [stderr] 45 |     result.add_message(format!("Ignored patterns:"));
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Ignored patterns:".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/subcommands/list.rs:13:39
[INFO] [stderr]    |
[INFO] [stderr] 13 |         result.add_repo_message(repo, format!(""));
[INFO] [stderr]    |                                       ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/subcommands/status.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 | /     let mut wstatus = match status {
[INFO] [stderr] 23 | |         s if s.contains(git2::STATUS_WT_NEW) => {
[INFO] [stderr] 24 | |             if istatus == ' ' {
[INFO] [stderr] 25 | |                 istatus = '?';
[INFO] [stderr] ...  |
[INFO] [stderr] 37 | |         wstatus = '!';
[INFO] [stderr] 38 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]    |
[INFO] [stderr] 22 |     let <mut> wstatus = if status.contains(git2::STATUS_IGNORED) { ..; '!' } else { match status {
[INFO] [stderr] 23 |         s if s.contains(git2::STATUS_WT_NEW) => {
[INFO] [stderr] 24 |             if istatus == ' ' {
[INFO] [stderr] 25 |                 istatus = '?';
[INFO] [stderr] 26 |             }
[INFO] [stderr] 27 |             '?'
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/subcommands/status.rs:59:10
[INFO] [stderr]    |
[INFO] [stderr] 59 |         .expect(&format!("Could not get statuses for {}.", repo));
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not get statuses for {}.", repo))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/subcommands/status.rs:66:13
[INFO] [stderr]    |
[INFO] [stderr] 66 |             format!("{}", status_for_path)
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `status_for_path.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/core.rs:56:23
[INFO] [stderr]    |
[INFO] [stderr] 56 |     pub fn new(repos: &Vec<Repo>) -> GitGlobalResult {
[INFO] [stderr]    |                       ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 56 |     pub fn new(repos: &[Repo]) -> GitGlobalResult {
[INFO] [stderr]    |                       ^^^^^^^
[INFO] [stderr] help: change `repos.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 63 |             repos: repos.to_owned(),
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/core.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 | /         match self.repo_messages.get_mut(&repo) {
[INFO] [stderr] 79 | |             Some(item) => item.push(data_line),
[INFO] [stderr] 80 | |             None => (),
[INFO] [stderr] 81 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(item) = self.repo_messages.get_mut(&repo) { item.push(data_line) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/core.rs:89:28
[INFO] [stderr]    |
[INFO] [stderr] 89 |             let messages = self.repo_messages.get(&repo).unwrap();
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.repo_messages[&repo]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/core.rs:90:16
[INFO] [stderr]    |
[INFO] [stderr] 90 |             if messages.len() > 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!messages.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/core.rs:115:16
[INFO] [stderr]     |
[INFO] [stderr] 115 |             if messages.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!messages.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/core.rs:146:29
[INFO] [stderr]     |
[INFO] [stderr] 146 |                      .split(",")
[INFO] [stderr]     |                             ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/core.rs:144:18
[INFO] [stderr]     |
[INFO] [stderr] 144 | /                  config.get_string(SETTING_IGNORED)
[INFO] [stderr] 145 | |                      .unwrap_or(String::new())
[INFO] [stderr]     | |______________________________________________^ help: try this: `config.get_string(SETTING_IGNORED).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]    --> src/core.rs:157:13
[INFO] [stderr]     |
[INFO] [stderr] 157 |             Err(_) => panic!("TODO: work without XDG"),
[INFO] [stderr]     |             ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]     = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]    --> src/core.rs:169:20
[INFO] [stderr]     |
[INFO] [stderr] 169 |               .iter()
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 170 | |             .fold(true, |acc, pattern| acc && !entry_path.contains(pattern))
[INFO] [stderr]     | |____________________________________________________________________________^ help: try: `.all(|pattern| !entry_path.contains(pattern))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/core.rs:177:34
[INFO] [stderr]     |
[INFO] [stderr] 177 |     fn cache_repos(&self, repos: &Vec<Repo>) {
[INFO] [stderr]     |                                  ^^^^^^^^^^ help: change this to: `&[Repo]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/core.rs:201:17
[INFO] [stderr]     |
[INFO] [stderr] 201 | /                 match line {
[INFO] [stderr] 202 | |                     Ok(repo_path) => repos.push(Repo::new(repo_path)),
[INFO] [stderr] 203 | |                     Err(_) => (),  // TODO: handle errors
[INFO] [stderr] 204 | |                 }
[INFO] [stderr]     | |_________________^ help: try this: `if let Ok(repo_path) = line { repos.push(Repo::new(repo_path)) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/core.rs:220:9
[INFO] [stderr]     |
[INFO] [stderr] 220 | /         match entry {
[INFO] [stderr] 221 | |             Ok(entry) => {
[INFO] [stderr] 222 | |                 if entry.file_type().is_dir() && entry.file_name() == ".git" {
[INFO] [stderr] 223 | |                     let parent_path = entry.path().parent().expect("Could not determine parent.");
[INFO] [stderr] ...   |
[INFO] [stderr] 232 | |             Err(_) => (),
[INFO] [stderr] 233 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 220 |         if let Ok(entry) = entry {
[INFO] [stderr] 221 |     if entry.file_type().is_dir() && entry.file_name() == ".git" {
[INFO] [stderr] 222 |         let parent_path = entry.path().parent().expect("Could not determine parent.");
[INFO] [stderr] 223 |         match parent_path.to_str() {
[INFO] [stderr] 224 |             Some(path) => {
[INFO] [stderr] 225 |                 repos.push(Repo::new(path.to_string()));
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/core.rs:224:21
[INFO] [stderr]     |
[INFO] [stderr] 224 | /                     match parent_path.to_str() {
[INFO] [stderr] 225 | |                         Some(path) => {
[INFO] [stderr] 226 | |                             repos.push(Repo::new(path.to_string()));
[INFO] [stderr] 227 | |                         }
[INFO] [stderr] 228 | |                         None => (),
[INFO] [stderr] 229 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 224 |                     if let Some(path) = parent_path.to_str() {
[INFO] [stderr] 225 |     repos.push(Repo::new(path.to_string()));
[INFO] [stderr] 226 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/core.rs:240:27
[INFO] [stderr]     |
[INFO] [stderr] 240 | pub fn cache_repos(repos: &Vec<Repo>) {
[INFO] [stderr]     |                           ^^^^^^^^^^ help: change this to: `&[Repo]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/subcommands/info.rs:31:19
[INFO] [stderr]    |
[INFO] [stderr] 31 |     let version = format!("{}", crate_version!());
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `env ! ( "CARGO_PKG_VERSION" ).to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/subcommands/info.rs:33:25
[INFO] [stderr]    |
[INFO] [stderr] 33 |     let mut underline = format!("===========");
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"===========".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/subcommands/info.rs:45:24
[INFO] [stderr]    |
[INFO] [stderr] 45 |     result.add_message(format!("Ignored patterns:"));
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Ignored patterns:".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/subcommands/list.rs:13:39
[INFO] [stderr]    |
[INFO] [stderr] 13 |         result.add_repo_message(repo, format!(""));
[INFO] [stderr]    |                                       ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/subcommands/status.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 | /     let mut wstatus = match status {
[INFO] [stderr] 23 | |         s if s.contains(git2::STATUS_WT_NEW) => {
[INFO] [stderr] 24 | |             if istatus == ' ' {
[INFO] [stderr] 25 | |                 istatus = '?';
[INFO] [stderr] ...  |
[INFO] [stderr] 37 | |         wstatus = '!';
[INFO] [stderr] 38 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]    |
[INFO] [stderr] 22 |     let <mut> wstatus = if status.contains(git2::STATUS_IGNORED) { ..; '!' } else { match status {
[INFO] [stderr] 23 |         s if s.contains(git2::STATUS_WT_NEW) => {
[INFO] [stderr] 24 |             if istatus == ' ' {
[INFO] [stderr] 25 |                 istatus = '?';
[INFO] [stderr] 26 |             }
[INFO] [stderr] 27 |             '?'
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/subcommands/status.rs:59:10
[INFO] [stderr]    |
[INFO] [stderr] 59 |         .expect(&format!("Could not get statuses for {}.", repo));
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not get statuses for {}.", repo))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/subcommands/status.rs:66:13
[INFO] [stderr]    |
[INFO] [stderr] 66 |             format!("{}", status_for_path)
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `status_for_path.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 29.19s
[INFO] running `"docker" "inspect" "8ee70bb52487d82f102b3372db7923af8c296353f3c4315312dd8ae8f1872645"`
[INFO] running `"docker" "rm" "-f" "8ee70bb52487d82f102b3372db7923af8c296353f3c4315312dd8ae8f1872645"`
[INFO] [stdout] 8ee70bb52487d82f102b3372db7923af8c296353f3c4315312dd8ae8f1872645