[INFO] crate git-checks 3.8.0 is already in cache [INFO] extracting crate git-checks 3.8.0 into work/ex/clippy-test-run/sources/stable/reg/git-checks/3.8.0 [INFO] extracting crate git-checks 3.8.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/git-checks/3.8.0 [INFO] validating manifest of git-checks-3.8.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of git-checks-3.8.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing git-checks-3.8.0 [INFO] finished frobbing git-checks-3.8.0 [INFO] frobbed toml for git-checks-3.8.0 written to work/ex/clippy-test-run/sources/stable/reg/git-checks/3.8.0/Cargo.toml [INFO] started frobbing git-checks-3.8.0 [INFO] finished frobbing git-checks-3.8.0 [INFO] frobbed toml for git-checks-3.8.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/git-checks/3.8.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting git-checks-3.8.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/git-checks/3.8.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cf481dc4b8af8ed9819b3567a5c2d5d531c01331d9f426c3aa9b32f7b97c3ff8 [INFO] running `"docker" "start" "-a" "cf481dc4b8af8ed9819b3567a5c2d5d531c01331d9f426c3aa9b32f7b97c3ff8"` [INFO] [stderr] Checking ttl_cache v0.3.0 [INFO] [stderr] Checking git-workarea v3.1.2 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking git-checks v3.8.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commit.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | raw: raw, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `raw` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commit.rs:350:13 [INFO] [stderr] | [INFO] [stderr] 350 | parents: parents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `parents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | workarea: workarea, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `workarea` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | topic_owner: topic_owner, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `topic_owner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/checks/allow_robot.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | identity: identity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `identity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/checks/changelog.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/checks/check_size.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | max_size: max_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/run.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | commit_results: commit_results, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `commit_results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/run.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | topic_result: topic_result, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `topic_result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | branch: branch, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `branch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commit.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | raw: raw, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `raw` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commit.rs:350:13 [INFO] [stderr] | [INFO] [stderr] 350 | parents: parents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `parents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | workarea: workarea, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `workarea` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | topic_owner: topic_owner, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `topic_owner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/checks/allow_robot.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | identity: identity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `identity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/checks/changelog.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/checks/check_size.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | max_size: max_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/run.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | commit_results: commit_results, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `commit_results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/run.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | topic_result: topic_result, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `topic_result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | branch: branch, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `branch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/context.rs:109:12 [INFO] [stderr] | [INFO] [stderr] 109 | Ok(self.workarea.checkout(paths)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 109 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/checks/commit_subject.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | / false || // rustfmt break [INFO] [stderr] 136 | | summary.starts_with("Merge ") || // rustfmt break [INFO] [stderr] 137 | | summary.starts_with("Revert ") [INFO] [stderr] | |__________________________________________^ help: try: `summary.starts_with("Revert ") || summary.starts_with("Merge ")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/checks/check_whitespace.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | fn add_error(&self, result: &mut CheckResult, output: &[u8], content: &Content) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/checks/valid_name.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | fn apply(&self, result: &mut CheckResult, msg: F) [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/commit.rs:707:5 [INFO] [stderr] | [INFO] [stderr] 707 | / fn test_commit_regular() { [INFO] [stderr] 708 | | let ctx = make_context(); [INFO] [stderr] 709 | | [INFO] [stderr] 710 | | let ben = Identity::new("Ben Boeckel", "ben.boeckel@kitware.com"); [INFO] [stderr] ... | [INFO] [stderr] 760 | | assert_eq!(diff.status, StatusChange::Added); [INFO] [stderr] 761 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 52 [INFO] [stderr] --> src/commit.rs:805:5 [INFO] [stderr] | [INFO] [stderr] 805 | / fn test_topic_regular_with_changes() { [INFO] [stderr] 806 | | let ctx = make_context(); [INFO] [stderr] 807 | | [INFO] [stderr] 808 | | let topic = Topic::new(&ctx, &CommitId::new(ROOT_COMMIT), &CommitId::new(CHANGES_COMMIT)).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 893 | | assert_eq!(diff.status, StatusChange::Added); [INFO] [stderr] 894 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 50 [INFO] [stderr] --> src/commit.rs:900:5 [INFO] [stderr] | [INFO] [stderr] 900 | / fn test_commit_quoted_paths() { [INFO] [stderr] 901 | | let ctx = make_context(); [INFO] [stderr] 902 | | [INFO] [stderr] 903 | | let ben = Identity::new("Ben Boeckel", "ben.boeckel@kitware.com"); [INFO] [stderr] ... | [INFO] [stderr] 983 | | assert_eq!(diff.status, StatusChange::Added); [INFO] [stderr] 984 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/commit.rs:960:42 [INFO] [stderr] | [INFO] [stderr] 960 | assert_eq!(diff.name.as_bytes(), "with whitespace".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"with whitespace"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/commit.rs:971:42 [INFO] [stderr] | [INFO] [stderr] 971 | assert_eq!(diff.name.as_bytes(), "with-dollar-$".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"with-dollar-$"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 51 [INFO] [stderr] --> src/commit.rs:987:5 [INFO] [stderr] | [INFO] [stderr] 987 | / fn test_commit_quoted_paths_with_bad_config() { [INFO] [stderr] 988 | | let raw_ctx = make_context(); [INFO] [stderr] 989 | | let tempdir = test::make_temp_dir("test_commit_quoted_paths_with_bad_config"); [INFO] [stderr] 990 | | let config_path = tempdir.path().join("config"); [INFO] [stderr] ... | [INFO] [stderr] 1084 | | assert_eq!(diff.status, StatusChange::Added); [INFO] [stderr] 1085 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/commit.rs:1061:42 [INFO] [stderr] | [INFO] [stderr] 1061 | assert_eq!(diff.name.as_bytes(), "with whitespace".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"with whitespace"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/commit.rs:1072:42 [INFO] [stderr] | [INFO] [stderr] 1072 | assert_eq!(diff.name.as_bytes(), "with-dollar-$".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"with-dollar-$"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/context.rs:109:12 [INFO] [stderr] | [INFO] [stderr] 109 | Ok(self.workarea.checkout(paths)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 109 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/checks/commit_subject.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | / false || // rustfmt break [INFO] [stderr] 136 | | summary.starts_with("Merge ") || // rustfmt break [INFO] [stderr] 137 | | summary.starts_with("Revert ") [INFO] [stderr] | |__________________________________________^ help: try: `summary.starts_with("Revert ") || summary.starts_with("Merge ")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/checks/commit_subject.rs:382:28 [INFO] [stderr] | [INFO] [stderr] 382 | Regex::new("hort").unwrap(), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/checks/check_whitespace.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | fn add_error(&self, result: &mut CheckResult, output: &[u8], content: &Content) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/checks/valid_name.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | fn apply(&self, result: &mut CheckResult, msg: F) [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.42s [INFO] running `"docker" "inspect" "cf481dc4b8af8ed9819b3567a5c2d5d531c01331d9f426c3aa9b32f7b97c3ff8"` [INFO] running `"docker" "rm" "-f" "cf481dc4b8af8ed9819b3567a5c2d5d531c01331d9f426c3aa9b32f7b97c3ff8"` [INFO] [stdout] cf481dc4b8af8ed9819b3567a5c2d5d531c01331d9f426c3aa9b32f7b97c3ff8