[INFO] crate gir-format-check 0.1.1 is already in cache [INFO] extracting crate gir-format-check 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/gir-format-check/0.1.1 [INFO] extracting crate gir-format-check 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gir-format-check/0.1.1 [INFO] validating manifest of gir-format-check-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gir-format-check-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gir-format-check-0.1.1 [INFO] finished frobbing gir-format-check-0.1.1 [INFO] frobbed toml for gir-format-check-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/gir-format-check/0.1.1/Cargo.toml [INFO] started frobbing gir-format-check-0.1.1 [INFO] finished frobbing gir-format-check-0.1.1 [INFO] frobbed toml for gir-format-check-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gir-format-check/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gir-format-check-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gir-format-check/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d0050327b6a09ab18030d33895630b99daf65f4336ef292548604d0d118a0a58 [INFO] running `"docker" "start" "-a" "d0050327b6a09ab18030d33895630b99daf65f4336ef292548604d0d118a0a58"` [INFO] [stderr] Checking gir-format-check v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/check_gir.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | if self.lower.ends_with("*") { // We always it to be first "because"! [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/check_gir.rs:61:33 [INFO] [stderr] | [INFO] [stderr] 61 | if lines[pos].ends_with("[") { [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/check_gir.rs:94:47 [INFO] [stderr] | [INFO] [stderr] 94 | } else if trimmed.ends_with("\"") { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 95 | | len -= 1; [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/check_gir.rs:92:46 [INFO] [stderr] | [INFO] [stderr] 92 | } else if trimmed.ends_with(",") { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 93 | | len -= 1; [INFO] [stderr] 94 | | } else if trimmed.ends_with("\"") { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/check_gir.rs:92:41 [INFO] [stderr] | [INFO] [stderr] 92 | } else if trimmed.ends_with(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/check_gir.rs:94:41 [INFO] [stderr] | [INFO] [stderr] 94 | } else if trimmed.ends_with("\"") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/check_gir.rs:97:48 [INFO] [stderr] | [INFO] [stderr] 97 | let start = if trimmed.starts_with("\"") { 1 } else { 0 }; [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/check_gir.rs:101:19 [INFO] [stderr] | [INFO] [stderr] 101 | } else if in_object == true && lines[pos].starts_with("name = \"") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `in_object` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `gir-format-check`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/check_gir.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | if self.lower.ends_with("*") { // We always it to be first "because"! [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/check_gir.rs:61:33 [INFO] [stderr] | [INFO] [stderr] 61 | if lines[pos].ends_with("[") { [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/check_gir.rs:94:47 [INFO] [stderr] | [INFO] [stderr] 94 | } else if trimmed.ends_with("\"") { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 95 | | len -= 1; [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/check_gir.rs:92:46 [INFO] [stderr] | [INFO] [stderr] 92 | } else if trimmed.ends_with(",") { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 93 | | len -= 1; [INFO] [stderr] 94 | | } else if trimmed.ends_with("\"") { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/check_gir.rs:92:41 [INFO] [stderr] | [INFO] [stderr] 92 | } else if trimmed.ends_with(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/check_gir.rs:94:41 [INFO] [stderr] | [INFO] [stderr] 94 | } else if trimmed.ends_with("\"") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/check_gir.rs:97:48 [INFO] [stderr] | [INFO] [stderr] 97 | let start = if trimmed.starts_with("\"") { 1 } else { 0 }; [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/check_gir.rs:101:19 [INFO] [stderr] | [INFO] [stderr] 101 | } else if in_object == true && lines[pos].starts_with("name = \"") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `in_object` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `gir-format-check`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d0050327b6a09ab18030d33895630b99daf65f4336ef292548604d0d118a0a58"` [INFO] running `"docker" "rm" "-f" "d0050327b6a09ab18030d33895630b99daf65f4336ef292548604d0d118a0a58"` [INFO] [stdout] d0050327b6a09ab18030d33895630b99daf65f4336ef292548604d0d118a0a58