[INFO] crate gild 0.1.1 is already in cache
[INFO] extracting crate gild 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/gild/0.1.1
[INFO] extracting crate gild 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gild/0.1.1
[INFO] validating manifest of gild-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of gild-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing gild-0.1.1
[INFO] finished frobbing gild-0.1.1
[INFO] frobbed toml for gild-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/gild/0.1.1/Cargo.toml
[INFO] started frobbing gild-0.1.1
[INFO] finished frobbing gild-0.1.1
[INFO] frobbed toml for gild-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gild/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting gild-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gild/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 48bb55a1535475718d5efcd2e86472e7d7d0538090c5206a30ab979b2d4162b5
[INFO] running `"docker" "start" "-a" "48bb55a1535475718d5efcd2e86472e7d7d0538090c5206a30ab979b2d4162b5"`
[INFO] [stderr]     Checking gild v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/validators/strings.rs:22:26
[INFO] [stderr]    |
[INFO] [stderr] 22 |         Box::new(Empty { allowed: allowed })
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^ help: replace it with: `allowed`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/validators/strings.rs:22:26
[INFO] [stderr]    |
[INFO] [stderr] 22 |         Box::new(Empty { allowed: allowed })
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^ help: replace it with: `allowed`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/validators/email.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             return true
[INFO] [stderr]    |             ^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/validators/email.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 |             return false
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `input`
[INFO] [stderr]   --> src/lib.rs:30:24
[INFO] [stderr]    |
[INFO] [stderr] 30 |     fn validate(&self, input: String) -> bool {
[INFO] [stderr]    |                        ^^^^^ help: consider using `_input` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/validators/email.rs:27:48
[INFO] [stderr]    |
[INFO] [stderr] 27 |         if input.is_empty() || !input.contains("@") {
[INFO] [stderr]    |                                                ^^^ help: try using a char instead: `'@'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/validators/email.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 | /         if EMAIL_REGEX.is_match(input.as_str()) {
[INFO] [stderr] 32 | |             return true
[INFO] [stderr] 33 | |         } else {
[INFO] [stderr] 34 | |             return false
[INFO] [stderr] 35 | |         }
[INFO] [stderr]    | |_________^ help: you can reduce it to: `return EMAIL_REGEX.is_match(input.as_str())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/validators/email.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         format!("Input is not a valid e-mail address")
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Input is not a valid e-mail address".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ValidationChain`
[INFO] [stderr]   --> src/lib.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 | /     pub fn new() -> Self {
[INFO] [stderr] 41 | |         ValidationChain { chain: Vec::new() }
[INFO] [stderr] 42 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 25 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]    --> src/tests.rs:2:1
[INFO] [stderr]     |
[INFO] [stderr] 2   | / mod tests {
[INFO] [stderr] 3   | |     use ValidationChain;
[INFO] [stderr] 4   | |     use validators;
[INFO] [stderr] 5   | |
[INFO] [stderr] ...   |
[INFO] [stderr] 115 | |     }
[INFO] [stderr] 116 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/validators/email.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             return true
[INFO] [stderr]    |             ^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/validators/email.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 |             return false
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `input`
[INFO] [stderr]   --> src/lib.rs:30:24
[INFO] [stderr]    |
[INFO] [stderr] 30 |     fn validate(&self, input: String) -> bool {
[INFO] [stderr]    |                        ^^^^^ help: consider using `_input` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/validators/email.rs:27:48
[INFO] [stderr]    |
[INFO] [stderr] 27 |         if input.is_empty() || !input.contains("@") {
[INFO] [stderr]    |                                                ^^^ help: try using a char instead: `'@'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/validators/email.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 | /         if EMAIL_REGEX.is_match(input.as_str()) {
[INFO] [stderr] 32 | |             return true
[INFO] [stderr] 33 | |         } else {
[INFO] [stderr] 34 | |             return false
[INFO] [stderr] 35 | |         }
[INFO] [stderr]    | |_________^ help: you can reduce it to: `return EMAIL_REGEX.is_match(input.as_str())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/validators/email.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         format!("Input is not a valid e-mail address")
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Input is not a valid e-mail address".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ValidationChain`
[INFO] [stderr]   --> src/lib.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 | /     pub fn new() -> Self {
[INFO] [stderr] 41 | |         ValidationChain { chain: Vec::new() }
[INFO] [stderr] 42 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 25 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.88s
[INFO] running `"docker" "inspect" "48bb55a1535475718d5efcd2e86472e7d7d0538090c5206a30ab979b2d4162b5"`
[INFO] running `"docker" "rm" "-f" "48bb55a1535475718d5efcd2e86472e7d7d0538090c5206a30ab979b2d4162b5"`
[INFO] [stdout] 48bb55a1535475718d5efcd2e86472e7d7d0538090c5206a30ab979b2d4162b5