[INFO] crate gif-dispose 2.1.1 is already in cache [INFO] extracting crate gif-dispose 2.1.1 into work/ex/clippy-test-run/sources/stable/reg/gif-dispose/2.1.1 [INFO] extracting crate gif-dispose 2.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gif-dispose/2.1.1 [INFO] validating manifest of gif-dispose-2.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gif-dispose-2.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gif-dispose-2.1.1 [INFO] finished frobbing gif-dispose-2.1.1 [INFO] frobbed toml for gif-dispose-2.1.1 written to work/ex/clippy-test-run/sources/stable/reg/gif-dispose/2.1.1/Cargo.toml [INFO] started frobbing gif-dispose-2.1.1 [INFO] finished frobbing gif-dispose-2.1.1 [INFO] frobbed toml for gif-dispose-2.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gif-dispose/2.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gif-dispose-2.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gif-dispose/2.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 58ef47c2ef7f30416c3a9250844019a24bf3fb22d8c9aa550e2063ddaed35aea [INFO] running `"docker" "start" "-a" "58ef47c2ef7f30416c3a9250844019a24bf3fb22d8c9aa550e2063ddaed35aea"` [INFO] [stderr] Checking imgref v1.3.5 [INFO] [stderr] Checking gif-dispose v2.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return "No palette"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"No palette"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return "No palette"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"No palette"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::iter': Size of this buffer is unpredictable. Use .rows() instead [INFO] [stderr] --> src/disposal.rs:44:41 [INFO] [stderr] | [INFO] [stderr] 44 | Previous => Some(pixels.iter().cloned().subimage(left as usize, top as usize, width as usize, height as usize, pixels.stride()).collect()), [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::iter': Size of this buffer is unpredictable. Use .rows() instead [INFO] [stderr] --> src/screen.rs:89:145 [INFO] [stderr] | [INFO] [stderr] 89 | for (dst, &src) in self.pixels.buf.iter_mut().subimage(left as usize, top as usize, buffer.width(), buffer.height(), stride).zip(buffer.iter()) { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::iter': Size of this buffer is unpredictable. Use .rows() instead [INFO] [stderr] --> src/disposal.rs:44:41 [INFO] [stderr] | [INFO] [stderr] 44 | Previous => Some(pixels.iter().cloned().subimage(left as usize, top as usize, width as usize, height as usize, pixels.stride()).collect()), [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::iter': Size of this buffer is unpredictable. Use .rows() instead [INFO] [stderr] --> src/screen.rs:89:145 [INFO] [stderr] | [INFO] [stderr] 89 | for (dst, &src) in self.pixels.buf.iter_mut().subimage(left as usize, top as usize, buffer.width(), buffer.height(), stride).zip(buffer.iter()) { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/screen.rs:83:29 [INFO] [stderr] | [INFO] [stderr] 83 | let pal = local_pal.or(self.global_pal.as_ref().map(|x| &x[..])).ok_or(Error::NoPalette)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.global_pal.as_ref().map(|x| &x[..]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/screen.rs:83:29 [INFO] [stderr] | [INFO] [stderr] 83 | let pal = local_pal.or(self.global_pal.as_ref().map(|x| &x[..])).ok_or(Error::NoPalette)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.global_pal.as_ref().map(|x| &x[..]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.65s [INFO] running `"docker" "inspect" "58ef47c2ef7f30416c3a9250844019a24bf3fb22d8c9aa550e2063ddaed35aea"` [INFO] running `"docker" "rm" "-f" "58ef47c2ef7f30416c3a9250844019a24bf3fb22d8c9aa550e2063ddaed35aea"` [INFO] [stdout] 58ef47c2ef7f30416c3a9250844019a24bf3fb22d8c9aa550e2063ddaed35aea