[INFO] crate ghcl 0.1.1 is already in cache [INFO] extracting crate ghcl 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/ghcl/0.1.1 [INFO] extracting crate ghcl 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ghcl/0.1.1 [INFO] validating manifest of ghcl-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ghcl-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ghcl-0.1.1 [INFO] finished frobbing ghcl-0.1.1 [INFO] frobbed toml for ghcl-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/ghcl/0.1.1/Cargo.toml [INFO] started frobbing ghcl-0.1.1 [INFO] finished frobbing ghcl-0.1.1 [INFO] frobbed toml for ghcl-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ghcl/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ghcl-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ghcl/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f8edb6265757d97c74fabf72319421c52eac9a4c0e7c922165153f0cf5e2dc69 [INFO] running `"docker" "start" "-a" "f8edb6265757d97c74fabf72319421c52eac9a4c0e7c922165153f0cf5e2dc69"` [INFO] [stderr] Checking ghcl v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/repository.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | user: user, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `user` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/repository.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/options.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | repository: repository, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `repository` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/options.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | track_upstream: track_upstream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `track_upstream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/options.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | clone_path: clone_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `clone_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/options.rs:212:42 [INFO] [stderr] | [INFO] [stderr] 212 | authentication: Authentication { username: username, password: password }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/options.rs:212:62 [INFO] [stderr] | [INFO] [stderr] 212 | authentication: Authentication { username: username, password: password }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `password` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(stderr, "")` [INFO] [stderr] --> src/git_operations.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | writeln!(stderr, "").ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(stderr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(io::stderr(), "")` [INFO] [stderr] --> src/git_operations.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | writeln!(io::stderr(), "").ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(io::stderr())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(io::stderr(), "")` [INFO] [stderr] --> src/git_operations.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | writeln!(io::stderr(), "").ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(io::stderr())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/repository.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | user: user, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `user` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/repository.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/options.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | repository: repository, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `repository` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/options.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | track_upstream: track_upstream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `track_upstream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/options.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | clone_path: clone_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `clone_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/options.rs:212:42 [INFO] [stderr] | [INFO] [stderr] 212 | authentication: Authentication { username: username, password: password }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/options.rs:212:62 [INFO] [stderr] | [INFO] [stderr] 212 | authentication: Authentication { username: username, password: password }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `password` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(stderr, "")` [INFO] [stderr] --> src/git_operations.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | writeln!(stderr, "").ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(stderr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(io::stderr(), "")` [INFO] [stderr] --> src/git_operations.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | writeln!(io::stderr(), "").ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(io::stderr())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(io::stderr(), "")` [INFO] [stderr] --> src/git_operations.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | writeln!(io::stderr(), "").ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(io::stderr())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/options.rs:201:67 [INFO] [stderr] | [INFO] [stderr] 201 | let username = matches.value_of("username").map(String::from).or(config_auth.as_mut().and_then(|auth| auth.username.take())).map(Ok).unwrap_or_else(|| ask_for("Username: ", false))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| config_auth.as_mut().and_then(|auth| auth.username.take()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/options.rs:202:67 [INFO] [stderr] | [INFO] [stderr] 202 | let password = matches.value_of("password").map(String::from).or(config_auth.as_mut().and_then(|auth| auth.password.take())).map(Ok).unwrap_or_else(|| ask_for("Password: ", true))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| config_auth.as_mut().and_then(|auth| auth.password.take()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/options.rs:215:75 [INFO] [stderr] | [INFO] [stderr] 215 | fork_timeout: matches.value_of("fork_timeout").map(|s| s.parse()).or(config.fork_timeout.map(Ok)).unwrap_or(Ok(30))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| config.fork_timeout.map(Ok))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/git_operations.rs:22:33 [INFO] [stderr] | [INFO] [stderr] 22 | .unwrap_or("git".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "git".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_fetchoptions` doesn't need a mutable reference [INFO] [stderr] --> src/git_operations.rs:73:79 [INFO] [stderr] | [INFO] [stderr] 73 | let repo = RepoBuilder::new().fetch_options(get_fetchoptions(quiet, auth, &mut progressed_atomic)).clone(url, location.as_ref())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_fetchoptions` doesn't need a mutable reference [INFO] [stderr] --> src/git_operations.rs:91:111 [INFO] [stderr] | [INFO] [stderr] 91 | remote.fetch(&[branch.name()?.ok_or(ErrorKind::BranchNotNamed)?], Some(&mut get_fetchoptions(quiet, auth, &mut progressed)), None)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/git_operations.rs:100:8 [INFO] [stderr] | [INFO] [stderr] 100 | Ok(branch.set_upstream(Some(&upstream_name))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 100 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/git_operations.rs:105:8 [INFO] [stderr] | [INFO] [stderr] 105 | Ok(repo.reset(&fetch_head, ResetType::Hard, None)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 105 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:42:43 [INFO] [stderr] | [INFO] [stderr] 42 | let should_retry = !progressed && if let &Err(Error(ErrorKind::Git(ref err), _)) = &res { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 43 | | err.class() == git2::ErrorClass::Net [INFO] [stderr] 44 | | } else { [INFO] [stderr] 45 | | false [INFO] [stderr] 46 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 42 | let should_retry = !progressed && if let Err(Error(ErrorKind::Git(ref err), _)) = res { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/options.rs:201:67 [INFO] [stderr] | [INFO] [stderr] 201 | let username = matches.value_of("username").map(String::from).or(config_auth.as_mut().and_then(|auth| auth.username.take())).map(Ok).unwrap_or_else(|| ask_for("Username: ", false))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| config_auth.as_mut().and_then(|auth| auth.username.take()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/options.rs:202:67 [INFO] [stderr] | [INFO] [stderr] 202 | let password = matches.value_of("password").map(String::from).or(config_auth.as_mut().and_then(|auth| auth.password.take())).map(Ok).unwrap_or_else(|| ask_for("Password: ", true))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| config_auth.as_mut().and_then(|auth| auth.password.take()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/options.rs:215:75 [INFO] [stderr] | [INFO] [stderr] 215 | fork_timeout: matches.value_of("fork_timeout").map(|s| s.parse()).or(config.fork_timeout.map(Ok)).unwrap_or(Ok(30))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| config.fork_timeout.map(Ok))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/git_operations.rs:22:33 [INFO] [stderr] | [INFO] [stderr] 22 | .unwrap_or("git".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "git".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_fetchoptions` doesn't need a mutable reference [INFO] [stderr] --> src/git_operations.rs:73:79 [INFO] [stderr] | [INFO] [stderr] 73 | let repo = RepoBuilder::new().fetch_options(get_fetchoptions(quiet, auth, &mut progressed_atomic)).clone(url, location.as_ref())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_fetchoptions` doesn't need a mutable reference [INFO] [stderr] --> src/git_operations.rs:91:111 [INFO] [stderr] | [INFO] [stderr] 91 | remote.fetch(&[branch.name()?.ok_or(ErrorKind::BranchNotNamed)?], Some(&mut get_fetchoptions(quiet, auth, &mut progressed)), None)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/git_operations.rs:100:8 [INFO] [stderr] | [INFO] [stderr] 100 | Ok(branch.set_upstream(Some(&upstream_name))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 100 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/git_operations.rs:105:8 [INFO] [stderr] | [INFO] [stderr] 105 | Ok(repo.reset(&fetch_head, ResetType::Hard, None)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 105 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:42:43 [INFO] [stderr] | [INFO] [stderr] 42 | let should_retry = !progressed && if let &Err(Error(ErrorKind::Git(ref err), _)) = &res { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 43 | | err.class() == git2::ErrorClass::Net [INFO] [stderr] 44 | | } else { [INFO] [stderr] 45 | | false [INFO] [stderr] 46 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 42 | let should_retry = !progressed && if let Err(Error(ErrorKind::Git(ref err), _)) = res { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.63s [INFO] running `"docker" "inspect" "f8edb6265757d97c74fabf72319421c52eac9a4c0e7c922165153f0cf5e2dc69"` [INFO] running `"docker" "rm" "-f" "f8edb6265757d97c74fabf72319421c52eac9a4c0e7c922165153f0cf5e2dc69"` [INFO] [stdout] f8edb6265757d97c74fabf72319421c52eac9a4c0e7c922165153f0cf5e2dc69