[INFO] crate ggbasm 0.2.2 is already in cache
[INFO] extracting crate ggbasm 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/ggbasm/0.2.2
[INFO] extracting crate ggbasm 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ggbasm/0.2.2
[INFO] validating manifest of ggbasm-0.2.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ggbasm-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ggbasm-0.2.2
[INFO] finished frobbing ggbasm-0.2.2
[INFO] frobbed toml for ggbasm-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/ggbasm/0.2.2/Cargo.toml
[INFO] started frobbing ggbasm-0.2.2
[INFO] finished frobbing ggbasm-0.2.2
[INFO] frobbed toml for ggbasm-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ggbasm/0.2.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ggbasm-0.2.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ggbasm/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e63b23b45104b73e6b40a0adc71067016558f7af290e3e881c1d25ce85420722
[INFO] running `"docker" "start" "-a" "e63b23b45104b73e6b40a0adc71067016558f7af290e3e881c1d25ce85420722"`
[INFO] [stderr]    Compiling num-derive v0.2.4
[INFO] [stderr]     Checking tiff v0.2.1
[INFO] [stderr]     Checking image v0.20.1
[INFO] [stderr]     Checking ggbasm v0.2.2 (/opt/crater/workdir)
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/audio.rs:65:32
[INFO] [stderr]    |
[INFO] [stderr] 65 |                     let ff11 = ((state.duty << 6 & 0b11000000))
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/audio.rs:65:52
[INFO] [stderr]    |
[INFO] [stderr] 65 |                     let ff11 = ((state.duty << 6 & 0b11000000))
[INFO] [stderr]    |                                                    ^^^^^^^^^^ help: consider: `0b1100_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/audio.rs:66:52
[INFO] [stderr]    |
[INFO] [stderr] 66 |                                | length          & 0b00111111;
[INFO] [stderr]    |                                                    ^^^^^^^^^^ help: consider: `0b0011_1111`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/audio.rs:69:54
[INFO] [stderr]    |
[INFO] [stderr] 69 |                         | (state.envelope_argument & 0b00000111);
[INFO] [stderr]    |                                                      ^^^^^^^^^^ help: consider: `0b0000_0111`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/audio.rs:71:58
[INFO] [stderr]    |
[INFO] [stderr] 71 |                     let ff14 = ((frequency >> 8) as u8 & 0b00000111)
[INFO] [stderr]    |                                                          ^^^^^^^^^^ help: consider: `0b0000_0111`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/audio.rs:110:32
[INFO] [stderr]     |
[INFO] [stderr] 110 |                     let ff16 = ((state.duty << 6 & 0b11000000))
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/audio.rs:110:52
[INFO] [stderr]     |
[INFO] [stderr] 110 |                     let ff16 = ((state.duty << 6 & 0b11000000))
[INFO] [stderr]     |                                                    ^^^^^^^^^^ help: consider: `0b1100_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/audio.rs:111:52
[INFO] [stderr]     |
[INFO] [stderr] 111 |                                | length          & 0b00111111;
[INFO] [stderr]     |                                                    ^^^^^^^^^^ help: consider: `0b0011_1111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/audio.rs:114:54
[INFO] [stderr]     |
[INFO] [stderr] 114 |                         | (state.envelope_argument & 0b00000111);
[INFO] [stderr]     |                                                      ^^^^^^^^^^ help: consider: `0b0000_0111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/audio.rs:116:58
[INFO] [stderr]     |
[INFO] [stderr] 116 |                     let ff19 = ((frequency >> 8) as u8 & 0b00000111)
[INFO] [stderr]     |                                                          ^^^^^^^^^^ help: consider: `0b0000_0111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/audio.rs:65:32
[INFO] [stderr]    |
[INFO] [stderr] 65 |                     let ff11 = ((state.duty << 6 & 0b11000000))
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/audio.rs:65:52
[INFO] [stderr]    |
[INFO] [stderr] 65 |                     let ff11 = ((state.duty << 6 & 0b11000000))
[INFO] [stderr]    |                                                    ^^^^^^^^^^ help: consider: `0b1100_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/audio.rs:66:52
[INFO] [stderr]    |
[INFO] [stderr] 66 |                                | length          & 0b00111111;
[INFO] [stderr]    |                                                    ^^^^^^^^^^ help: consider: `0b0011_1111`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/audio.rs:69:54
[INFO] [stderr]    |
[INFO] [stderr] 69 |                         | (state.envelope_argument & 0b00000111);
[INFO] [stderr]    |                                                      ^^^^^^^^^^ help: consider: `0b0000_0111`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/audio.rs:71:58
[INFO] [stderr]    |
[INFO] [stderr] 71 |                     let ff14 = ((frequency >> 8) as u8 & 0b00000111)
[INFO] [stderr]    |                                                          ^^^^^^^^^^ help: consider: `0b0000_0111`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/audio.rs:110:32
[INFO] [stderr]     |
[INFO] [stderr] 110 |                     let ff16 = ((state.duty << 6 & 0b11000000))
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/audio.rs:110:52
[INFO] [stderr]     |
[INFO] [stderr] 110 |                     let ff16 = ((state.duty << 6 & 0b11000000))
[INFO] [stderr]     |                                                    ^^^^^^^^^^ help: consider: `0b1100_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/audio.rs:111:52
[INFO] [stderr]     |
[INFO] [stderr] 111 |                                | length          & 0b00111111;
[INFO] [stderr]     |                                                    ^^^^^^^^^^ help: consider: `0b0011_1111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/audio.rs:114:54
[INFO] [stderr]     |
[INFO] [stderr] 114 |                         | (state.envelope_argument & 0b00000111);
[INFO] [stderr]     |                                                      ^^^^^^^^^^ help: consider: `0b0000_0111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/audio.rs:116:58
[INFO] [stderr]     |
[INFO] [stderr] 116 |                     let ff19 = ((frequency >> 8) as u8 & 0b00000111)
[INFO] [stderr]     |                                                          ^^^^^^^^^^ help: consider: `0b0000_0111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 36
[INFO] [stderr]    --> src/ast.rs:344:5
[INFO] [stderr]     |
[INFO] [stderr] 344 | /     pub fn write_to_rom(&self, rom: &mut Vec<u8>, constants: &HashMap<String, i64>) -> Result<(), Error> {
[INFO] [stderr] 345 | |         match self {
[INFO] [stderr] 346 | |             Instruction::AdvanceAddress (advance_address) => {
[INFO] [stderr] 347 | |                 let address_bank = (rom.len() as u32 % ROM_BANK_SIZE) as u16;
[INFO] [stderr] ...   |
[INFO] [stderr] 879 | |         Ok(())
[INFO] [stderr] 880 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/audio.rs:162:12
[INFO] [stderr]     |
[INFO] [stderr] 162 |         if tokens.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tokens.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/rom_builder.rs:53:45
[INFO] [stderr]    |
[INFO] [stderr] 53 |             DataSource::Code             => format!("data generated by rust code"),
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"data generated by rust code".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/rom_builder.rs:54:45
[INFO] [stderr]    |
[INFO] [stderr] 54 |             DataSource::AudioPlayer      => format!("instructions generated by the built-in ggbasm audio player"),
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"instructions generated by the built-in ggbasm audio player".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/rom_builder.rs:152:16
[INFO] [stderr]     |
[INFO] [stderr] 152 |           if let Some(_) = self.constants.insert(identifier.to_string(), self.address as i64) {
[INFO] [stderr]     |  _________-      ^^^^^^^
[INFO] [stderr] 153 | |             // TODO: Display first usage
[INFO] [stderr] 154 | |             bail!("Identifier {} is already used", identifier)
[INFO] [stderr] 155 | |         }
[INFO] [stderr]     | |_________- help: try this: `if self.constants.insert(identifier.to_string(), self.address as i64).is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/rom_builder.rs:152:72
[INFO] [stderr]     |
[INFO] [stderr] 152 |         if let Some(_) = self.constants.insert(identifier.to_string(), self.address as i64) {
[INFO] [stderr]     |                                                                        ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.address)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/rom_builder.rs:180:16
[INFO] [stderr]     |
[INFO] [stderr] 180 |           if let Some(_) = self.constants.insert(identifier.to_string(), self.address as i64) {
[INFO] [stderr]     |  _________-      ^^^^^^^
[INFO] [stderr] 181 | |             // TODO: Display first usage
[INFO] [stderr] 182 | |             bail!("Identifier {} is already used", identifier)
[INFO] [stderr] 183 | |         }
[INFO] [stderr]     | |_________- help: try this: `if self.constants.insert(identifier.to_string(), self.address as i64).is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/rom_builder.rs:180:72
[INFO] [stderr]     |
[INFO] [stderr] 180 |         if let Some(_) = self.constants.insert(identifier.to_string(), self.address as i64) {
[INFO] [stderr]     |                                                                        ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.address)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/rom_builder.rs:383:29
[INFO] [stderr]     |
[INFO] [stderr] 383 |             .map(|(i, x)| x.expect(&format!("Invalid instruction on line {} of audio_player.asm", i + 1)))
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Invalid instruction on line {} of audio_player.asm", i + 1))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/rom_builder.rs:445:24
[INFO] [stderr]     |
[INFO] [stderr] 445 |                   if let Some(_) = self.constants.insert(label.to_string(), cur_address as i64) {
[INFO] [stderr]     |  _________________-      ^^^^^^^
[INFO] [stderr] 446 | |                     // TODO: Display first usage
[INFO] [stderr] 447 | |                     bail!("Identifier {} is used twice: One usage occured in {} on line {}", label, source.to_string(), i + 1);
[INFO] [stderr] 448 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if self.constants.insert(label.to_string(), cur_address as i64).is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/rom_builder.rs:445:75
[INFO] [stderr]     |
[INFO] [stderr] 445 |                 if let Some(_) = self.constants.insert(label.to_string(), cur_address as i64) {
[INFO] [stderr]     |                                                                           ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(cur_address)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/rom_builder.rs:451:32
[INFO] [stderr]     |
[INFO] [stderr] 451 |                 cur_address += instruction.len((cur_address % ROM_BANK_SIZE) as u16) as u32;
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(instruction.len((cur_address % ROM_BANK_SIZE) as u16))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/rom_builder.rs:583:32
[INFO] [stderr]     |
[INFO] [stderr] 583 |                           if let Some(_) = constants.insert(equ.ident.clone(), value) {
[INFO] [stderr]     |  _________________________-      ^^^^^^^
[INFO] [stderr] 584 | |                             // TODO: Display first usage
[INFO] [stderr] 585 | |                             outer_error = Some(format!("Identifier {} is used twice: One usage occured in {} on line {}", &equ.ident, equ.source.to_string(), equ.line));
[INFO] [stderr] 586 | |                         }
[INFO] [stderr]     | |_________________________- help: try this: `if constants.insert(equ.ident.clone(), value).is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/rom_builder.rs:744:9
[INFO] [stderr]     |
[INFO] [stderr] 744 |         File::create(&output)?.write(&rom)?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `ggbasm`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: the function has a cyclomatic complexity of 36
[INFO] [stderr]    --> src/ast.rs:344:5
[INFO] [stderr]     |
[INFO] [stderr] 344 | /     pub fn write_to_rom(&self, rom: &mut Vec<u8>, constants: &HashMap<String, i64>) -> Result<(), Error> {
[INFO] [stderr] 345 | |         match self {
[INFO] [stderr] 346 | |             Instruction::AdvanceAddress (advance_address) => {
[INFO] [stderr] 347 | |                 let address_bank = (rom.len() as u32 % ROM_BANK_SIZE) as u16;
[INFO] [stderr] ...   |
[INFO] [stderr] 879 | |         Ok(())
[INFO] [stderr] 880 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/audio.rs:162:12
[INFO] [stderr]     |
[INFO] [stderr] 162 |         if tokens.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tokens.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/rom_builder.rs:53:45
[INFO] [stderr]    |
[INFO] [stderr] 53 |             DataSource::Code             => format!("data generated by rust code"),
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"data generated by rust code".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/rom_builder.rs:54:45
[INFO] [stderr]    |
[INFO] [stderr] 54 |             DataSource::AudioPlayer      => format!("instructions generated by the built-in ggbasm audio player"),
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"instructions generated by the built-in ggbasm audio player".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/rom_builder.rs:152:16
[INFO] [stderr]     |
[INFO] [stderr] 152 |           if let Some(_) = self.constants.insert(identifier.to_string(), self.address as i64) {
[INFO] [stderr]     |  _________-      ^^^^^^^
[INFO] [stderr] 153 | |             // TODO: Display first usage
[INFO] [stderr] 154 | |             bail!("Identifier {} is already used", identifier)
[INFO] [stderr] 155 | |         }
[INFO] [stderr]     | |_________- help: try this: `if self.constants.insert(identifier.to_string(), self.address as i64).is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/rom_builder.rs:152:72
[INFO] [stderr]     |
[INFO] [stderr] 152 |         if let Some(_) = self.constants.insert(identifier.to_string(), self.address as i64) {
[INFO] [stderr]     |                                                                        ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.address)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/rom_builder.rs:180:16
[INFO] [stderr]     |
[INFO] [stderr] 180 |           if let Some(_) = self.constants.insert(identifier.to_string(), self.address as i64) {
[INFO] [stderr]     |  _________-      ^^^^^^^
[INFO] [stderr] 181 | |             // TODO: Display first usage
[INFO] [stderr] 182 | |             bail!("Identifier {} is already used", identifier)
[INFO] [stderr] 183 | |         }
[INFO] [stderr]     | |_________- help: try this: `if self.constants.insert(identifier.to_string(), self.address as i64).is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/rom_builder.rs:180:72
[INFO] [stderr]     |
[INFO] [stderr] 180 |         if let Some(_) = self.constants.insert(identifier.to_string(), self.address as i64) {
[INFO] [stderr]     |                                                                        ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.address)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/rom_builder.rs:383:29
[INFO] [stderr]     |
[INFO] [stderr] 383 |             .map(|(i, x)| x.expect(&format!("Invalid instruction on line {} of audio_player.asm", i + 1)))
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Invalid instruction on line {} of audio_player.asm", i + 1))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/rom_builder.rs:445:24
[INFO] [stderr]     |
[INFO] [stderr] 445 |                   if let Some(_) = self.constants.insert(label.to_string(), cur_address as i64) {
[INFO] [stderr]     |  _________________-      ^^^^^^^
[INFO] [stderr] 446 | |                     // TODO: Display first usage
[INFO] [stderr] 447 | |                     bail!("Identifier {} is used twice: One usage occured in {} on line {}", label, source.to_string(), i + 1);
[INFO] [stderr] 448 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if self.constants.insert(label.to_string(), cur_address as i64).is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/rom_builder.rs:445:75
[INFO] [stderr]     |
[INFO] [stderr] 445 |                 if let Some(_) = self.constants.insert(label.to_string(), cur_address as i64) {
[INFO] [stderr]     |                                                                           ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(cur_address)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/rom_builder.rs:451:32
[INFO] [stderr]     |
[INFO] [stderr] 451 |                 cur_address += instruction.len((cur_address % ROM_BANK_SIZE) as u16) as u32;
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(instruction.len((cur_address % ROM_BANK_SIZE) as u16))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/rom_builder.rs:583:32
[INFO] [stderr]     |
[INFO] [stderr] 583 |                           if let Some(_) = constants.insert(equ.ident.clone(), value) {
[INFO] [stderr]     |  _________________________-      ^^^^^^^
[INFO] [stderr] 584 | |                             // TODO: Display first usage
[INFO] [stderr] 585 | |                             outer_error = Some(format!("Identifier {} is used twice: One usage occured in {} on line {}", &equ.ident, equ.source.to_string(), equ.line));
[INFO] [stderr] 586 | |                         }
[INFO] [stderr]     | |_________________________- help: try this: `if constants.insert(equ.ident.clone(), value).is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/rom_builder.rs:744:9
[INFO] [stderr]     |
[INFO] [stderr] 744 |         File::create(&output)?.write(&rom)?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `ggbasm`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "e63b23b45104b73e6b40a0adc71067016558f7af290e3e881c1d25ce85420722"`
[INFO] running `"docker" "rm" "-f" "e63b23b45104b73e6b40a0adc71067016558f7af290e3e881c1d25ce85420722"`
[INFO] [stdout] e63b23b45104b73e6b40a0adc71067016558f7af290e3e881c1d25ce85420722