[INFO] crate gfx_text 0.23.0 is already in cache [INFO] extracting crate gfx_text 0.23.0 into work/ex/clippy-test-run/sources/stable/reg/gfx_text/0.23.0 [INFO] extracting crate gfx_text 0.23.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gfx_text/0.23.0 [INFO] validating manifest of gfx_text-0.23.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gfx_text-0.23.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gfx_text-0.23.0 [INFO] finished frobbing gfx_text-0.23.0 [INFO] frobbed toml for gfx_text-0.23.0 written to work/ex/clippy-test-run/sources/stable/reg/gfx_text/0.23.0/Cargo.toml [INFO] started frobbing gfx_text-0.23.0 [INFO] finished frobbing gfx_text-0.23.0 [INFO] frobbed toml for gfx_text-0.23.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gfx_text/0.23.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gfx_text-0.23.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gfx_text/0.23.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d4e1d656dda32e47efec8717dd92079af6f6a2bbe9ed05db0a6fafa05cf263f9 [INFO] running `"docker" "start" "-a" "d4e1d656dda32e47efec8717dd92079af6f6a2bbe9ed05db0a6fafa05cf263f9"` [INFO] [stderr] Compiling freetype-sys v0.7.1 [INFO] [stderr] Checking gfx_device_gl v0.15.5 [INFO] [stderr] Checking winit v0.17.2 [INFO] [stderr] Checking freetype-rs v0.19.1 [INFO] [stderr] Checking gfx_text v0.23.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/font.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | factory: factory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `factory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | shaders: shaders, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `shaders` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:276:13 [INFO] [stderr] | [INFO] [stderr] 276 | vertex_buffer: vertex_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:278:13 [INFO] [stderr] | [INFO] [stderr] 278 | index_buffer: index_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | font_bitmap: font_bitmap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `font_bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:368:17 [INFO] [stderr] | [INFO] [stderr] 368 | world_pos: world_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `world_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:369:17 [INFO] [stderr] | [INFO] [stderr] 369 | screen_rel: screen_rel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `screen_rel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:370:17 [INFO] [stderr] | [INFO] [stderr] 370 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:376:17 [INFO] [stderr] | [INFO] [stderr] 376 | world_pos: world_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `world_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:377:17 [INFO] [stderr] | [INFO] [stderr] 377 | screen_rel: screen_rel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `screen_rel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:378:17 [INFO] [stderr] | [INFO] [stderr] 378 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:384:17 [INFO] [stderr] | [INFO] [stderr] 384 | world_pos: world_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `world_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:385:17 [INFO] [stderr] | [INFO] [stderr] 385 | screen_rel: screen_rel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `screen_rel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:386:17 [INFO] [stderr] | [INFO] [stderr] 386 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:392:17 [INFO] [stderr] | [INFO] [stderr] 392 | world_pos: world_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `world_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:393:17 [INFO] [stderr] | [INFO] [stderr] 393 | screen_rel: screen_rel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `screen_rel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:394:17 [INFO] [stderr] | [INFO] [stderr] 394 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:487:13 [INFO] [stderr] | [INFO] [stderr] 487 | proj: proj, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `proj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:580:20 [INFO] [stderr] | [INFO] [stderr] 580 | const VERTEX_SRC: &'static [u8] = b" [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:613:22 [INFO] [stderr] | [INFO] [stderr] 613 | const FRAGMENT_SRC: &'static [u8] = b" [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Checking glutin v0.18.0 [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/font.rs:99:38 [INFO] [stderr] | [INFO] [stderr] 99 | try!(face.set_pixel_sizes(0, font_size as u32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/font.rs:170:31 [INFO] [stderr] | [INFO] [stderr] 170 | let ch_y_offset = font_size as i32 - glyph.bitmap_top(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/lib.rs:292:12 [INFO] [stderr] | [INFO] [stderr] 292 | Ok(if let Entry::Vacant(e) = self.pso_map.entry(format) { [INFO] [stderr] | ____________^ [INFO] [stderr] 293 | | let init = pipe::Init { [INFO] [stderr] 294 | | vbuf: (), [INFO] [stderr] 295 | | screen_size: "u_Screen_Size", [INFO] [stderr] ... | [INFO] [stderr] 306 | | e.insert(pso); [INFO] [stderr] 307 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 292 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `index` [INFO] [stderr] --> src/lib.rs:402:34 [INFO] [stderr] | [INFO] [stderr] 402 | self.index_data.push(index + 0); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:490:18 [INFO] [stderr] | [INFO] [stderr] 490 | [w as f32, h as f32] [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:490:28 [INFO] [stderr] | [INFO] [stderr] 490 | [w as f32, h as f32] [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:522:9 [INFO] [stderr] | [INFO] [stderr] 522 | / match last_char { [INFO] [stderr] 523 | | Some(info) => width += info.x_offset + info.width - info.x_advance, [INFO] [stderr] 524 | | None => (), [INFO] [stderr] 525 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(info) = last_char { width += info.x_offset + info.width - info.x_advance }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:527:17 [INFO] [stderr] | [INFO] [stderr] 527 | (width, self.font_bitmap.get_font_height() as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.font_bitmap.get_font_height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Checking gfx_window_glutin v0.26.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/font.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | factory: factory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `factory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | shaders: shaders, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `shaders` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:276:13 [INFO] [stderr] | [INFO] [stderr] 276 | vertex_buffer: vertex_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:278:13 [INFO] [stderr] | [INFO] [stderr] 278 | index_buffer: index_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | font_bitmap: font_bitmap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `font_bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:368:17 [INFO] [stderr] | [INFO] [stderr] 368 | world_pos: world_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `world_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:369:17 [INFO] [stderr] | [INFO] [stderr] 369 | screen_rel: screen_rel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `screen_rel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:370:17 [INFO] [stderr] | [INFO] [stderr] 370 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:376:17 [INFO] [stderr] | [INFO] [stderr] 376 | world_pos: world_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `world_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:377:17 [INFO] [stderr] | [INFO] [stderr] 377 | screen_rel: screen_rel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `screen_rel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:378:17 [INFO] [stderr] | [INFO] [stderr] 378 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:384:17 [INFO] [stderr] | [INFO] [stderr] 384 | world_pos: world_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `world_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:385:17 [INFO] [stderr] | [INFO] [stderr] 385 | screen_rel: screen_rel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `screen_rel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:386:17 [INFO] [stderr] | [INFO] [stderr] 386 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:392:17 [INFO] [stderr] | [INFO] [stderr] 392 | world_pos: world_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `world_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:393:17 [INFO] [stderr] | [INFO] [stderr] 393 | screen_rel: screen_rel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `screen_rel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:394:17 [INFO] [stderr] | [INFO] [stderr] 394 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:487:13 [INFO] [stderr] | [INFO] [stderr] 487 | proj: proj, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `proj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:580:20 [INFO] [stderr] | [INFO] [stderr] 580 | const VERTEX_SRC: &'static [u8] = b" [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:613:22 [INFO] [stderr] | [INFO] [stderr] 613 | const FRAGMENT_SRC: &'static [u8] = b" [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/font.rs:99:38 [INFO] [stderr] | [INFO] [stderr] 99 | try!(face.set_pixel_sizes(0, font_size as u32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/font.rs:170:31 [INFO] [stderr] | [INFO] [stderr] 170 | let ch_y_offset = font_size as i32 - glyph.bitmap_top(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/lib.rs:292:12 [INFO] [stderr] | [INFO] [stderr] 292 | Ok(if let Entry::Vacant(e) = self.pso_map.entry(format) { [INFO] [stderr] | ____________^ [INFO] [stderr] 293 | | let init = pipe::Init { [INFO] [stderr] 294 | | vbuf: (), [INFO] [stderr] 295 | | screen_size: "u_Screen_Size", [INFO] [stderr] ... | [INFO] [stderr] 306 | | e.insert(pso); [INFO] [stderr] 307 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 292 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `index` [INFO] [stderr] --> src/lib.rs:402:34 [INFO] [stderr] | [INFO] [stderr] 402 | self.index_data.push(index + 0); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:490:18 [INFO] [stderr] | [INFO] [stderr] 490 | [w as f32, h as f32] [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:490:28 [INFO] [stderr] | [INFO] [stderr] 490 | [w as f32, h as f32] [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:522:9 [INFO] [stderr] | [INFO] [stderr] 522 | / match last_char { [INFO] [stderr] 523 | | Some(info) => width += info.x_offset + info.width - info.x_advance, [INFO] [stderr] 524 | | None => (), [INFO] [stderr] 525 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(info) = last_char { width += info.x_offset + info.width - info.x_advance }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:527:17 [INFO] [stderr] | [INFO] [stderr] 527 | (width, self.font_bitmap.get_font_height() as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.font_bitmap.get_font_height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/styles.rs:20:19 [INFO] [stderr] | [INFO] [stderr] 20 | const FONT_PATH: &'static str = "examples/assets/Ubuntu-R.ttf"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> examples/styles.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | .with_title(format!("gfx_text example")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"gfx_text example".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.85s [INFO] running `"docker" "inspect" "d4e1d656dda32e47efec8717dd92079af6f6a2bbe9ed05db0a6fafa05cf263f9"` [INFO] running `"docker" "rm" "-f" "d4e1d656dda32e47efec8717dd92079af6f6a2bbe9ed05db0a6fafa05cf263f9"` [INFO] [stdout] d4e1d656dda32e47efec8717dd92079af6f6a2bbe9ed05db0a6fafa05cf263f9