[INFO] crate gfx_phase 0.6.0 is already in cache [INFO] extracting crate gfx_phase 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/gfx_phase/0.6.0 [INFO] extracting crate gfx_phase 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gfx_phase/0.6.0 [INFO] validating manifest of gfx_phase-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gfx_phase-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gfx_phase-0.6.0 [INFO] removed path dependency draw_queue from gfx_phase-0.6.0 [INFO] finished frobbing gfx_phase-0.6.0 [INFO] frobbed toml for gfx_phase-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/gfx_phase/0.6.0/Cargo.toml [INFO] started frobbing gfx_phase-0.6.0 [INFO] removed path dependency draw_queue from gfx_phase-0.6.0 [INFO] finished frobbing gfx_phase-0.6.0 [INFO] frobbed toml for gfx_phase-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gfx_phase/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gfx_phase-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gfx_phase/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] de5c240fae110557ac6b08d46cc7d1aab059004fab4199e2c8551a047682b6cf [INFO] running `"docker" "start" "-a" "de5c240fae110557ac6b08d46cc7d1aab059004fab4199e2c8551a047682b6cf"` [INFO] [stderr] Checking draw_queue v0.1.1 [INFO] [stderr] Checking draw_state v0.2.0 [INFO] [stderr] Checking hprof v0.1.3 [INFO] [stderr] Checking gfx v0.8.1 [INFO] [stderr] Checking gfx_phase v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> phase.rs:256:17 [INFO] [stderr] | [INFO] [stderr] 256 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> phase.rs:258:17 [INFO] [stderr] | [INFO] [stderr] 258 | instances: instances, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instances` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> phase.rs:259:17 [INFO] [stderr] | [INFO] [stderr] 259 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> phase.rs:260:17 [INFO] [stderr] | [INFO] [stderr] 260 | kernel: kernel, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `kernel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> phase.rs:256:17 [INFO] [stderr] | [INFO] [stderr] 256 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> phase.rs:258:17 [INFO] [stderr] | [INFO] [stderr] 258 | instances: instances, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instances` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> phase.rs:259:17 [INFO] [stderr] | [INFO] [stderr] 259 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> phase.rs:260:17 [INFO] [stderr] | [INFO] [stderr] 260 | kernel: kernel, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `kernel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> mem.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | self.get(input).map(|r| r.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.get(input).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> phase.rs:46:24 [INFO] [stderr] | [INFO] [stderr] 46 | instances: self.instances.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.instances` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> phase.rs:151:8 [INFO] [stderr] | [INFO] [stderr] 151 | R: gfx::Resources, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> phase.rs:155:14 [INFO] [stderr] | [INFO] [stderr] 155 | > = HashMap<(T::Kernel, gfx::Mesh), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> phase.rs:156:27 [INFO] [stderr] | [INFO] [stderr] 156 | mem::MemResult>, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> phase.rs:156:37 [INFO] [stderr] | [INFO] [stderr] 156 | mem::MemResult>, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> phase.rs:156:48 [INFO] [stderr] | [INFO] [stderr] 156 | mem::MemResult>, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> phase.rs:152:8 [INFO] [stderr] | [INFO] [stderr] 152 | M: ::Material, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> phase.rs:153:8 [INFO] [stderr] | [INFO] [stderr] 153 | V: ::ToDepth, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> phase.rs:154:8 [INFO] [stderr] | [INFO] [stderr] 154 | T: ::Technique, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> phase.rs:161:8 [INFO] [stderr] | [INFO] [stderr] 161 | R: gfx::Resources, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> phase.rs:162:8 [INFO] [stderr] | [INFO] [stderr] 162 | M: ::Material, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> phase.rs:163:8 [INFO] [stderr] | [INFO] [stderr] 163 | V: ::ToDepth, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> phase.rs:164:8 [INFO] [stderr] | [INFO] [stderr] 164 | T: ::Technique, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> phase.rs:246:45 [INFO] [stderr] | [INFO] [stderr] 246 | temp_mesh.attributes.extend(orig_mesh.attributes.iter() [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 247 | | .chain(extra_attributes.iter()).map(|a| a.clone())); [INFO] [stderr] | |______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 246 | temp_mesh.attributes.extend(orig_mesh.attributes.iter() [INFO] [stderr] 247 | .chain(extra_attributes.iter()).cloned()); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> lib.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / fn compile<'a>(&'a self, Self::Kernel) [INFO] [stderr] 55 | | -> TechResult<'a, R, Self::Params>; [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> mem.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | self.get(input).map(|r| r.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.get(input).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> phase.rs:46:24 [INFO] [stderr] | [INFO] [stderr] 46 | instances: self.instances.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.instances` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> phase.rs:151:8 [INFO] [stderr] | [INFO] [stderr] 151 | R: gfx::Resources, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> phase.rs:155:14 [INFO] [stderr] | [INFO] [stderr] 155 | > = HashMap<(T::Kernel, gfx::Mesh), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> phase.rs:156:27 [INFO] [stderr] | [INFO] [stderr] 156 | mem::MemResult>, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> phase.rs:156:37 [INFO] [stderr] | [INFO] [stderr] 156 | mem::MemResult>, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> phase.rs:156:48 [INFO] [stderr] | [INFO] [stderr] 156 | mem::MemResult>, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> phase.rs:152:8 [INFO] [stderr] | [INFO] [stderr] 152 | M: ::Material, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> phase.rs:153:8 [INFO] [stderr] | [INFO] [stderr] 153 | V: ::ToDepth, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> phase.rs:154:8 [INFO] [stderr] | [INFO] [stderr] 154 | T: ::Technique, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> phase.rs:161:8 [INFO] [stderr] | [INFO] [stderr] 161 | R: gfx::Resources, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> phase.rs:162:8 [INFO] [stderr] | [INFO] [stderr] 162 | M: ::Material, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> phase.rs:163:8 [INFO] [stderr] | [INFO] [stderr] 163 | V: ::ToDepth, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> phase.rs:164:8 [INFO] [stderr] | [INFO] [stderr] 164 | T: ::Technique, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> phase.rs:246:45 [INFO] [stderr] | [INFO] [stderr] 246 | temp_mesh.attributes.extend(orig_mesh.attributes.iter() [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 247 | | .chain(extra_attributes.iter()).map(|a| a.clone())); [INFO] [stderr] | |______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 246 | temp_mesh.attributes.extend(orig_mesh.attributes.iter() [INFO] [stderr] 247 | .chain(extra_attributes.iter()).cloned()); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> lib.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / fn compile<'a>(&'a self, Self::Kernel) [INFO] [stderr] 55 | | -> TechResult<'a, R, Self::Params>; [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.64s [INFO] running `"docker" "inspect" "de5c240fae110557ac6b08d46cc7d1aab059004fab4199e2c8551a047682b6cf"` [INFO] running `"docker" "rm" "-f" "de5c240fae110557ac6b08d46cc7d1aab059004fab4199e2c8551a047682b6cf"` [INFO] [stdout] de5c240fae110557ac6b08d46cc7d1aab059004fab4199e2c8551a047682b6cf