[INFO] crate gfx_device_vulkan 0.1.0 is already in cache [INFO] extracting crate gfx_device_vulkan 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/gfx_device_vulkan/0.1.0 [INFO] extracting crate gfx_device_vulkan 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gfx_device_vulkan/0.1.0 [INFO] validating manifest of gfx_device_vulkan-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gfx_device_vulkan-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gfx_device_vulkan-0.1.0 [INFO] removed path dependency gfx_core from gfx_device_vulkan-0.1.0 [INFO] finished frobbing gfx_device_vulkan-0.1.0 [INFO] frobbed toml for gfx_device_vulkan-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/gfx_device_vulkan/0.1.0/Cargo.toml [INFO] started frobbing gfx_device_vulkan-0.1.0 [INFO] removed path dependency gfx_core from gfx_device_vulkan-0.1.0 [INFO] finished frobbing gfx_device_vulkan-0.1.0 [INFO] frobbed toml for gfx_device_vulkan-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gfx_device_vulkan/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gfx_device_vulkan-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gfx_device_vulkan/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 17646224135efc12f3db059f71c17d336596c17a4737817903417710e9abc674 [INFO] running `"docker" "start" "-a" "17646224135efc12f3db059f71c17d336596c17a4737817903417710e9abc674"` [INFO] [stderr] Compiling lalrpop-util v0.11.0 [INFO] [stderr] Checking vk-sys v0.2.7 [INFO] [stderr] Checking vk v0.0.1 [INFO] [stderr] Checking gfx_core v0.6.1 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Compiling spirv-utils v0.2.1 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking gfx_device_vulkan v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | family: family, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `family` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | share: share, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `share` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command.rs:306:13 [INFO] [stderr] | [INFO] [stderr] 306 | share: share, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `share` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | share: share, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `share` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | sub_range: sub_range, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sub_range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | layer: layer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `layer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | family: family, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `family` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | share: share, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `share` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command.rs:306:13 [INFO] [stderr] | [INFO] [stderr] 306 | share: share, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `share` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | share: share, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `share` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | sub_range: sub_range, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sub_range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | layer: layer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `layer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | usage: usage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | role: role, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `role` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:332:13 [INFO] [stderr] | [INFO] [stderr] 332 | bind: bind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:334:13 [INFO] [stderr] | [INFO] [stderr] 334 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:367:13 [INFO] [stderr] | [INFO] [stderr] 367 | shader: shader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `shader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:368:13 [INFO] [stderr] | [INFO] [stderr] 368 | reflection: reflection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reflection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:523:21 [INFO] [stderr] | [INFO] [stderr] 523 | layout: layout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:760:13 [INFO] [stderr] | [INFO] [stderr] 760 | pipeline: pipeline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pipeline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:761:13 [INFO] [stderr] | [INFO] [stderr] 761 | pipe_layout: pipe_layout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pipe_layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:764:13 [INFO] [stderr] | [INFO] [stderr] 764 | render_pass: render_pass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `render_pass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:796:13 [INFO] [stderr] | [INFO] [stderr] 796 | tiling: tiling, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tiling` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:797:13 [INFO] [stderr] | [INFO] [stderr] 797 | usage: usage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:814:13 [INFO] [stderr] | [INFO] [stderr] 814 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | usage: usage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | role: role, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `role` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:332:13 [INFO] [stderr] | [INFO] [stderr] 332 | bind: bind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:334:13 [INFO] [stderr] | [INFO] [stderr] 334 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:367:13 [INFO] [stderr] | [INFO] [stderr] 367 | shader: shader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `shader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:368:13 [INFO] [stderr] | [INFO] [stderr] 368 | reflection: reflection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reflection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:523:21 [INFO] [stderr] | [INFO] [stderr] 523 | layout: layout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:760:13 [INFO] [stderr] | [INFO] [stderr] 760 | pipeline: pipeline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pipeline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:761:13 [INFO] [stderr] | [INFO] [stderr] 761 | pipe_layout: pipe_layout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pipe_layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:764:13 [INFO] [stderr] | [INFO] [stderr] 764 | render_pass: render_pass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `render_pass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:796:13 [INFO] [stderr] | [INFO] [stderr] 796 | tiling: tiling, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tiling` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:797:13 [INFO] [stderr] | [INFO] [stderr] 797 | usage: usage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:814:13 [INFO] [stderr] | [INFO] [stderr] 814 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mirror.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mirror.rs:212:25 [INFO] [stderr] | [INFO] [stderr] 212 | stage: stage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mirror.rs:261:9 [INFO] [stderr] | [INFO] [stderr] 261 | entry_points: entry_points, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry_points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mirror.rs:262:9 [INFO] [stderr] | [INFO] [stderr] 262 | variables: variables, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `variables` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mirror.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | types: types, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `types` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mirror.rs:282:29 [INFO] [stderr] | [INFO] [stderr] 282 | container: container, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `container` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mirror.rs:306:33 [INFO] [stderr] | [INFO] [stderr] 306 | container: container, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `container` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mirror.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | elements: elements, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mirror.rs:362:33 [INFO] [stderr] | [INFO] [stderr] 362 | base_type: base_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `base_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | instance: instance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `instance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | inst_pointers: inst_pointers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inst_pointers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:274:9 [INFO] [stderr] | [INFO] [stderr] 274 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | dev_pointers: dev_pointers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dev_pointers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mirror.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mirror.rs:212:25 [INFO] [stderr] | [INFO] [stderr] 212 | stage: stage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mirror.rs:261:9 [INFO] [stderr] | [INFO] [stderr] 261 | entry_points: entry_points, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry_points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mirror.rs:262:9 [INFO] [stderr] | [INFO] [stderr] 262 | variables: variables, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `variables` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mirror.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | types: types, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `types` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mirror.rs:282:29 [INFO] [stderr] | [INFO] [stderr] 282 | container: container, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `container` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mirror.rs:306:33 [INFO] [stderr] | [INFO] [stderr] 306 | container: container, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `container` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mirror.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | elements: elements, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mirror.rs:362:33 [INFO] [stderr] | [INFO] [stderr] 362 | base_type: base_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `base_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | instance: instance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `instance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | inst_pointers: inst_pointers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inst_pointers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:274:9 [INFO] [stderr] | [INFO] [stderr] 274 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | dev_pointers: dev_pointers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dev_pointers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | 0x00000000 => Some(vk::BORDER_COLOR_FLOAT_TRANSPARENT_BLACK), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | 0xFF000000 => Some(vk::BORDER_COLOR_FLOAT_OPAQUE_BLACK), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFF00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | 0xFFFFFFFF => Some(vk::BORDER_COLOR_FLOAT_OPAQUE_WHITE), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `Decoration` [INFO] [stderr] --> src/mirror.rs:127:36 [INFO] [stderr] | [INFO] [stderr] 127 | use spirv_utils::instruction::{Decoration, Instruction}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:102:28 [INFO] [stderr] | [INFO] [stderr] 102 | const SURFACE_EXTENSIONS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:102:38 [INFO] [stderr] | [INFO] [stderr] 102 | const SURFACE_EXTENSIONS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:140:21 [INFO] [stderr] | [INFO] [stderr] 140 | apiVersion: 0x400000, //TODO [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | 0x00000000 => Some(vk::BORDER_COLOR_FLOAT_TRANSPARENT_BLACK), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | 0xFF000000 => Some(vk::BORDER_COLOR_FLOAT_OPAQUE_BLACK), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFF00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | 0xFFFFFFFF => Some(vk::BORDER_COLOR_FLOAT_OPAQUE_WHITE), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `Decoration` [INFO] [stderr] --> src/mirror.rs:127:36 [INFO] [stderr] | [INFO] [stderr] 127 | use spirv_utils::instruction::{Decoration, Instruction}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:102:28 [INFO] [stderr] | [INFO] [stderr] 102 | const SURFACE_EXTENSIONS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:102:38 [INFO] [stderr] | [INFO] [stderr] 102 | const SURFACE_EXTENSIONS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:140:21 [INFO] [stderr] | [INFO] [stderr] 140 | apiVersion: 0x400000, //TODO [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `decoration` [INFO] [stderr] --> src/mirror.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | let decoration = map_decorations_by_id(&module, result_type.into()); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_decoration` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `decoration` [INFO] [stderr] --> src/mirror.rs:220:21 [INFO] [stderr] | [INFO] [stderr] 220 | let decoration = map_decorations_by_id(&module, result_id.into()); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_decoration` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `field` [INFO] [stderr] --> src/mirror.rs:330:33 [INFO] [stderr] | [INFO] [stderr] 330 | for field in fields { [INFO] [stderr] | ^^^^^ help: consider using `_field` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mapping` [INFO] [stderr] --> src/command.rs:350:17 [INFO] [stderr] | [INFO] [stderr] 350 | let mapping = buffer.lock_mapping().unwrap(); [INFO] [stderr] | ^^^^^^^ help: consider using `_mapping` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `fence` [INFO] [stderr] --> src/command.rs:431:30 [INFO] [stderr] | [INFO] [stderr] 431 | fn wait_fence(&mut self, fence: &handle::Fence) { [INFO] [stderr] | ^^^^^ help: consider using `_fence` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `decoration` [INFO] [stderr] --> src/mirror.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | let decoration = map_decorations_by_id(&module, result_type.into()); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_decoration` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `decoration` [INFO] [stderr] --> src/mirror.rs:220:21 [INFO] [stderr] | [INFO] [stderr] 220 | let decoration = map_decorations_by_id(&module, result_id.into()); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_decoration` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `field` [INFO] [stderr] --> src/mirror.rs:330:33 [INFO] [stderr] | [INFO] [stderr] 330 | for field in fields { [INFO] [stderr] | ^^^^^ help: consider using `_field` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mapping` [INFO] [stderr] --> src/command.rs:350:17 [INFO] [stderr] | [INFO] [stderr] 350 | let mapping = buffer.lock_mapping().unwrap(); [INFO] [stderr] | ^^^^^^^ help: consider using `_mapping` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `fence` [INFO] [stderr] --> src/command.rs:431:30 [INFO] [stderr] | [INFO] [stderr] 431 | fn wait_fence(&mut self, fence: &handle::Fence) { [INFO] [stderr] | ^^^^^ help: consider using `_fence` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `invalidate_mappings` [INFO] [stderr] --> src/command.rs:346:5 [INFO] [stderr] | [INFO] [stderr] 346 | fn invalidate_mappings(&mut self, buffers: &[handle::RawBuffer]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `track_mapped_gpu_access` [INFO] [stderr] --> src/command.rs:365:5 [INFO] [stderr] | [INFO] [stderr] 365 | / fn track_mapped_gpu_access(&mut self, [INFO] [stderr] 366 | | buffers: &[handle::RawBuffer], [INFO] [stderr] 367 | | fence: &handle::Fence) { [INFO] [stderr] 368 | | for buffer in buffers { [INFO] [stderr] ... | [INFO] [stderr] 372 | | } [INFO] [stderr] 373 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `map_member_name_by_id` [INFO] [stderr] --> src/mirror.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | fn map_member_name_by_id<'a>(module: &'a spirv_utils::RawModule, id: desc::Id, member_id: u32) -> Option<&'a str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `map_member_decorations_by_id` [INFO] [stderr] --> src/mirror.rs:86:1 [INFO] [stderr] | [INFO] [stderr] 86 | fn map_member_decorations_by_id(module: &spirv_utils::RawModule, id: desc::Id, member_id: u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/command.rs:153:20 [INFO] [stderr] | [INFO] [stderr] 153 | width: view.0 as f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(view.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/command.rs:154:21 [INFO] [stderr] | [INFO] [stderr] 154 | height: view.1 as f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(view.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/command.rs:164:21 [INFO] [stderr] | [INFO] [stderr] 164 | / if let &Some(ref tv) = color { [INFO] [stderr] 165 | | ats.push(tv.view); [INFO] [stderr] 166 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 164 | if let Some(ref tv) = *color { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/command.rs:186:28 [INFO] [stderr] | [INFO] [stderr] 186 | width: view.0 as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(view.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/command.rs:187:29 [INFO] [stderr] | [INFO] [stderr] 187 | height: view.1 as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(view.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/command.rs:188:29 [INFO] [stderr] | [INFO] [stderr] 188 | layers: view.2 as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(view.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/command.rs:208:28 [INFO] [stderr] | [INFO] [stderr] 208 | width: view.0 as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(view.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/command.rs:209:29 [INFO] [stderr] | [INFO] [stderr] 209 | height: view.1 as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(view.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/command.rs:267:22 [INFO] [stderr] | [INFO] [stderr] 267 | stencil: stencil.unwrap_or(0) as u32, //TODO [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(stencil.unwrap_or(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:266:115 [INFO] [stderr] | [INFO] [stderr] 266 | FilterMethod::Anisotropic(a) => (vk::FILTER_LINEAR, vk::FILTER_LINEAR, vk::SAMPLER_MIPMAP_MODE_LINEAR, a as f32), [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:350:31 [INFO] [stderr] | [INFO] [stderr] 350 | pub fn map_stencil_side(side: &state::StencilSide) -> vk::StencilOpState { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `state::StencilSide` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:356:22 [INFO] [stderr] | [INFO] [stderr] 356 | compareMask: side.mask_read as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(side.mask_read)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:357:20 [INFO] [stderr] | [INFO] [stderr] 357 | writeMask: side.mask_write as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(side.mask_write)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/factory.rs:38:10 [INFO] [stderr] | [INFO] [stderr] 38 | *(self.pointer as *mut T).offset(index as isize) = val; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.pointer as *mut T).add(index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:92:27 [INFO] [stderr] | [INFO] [stderr] 92 | baseMipLevel: desc.min as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(desc.min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:93:25 [INFO] [stderr] | [INFO] [stderr] 93 | levelCount: (desc.max + 1 - desc.min) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(desc.max + 1 - desc.min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:94:29 [INFO] [stderr] | [INFO] [stderr] 94 | baseArrayLayer: desc.layer.unwrap_or(0) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(desc.layer.unwrap_or(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:97:25 [INFO] [stderr] | [INFO] [stderr] 97 | None => td.kind.get_num_slices().unwrap_or(1) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(td.kind.get_num_slices().unwrap_or(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/factory.rs:358:20 [INFO] [stderr] | [INFO] [stderr] 358 | pCode: code.as_ptr() as *const _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/factory.rs:420:5 [INFO] [stderr] | [INFO] [stderr] 420 | / fn create_pipeline_state_raw(&mut self, program: &h::Program, desc: &pso::Descriptor) [INFO] [stderr] 421 | | -> Result, pso::CreationError> { [INFO] [stderr] 422 | | use core::handle::Producer; [INFO] [stderr] 423 | | let stages = self.get_shader_stages(program); [INFO] [stderr] ... | [INFO] [stderr] 767 | | Ok(self.share.handles.borrow_mut().make_pso(pso, program)) [INFO] [stderr] 768 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: method is never used: `invalidate_mappings` [INFO] [stderr] --> src/command.rs:346:5 [INFO] [stderr] | [INFO] [stderr] 346 | fn invalidate_mappings(&mut self, buffers: &[handle::RawBuffer]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `track_mapped_gpu_access` [INFO] [stderr] --> src/command.rs:365:5 [INFO] [stderr] | [INFO] [stderr] 365 | / fn track_mapped_gpu_access(&mut self, [INFO] [stderr] 366 | | buffers: &[handle::RawBuffer], [INFO] [stderr] 367 | | fence: &handle::Fence) { [INFO] [stderr] 368 | | for buffer in buffers { [INFO] [stderr] ... | [INFO] [stderr] 372 | | } [INFO] [stderr] 373 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `map_member_name_by_id` [INFO] [stderr] --> src/mirror.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | fn map_member_name_by_id<'a>(module: &'a spirv_utils::RawModule, id: desc::Id, member_id: u32) -> Option<&'a str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `map_member_decorations_by_id` [INFO] [stderr] --> src/mirror.rs:86:1 [INFO] [stderr] | [INFO] [stderr] 86 | fn map_member_decorations_by_id(module: &spirv_utils::RawModule, id: desc::Id, member_id: u32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/command.rs:153:20 [INFO] [stderr] | [INFO] [stderr] 153 | width: view.0 as f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(view.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/command.rs:154:21 [INFO] [stderr] | [INFO] [stderr] 154 | height: view.1 as f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(view.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/command.rs:164:21 [INFO] [stderr] | [INFO] [stderr] 164 | / if let &Some(ref tv) = color { [INFO] [stderr] 165 | | ats.push(tv.view); [INFO] [stderr] 166 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 164 | if let Some(ref tv) = *color { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/command.rs:186:28 [INFO] [stderr] | [INFO] [stderr] 186 | width: view.0 as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(view.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/factory.rs:429:17 [INFO] [stderr] | [INFO] [stderr] 429 | / if let &Some(usage) = cb { [INFO] [stderr] 430 | | bindings.push(vk::DescriptorSetLayoutBinding { [INFO] [stderr] 431 | | binding: i as u32, [INFO] [stderr] 432 | | descriptorType: vk::DESCRIPTOR_TYPE_UNIFORM_BUFFER, [INFO] [stderr] ... | [INFO] [stderr] 436 | | }); [INFO] [stderr] 437 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 429 | if let Some(usage) = *cb { [INFO] [stderr] | ^^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/command.rs:187:29 [INFO] [stderr] | [INFO] [stderr] 187 | height: view.1 as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(view.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/command.rs:188:29 [INFO] [stderr] | [INFO] [stderr] 188 | layers: view.2 as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(view.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/factory.rs:440:17 [INFO] [stderr] | [INFO] [stderr] 440 | / if let &Some(usage) = srv { [INFO] [stderr] 441 | | bindings.push(vk::DescriptorSetLayoutBinding { [INFO] [stderr] 442 | | binding: i as u32, [INFO] [stderr] 443 | | descriptorType: vk::DESCRIPTOR_TYPE_SAMPLED_IMAGE, [INFO] [stderr] ... | [INFO] [stderr] 447 | | }); [INFO] [stderr] 448 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 440 | if let Some(usage) = *srv { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/factory.rs:451:17 [INFO] [stderr] | [INFO] [stderr] 451 | / if let &Some(usage) = uav { [INFO] [stderr] 452 | | bindings.push(vk::DescriptorSetLayoutBinding { [INFO] [stderr] 453 | | binding: i as u32, [INFO] [stderr] 454 | | descriptorType: vk::DESCRIPTOR_TYPE_STORAGE_IMAGE, //TODO: buffer views [INFO] [stderr] ... | [INFO] [stderr] 458 | | }); [INFO] [stderr] 459 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 451 | if let Some(usage) = *uav { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/command.rs:208:28 [INFO] [stderr] | [INFO] [stderr] 208 | width: view.0 as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(view.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/command.rs:209:29 [INFO] [stderr] | [INFO] [stderr] 209 | height: view.1 as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(view.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/factory.rs:462:17 [INFO] [stderr] | [INFO] [stderr] 462 | / if let &Some(usage) = sam { [INFO] [stderr] 463 | | bindings.push(vk::DescriptorSetLayoutBinding { [INFO] [stderr] 464 | | binding: i as u32, [INFO] [stderr] 465 | | descriptorType: vk::DESCRIPTOR_TYPE_SAMPLER, [INFO] [stderr] ... | [INFO] [stderr] 469 | | }); [INFO] [stderr] 470 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 462 | if let Some(usage) = *sam { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/command.rs:267:22 [INFO] [stderr] | [INFO] [stderr] 267 | stencil: stencil.unwrap_or(0) as u32, //TODO [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(stencil.unwrap_or(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/factory.rs:591:17 [INFO] [stderr] | [INFO] [stderr] 591 | / if let &Some(v) = vbuf { [INFO] [stderr] 592 | | vertex_bindings.push(vk::VertexInputBindingDescription { [INFO] [stderr] 593 | | binding: i as u32, [INFO] [stderr] 594 | | stride: v.stride as u32, [INFO] [stderr] 595 | | inputRate: v.rate as vk::VertexInputRate, [INFO] [stderr] 596 | | }); [INFO] [stderr] 597 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 591 | if let Some(v) = *vbuf { [INFO] [stderr] | ^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:594:33 [INFO] [stderr] | [INFO] [stderr] 594 | stride: v.stride as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(v.stride)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:595:36 [INFO] [stderr] | [INFO] [stderr] 595 | inputRate: v.rate as vk::VertexInputRate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(v.rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/factory.rs:601:17 [INFO] [stderr] | [INFO] [stderr] 601 | / if let &Some(a) = attr { [INFO] [stderr] 602 | | vertex_attributes.push(vk::VertexInputAttributeDescription { [INFO] [stderr] 603 | | location: i as u32, [INFO] [stderr] 604 | | binding: a.0 as u32, [INFO] [stderr] ... | [INFO] [stderr] 610 | | }); [INFO] [stderr] 611 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 601 | if let Some(a) = *attr { [INFO] [stderr] | ^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:604:34 [INFO] [stderr] | [INFO] [stderr] 604 | binding: a.0 as u32, [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(a.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/factory.rs:615:17 [INFO] [stderr] | [INFO] [stderr] 615 | / if let &Some(ref cd) = ocd { [INFO] [stderr] 616 | | attachments.push(data::map_blend(&cd.1)); [INFO] [stderr] 617 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 615 | if let Some(ref cd) = *ocd { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:789:24 [INFO] [stderr] | [INFO] [stderr] 789 | width: w as u32, [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:790:25 [INFO] [stderr] | [INFO] [stderr] 790 | height: h as u32, [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:791:45 [INFO] [stderr] | [INFO] [stderr] 791 | depth: if slices.is_none() {d as u32} else {1}, [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:793:24 [INFO] [stderr] | [INFO] [stderr] 793 | mipLevels: desc.levels as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(desc.levels)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:794:26 [INFO] [stderr] | [INFO] [stderr] 794 | arrayLayers: slices.unwrap_or(1) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slices.unwrap_or(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:795:22 [INFO] [stderr] | [INFO] [stderr] 795 | samples: aa.get_num_fragments() as vk::SampleCountFlagBits, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(aa.get_num_fragments())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:266:115 [INFO] [stderr] | [INFO] [stderr] 266 | FilterMethod::Anisotropic(a) => (vk::FILTER_LINEAR, vk::FILTER_LINEAR, vk::SAMPLER_MIPMAP_MODE_LINEAR, a as f32), [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:350:31 [INFO] [stderr] | [INFO] [stderr] 350 | pub fn map_stencil_side(side: &state::StencilSide) -> vk::StencilOpState { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `state::StencilSide` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:356:22 [INFO] [stderr] | [INFO] [stderr] 356 | compareMask: side.mask_read as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(side.mask_read)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:357:20 [INFO] [stderr] | [INFO] [stderr] 357 | writeMask: side.mask_write as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(side.mask_write)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/factory.rs:38:10 [INFO] [stderr] | [INFO] [stderr] 38 | *(self.pointer as *mut T).offset(index as isize) = val; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.pointer as *mut T).add(index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:92:27 [INFO] [stderr] | [INFO] [stderr] 92 | baseMipLevel: desc.min as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(desc.min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:93:25 [INFO] [stderr] | [INFO] [stderr] 93 | levelCount: (desc.max + 1 - desc.min) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(desc.max + 1 - desc.min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:94:29 [INFO] [stderr] | [INFO] [stderr] 94 | baseArrayLayer: desc.layer.unwrap_or(0) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(desc.layer.unwrap_or(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:97:25 [INFO] [stderr] | [INFO] [stderr] 97 | None => td.kind.get_num_slices().unwrap_or(1) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(td.kind.get_num_slices().unwrap_or(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/native.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | / impl hash::Hash for Texture { [INFO] [stderr] 55 | | fn hash(&self, state: &mut H) where H: hash::Hasher { [INFO] [stderr] 56 | | self.image.hash(state); [INFO] [stderr] 57 | | self.layout.get().hash(state); [INFO] [stderr] 58 | | self.memory.hash(state); [INFO] [stderr] 59 | | } [INFO] [stderr] 60 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/native.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | #[derive(Clone, Debug, Eq, PartialEq)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: structure field `aspectMask` should have a snake case name such as `aspect_mask` [INFO] [stderr] --> src/native.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | pub aspectMask: vk::ImageAspectFlags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `baseMipLevel` should have a snake case name such as `base_mip_level` [INFO] [stderr] --> src/native.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | pub baseMipLevel: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `levelCount` should have a snake case name such as `level_count` [INFO] [stderr] --> src/native.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | pub levelCount: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `baseArrayLayer` should have a snake case name such as `base_array_layer` [INFO] [stderr] --> src/native.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | pub baseArrayLayer: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `layerCount` should have a snake case name such as `layer_count` [INFO] [stderr] --> src/native.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | pub layerCount: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/factory.rs:358:20 [INFO] [stderr] | [INFO] [stderr] 358 | pCode: code.as_ptr() as *const _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/factory.rs:420:5 [INFO] [stderr] | [INFO] [stderr] 420 | / fn create_pipeline_state_raw(&mut self, program: &h::Program, desc: &pso::Descriptor) [INFO] [stderr] 421 | | -> Result, pso::CreationError> { [INFO] [stderr] 422 | | use core::handle::Producer; [INFO] [stderr] 423 | | let stages = self.get_shader_stages(program); [INFO] [stderr] ... | [INFO] [stderr] 767 | | Ok(self.share.handles.borrow_mut().make_pso(pso, program)) [INFO] [stderr] 768 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mirror.rs:52:1 [INFO] [stderr] | [INFO] [stderr] 52 | / fn map_name_by_id<'a>(module: &'a spirv_utils::RawModule, id: desc::Id) -> Option<&'a str> { [INFO] [stderr] 53 | | module.uses(id).filter_map(|instr| { [INFO] [stderr] 54 | | match *instr { [INFO] [stderr] 55 | | instruction::Instruction::Name { ref name, .. } => { [INFO] [stderr] ... | [INFO] [stderr] 60 | | }).next() [INFO] [stderr] 61 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mirror.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | / fn map_member_name_by_id<'a>(module: &'a spirv_utils::RawModule, id: desc::Id, member_id: u32) -> Option<&'a str> { [INFO] [stderr] 64 | | module.uses(id).filter_map(|instr| { [INFO] [stderr] 65 | | match *instr { [INFO] [stderr] 66 | | instruction::Instruction::MemberName { ref name, member, .. } if member == member_id => { [INFO] [stderr] ... | [INFO] [stderr] 71 | | }).next() [INFO] [stderr] 72 | | } [INFO] [stderr] | |_^ [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/factory.rs:429:17 [INFO] [stderr] | [INFO] [stderr] 429 | / if let &Some(usage) = cb { [INFO] [stderr] 430 | | bindings.push(vk::DescriptorSetLayoutBinding { [INFO] [stderr] 431 | | binding: i as u32, [INFO] [stderr] 432 | | descriptorType: vk::DESCRIPTOR_TYPE_UNIFORM_BUFFER, [INFO] [stderr] ... | [INFO] [stderr] 436 | | }); [INFO] [stderr] 437 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 429 | if let Some(usage) = *cb { [INFO] [stderr] | ^^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/factory.rs:440:17 [INFO] [stderr] | [INFO] [stderr] 440 | / if let &Some(usage) = srv { [INFO] [stderr] 441 | | bindings.push(vk::DescriptorSetLayoutBinding { [INFO] [stderr] 442 | | binding: i as u32, [INFO] [stderr] 443 | | descriptorType: vk::DESCRIPTOR_TYPE_SAMPLED_IMAGE, [INFO] [stderr] ... | [INFO] [stderr] 447 | | }); [INFO] [stderr] 448 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 440 | if let Some(usage) = *srv { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/factory.rs:451:17 [INFO] [stderr] | [INFO] [stderr] 451 | / if let &Some(usage) = uav { [INFO] [stderr] 452 | | bindings.push(vk::DescriptorSetLayoutBinding { [INFO] [stderr] 453 | | binding: i as u32, [INFO] [stderr] 454 | | descriptorType: vk::DESCRIPTOR_TYPE_STORAGE_IMAGE, //TODO: buffer views [INFO] [stderr] ... | [INFO] [stderr] 458 | | }); [INFO] [stderr] 459 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 451 | if let Some(usage) = *uav { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/factory.rs:462:17 [INFO] [stderr] | [INFO] [stderr] 462 | / if let &Some(usage) = sam { [INFO] [stderr] 463 | | bindings.push(vk::DescriptorSetLayoutBinding { [INFO] [stderr] 464 | | binding: i as u32, [INFO] [stderr] 465 | | descriptorType: vk::DESCRIPTOR_TYPE_SAMPLER, [INFO] [stderr] ... | [INFO] [stderr] 469 | | }); [INFO] [stderr] 470 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 462 | if let Some(usage) = *sam { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/factory.rs:591:17 [INFO] [stderr] | [INFO] [stderr] 591 | / if let &Some(v) = vbuf { [INFO] [stderr] 592 | | vertex_bindings.push(vk::VertexInputBindingDescription { [INFO] [stderr] 593 | | binding: i as u32, [INFO] [stderr] 594 | | stride: v.stride as u32, [INFO] [stderr] 595 | | inputRate: v.rate as vk::VertexInputRate, [INFO] [stderr] 596 | | }); [INFO] [stderr] 597 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 591 | if let Some(v) = *vbuf { [INFO] [stderr] | ^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:594:33 [INFO] [stderr] | [INFO] [stderr] 594 | stride: v.stride as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(v.stride)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:595:36 [INFO] [stderr] | [INFO] [stderr] 595 | inputRate: v.rate as vk::VertexInputRate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(v.rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/factory.rs:601:17 [INFO] [stderr] | [INFO] [stderr] 601 | / if let &Some(a) = attr { [INFO] [stderr] 602 | | vertex_attributes.push(vk::VertexInputAttributeDescription { [INFO] [stderr] 603 | | location: i as u32, [INFO] [stderr] 604 | | binding: a.0 as u32, [INFO] [stderr] ... | [INFO] [stderr] 610 | | }); [INFO] [stderr] 611 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 601 | if let Some(a) = *attr { [INFO] [stderr] | ^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:604:34 [INFO] [stderr] | [INFO] [stderr] 604 | binding: a.0 as u32, [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(a.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/factory.rs:615:17 [INFO] [stderr] | [INFO] [stderr] 615 | / if let &Some(ref cd) = ocd { [INFO] [stderr] 616 | | attachments.push(data::map_blend(&cd.1)); [INFO] [stderr] 617 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 615 | if let Some(ref cd) = *ocd { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:789:24 [INFO] [stderr] | [INFO] [stderr] 789 | width: w as u32, [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:790:25 [INFO] [stderr] | [INFO] [stderr] 790 | height: h as u32, [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:791:45 [INFO] [stderr] | [INFO] [stderr] 791 | depth: if slices.is_none() {d as u32} else {1}, [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:793:24 [INFO] [stderr] | [INFO] [stderr] 793 | mipLevels: desc.levels as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(desc.levels)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:794:26 [INFO] [stderr] | [INFO] [stderr] 794 | arrayLayers: slices.unwrap_or(1) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slices.unwrap_or(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/factory.rs:795:22 [INFO] [stderr] | [INFO] [stderr] 795 | samples: aa.get_num_fragments() as vk::SampleCountFlagBits, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(aa.get_num_fragments())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mirror.rs:223:61 [INFO] [stderr] | [INFO] [stderr] 223 | let ptr_ty = module.def::(result_type.into()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `result_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/native.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | / impl hash::Hash for Texture { [INFO] [stderr] 55 | | fn hash(&self, state: &mut H) where H: hash::Hasher { [INFO] [stderr] 56 | | self.image.hash(state); [INFO] [stderr] 57 | | self.layout.get().hash(state); [INFO] [stderr] 58 | | self.memory.hash(state); [INFO] [stderr] 59 | | } [INFO] [stderr] 60 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/native.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | #[derive(Clone, Debug, Eq, PartialEq)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: structure field `aspectMask` should have a snake case name such as `aspect_mask` [INFO] [stderr] --> src/native.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | pub aspectMask: vk::ImageAspectFlags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `baseMipLevel` should have a snake case name such as `base_mip_level` [INFO] [stderr] --> src/native.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | pub baseMipLevel: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `levelCount` should have a snake case name such as `level_count` [INFO] [stderr] --> src/native.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | pub levelCount: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `baseArrayLayer` should have a snake case name such as `base_array_layer` [INFO] [stderr] --> src/native.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | pub baseArrayLayer: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `layerCount` should have a snake case name such as `layer_count` [INFO] [stderr] --> src/native.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | pub layerCount: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mirror.rs:52:1 [INFO] [stderr] | [INFO] [stderr] 52 | / fn map_name_by_id<'a>(module: &'a spirv_utils::RawModule, id: desc::Id) -> Option<&'a str> { [INFO] [stderr] 53 | | module.uses(id).filter_map(|instr| { [INFO] [stderr] 54 | | match *instr { [INFO] [stderr] 55 | | instruction::Instruction::Name { ref name, .. } => { [INFO] [stderr] ... | [INFO] [stderr] 60 | | }).next() [INFO] [stderr] 61 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mirror.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | / fn map_member_name_by_id<'a>(module: &'a spirv_utils::RawModule, id: desc::Id, member_id: u32) -> Option<&'a str> { [INFO] [stderr] 64 | | module.uses(id).filter_map(|instr| { [INFO] [stderr] 65 | | match *instr { [INFO] [stderr] 66 | | instruction::Instruction::MemberName { ref name, member, .. } if member == member_id => { [INFO] [stderr] ... | [INFO] [stderr] 71 | | }).next() [INFO] [stderr] 72 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mirror.rs:223:61 [INFO] [stderr] | [INFO] [stderr] 223 | let ptr_ty = module.def::(result_type.into()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `result_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `gfx_device_vulkan`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `gfx_device_vulkan`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "17646224135efc12f3db059f71c17d336596c17a4737817903417710e9abc674"` [INFO] running `"docker" "rm" "-f" "17646224135efc12f3db059f71c17d336596c17a4737817903417710e9abc674"` [INFO] [stdout] 17646224135efc12f3db059f71c17d336596c17a4737817903417710e9abc674