[INFO] crate gfx_device_gl 0.15.3 is already in cache [INFO] extracting crate gfx_device_gl 0.15.3 into work/ex/clippy-test-run/sources/stable/reg/gfx_device_gl/0.15.3 [INFO] extracting crate gfx_device_gl 0.15.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gfx_device_gl/0.15.3 [INFO] validating manifest of gfx_device_gl-0.15.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gfx_device_gl-0.15.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gfx_device_gl-0.15.3 [INFO] finished frobbing gfx_device_gl-0.15.3 [INFO] frobbed toml for gfx_device_gl-0.15.3 written to work/ex/clippy-test-run/sources/stable/reg/gfx_device_gl/0.15.3/Cargo.toml [INFO] started frobbing gfx_device_gl-0.15.3 [INFO] finished frobbing gfx_device_gl-0.15.3 [INFO] frobbed toml for gfx_device_gl-0.15.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gfx_device_gl/0.15.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gfx_device_gl-0.15.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gfx_device_gl/0.15.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 30d3fef2c4ffc5ac19e425c1c14f3066f93496957b67db83d5f071dff47fa670 [INFO] running `"docker" "start" "-a" "30d3fef2c4ffc5ac19e425c1c14f3066f93496957b67db83d5f071dff47fa670"` [INFO] [stderr] Checking gfx_device_gl v0.15.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | share: share, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `share` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | share: share, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `share` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:196:17 [INFO] [stderr] | [INFO] [stderr] 196 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | role: role, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `role` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | bind: bind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:329:13 [INFO] [stderr] | [INFO] [stderr] 329 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:397:13 [INFO] [stderr] | [INFO] [stderr] 397 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/info.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/info.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/info.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | vendor_info: vendor_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vendor_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | container: container, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `container` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:196:17 [INFO] [stderr] | [INFO] [stderr] 196 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | role: role, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `role` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:307:25 [INFO] [stderr] | [INFO] [stderr] 307 | container: container, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `container` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | bind: bind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:329:13 [INFO] [stderr] | [INFO] [stderr] 329 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:363:21 [INFO] [stderr] | [INFO] [stderr] 363 | container: container, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `container` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:397:13 [INFO] [stderr] | [INFO] [stderr] 397 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:379:21 [INFO] [stderr] | [INFO] [stderr] 379 | usage: usage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/info.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:386:25 [INFO] [stderr] | [INFO] [stderr] 386 | usage: usage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:451:17 [INFO] [stderr] | [INFO] [stderr] 451 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:454:17 [INFO] [stderr] | [INFO] [stderr] 454 | container: container, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `container` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:510:13 [INFO] [stderr] | [INFO] [stderr] 510 | textures: textures, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `textures` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/info.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:512:13 [INFO] [stderr] | [INFO] [stderr] 512 | samplers: samplers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `samplers` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/info.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | vendor_info: vendor_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vendor_info` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | container: container, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `container` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:307:25 [INFO] [stderr] | [INFO] [stderr] 307 | container: container, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `container` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:317:13 [INFO] [stderr] | [INFO] [stderr] 317 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:363:21 [INFO] [stderr] | [INFO] [stderr] 363 | container: container, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `container` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:379:21 [INFO] [stderr] | [INFO] [stderr] 379 | usage: usage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:386:25 [INFO] [stderr] | [INFO] [stderr] 386 | usage: usage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:451:17 [INFO] [stderr] | [INFO] [stderr] 451 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:454:17 [INFO] [stderr] | [INFO] [stderr] 454 | container: container, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `container` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:510:13 [INFO] [stderr] | [INFO] [stderr] 510 | textures: textures, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `textures` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:319:13 [INFO] [stderr] | [INFO] [stderr] 319 | vao: vao, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:512:13 [INFO] [stderr] | [INFO] [stderr] 512 | samplers: samplers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `samplers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:317:13 [INFO] [stderr] | [INFO] [stderr] 317 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:319:13 [INFO] [stderr] | [INFO] [stderr] 319 | vao: vao, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/info.rs:128:22 [INFO] [stderr] | [INFO] [stderr] 128 | const EMPTY_STRING: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/shade.rs:435:14 [INFO] [stderr] | [INFO] [stderr] 435 | }else [INFO] [stderr] | ______________^ [INFO] [stderr] 436 | | if &name == "gl_FragColor" { [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/shade.rs:439:14 [INFO] [stderr] | [INFO] [stderr] 439 | }else [INFO] [stderr] | ______________^ [INFO] [stderr] 440 | | if &name == "gl_FragDepth" { [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:321:38 [INFO] [stderr] | [INFO] [stderr] 321 | max_resource_count: Some(999999), [INFO] [stderr] | ^^^^^^ help: consider: `999_999` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/info.rs:128:22 [INFO] [stderr] | [INFO] [stderr] 128 | const EMPTY_STRING: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/shade.rs:435:14 [INFO] [stderr] | [INFO] [stderr] 435 | }else [INFO] [stderr] | ______________^ [INFO] [stderr] 436 | | if &name == "gl_FragColor" { [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/shade.rs:439:14 [INFO] [stderr] | [INFO] [stderr] 439 | }else [INFO] [stderr] | ______________^ [INFO] [stderr] 440 | | if &name == "gl_FragDepth" { [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:321:38 [INFO] [stderr] | [INFO] [stderr] 321 | max_resource_count: Some(999999), [INFO] [stderr] | ^^^^^^ help: consider: `999_999` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command::DataBuffer` [INFO] [stderr] --> src/command.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn new() -> DataBuffer { [INFO] [stderr] 59 | | DataBuffer(Vec::new()) [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 55 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/command.rs:451:54 [INFO] [stderr] | [INFO] [stderr] 451 | self.buf.push(Command::BindUnorderedView(param.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*param` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/command.rs:458:48 [INFO] [stderr] | [INFO] [stderr] 458 | self.buf.push(Command::BindSampler(param.clone(), bind)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*param` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/command.rs:491:18 [INFO] [stderr] | [INFO] [stderr] 491 | .unwrap_or(pts.colors.len()) as c::ColorSlot; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| pts.colors.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/factory.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | 0 as *const gl::types::GLvoid [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/factory.rs:134:28 [INFO] [stderr] | [INFO] [stderr] 134 | data_ptr = 0 as *const _; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/factory.rs:208:28 [INFO] [stderr] | [INFO] [stderr] 208 | let shader_slice = match shader_set { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 209 | | &d::ShaderSet::Simple(ref vs, ref ps) => { [INFO] [stderr] 210 | | shaders[0] = *vs.reference(&mut handler); [INFO] [stderr] 211 | | shaders[1] = *ps.reference(&mut handler); [INFO] [stderr] ... | [INFO] [stderr] 226 | | }, [INFO] [stderr] 227 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 208 | let shader_slice = match *shader_set { [INFO] [stderr] 209 | d::ShaderSet::Simple(ref vs, ref ps) => { [INFO] [stderr] 210 | shaders[0] = *vs.reference(&mut handler); [INFO] [stderr] 211 | shaders[1] = *ps.reference(&mut handler); [INFO] [stderr] 212 | &shaders[..2] [INFO] [stderr] 213 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/factory.rs:266:10 [INFO] [stderr] | [INFO] [stderr] 266 | *(self.pointer as *mut T).offset(index as isize) = val; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.pointer as *mut T).add(index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `inputs` [INFO] [stderr] --> src/factory.rs:385:18 [INFO] [stderr] | [INFO] [stderr] 385 | for i in 0 .. d::MAX_VERTEX_ATTRIBUTES { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 385 | for (i, ) in inputs.iter_mut().enumerate().take(d::MAX_VERTEX_ATTRIBUTES) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/factory.rs:465:9 [INFO] [stderr] | [INFO] [stderr] 465 | / match htex.resource() { [INFO] [stderr] 466 | | &NewTexture::Surface(_) => Err(f::ResourceViewError::NoBindFlag), [INFO] [stderr] 467 | | &NewTexture::Texture(t) => { [INFO] [stderr] 468 | | //TODO: use the view descriptor [INFO] [stderr] ... | [INFO] [stderr] 471 | | }, [INFO] [stderr] 472 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 465 | match *htex.resource() { [INFO] [stderr] 466 | NewTexture::Surface(_) => Err(f::ResourceViewError::NoBindFlag), [INFO] [stderr] 467 | NewTexture::Texture(t) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/factory.rs:506:19 [INFO] [stderr] | [INFO] [stderr] 506 | info: info.clone(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/factory.rs:555:26 [INFO] [stderr] | [INFO] [stderr] 555 | pub fn wait_fence(fence: &Fence, gl: &gl::Gl) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Fence` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/shade.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | usage = usage | stage; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `usage |= stage` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/shade.rs:316:24 [INFO] [stderr] | [INFO] [stderr] 316 | -> (Vec, Vec, Vec, Vec, Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | rect.x as gl::types::GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(rect.x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | rect.y as gl::types::GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(rect.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | rect.w as gl::types::GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(rect.w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | rect.h as gl::types::GLint [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(rect.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | r.x as gl::types::GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(r.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | r.y as gl::types::GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(r.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | r.w as gl::types::GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(r.w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | r.h as gl::types::GLint [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(r.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state.rs:134:39 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn bind_depth(gl: &gl::Gl, depth: &Option) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/state.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | / match depth { [INFO] [stderr] 136 | | &Some(ref d) => { unsafe { [INFO] [stderr] 137 | | gl.Enable(gl::DEPTH_TEST); [INFO] [stderr] 138 | | gl.DepthFunc(map_comparison(d.fun)); [INFO] [stderr] ... | [INFO] [stderr] 141 | | &None => unsafe { gl.Disable(gl::DEPTH_TEST) }, [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 135 | match *depth { [INFO] [stderr] 136 | Some(ref d) => { unsafe { [INFO] [stderr] 137 | gl.Enable(gl::DEPTH_TEST); [INFO] [stderr] 138 | gl.DepthFunc(map_comparison(d.fun)); [INFO] [stderr] 139 | gl.DepthMask(d.write as _); [INFO] [stderr] 140 | }}, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | ref_value as gl::types::GLint, side.mask_read as gl::types::GLuint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ref_value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:161:44 [INFO] [stderr] | [INFO] [stderr] 161 | ref_value as gl::types::GLint, side.mask_read as gl::types::GLuint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(side.mask_read)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:162:38 [INFO] [stderr] | [INFO] [stderr] 162 | gl.StencilMaskSeparate(face, side.mask_write as gl::types::GLuint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(side.mask_write)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/state.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | / match stencil { [INFO] [stderr] 167 | | &Some(ref s) => { [INFO] [stderr] 168 | | unsafe { gl.Enable(gl::STENCIL_TEST) }; [INFO] [stderr] 169 | | if cull != CullFace::Front { [INFO] [stderr] ... | [INFO] [stderr] 176 | | &None => unsafe { gl.Disable(gl::STENCIL_TEST) }, [INFO] [stderr] 177 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 166 | match *stencil { [INFO] [stderr] 167 | Some(ref s) => { [INFO] [stderr] 168 | unsafe { gl.Enable(gl::STENCIL_TEST) }; [INFO] [stderr] 169 | if cull != CullFace::Front { [INFO] [stderr] 170 | bind_side(gl, gl::FRONT, s.front, refs.0); [INFO] [stderr] 171 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:253:15 [INFO] [stderr] | [INFO] [stderr] 253 | let buf = slot as gl::types::GLuint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:235:54 [INFO] [stderr] | [INFO] [stderr] 235 | gl.TexParameteri(target, gl::TEXTURE_BASE_LEVEL, base as GLint); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(base)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:236:53 [INFO] [stderr] | [INFO] [stderr] 236 | gl.TexParameteri(target, gl::TEXTURE_MAX_LEVEL, max as GLint); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:255:17 [INFO] [stderr] | [INFO] [stderr] 255 | dim.0 as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(dim.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:256:17 [INFO] [stderr] | [INFO] [stderr] 256 | dim.1 as GLsizei [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(dim.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:262:17 [INFO] [stderr] | [INFO] [stderr] 262 | samples as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(samples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:264:17 [INFO] [stderr] | [INFO] [stderr] 264 | dim.0 as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(dim.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:265:17 [INFO] [stderr] | [INFO] [stderr] 265 | dim.1 as GLsizei [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(dim.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:297:17 [INFO] [stderr] | [INFO] [stderr] 297 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:309:17 [INFO] [stderr] | [INFO] [stderr] 309 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:310:17 [INFO] [stderr] | [INFO] [stderr] 310 | a as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:322:17 [INFO] [stderr] | [INFO] [stderr] 322 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:323:17 [INFO] [stderr] | [INFO] [stderr] 323 | h as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:333:17 [INFO] [stderr] | [INFO] [stderr] 333 | samples as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(samples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:335:17 [INFO] [stderr] | [INFO] [stderr] 335 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:336:17 [INFO] [stderr] | [INFO] [stderr] 336 | h as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:345:17 [INFO] [stderr] | [INFO] [stderr] 345 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:346:17 [INFO] [stderr] | [INFO] [stderr] 346 | h as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:347:17 [INFO] [stderr] | [INFO] [stderr] 347 | a as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:357:17 [INFO] [stderr] | [INFO] [stderr] 357 | samples as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(samples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:359:17 [INFO] [stderr] | [INFO] [stderr] 359 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:360:17 [INFO] [stderr] | [INFO] [stderr] 360 | h as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:361:17 [INFO] [stderr] | [INFO] [stderr] 361 | a as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:370:17 [INFO] [stderr] | [INFO] [stderr] 370 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:371:17 [INFO] [stderr] | [INFO] [stderr] 371 | h as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:372:17 [INFO] [stderr] | [INFO] [stderr] 372 | d as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:387:21 [INFO] [stderr] | [INFO] [stderr] 387 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:388:21 [INFO] [stderr] | [INFO] [stderr] 388 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:431:9 [INFO] [stderr] | [INFO] [stderr] 431 | ::std::cmp::min(a, b) as GLint [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(::std::cmp::min(a, b))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:434:10 [INFO] [stderr] | [INFO] [stderr] 434 | ((w as f32).log2() + 1.0) as u8 [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:437:10 [INFO] [stderr] | [INFO] [stderr] 437 | ((max(w, h) as f32).log2() + 1.0) as u8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(max(w, h))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:440:10 [INFO] [stderr] | [INFO] [stderr] 440 | ((max(w, max(h, d)) as f32).log2() + 1.0) as u8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(max(w, max(h, d)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:450:17 [INFO] [stderr] | [INFO] [stderr] 450 | w as GLsizei [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:458:17 [INFO] [stderr] | [INFO] [stderr] 458 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:459:17 [INFO] [stderr] | [INFO] [stderr] 459 | a as GLsizei [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:467:17 [INFO] [stderr] | [INFO] [stderr] 467 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:468:17 [INFO] [stderr] | [INFO] [stderr] 468 | h as GLsizei [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:476:17 [INFO] [stderr] | [INFO] [stderr] 476 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:477:17 [INFO] [stderr] | [INFO] [stderr] 477 | h as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:478:17 [INFO] [stderr] | [INFO] [stderr] 478 | a as GLsizei [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:484:17 [INFO] [stderr] | [INFO] [stderr] 484 | samples as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(samples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:486:17 [INFO] [stderr] | [INFO] [stderr] 486 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:487:17 [INFO] [stderr] | [INFO] [stderr] 487 | h as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:494:17 [INFO] [stderr] | [INFO] [stderr] 494 | samples as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(samples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:496:17 [INFO] [stderr] | [INFO] [stderr] 496 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:497:17 [INFO] [stderr] | [INFO] [stderr] 497 | h as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:498:17 [INFO] [stderr] | [INFO] [stderr] 498 | a as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:507:17 [INFO] [stderr] | [INFO] [stderr] 507 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:508:17 [INFO] [stderr] | [INFO] [stderr] 508 | h as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:509:17 [INFO] [stderr] | [INFO] [stderr] 509 | d as GLsizei [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:517:17 [INFO] [stderr] | [INFO] [stderr] 517 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:518:17 [INFO] [stderr] | [INFO] [stderr] 518 | w as GLsizei [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:526:17 [INFO] [stderr] | [INFO] [stderr] 526 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:527:17 [INFO] [stderr] | [INFO] [stderr] 527 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:528:17 [INFO] [stderr] | [INFO] [stderr] 528 | d as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tex.rs:557:5 [INFO] [stderr] | [INFO] [stderr] 557 | / match info.filter { [INFO] [stderr] 558 | | t::FilterMethod::Anisotropic(fac) => [INFO] [stderr] 559 | | gl.TexParameterf(target, gl::TEXTURE_MAX_ANISOTROPY_EXT, fac as GLfloat), [INFO] [stderr] 560 | | _ => () [INFO] [stderr] 561 | | } [INFO] [stderr] | |_____^ help: try this: `if let t::FilterMethod::Anisotropic(fac) = info.filter { gl.TexParameterf(target, gl::TEXTURE_MAX_ANISOTROPY_EXT, fac as GLfloat) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:559:70 [INFO] [stderr] | [INFO] [stderr] 559 | gl.TexParameterf(target, gl::TEXTURE_MAX_ANISOTROPY_EXT, fac as GLfloat), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(fac)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/tex.rs:602:8 [INFO] [stderr] | [INFO] [stderr] 602 | Ok(match kind { [INFO] [stderr] | ________^ [INFO] [stderr] 603 | | t::Kind::D1(_) => unsafe { [INFO] [stderr] 604 | | gl.TexSubImage1D( [INFO] [stderr] 605 | | target, [INFO] [stderr] ... | [INFO] [stderr] 657 | | t::Kind::D2Array(_, _, _, aa) => return Err(t::CreationError::Samples(aa)), [INFO] [stderr] 658 | | }) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 602 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:606:17 [INFO] [stderr] | [INFO] [stderr] 606 | img.mipmap as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.mipmap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:607:17 [INFO] [stderr] | [INFO] [stderr] 607 | img.xoffset as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.xoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:608:17 [INFO] [stderr] | [INFO] [stderr] 608 | img.width as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:617:17 [INFO] [stderr] | [INFO] [stderr] 617 | img.mipmap as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.mipmap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:618:17 [INFO] [stderr] | [INFO] [stderr] 618 | img.xoffset as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.xoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:619:17 [INFO] [stderr] | [INFO] [stderr] 619 | img.yoffset as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.yoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:620:17 [INFO] [stderr] | [INFO] [stderr] 620 | img.width as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:621:17 [INFO] [stderr] | [INFO] [stderr] 621 | img.height as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:630:17 [INFO] [stderr] | [INFO] [stderr] 630 | img.mipmap as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.mipmap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:631:17 [INFO] [stderr] | [INFO] [stderr] 631 | img.xoffset as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.xoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:632:17 [INFO] [stderr] | [INFO] [stderr] 632 | img.yoffset as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.yoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:633:17 [INFO] [stderr] | [INFO] [stderr] 633 | img.zoffset as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.zoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:634:17 [INFO] [stderr] | [INFO] [stderr] 634 | img.width as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:635:17 [INFO] [stderr] | [INFO] [stderr] 635 | img.height as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:636:17 [INFO] [stderr] | [INFO] [stderr] 636 | img.depth as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.depth)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:645:17 [INFO] [stderr] | [INFO] [stderr] 645 | img.mipmap as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.mipmap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:646:17 [INFO] [stderr] | [INFO] [stderr] 646 | img.xoffset as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.xoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:647:17 [INFO] [stderr] | [INFO] [stderr] 647 | img.yoffset as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.yoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:648:17 [INFO] [stderr] | [INFO] [stderr] 648 | img.width as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:649:17 [INFO] [stderr] | [INFO] [stderr] 649 | img.height as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:682:78 [INFO] [stderr] | [INFO] [stderr] 682 | gl.FramebufferTexture(target, gl::COLOR_ATTACHMENT0, t as _, level as _); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(level)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/tex.rs:737:8 [INFO] [stderr] | [INFO] [stderr] 737 | Ok(match src.texture { [INFO] [stderr] | ________^ [INFO] [stderr] 738 | | NewTexture::Texture(t) if can_get_tex_image => { [INFO] [stderr] 739 | | let target = kind_to_gl(src.kind); [INFO] [stderr] 740 | | unsafe { gl.BindTexture(target, t); } [INFO] [stderr] ... | [INFO] [stderr] 767 | | } [INFO] [stderr] 768 | | }) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 737 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:746:21 [INFO] [stderr] | [INFO] [stderr] 746 | src.info.mipmap as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.mipmap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:758:21 [INFO] [stderr] | [INFO] [stderr] 758 | src.info.xoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.xoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:759:21 [INFO] [stderr] | [INFO] [stderr] 759 | src.info.yoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.yoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:760:21 [INFO] [stderr] | [INFO] [stderr] 760 | src.info.width as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:761:21 [INFO] [stderr] | [INFO] [stderr] 761 | src.info.height as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/tex.rs:796:8 [INFO] [stderr] | [INFO] [stderr] 796 | Ok(match dst.kind { [INFO] [stderr] | ________^ [INFO] [stderr] 797 | | t::Kind::D2(_, _, t::AaMode::Single) | [INFO] [stderr] 798 | | t::Kind::Cube(_) => unsafe { [INFO] [stderr] 799 | | gl.CopyTexSubImage2D(copy_target, dst.info.mipmap as _, [INFO] [stderr] ... | [INFO] [stderr] 811 | | _ => return Err(t::CreationError::Kind) [INFO] [stderr] 812 | | }) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 796 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:799:47 [INFO] [stderr] | [INFO] [stderr] 799 | gl.CopyTexSubImage2D(copy_target, dst.info.mipmap as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(dst.info.mipmap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:800:17 [INFO] [stderr] | [INFO] [stderr] 800 | dst.info.xoffset as _, dst.info.yoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(dst.info.xoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:800:40 [INFO] [stderr] | [INFO] [stderr] 800 | dst.info.xoffset as _, dst.info.yoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(dst.info.yoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:801:17 [INFO] [stderr] | [INFO] [stderr] 801 | src.info.xoffset as _, src.info.yoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.xoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:801:40 [INFO] [stderr] | [INFO] [stderr] 801 | src.info.xoffset as _, src.info.yoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.yoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:802:17 [INFO] [stderr] | [INFO] [stderr] 802 | src.info.width as _, src.info.height as _); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:802:38 [INFO] [stderr] | [INFO] [stderr] 802 | src.info.width as _, src.info.height as _); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:806:47 [INFO] [stderr] | [INFO] [stderr] 806 | gl.CopyTexSubImage3D(copy_target, dst.info.mipmap as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(dst.info.mipmap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:807:17 [INFO] [stderr] | [INFO] [stderr] 807 | dst.info.xoffset as _, dst.info.yoffset as _, dst.info.zoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(dst.info.xoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:807:40 [INFO] [stderr] | [INFO] [stderr] 807 | dst.info.xoffset as _, dst.info.yoffset as _, dst.info.zoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(dst.info.yoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:807:63 [INFO] [stderr] | [INFO] [stderr] 807 | dst.info.xoffset as _, dst.info.yoffset as _, dst.info.zoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(dst.info.zoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:808:17 [INFO] [stderr] | [INFO] [stderr] 808 | src.info.xoffset as _, src.info.yoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.xoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:808:40 [INFO] [stderr] | [INFO] [stderr] 808 | src.info.xoffset as _, src.info.yoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.yoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:809:17 [INFO] [stderr] | [INFO] [stderr] 809 | src.info.width as _, src.info.height as _); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:809:38 [INFO] [stderr] | [INFO] [stderr] 809 | src.info.width as _, src.info.height as _); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tex.rs:1010:5 [INFO] [stderr] | [INFO] [stderr] 1010 | / match info.filter{ [INFO] [stderr] 1011 | | t::FilterMethod::Anisotropic(fac) => [INFO] [stderr] 1012 | | gl.SamplerParameterf(name, gl::TEXTURE_MAX_ANISOTROPY_EXT, fac as GLfloat), [INFO] [stderr] 1013 | | _ => () [INFO] [stderr] 1014 | | } [INFO] [stderr] | |_____^ help: try this: `if let t::FilterMethod::Anisotropic(fac) = info.filter { gl.SamplerParameterf(name, gl::TEXTURE_MAX_ANISOTROPY_EXT, fac as GLfloat) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:1012:72 [INFO] [stderr] | [INFO] [stderr] 1012 | gl.SamplerParameterf(name, gl::TEXTURE_MAX_ANISOTROPY_EXT, fac as GLfloat), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(fac)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:334:5 [INFO] [stderr] | [INFO] [stderr] 334 | / pub fn get_info<'a>(&'a self) -> &'a Info { [INFO] [stderr] 335 | | &self.info [INFO] [stderr] 336 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:372:22 [INFO] [stderr] | [INFO] [stderr] 372 | let stride = bel.desc.stride as gl::types::GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(bel.desc.stride)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:375:41 [INFO] [stderr] | [INFO] [stderr] 375 | gl.VertexAttribIPointer(slot as gl::types::GLuint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:379:40 [INFO] [stderr] | [INFO] [stderr] 379 | gl.VertexAttribPointer(slot as gl::types::GLuint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:387:40 [INFO] [stderr] | [INFO] [stderr] 387 | gl.VertexAttribPointer(slot as gl::types::GLuint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:392:45 [INFO] [stderr] | [INFO] [stderr] 392 | unsafe { gl.EnableVertexAttribArray(slot as gl::types::GLuint) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:394:45 [INFO] [stderr] | [INFO] [stderr] 394 | unsafe { gl.VertexAttribDivisor(slot as gl::types::GLuint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:395:17 [INFO] [stderr] | [INFO] [stderr] 395 | bel.desc.rate as gl::types::GLuint) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bel.desc.rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:401:94 [INFO] [stderr] | [INFO] [stderr] 401 | fn bind_target(&mut self, point: gl::types::GLenum, attachment: gl::types::GLenum, view: &TargetView) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `TargetView` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:403:9 [INFO] [stderr] | [INFO] [stderr] 403 | / match view { [INFO] [stderr] 404 | | &TargetView::Surface(surface) => unsafe { [INFO] [stderr] 405 | | gl.FramebufferRenderbuffer(point, attachment, gl::RENDERBUFFER, surface); [INFO] [stderr] 406 | | }, [INFO] [stderr] ... | [INFO] [stderr] 415 | | }, [INFO] [stderr] 416 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 403 | match *view { [INFO] [stderr] 404 | TargetView::Surface(surface) => unsafe { [INFO] [stderr] 405 | gl.FramebufferRenderbuffer(point, attachment, gl::RENDERBUFFER, surface); [INFO] [stderr] 406 | }, [INFO] [stderr] 407 | TargetView::Texture(texture, level) => unsafe { [INFO] [stderr] 408 | gl.FramebufferTexture(point, attachment, texture, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:409:39 [INFO] [stderr] | [INFO] [stderr] 409 | level as gl::types::GLint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(level)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:413:44 [INFO] [stderr] | [INFO] [stderr] 413 | level as gl::types::GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(level)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:414:44 [INFO] [stderr] | [INFO] [stderr] 414 | layer as gl::types::GLint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(layer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 57 [INFO] [stderr] --> src/lib.rs:435:5 [INFO] [stderr] | [INFO] [stderr] 435 | / fn process(&mut self, cmd: &Command, data_buf: &DataBuffer) { [INFO] [stderr] 436 | | match *cmd { [INFO] [stderr] 437 | | Command::Clear(color, depth, stencil) => { [INFO] [stderr] 438 | | let gl = &self.share.context; [INFO] [stderr] ... | [INFO] [stderr] 817 | | } [INFO] [stderr] 818 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:462:33 [INFO] [stderr] | [INFO] [stderr] 462 | let v = s as gl::types::GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:487:43 [INFO] [stderr] | [INFO] [stderr] 487 | gl.ClearDepth(d as gl::types::GLdouble); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:494:45 [INFO] [stderr] | [INFO] [stderr] 494 | gl.ClearStencil(s as gl::types::GLint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:506:71 [INFO] [stderr] | [INFO] [stderr] 506 | self.share.context.BindBufferBase(gl::UNIFORM_BUFFER, slot as gl::types::GLuint, buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:509:65 [INFO] [stderr] | [INFO] [stderr] 509 | self.share.context.ActiveTexture(gl::TEXTURE0 + slot as gl::types::GLenum); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:516:45 [INFO] [stderr] | [INFO] [stderr] 516 | unsafe { gl.BindSampler(slot as gl::types::GLuint, sampler.object) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:559:61 [INFO] [stderr] | [INFO] [stderr] 559 | self.share.context.DisableVertexAttribArray(slot as gl::types::GLuint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:612:60 [INFO] [stderr] | [INFO] [stderr] 612 | gl.PatchParameteri(gl::PATCH_VERTICES, num as gl::types::GLint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:802:21 [INFO] [stderr] | [INFO] [stderr] 802 | s_rect.x as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(s_rect.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:803:21 [INFO] [stderr] | [INFO] [stderr] 803 | s_rect.y as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(s_rect.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:804:21 [INFO] [stderr] | [INFO] [stderr] 804 | s_end_x as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(s_end_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:805:21 [INFO] [stderr] | [INFO] [stderr] 805 | s_end_y as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(s_end_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:806:21 [INFO] [stderr] | [INFO] [stderr] 806 | d_rect.x as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(d_rect.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:807:21 [INFO] [stderr] | [INFO] [stderr] 807 | d_rect.y as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(d_rect.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:808:21 [INFO] [stderr] | [INFO] [stderr] 808 | (d_rect.x + d_rect.w) as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(d_rect.x + d_rect.w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:809:21 [INFO] [stderr] | [INFO] [stderr] 809 | (d_rect.y + d_rect.h) as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(d_rect.y + d_rect.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:845:26 [INFO] [stderr] | [INFO] [stderr] 845 | let status = match &mut mapping.kind { [INFO] [stderr] | __________________________^ [INFO] [stderr] 846 | | &mut MappingKind::Persistent(ref mut status) => status, [INFO] [stderr] 847 | | _ => unreachable!(), [INFO] [stderr] 848 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 845 | let status = match *(&mut mapping.kind) { [INFO] [stderr] 846 | MappingKind::Persistent(ref mut status) => status, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:912:26 [INFO] [stderr] | [INFO] [stderr] 912 | let status = match &mut mapping.kind { [INFO] [stderr] | __________________________^ [INFO] [stderr] 913 | | &mut MappingKind::Persistent(ref mut status) => status, [INFO] [stderr] 914 | | _ => unreachable!(), [INFO] [stderr] 915 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 912 | let status = match *(&mut mapping.kind) { [INFO] [stderr] 913 | MappingKind::Persistent(ref mut status) => status, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:980:17 [INFO] [stderr] | [INFO] [stderr] 980 | buffer.mapping().map(|raw| { [INFO] [stderr] | _________________^ [INFO] [stderr] | |_________________| [INFO] [stderr] | || [INFO] [stderr] 981 | || // we have exclusive access because it's the last reference [INFO] [stderr] 982 | || let mapping = unsafe { raw.use_access() }; [INFO] [stderr] 983 | || match mapping.kind { [INFO] [stderr] ... || [INFO] [stderr] 992 | || } [INFO] [stderr] 993 | || }); [INFO] [stderr] | ||__________________^- help: try this: `if let Some(raw) = buffer.mapping() { ... }` [INFO] [stderr] | |___________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:999:31 [INFO] [stderr] | [INFO] [stderr] 999 | |gl, raw_texture| match raw_texture.resource() { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 1000 | | &NewTexture::Surface(ref suf) => unsafe { gl.DeleteRenderbuffers(1, suf) }, [INFO] [stderr] 1001 | | &NewTexture::Texture(ref tex) => unsafe { gl.DeleteTextures(1, tex) }, [INFO] [stderr] 1002 | | }, // new texture [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 999 | |gl, raw_texture| match *raw_texture.resource() { [INFO] [stderr] 1000 | NewTexture::Surface(ref suf) => unsafe { gl.DeleteRenderbuffers(1, suf) }, [INFO] [stderr] 1001 | NewTexture::Texture(ref tex) => unsafe { gl.DeleteTextures(1, tex) }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command::DataBuffer` [INFO] [stderr] --> src/command.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn new() -> DataBuffer { [INFO] [stderr] 59 | | DataBuffer(Vec::new()) [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 55 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/command.rs:451:54 [INFO] [stderr] | [INFO] [stderr] 451 | self.buf.push(Command::BindUnorderedView(param.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*param` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/command.rs:458:48 [INFO] [stderr] | [INFO] [stderr] 458 | self.buf.push(Command::BindSampler(param.clone(), bind)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*param` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/command.rs:491:18 [INFO] [stderr] | [INFO] [stderr] 491 | .unwrap_or(pts.colors.len()) as c::ColorSlot; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| pts.colors.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/factory.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | 0 as *const gl::types::GLvoid [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/factory.rs:134:28 [INFO] [stderr] | [INFO] [stderr] 134 | data_ptr = 0 as *const _; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/factory.rs:208:28 [INFO] [stderr] | [INFO] [stderr] 208 | let shader_slice = match shader_set { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 209 | | &d::ShaderSet::Simple(ref vs, ref ps) => { [INFO] [stderr] 210 | | shaders[0] = *vs.reference(&mut handler); [INFO] [stderr] 211 | | shaders[1] = *ps.reference(&mut handler); [INFO] [stderr] ... | [INFO] [stderr] 226 | | }, [INFO] [stderr] 227 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 208 | let shader_slice = match *shader_set { [INFO] [stderr] 209 | d::ShaderSet::Simple(ref vs, ref ps) => { [INFO] [stderr] 210 | shaders[0] = *vs.reference(&mut handler); [INFO] [stderr] 211 | shaders[1] = *ps.reference(&mut handler); [INFO] [stderr] 212 | &shaders[..2] [INFO] [stderr] 213 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/factory.rs:266:10 [INFO] [stderr] | [INFO] [stderr] 266 | *(self.pointer as *mut T).offset(index as isize) = val; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.pointer as *mut T).add(index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `inputs` [INFO] [stderr] --> src/factory.rs:385:18 [INFO] [stderr] | [INFO] [stderr] 385 | for i in 0 .. d::MAX_VERTEX_ATTRIBUTES { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 385 | for (i, ) in inputs.iter_mut().enumerate().take(d::MAX_VERTEX_ATTRIBUTES) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/factory.rs:465:9 [INFO] [stderr] | [INFO] [stderr] 465 | / match htex.resource() { [INFO] [stderr] 466 | | &NewTexture::Surface(_) => Err(f::ResourceViewError::NoBindFlag), [INFO] [stderr] 467 | | &NewTexture::Texture(t) => { [INFO] [stderr] 468 | | //TODO: use the view descriptor [INFO] [stderr] ... | [INFO] [stderr] 471 | | }, [INFO] [stderr] 472 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 465 | match *htex.resource() { [INFO] [stderr] 466 | NewTexture::Surface(_) => Err(f::ResourceViewError::NoBindFlag), [INFO] [stderr] 467 | NewTexture::Texture(t) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/factory.rs:506:19 [INFO] [stderr] | [INFO] [stderr] 506 | info: info.clone(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/factory.rs:555:26 [INFO] [stderr] | [INFO] [stderr] 555 | pub fn wait_fence(fence: &Fence, gl: &gl::Gl) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Fence` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/shade.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | usage = usage | stage; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `usage |= stage` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/shade.rs:316:24 [INFO] [stderr] | [INFO] [stderr] 316 | -> (Vec, Vec, Vec, Vec, Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | rect.x as gl::types::GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(rect.x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | rect.y as gl::types::GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(rect.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | rect.w as gl::types::GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(rect.w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | rect.h as gl::types::GLint [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(rect.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | r.x as gl::types::GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(r.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | r.y as gl::types::GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(r.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | r.w as gl::types::GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(r.w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | r.h as gl::types::GLint [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(r.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state.rs:134:39 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn bind_depth(gl: &gl::Gl, depth: &Option) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/state.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | / match depth { [INFO] [stderr] 136 | | &Some(ref d) => { unsafe { [INFO] [stderr] 137 | | gl.Enable(gl::DEPTH_TEST); [INFO] [stderr] 138 | | gl.DepthFunc(map_comparison(d.fun)); [INFO] [stderr] ... | [INFO] [stderr] 141 | | &None => unsafe { gl.Disable(gl::DEPTH_TEST) }, [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 135 | match *depth { [INFO] [stderr] 136 | Some(ref d) => { unsafe { [INFO] [stderr] 137 | gl.Enable(gl::DEPTH_TEST); [INFO] [stderr] 138 | gl.DepthFunc(map_comparison(d.fun)); [INFO] [stderr] 139 | gl.DepthMask(d.write as _); [INFO] [stderr] 140 | }}, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | ref_value as gl::types::GLint, side.mask_read as gl::types::GLuint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ref_value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:161:44 [INFO] [stderr] | [INFO] [stderr] 161 | ref_value as gl::types::GLint, side.mask_read as gl::types::GLuint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(side.mask_read)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:162:38 [INFO] [stderr] | [INFO] [stderr] 162 | gl.StencilMaskSeparate(face, side.mask_write as gl::types::GLuint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(side.mask_write)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/state.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | / match stencil { [INFO] [stderr] 167 | | &Some(ref s) => { [INFO] [stderr] 168 | | unsafe { gl.Enable(gl::STENCIL_TEST) }; [INFO] [stderr] 169 | | if cull != CullFace::Front { [INFO] [stderr] ... | [INFO] [stderr] 176 | | &None => unsafe { gl.Disable(gl::STENCIL_TEST) }, [INFO] [stderr] 177 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 166 | match *stencil { [INFO] [stderr] 167 | Some(ref s) => { [INFO] [stderr] 168 | unsafe { gl.Enable(gl::STENCIL_TEST) }; [INFO] [stderr] 169 | if cull != CullFace::Front { [INFO] [stderr] 170 | bind_side(gl, gl::FRONT, s.front, refs.0); [INFO] [stderr] 171 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:253:15 [INFO] [stderr] | [INFO] [stderr] 253 | let buf = slot as gl::types::GLuint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:235:54 [INFO] [stderr] | [INFO] [stderr] 235 | gl.TexParameteri(target, gl::TEXTURE_BASE_LEVEL, base as GLint); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(base)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:236:53 [INFO] [stderr] | [INFO] [stderr] 236 | gl.TexParameteri(target, gl::TEXTURE_MAX_LEVEL, max as GLint); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:255:17 [INFO] [stderr] | [INFO] [stderr] 255 | dim.0 as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(dim.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:256:17 [INFO] [stderr] | [INFO] [stderr] 256 | dim.1 as GLsizei [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(dim.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:262:17 [INFO] [stderr] | [INFO] [stderr] 262 | samples as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(samples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:264:17 [INFO] [stderr] | [INFO] [stderr] 264 | dim.0 as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(dim.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:265:17 [INFO] [stderr] | [INFO] [stderr] 265 | dim.1 as GLsizei [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(dim.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:297:17 [INFO] [stderr] | [INFO] [stderr] 297 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:309:17 [INFO] [stderr] | [INFO] [stderr] 309 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:310:17 [INFO] [stderr] | [INFO] [stderr] 310 | a as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:322:17 [INFO] [stderr] | [INFO] [stderr] 322 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:323:17 [INFO] [stderr] | [INFO] [stderr] 323 | h as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:333:17 [INFO] [stderr] | [INFO] [stderr] 333 | samples as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(samples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:335:17 [INFO] [stderr] | [INFO] [stderr] 335 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:336:17 [INFO] [stderr] | [INFO] [stderr] 336 | h as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:345:17 [INFO] [stderr] | [INFO] [stderr] 345 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:346:17 [INFO] [stderr] | [INFO] [stderr] 346 | h as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:347:17 [INFO] [stderr] | [INFO] [stderr] 347 | a as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:357:17 [INFO] [stderr] | [INFO] [stderr] 357 | samples as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(samples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:359:17 [INFO] [stderr] | [INFO] [stderr] 359 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:360:17 [INFO] [stderr] | [INFO] [stderr] 360 | h as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:361:17 [INFO] [stderr] | [INFO] [stderr] 361 | a as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:370:17 [INFO] [stderr] | [INFO] [stderr] 370 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:371:17 [INFO] [stderr] | [INFO] [stderr] 371 | h as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:372:17 [INFO] [stderr] | [INFO] [stderr] 372 | d as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:387:21 [INFO] [stderr] | [INFO] [stderr] 387 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:388:21 [INFO] [stderr] | [INFO] [stderr] 388 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:431:9 [INFO] [stderr] | [INFO] [stderr] 431 | ::std::cmp::min(a, b) as GLint [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(::std::cmp::min(a, b))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:434:10 [INFO] [stderr] | [INFO] [stderr] 434 | ((w as f32).log2() + 1.0) as u8 [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:437:10 [INFO] [stderr] | [INFO] [stderr] 437 | ((max(w, h) as f32).log2() + 1.0) as u8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(max(w, h))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:440:10 [INFO] [stderr] | [INFO] [stderr] 440 | ((max(w, max(h, d)) as f32).log2() + 1.0) as u8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(max(w, max(h, d)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:450:17 [INFO] [stderr] | [INFO] [stderr] 450 | w as GLsizei [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:458:17 [INFO] [stderr] | [INFO] [stderr] 458 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:459:17 [INFO] [stderr] | [INFO] [stderr] 459 | a as GLsizei [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:467:17 [INFO] [stderr] | [INFO] [stderr] 467 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:468:17 [INFO] [stderr] | [INFO] [stderr] 468 | h as GLsizei [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:476:17 [INFO] [stderr] | [INFO] [stderr] 476 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:477:17 [INFO] [stderr] | [INFO] [stderr] 477 | h as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:478:17 [INFO] [stderr] | [INFO] [stderr] 478 | a as GLsizei [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:484:17 [INFO] [stderr] | [INFO] [stderr] 484 | samples as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(samples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:486:17 [INFO] [stderr] | [INFO] [stderr] 486 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:487:17 [INFO] [stderr] | [INFO] [stderr] 487 | h as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:494:17 [INFO] [stderr] | [INFO] [stderr] 494 | samples as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(samples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:496:17 [INFO] [stderr] | [INFO] [stderr] 496 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:497:17 [INFO] [stderr] | [INFO] [stderr] 497 | h as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:498:17 [INFO] [stderr] | [INFO] [stderr] 498 | a as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:507:17 [INFO] [stderr] | [INFO] [stderr] 507 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:508:17 [INFO] [stderr] | [INFO] [stderr] 508 | h as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:509:17 [INFO] [stderr] | [INFO] [stderr] 509 | d as GLsizei [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:517:17 [INFO] [stderr] | [INFO] [stderr] 517 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:518:17 [INFO] [stderr] | [INFO] [stderr] 518 | w as GLsizei [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:526:17 [INFO] [stderr] | [INFO] [stderr] 526 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:527:17 [INFO] [stderr] | [INFO] [stderr] 527 | w as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:528:17 [INFO] [stderr] | [INFO] [stderr] 528 | d as GLsizei, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tex.rs:557:5 [INFO] [stderr] | [INFO] [stderr] 557 | / match info.filter { [INFO] [stderr] 558 | | t::FilterMethod::Anisotropic(fac) => [INFO] [stderr] 559 | | gl.TexParameterf(target, gl::TEXTURE_MAX_ANISOTROPY_EXT, fac as GLfloat), [INFO] [stderr] 560 | | _ => () [INFO] [stderr] 561 | | } [INFO] [stderr] | |_____^ help: try this: `if let t::FilterMethod::Anisotropic(fac) = info.filter { gl.TexParameterf(target, gl::TEXTURE_MAX_ANISOTROPY_EXT, fac as GLfloat) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:559:70 [INFO] [stderr] | [INFO] [stderr] 559 | gl.TexParameterf(target, gl::TEXTURE_MAX_ANISOTROPY_EXT, fac as GLfloat), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(fac)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/tex.rs:602:8 [INFO] [stderr] | [INFO] [stderr] 602 | Ok(match kind { [INFO] [stderr] | ________^ [INFO] [stderr] 603 | | t::Kind::D1(_) => unsafe { [INFO] [stderr] 604 | | gl.TexSubImage1D( [INFO] [stderr] 605 | | target, [INFO] [stderr] ... | [INFO] [stderr] 657 | | t::Kind::D2Array(_, _, _, aa) => return Err(t::CreationError::Samples(aa)), [INFO] [stderr] 658 | | }) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 602 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:606:17 [INFO] [stderr] | [INFO] [stderr] 606 | img.mipmap as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.mipmap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:607:17 [INFO] [stderr] | [INFO] [stderr] 607 | img.xoffset as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.xoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:608:17 [INFO] [stderr] | [INFO] [stderr] 608 | img.width as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:617:17 [INFO] [stderr] | [INFO] [stderr] 617 | img.mipmap as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.mipmap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:618:17 [INFO] [stderr] | [INFO] [stderr] 618 | img.xoffset as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.xoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:619:17 [INFO] [stderr] | [INFO] [stderr] 619 | img.yoffset as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.yoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:620:17 [INFO] [stderr] | [INFO] [stderr] 620 | img.width as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:621:17 [INFO] [stderr] | [INFO] [stderr] 621 | img.height as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:630:17 [INFO] [stderr] | [INFO] [stderr] 630 | img.mipmap as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.mipmap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:631:17 [INFO] [stderr] | [INFO] [stderr] 631 | img.xoffset as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.xoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:632:17 [INFO] [stderr] | [INFO] [stderr] 632 | img.yoffset as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.yoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:633:17 [INFO] [stderr] | [INFO] [stderr] 633 | img.zoffset as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.zoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:634:17 [INFO] [stderr] | [INFO] [stderr] 634 | img.width as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:635:17 [INFO] [stderr] | [INFO] [stderr] 635 | img.height as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:636:17 [INFO] [stderr] | [INFO] [stderr] 636 | img.depth as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.depth)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:645:17 [INFO] [stderr] | [INFO] [stderr] 645 | img.mipmap as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.mipmap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:646:17 [INFO] [stderr] | [INFO] [stderr] 646 | img.xoffset as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.xoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:647:17 [INFO] [stderr] | [INFO] [stderr] 647 | img.yoffset as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.yoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:648:17 [INFO] [stderr] | [INFO] [stderr] 648 | img.width as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:649:17 [INFO] [stderr] | [INFO] [stderr] 649 | img.height as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:682:78 [INFO] [stderr] | [INFO] [stderr] 682 | gl.FramebufferTexture(target, gl::COLOR_ATTACHMENT0, t as _, level as _); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(level)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/tex.rs:737:8 [INFO] [stderr] | [INFO] [stderr] 737 | Ok(match src.texture { [INFO] [stderr] | ________^ [INFO] [stderr] 738 | | NewTexture::Texture(t) if can_get_tex_image => { [INFO] [stderr] 739 | | let target = kind_to_gl(src.kind); [INFO] [stderr] 740 | | unsafe { gl.BindTexture(target, t); } [INFO] [stderr] ... | [INFO] [stderr] 767 | | } [INFO] [stderr] 768 | | }) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 737 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:746:21 [INFO] [stderr] | [INFO] [stderr] 746 | src.info.mipmap as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.mipmap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:758:21 [INFO] [stderr] | [INFO] [stderr] 758 | src.info.xoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.xoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:759:21 [INFO] [stderr] | [INFO] [stderr] 759 | src.info.yoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.yoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:760:21 [INFO] [stderr] | [INFO] [stderr] 760 | src.info.width as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:761:21 [INFO] [stderr] | [INFO] [stderr] 761 | src.info.height as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/tex.rs:796:8 [INFO] [stderr] | [INFO] [stderr] 796 | Ok(match dst.kind { [INFO] [stderr] | ________^ [INFO] [stderr] 797 | | t::Kind::D2(_, _, t::AaMode::Single) | [INFO] [stderr] 798 | | t::Kind::Cube(_) => unsafe { [INFO] [stderr] 799 | | gl.CopyTexSubImage2D(copy_target, dst.info.mipmap as _, [INFO] [stderr] ... | [INFO] [stderr] 811 | | _ => return Err(t::CreationError::Kind) [INFO] [stderr] 812 | | }) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 796 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:799:47 [INFO] [stderr] | [INFO] [stderr] 799 | gl.CopyTexSubImage2D(copy_target, dst.info.mipmap as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(dst.info.mipmap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:800:17 [INFO] [stderr] | [INFO] [stderr] 800 | dst.info.xoffset as _, dst.info.yoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(dst.info.xoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:800:40 [INFO] [stderr] | [INFO] [stderr] 800 | dst.info.xoffset as _, dst.info.yoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(dst.info.yoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:801:17 [INFO] [stderr] | [INFO] [stderr] 801 | src.info.xoffset as _, src.info.yoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.xoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:801:40 [INFO] [stderr] | [INFO] [stderr] 801 | src.info.xoffset as _, src.info.yoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.yoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:802:17 [INFO] [stderr] | [INFO] [stderr] 802 | src.info.width as _, src.info.height as _); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:802:38 [INFO] [stderr] | [INFO] [stderr] 802 | src.info.width as _, src.info.height as _); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:806:47 [INFO] [stderr] | [INFO] [stderr] 806 | gl.CopyTexSubImage3D(copy_target, dst.info.mipmap as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(dst.info.mipmap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:807:17 [INFO] [stderr] | [INFO] [stderr] 807 | dst.info.xoffset as _, dst.info.yoffset as _, dst.info.zoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(dst.info.xoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:807:40 [INFO] [stderr] | [INFO] [stderr] 807 | dst.info.xoffset as _, dst.info.yoffset as _, dst.info.zoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(dst.info.yoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:807:63 [INFO] [stderr] | [INFO] [stderr] 807 | dst.info.xoffset as _, dst.info.yoffset as _, dst.info.zoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(dst.info.zoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:808:17 [INFO] [stderr] | [INFO] [stderr] 808 | src.info.xoffset as _, src.info.yoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.xoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:808:40 [INFO] [stderr] | [INFO] [stderr] 808 | src.info.xoffset as _, src.info.yoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.yoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:809:17 [INFO] [stderr] | [INFO] [stderr] 809 | src.info.width as _, src.info.height as _); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:809:38 [INFO] [stderr] | [INFO] [stderr] 809 | src.info.width as _, src.info.height as _); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(src.info.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tex.rs:1010:5 [INFO] [stderr] | [INFO] [stderr] 1010 | / match info.filter{ [INFO] [stderr] 1011 | | t::FilterMethod::Anisotropic(fac) => [INFO] [stderr] 1012 | | gl.SamplerParameterf(name, gl::TEXTURE_MAX_ANISOTROPY_EXT, fac as GLfloat), [INFO] [stderr] 1013 | | _ => () [INFO] [stderr] 1014 | | } [INFO] [stderr] | |_____^ help: try this: `if let t::FilterMethod::Anisotropic(fac) = info.filter { gl.SamplerParameterf(name, gl::TEXTURE_MAX_ANISOTROPY_EXT, fac as GLfloat) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/tex.rs:1012:72 [INFO] [stderr] | [INFO] [stderr] 1012 | gl.SamplerParameterf(name, gl::TEXTURE_MAX_ANISOTROPY_EXT, fac as GLfloat), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(fac)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:334:5 [INFO] [stderr] | [INFO] [stderr] 334 | / pub fn get_info<'a>(&'a self) -> &'a Info { [INFO] [stderr] 335 | | &self.info [INFO] [stderr] 336 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:372:22 [INFO] [stderr] | [INFO] [stderr] 372 | let stride = bel.desc.stride as gl::types::GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(bel.desc.stride)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:375:41 [INFO] [stderr] | [INFO] [stderr] 375 | gl.VertexAttribIPointer(slot as gl::types::GLuint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:379:40 [INFO] [stderr] | [INFO] [stderr] 379 | gl.VertexAttribPointer(slot as gl::types::GLuint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:387:40 [INFO] [stderr] | [INFO] [stderr] 387 | gl.VertexAttribPointer(slot as gl::types::GLuint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:392:45 [INFO] [stderr] | [INFO] [stderr] 392 | unsafe { gl.EnableVertexAttribArray(slot as gl::types::GLuint) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:394:45 [INFO] [stderr] | [INFO] [stderr] 394 | unsafe { gl.VertexAttribDivisor(slot as gl::types::GLuint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:395:17 [INFO] [stderr] | [INFO] [stderr] 395 | bel.desc.rate as gl::types::GLuint) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bel.desc.rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:401:94 [INFO] [stderr] | [INFO] [stderr] 401 | fn bind_target(&mut self, point: gl::types::GLenum, attachment: gl::types::GLenum, view: &TargetView) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `TargetView` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:403:9 [INFO] [stderr] | [INFO] [stderr] 403 | / match view { [INFO] [stderr] 404 | | &TargetView::Surface(surface) => unsafe { [INFO] [stderr] 405 | | gl.FramebufferRenderbuffer(point, attachment, gl::RENDERBUFFER, surface); [INFO] [stderr] 406 | | }, [INFO] [stderr] ... | [INFO] [stderr] 415 | | }, [INFO] [stderr] 416 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 403 | match *view { [INFO] [stderr] 404 | TargetView::Surface(surface) => unsafe { [INFO] [stderr] 405 | gl.FramebufferRenderbuffer(point, attachment, gl::RENDERBUFFER, surface); [INFO] [stderr] 406 | }, [INFO] [stderr] 407 | TargetView::Texture(texture, level) => unsafe { [INFO] [stderr] 408 | gl.FramebufferTexture(point, attachment, texture, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:409:39 [INFO] [stderr] | [INFO] [stderr] 409 | level as gl::types::GLint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(level)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:413:44 [INFO] [stderr] | [INFO] [stderr] 413 | level as gl::types::GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(level)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:414:44 [INFO] [stderr] | [INFO] [stderr] 414 | layer as gl::types::GLint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(layer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 57 [INFO] [stderr] --> src/lib.rs:435:5 [INFO] [stderr] | [INFO] [stderr] 435 | / fn process(&mut self, cmd: &Command, data_buf: &DataBuffer) { [INFO] [stderr] 436 | | match *cmd { [INFO] [stderr] 437 | | Command::Clear(color, depth, stencil) => { [INFO] [stderr] 438 | | let gl = &self.share.context; [INFO] [stderr] ... | [INFO] [stderr] 817 | | } [INFO] [stderr] 818 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:462:33 [INFO] [stderr] | [INFO] [stderr] 462 | let v = s as gl::types::GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:487:43 [INFO] [stderr] | [INFO] [stderr] 487 | gl.ClearDepth(d as gl::types::GLdouble); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:494:45 [INFO] [stderr] | [INFO] [stderr] 494 | gl.ClearStencil(s as gl::types::GLint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:506:71 [INFO] [stderr] | [INFO] [stderr] 506 | self.share.context.BindBufferBase(gl::UNIFORM_BUFFER, slot as gl::types::GLuint, buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:509:65 [INFO] [stderr] | [INFO] [stderr] 509 | self.share.context.ActiveTexture(gl::TEXTURE0 + slot as gl::types::GLenum); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:516:45 [INFO] [stderr] | [INFO] [stderr] 516 | unsafe { gl.BindSampler(slot as gl::types::GLuint, sampler.object) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:559:61 [INFO] [stderr] | [INFO] [stderr] 559 | self.share.context.DisableVertexAttribArray(slot as gl::types::GLuint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:612:60 [INFO] [stderr] | [INFO] [stderr] 612 | gl.PatchParameteri(gl::PATCH_VERTICES, num as gl::types::GLint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:802:21 [INFO] [stderr] | [INFO] [stderr] 802 | s_rect.x as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(s_rect.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:803:21 [INFO] [stderr] | [INFO] [stderr] 803 | s_rect.y as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(s_rect.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:804:21 [INFO] [stderr] | [INFO] [stderr] 804 | s_end_x as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(s_end_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:805:21 [INFO] [stderr] | [INFO] [stderr] 805 | s_end_y as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(s_end_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:806:21 [INFO] [stderr] | [INFO] [stderr] 806 | d_rect.x as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(d_rect.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:807:21 [INFO] [stderr] | [INFO] [stderr] 807 | d_rect.y as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(d_rect.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:808:21 [INFO] [stderr] | [INFO] [stderr] 808 | (d_rect.x + d_rect.w) as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(d_rect.x + d_rect.w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:809:21 [INFO] [stderr] | [INFO] [stderr] 809 | (d_rect.y + d_rect.h) as GLint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(d_rect.y + d_rect.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:845:26 [INFO] [stderr] | [INFO] [stderr] 845 | let status = match &mut mapping.kind { [INFO] [stderr] | __________________________^ [INFO] [stderr] 846 | | &mut MappingKind::Persistent(ref mut status) => status, [INFO] [stderr] 847 | | _ => unreachable!(), [INFO] [stderr] 848 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 845 | let status = match *(&mut mapping.kind) { [INFO] [stderr] 846 | MappingKind::Persistent(ref mut status) => status, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:912:26 [INFO] [stderr] | [INFO] [stderr] 912 | let status = match &mut mapping.kind { [INFO] [stderr] | __________________________^ [INFO] [stderr] 913 | | &mut MappingKind::Persistent(ref mut status) => status, [INFO] [stderr] 914 | | _ => unreachable!(), [INFO] [stderr] 915 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 912 | let status = match *(&mut mapping.kind) { [INFO] [stderr] 913 | MappingKind::Persistent(ref mut status) => status, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:980:17 [INFO] [stderr] | [INFO] [stderr] 980 | buffer.mapping().map(|raw| { [INFO] [stderr] | _________________^ [INFO] [stderr] | |_________________| [INFO] [stderr] | || [INFO] [stderr] 981 | || // we have exclusive access because it's the last reference [INFO] [stderr] 982 | || let mapping = unsafe { raw.use_access() }; [INFO] [stderr] 983 | || match mapping.kind { [INFO] [stderr] ... || [INFO] [stderr] 992 | || } [INFO] [stderr] 993 | || }); [INFO] [stderr] | ||__________________^- help: try this: `if let Some(raw) = buffer.mapping() { ... }` [INFO] [stderr] | |___________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:999:31 [INFO] [stderr] | [INFO] [stderr] 999 | |gl, raw_texture| match raw_texture.resource() { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 1000 | | &NewTexture::Surface(ref suf) => unsafe { gl.DeleteRenderbuffers(1, suf) }, [INFO] [stderr] 1001 | | &NewTexture::Texture(ref tex) => unsafe { gl.DeleteTextures(1, tex) }, [INFO] [stderr] 1002 | | }, // new texture [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 999 | |gl, raw_texture| match *raw_texture.resource() { [INFO] [stderr] 1000 | NewTexture::Surface(ref suf) => unsafe { gl.DeleteRenderbuffers(1, suf) }, [INFO] [stderr] 1001 | NewTexture::Texture(ref tex) => unsafe { gl.DeleteTextures(1, tex) }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.72s [INFO] running `"docker" "inspect" "30d3fef2c4ffc5ac19e425c1c14f3066f93496957b67db83d5f071dff47fa670"` [INFO] running `"docker" "rm" "-f" "30d3fef2c4ffc5ac19e425c1c14f3066f93496957b67db83d5f071dff47fa670"` [INFO] [stdout] 30d3fef2c4ffc5ac19e425c1c14f3066f93496957b67db83d5f071dff47fa670