[INFO] crate gfx_core 0.8.3 is already in cache [INFO] extracting crate gfx_core 0.8.3 into work/ex/clippy-test-run/sources/stable/reg/gfx_core/0.8.3 [INFO] extracting crate gfx_core 0.8.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gfx_core/0.8.3 [INFO] validating manifest of gfx_core-0.8.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gfx_core-0.8.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gfx_core-0.8.3 [INFO] finished frobbing gfx_core-0.8.3 [INFO] frobbed toml for gfx_core-0.8.3 written to work/ex/clippy-test-run/sources/stable/reg/gfx_core/0.8.3/Cargo.toml [INFO] started frobbing gfx_core-0.8.3 [INFO] finished frobbing gfx_core-0.8.3 [INFO] frobbed toml for gfx_core-0.8.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gfx_core/0.8.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gfx_core-0.8.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gfx_core/0.8.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 206e0ab45288f8b255f25cf9d6062a886c18a31e76a7854509b66fb15174e8d6 [INFO] running `"docker" "start" "-a" "206e0ab45288f8b255f25cf9d6062a886c18a31e76a7854509b66fb15174e8d6"` [INFO] [stderr] Checking gfx_core v0.8.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | resource: resource, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `resource` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:245:13 [INFO] [stderr] | [INFO] [stderr] 245 | role: role, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `role` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | usage: usage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | bind: bind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:337:13 [INFO] [stderr] | [INFO] [stderr] 337 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | levels: levels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `levels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:340:13 [INFO] [stderr] | [INFO] [stderr] 340 | bind: bind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:341:13 [INFO] [stderr] | [INFO] [stderr] 341 | usage: usage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | swizzle: swizzle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `swizzle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:399:13 [INFO] [stderr] | [INFO] [stderr] 399 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:400:13 [INFO] [stderr] | [INFO] [stderr] 400 | layer: layer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `layer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:414:13 [INFO] [stderr] | [INFO] [stderr] 414 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:415:13 [INFO] [stderr] | [INFO] [stderr] 415 | layer: layer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `layer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:416:13 [INFO] [stderr] | [INFO] [stderr] 416 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:445:13 [INFO] [stderr] | [INFO] [stderr] 445 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:446:13 [INFO] [stderr] | [INFO] [stderr] 446 | levels: levels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `levels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapping.rs:114:28 [INFO] [stderr] | [INFO] [stderr] 114 | Ok(Guard { raw: raw }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `raw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapping.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | mapping: mapping, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapping.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | mapping: mapping, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pso.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | mask: mask, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pso.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | primitive: primitive, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `primitive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:487:13 [INFO] [stderr] | [INFO] [stderr] 487 | resource: resource, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `resource` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:488:13 [INFO] [stderr] | [INFO] [stderr] 488 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | resource: resource, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `resource` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:512:13 [INFO] [stderr] | [INFO] [stderr] 512 | filter: filter, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | resource: resource, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `resource` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:245:13 [INFO] [stderr] | [INFO] [stderr] 245 | role: role, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `role` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | usage: usage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | bind: bind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:337:13 [INFO] [stderr] | [INFO] [stderr] 337 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | levels: levels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `levels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:340:13 [INFO] [stderr] | [INFO] [stderr] 340 | bind: bind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:341:13 [INFO] [stderr] | [INFO] [stderr] 341 | usage: usage, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | swizzle: swizzle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `swizzle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:399:13 [INFO] [stderr] | [INFO] [stderr] 399 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:400:13 [INFO] [stderr] | [INFO] [stderr] 400 | layer: layer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `layer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:414:13 [INFO] [stderr] | [INFO] [stderr] 414 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:415:13 [INFO] [stderr] | [INFO] [stderr] 415 | layer: layer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `layer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:416:13 [INFO] [stderr] | [INFO] [stderr] 416 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:445:13 [INFO] [stderr] | [INFO] [stderr] 445 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factory.rs:446:13 [INFO] [stderr] | [INFO] [stderr] 446 | levels: levels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `levels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapping.rs:114:28 [INFO] [stderr] | [INFO] [stderr] 114 | Ok(Guard { raw: raw }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `raw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapping.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | mapping: mapping, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapping.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | mapping: mapping, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pso.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | mask: mask, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pso.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | primitive: primitive, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `primitive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:487:13 [INFO] [stderr] | [INFO] [stderr] 487 | resource: resource, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `resource` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shade.rs:488:13 [INFO] [stderr] | [INFO] [stderr] 488 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | resource: resource, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `resource` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:512:13 [INFO] [stderr] | [INFO] [stderr] 512 | filter: filter, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: item `buffer::Raw` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/buffer.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | / impl Raw { [INFO] [stderr] 31 | | #[doc(hidden)] [INFO] [stderr] 32 | | pub fn new(resource: R::Buffer, [INFO] [stderr] 33 | | info: Info, [INFO] [stderr] ... | [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/buffer.rs:38:34 [INFO] [stderr] | [INFO] [stderr] 38 | mapping: mapping.map(|m| mapping::Raw::new(m)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `mapping::Raw::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command::AccessInfo` [INFO] [stderr] --> src/command.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | / pub fn new() -> Self { [INFO] [stderr] 149 | | AccessInfo { [INFO] [stderr] 150 | | mapped_reads: HashSet::new(), [INFO] [stderr] 151 | | mapped_writes: HashSet::new(), [INFO] [stderr] 152 | | } [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 141 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `dummy::DummyDevice` [INFO] [stderr] --> src/dummy.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn new() -> DummyDevice { [INFO] [stderr] 64 | | let caps = Capabilities { [INFO] [stderr] 65 | | max_vertex_count: 0, [INFO] [stderr] 66 | | max_index_count: 0, [INFO] [stderr] ... | [INFO] [stderr] 81 | | } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | impl Default for dummy::DummyDevice { [INFO] [stderr] 62 | fn default() -> Self { [INFO] [stderr] 63 | Self::new() [INFO] [stderr] 64 | } [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/factory.rs:239:18 [INFO] [stderr] | [INFO] [stderr] 239 | .map(|raw| Typed::new(raw)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Typed::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/factory.rs:251:42 [INFO] [stderr] | [INFO] [stderr] 251 | self.create_buffer_raw(info).map(|raw| Typed::new(raw)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Typed::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/factory.rs:269:60 [INFO] [stderr] | [INFO] [stderr] 269 | self.create_shader(shade::Stage::Vertex, code).map(|s| VertexShader(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `VertexShader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/factory.rs:273:58 [INFO] [stderr] | [INFO] [stderr] 273 | self.create_shader(shade::Stage::Hull, code).map(|s| HullShader(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HullShader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/factory.rs:277:60 [INFO] [stderr] | [INFO] [stderr] 277 | self.create_shader(shade::Stage::Domain, code).map(|s| DomainShader(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DomainShader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/factory.rs:281:62 [INFO] [stderr] | [INFO] [stderr] 281 | self.create_shader(shade::Stage::Geometry, code).map(|s| GeometryShader(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `GeometryShader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/factory.rs:286:59 [INFO] [stderr] | [INFO] [stderr] 286 | self.create_shader(shade::Stage::Pixel, code).map(|s| PixelShader(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PixelShader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/factory.rs:429:39 [INFO] [stderr] | [INFO] [stderr] 429 | -> Result<(handle::Texture, [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 430 | | handle::ShaderResourceView), [INFO] [stderr] 431 | | CombinedError> [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/factory.rs:464:12 [INFO] [stderr] | [INFO] [stderr] 464 | -> Result<(handle::Texture, handle::ShaderResourceView), [INFO] [stderr] | ____________^ [INFO] [stderr] 465 | | CombinedError> [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/factory.rs:478:32 [INFO] [stderr] | [INFO] [stderr] 478 | -> Result<(handle::Texture, [INFO] [stderr] | ________________________________^ [INFO] [stderr] 479 | | handle::ShaderResourceView, [INFO] [stderr] 480 | | handle::RenderTargetView [INFO] [stderr] 481 | | ), CombinedError> [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/factory.rs:494:32 [INFO] [stderr] | [INFO] [stderr] 494 | -> Result<(handle::Texture, [INFO] [stderr] | ________________________________^ [INFO] [stderr] 495 | | handle::ShaderResourceView, [INFO] [stderr] 496 | | handle::DepthStencilView [INFO] [stderr] 497 | | ), CombinedError> [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `format::Swizzle` [INFO] [stderr] --> src/format.rs:182:5 [INFO] [stderr] | [INFO] [stderr] 182 | / pub fn new() -> Swizzle { [INFO] [stderr] 183 | | Swizzle(ChannelSource::X, ChannelSource::Y, ChannelSource::Z, ChannelSource::W) [INFO] [stderr] 184 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 180 | impl Default for format::Swizzle { [INFO] [stderr] 181 | fn default() -> Self { [INFO] [stderr] 182 | Self::new() [INFO] [stderr] 183 | } [INFO] [stderr] 184 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/format.rs:320:30 [INFO] [stderr] | [INFO] [stderr] 320 | unsafe { transmute(slice) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&*(slice as *const [u8] as *const [format::U8Norm])` [INFO] [stderr] ... [INFO] [stderr] 327 | / alias! { [INFO] [stderr] 328 | | U8Norm = u8, [INFO] [stderr] 329 | | I8Norm = i8, [INFO] [stderr] 330 | | U16Norm = u16, [INFO] [stderr] 331 | | I16Norm = i16, [INFO] [stderr] 332 | | F16 = u16, // half-float [INFO] [stderr] 333 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/format.rs:320:30 [INFO] [stderr] | [INFO] [stderr] 320 | unsafe { transmute(slice) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&*(slice as *const [i8] as *const [format::I8Norm])` [INFO] [stderr] ... [INFO] [stderr] 327 | / alias! { [INFO] [stderr] 328 | | U8Norm = u8, [INFO] [stderr] 329 | | I8Norm = i8, [INFO] [stderr] 330 | | U16Norm = u16, [INFO] [stderr] 331 | | I16Norm = i16, [INFO] [stderr] 332 | | F16 = u16, // half-float [INFO] [stderr] 333 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/format.rs:320:30 [INFO] [stderr] | [INFO] [stderr] 320 | unsafe { transmute(slice) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&*(slice as *const [u16] as *const [format::U16Norm])` [INFO] [stderr] ... [INFO] [stderr] 327 | / alias! { [INFO] [stderr] 328 | | U8Norm = u8, [INFO] [stderr] 329 | | I8Norm = i8, [INFO] [stderr] 330 | | U16Norm = u16, [INFO] [stderr] 331 | | I16Norm = i16, [INFO] [stderr] 332 | | F16 = u16, // half-float [INFO] [stderr] 333 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/format.rs:320:30 [INFO] [stderr] | [INFO] [stderr] 320 | unsafe { transmute(slice) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&*(slice as *const [i16] as *const [format::I16Norm])` [INFO] [stderr] ... [INFO] [stderr] 327 | / alias! { [INFO] [stderr] 328 | | U8Norm = u8, [INFO] [stderr] 329 | | I8Norm = i8, [INFO] [stderr] 330 | | U16Norm = u16, [INFO] [stderr] 331 | | I16Norm = i16, [INFO] [stderr] 332 | | F16 = u16, // half-float [INFO] [stderr] 333 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/format.rs:320:30 [INFO] [stderr] | [INFO] [stderr] 320 | unsafe { transmute(slice) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&*(slice as *const [u16] as *const [format::F16])` [INFO] [stderr] ... [INFO] [stderr] 327 | / alias! { [INFO] [stderr] 328 | | U8Norm = u8, [INFO] [stderr] 329 | | I8Norm = i8, [INFO] [stderr] 330 | | U16Norm = u16, [INFO] [stderr] 331 | | I16Norm = i16, [INFO] [stderr] 332 | | F16 = u16, // half-float [INFO] [stderr] 333 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: item `handle::Buffer` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/handle.rs:52:1 [INFO] [stderr] | [INFO] [stderr] 52 | / impl Buffer { [INFO] [stderr] 53 | | /// Get the associated information about the buffer [INFO] [stderr] 54 | | pub fn get_info(&self) -> &buffer::Info { self.raw().get_info() } [INFO] [stderr] 55 | | [INFO] [stderr] ... | [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/handle.rs:299:5 [INFO] [stderr] | [INFO] [stderr] 299 | / fn clean_with), [INFO] [stderr] 301 | | B: Fn(&mut T, &R::Shader), [INFO] [stderr] 302 | | C: Fn(&mut T, &shade::Program), [INFO] [stderr] ... | [INFO] [stderr] 310 | | K: Fn(&mut T, &R::Fence), [INFO] [stderr] 311 | | >(&mut self, &mut T, A, B, C, D, E, F, G, H, I, J, K); [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `handle::Manager` [INFO] [stderr] --> src/handle.rs:442:5 [INFO] [stderr] | [INFO] [stderr] 442 | / pub fn new() -> Manager { [INFO] [stderr] 443 | | Manager { [INFO] [stderr] 444 | | buffers: Vec::new(), [INFO] [stderr] 445 | | shaders: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 455 | | } [INFO] [stderr] 456 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 263 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:473:31 [INFO] [stderr] | [INFO] [stderr] 473 | self.buffers .extend(other.buffers .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.buffers .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:474:31 [INFO] [stderr] | [INFO] [stderr] 474 | self.shaders .extend(other.shaders .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.shaders .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:475:31 [INFO] [stderr] | [INFO] [stderr] 475 | self.programs .extend(other.programs .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.programs .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:476:31 [INFO] [stderr] | [INFO] [stderr] 476 | self.psos .extend(other.psos .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.psos .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:477:31 [INFO] [stderr] | [INFO] [stderr] 477 | self.textures .extend(other.textures .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.textures .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:478:31 [INFO] [stderr] | [INFO] [stderr] 478 | self.srvs .extend(other.srvs .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.srvs .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:479:31 [INFO] [stderr] | [INFO] [stderr] 479 | self.uavs .extend(other.uavs .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.uavs .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:480:31 [INFO] [stderr] | [INFO] [stderr] 480 | self.rtvs .extend(other.rtvs .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.rtvs .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:481:31 [INFO] [stderr] | [INFO] [stderr] 481 | self.dsvs .extend(other.dsvs .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.dsvs .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:482:31 [INFO] [stderr] | [INFO] [stderr] 482 | self.samplers .extend(other.samplers .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.samplers .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:483:31 [INFO] [stderr] | [INFO] [stderr] 483 | self.fences .extend(other.fences .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.fences .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/mapping.rs:92:21 [INFO] [stderr] | [INFO] [stderr] 92 | assert!(self.accessible.swap(true, atomic::Ordering::Relaxed) == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.accessible.swap(true, atomic::Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/mapping.rs:98:40 [INFO] [stderr] | [INFO] [stderr] 98 | pub unsafe fn use_access(&self) -> &mut R::Mapping { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/mapping.rs:98:30 [INFO] [stderr] | [INFO] [stderr] 98 | pub unsafe fn use_access(&self) -> &mut R::Mapping { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/memory.rs:99:23 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn is_mutable(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `pso::VertexBufferSet` [INFO] [stderr] --> src/pso.rs:223:5 [INFO] [stderr] | [INFO] [stderr] 223 | / pub fn new() -> VertexBufferSet { [INFO] [stderr] 224 | | VertexBufferSet([None; MAX_VERTEX_ATTRIBUTES]) [INFO] [stderr] 225 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 216 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `pso::PixelTargetSet` [INFO] [stderr] --> src/pso.rs:259:5 [INFO] [stderr] | [INFO] [stderr] 259 | / pub fn new() -> PixelTargetSet { [INFO] [stderr] 260 | | PixelTargetSet { [INFO] [stderr] 261 | | colors: [None; MAX_COLOR_TARGETS], [INFO] [stderr] 262 | | depth: None, [INFO] [stderr] ... | [INFO] [stderr] 265 | | } [INFO] [stderr] 266 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 246 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/pso.rs:273:43 [INFO] [stderr] | [INFO] [stderr] 273 | self.colors[slot as usize] = Some(view.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*view` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/shade.rs:77:23 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn can_sample(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/shade.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / match self { [INFO] [stderr] 79 | | &TextureType::Buffer => false, [INFO] [stderr] 80 | | &TextureType::D1(_) => true, [INFO] [stderr] 81 | | &TextureType::D2(_, IsMultiSample::MultiSample) => false, [INFO] [stderr] ... | [INFO] [stderr] 84 | | &TextureType::Cube(_) => true, [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 78 | match *self { [INFO] [stderr] 79 | TextureType::Buffer => false, [INFO] [stderr] 80 | TextureType::D1(_) => true, [INFO] [stderr] 81 | TextureType::D2(_, IsMultiSample::MultiSample) => false, [INFO] [stderr] 82 | TextureType::D2(_, IsMultiSample::NoMultiSample) => true, [INFO] [stderr] 83 | TextureType::D3 => true, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/texture.rs:183:30 [INFO] [stderr] | [INFO] [stderr] 183 | pub fn get_num_fragments(&self) -> NumFragments { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/texture.rs:191:26 [INFO] [stderr] | [INFO] [stderr] 191 | pub fn needs_resolve(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:453:9 [INFO] [stderr] | [INFO] [stderr] 453 | self.0 as f32 / 8.0 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(self.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `out` [INFO] [stderr] --> src/texture.rs:473:18 [INFO] [stderr] | [INFO] [stderr] 473 | for i in 0 .. 4 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 473 | for (i, ) in out.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/texture.rs:564:50 [INFO] [stderr] | [INFO] [stderr] 564 | let format = format::Format(self.format, cty.into()); [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `cty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `gfx_core`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: item `buffer::Raw` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/buffer.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | / impl Raw { [INFO] [stderr] 31 | | #[doc(hidden)] [INFO] [stderr] 32 | | pub fn new(resource: R::Buffer, [INFO] [stderr] 33 | | info: Info, [INFO] [stderr] ... | [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/buffer.rs:38:34 [INFO] [stderr] | [INFO] [stderr] 38 | mapping: mapping.map(|m| mapping::Raw::new(m)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `mapping::Raw::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `command::AccessInfo` [INFO] [stderr] --> src/command.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | / pub fn new() -> Self { [INFO] [stderr] 149 | | AccessInfo { [INFO] [stderr] 150 | | mapped_reads: HashSet::new(), [INFO] [stderr] 151 | | mapped_writes: HashSet::new(), [INFO] [stderr] 152 | | } [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 141 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `dummy::DummyDevice` [INFO] [stderr] --> src/dummy.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn new() -> DummyDevice { [INFO] [stderr] 64 | | let caps = Capabilities { [INFO] [stderr] 65 | | max_vertex_count: 0, [INFO] [stderr] 66 | | max_index_count: 0, [INFO] [stderr] ... | [INFO] [stderr] 81 | | } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | impl Default for dummy::DummyDevice { [INFO] [stderr] 62 | fn default() -> Self { [INFO] [stderr] 63 | Self::new() [INFO] [stderr] 64 | } [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/factory.rs:239:18 [INFO] [stderr] | [INFO] [stderr] 239 | .map(|raw| Typed::new(raw)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Typed::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/factory.rs:251:42 [INFO] [stderr] | [INFO] [stderr] 251 | self.create_buffer_raw(info).map(|raw| Typed::new(raw)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Typed::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/factory.rs:269:60 [INFO] [stderr] | [INFO] [stderr] 269 | self.create_shader(shade::Stage::Vertex, code).map(|s| VertexShader(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `VertexShader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/factory.rs:273:58 [INFO] [stderr] | [INFO] [stderr] 273 | self.create_shader(shade::Stage::Hull, code).map(|s| HullShader(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HullShader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/factory.rs:277:60 [INFO] [stderr] | [INFO] [stderr] 277 | self.create_shader(shade::Stage::Domain, code).map(|s| DomainShader(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DomainShader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/factory.rs:281:62 [INFO] [stderr] | [INFO] [stderr] 281 | self.create_shader(shade::Stage::Geometry, code).map(|s| GeometryShader(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `GeometryShader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/factory.rs:286:59 [INFO] [stderr] | [INFO] [stderr] 286 | self.create_shader(shade::Stage::Pixel, code).map(|s| PixelShader(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PixelShader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/factory.rs:429:39 [INFO] [stderr] | [INFO] [stderr] 429 | -> Result<(handle::Texture, [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 430 | | handle::ShaderResourceView), [INFO] [stderr] 431 | | CombinedError> [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/factory.rs:464:12 [INFO] [stderr] | [INFO] [stderr] 464 | -> Result<(handle::Texture, handle::ShaderResourceView), [INFO] [stderr] | ____________^ [INFO] [stderr] 465 | | CombinedError> [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/factory.rs:478:32 [INFO] [stderr] | [INFO] [stderr] 478 | -> Result<(handle::Texture, [INFO] [stderr] | ________________________________^ [INFO] [stderr] 479 | | handle::ShaderResourceView, [INFO] [stderr] 480 | | handle::RenderTargetView [INFO] [stderr] 481 | | ), CombinedError> [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/factory.rs:494:32 [INFO] [stderr] | [INFO] [stderr] 494 | -> Result<(handle::Texture, [INFO] [stderr] | ________________________________^ [INFO] [stderr] 495 | | handle::ShaderResourceView, [INFO] [stderr] 496 | | handle::DepthStencilView [INFO] [stderr] 497 | | ), CombinedError> [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `format::Swizzle` [INFO] [stderr] --> src/format.rs:182:5 [INFO] [stderr] | [INFO] [stderr] 182 | / pub fn new() -> Swizzle { [INFO] [stderr] 183 | | Swizzle(ChannelSource::X, ChannelSource::Y, ChannelSource::Z, ChannelSource::W) [INFO] [stderr] 184 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 180 | impl Default for format::Swizzle { [INFO] [stderr] 181 | fn default() -> Self { [INFO] [stderr] 182 | Self::new() [INFO] [stderr] 183 | } [INFO] [stderr] 184 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/format.rs:320:30 [INFO] [stderr] | [INFO] [stderr] 320 | unsafe { transmute(slice) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&*(slice as *const [u8] as *const [format::U8Norm])` [INFO] [stderr] ... [INFO] [stderr] 327 | / alias! { [INFO] [stderr] 328 | | U8Norm = u8, [INFO] [stderr] 329 | | I8Norm = i8, [INFO] [stderr] 330 | | U16Norm = u16, [INFO] [stderr] 331 | | I16Norm = i16, [INFO] [stderr] 332 | | F16 = u16, // half-float [INFO] [stderr] 333 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/format.rs:320:30 [INFO] [stderr] | [INFO] [stderr] 320 | unsafe { transmute(slice) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&*(slice as *const [i8] as *const [format::I8Norm])` [INFO] [stderr] ... [INFO] [stderr] 327 | / alias! { [INFO] [stderr] 328 | | U8Norm = u8, [INFO] [stderr] 329 | | I8Norm = i8, [INFO] [stderr] 330 | | U16Norm = u16, [INFO] [stderr] 331 | | I16Norm = i16, [INFO] [stderr] 332 | | F16 = u16, // half-float [INFO] [stderr] 333 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/format.rs:320:30 [INFO] [stderr] | [INFO] [stderr] 320 | unsafe { transmute(slice) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&*(slice as *const [u16] as *const [format::U16Norm])` [INFO] [stderr] ... [INFO] [stderr] 327 | / alias! { [INFO] [stderr] 328 | | U8Norm = u8, [INFO] [stderr] 329 | | I8Norm = i8, [INFO] [stderr] 330 | | U16Norm = u16, [INFO] [stderr] 331 | | I16Norm = i16, [INFO] [stderr] 332 | | F16 = u16, // half-float [INFO] [stderr] 333 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/format.rs:320:30 [INFO] [stderr] | [INFO] [stderr] 320 | unsafe { transmute(slice) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&*(slice as *const [i16] as *const [format::I16Norm])` [INFO] [stderr] ... [INFO] [stderr] 327 | / alias! { [INFO] [stderr] 328 | | U8Norm = u8, [INFO] [stderr] 329 | | I8Norm = i8, [INFO] [stderr] 330 | | U16Norm = u16, [INFO] [stderr] 331 | | I16Norm = i16, [INFO] [stderr] 332 | | F16 = u16, // half-float [INFO] [stderr] 333 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/format.rs:320:30 [INFO] [stderr] | [INFO] [stderr] 320 | unsafe { transmute(slice) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&*(slice as *const [u16] as *const [format::F16])` [INFO] [stderr] ... [INFO] [stderr] 327 | / alias! { [INFO] [stderr] 328 | | U8Norm = u8, [INFO] [stderr] 329 | | I8Norm = i8, [INFO] [stderr] 330 | | U16Norm = u16, [INFO] [stderr] 331 | | I16Norm = i16, [INFO] [stderr] 332 | | F16 = u16, // half-float [INFO] [stderr] 333 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: item `handle::Buffer` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/handle.rs:52:1 [INFO] [stderr] | [INFO] [stderr] 52 | / impl Buffer { [INFO] [stderr] 53 | | /// Get the associated information about the buffer [INFO] [stderr] 54 | | pub fn get_info(&self) -> &buffer::Info { self.raw().get_info() } [INFO] [stderr] 55 | | [INFO] [stderr] ... | [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/handle.rs:299:5 [INFO] [stderr] | [INFO] [stderr] 299 | / fn clean_with), [INFO] [stderr] 301 | | B: Fn(&mut T, &R::Shader), [INFO] [stderr] 302 | | C: Fn(&mut T, &shade::Program), [INFO] [stderr] ... | [INFO] [stderr] 310 | | K: Fn(&mut T, &R::Fence), [INFO] [stderr] 311 | | >(&mut self, &mut T, A, B, C, D, E, F, G, H, I, J, K); [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `handle::Manager` [INFO] [stderr] --> src/handle.rs:442:5 [INFO] [stderr] | [INFO] [stderr] 442 | / pub fn new() -> Manager { [INFO] [stderr] 443 | | Manager { [INFO] [stderr] 444 | | buffers: Vec::new(), [INFO] [stderr] 445 | | shaders: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 455 | | } [INFO] [stderr] 456 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 263 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:473:31 [INFO] [stderr] | [INFO] [stderr] 473 | self.buffers .extend(other.buffers .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.buffers .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:474:31 [INFO] [stderr] | [INFO] [stderr] 474 | self.shaders .extend(other.shaders .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.shaders .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:475:31 [INFO] [stderr] | [INFO] [stderr] 475 | self.programs .extend(other.programs .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.programs .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:476:31 [INFO] [stderr] | [INFO] [stderr] 476 | self.psos .extend(other.psos .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.psos .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:477:31 [INFO] [stderr] | [INFO] [stderr] 477 | self.textures .extend(other.textures .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.textures .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:478:31 [INFO] [stderr] | [INFO] [stderr] 478 | self.srvs .extend(other.srvs .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.srvs .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:479:31 [INFO] [stderr] | [INFO] [stderr] 479 | self.uavs .extend(other.uavs .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.uavs .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:480:31 [INFO] [stderr] | [INFO] [stderr] 480 | self.rtvs .extend(other.rtvs .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.rtvs .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:481:31 [INFO] [stderr] | [INFO] [stderr] 481 | self.dsvs .extend(other.dsvs .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.dsvs .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:482:31 [INFO] [stderr] | [INFO] [stderr] 482 | self.samplers .extend(other.samplers .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.samplers .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handle.rs:483:31 [INFO] [stderr] | [INFO] [stderr] 483 | self.fences .extend(other.fences .iter().map(|h| h.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `other.fences .iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/mapping.rs:92:21 [INFO] [stderr] | [INFO] [stderr] 92 | assert!(self.accessible.swap(true, atomic::Ordering::Relaxed) == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.accessible.swap(true, atomic::Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/mapping.rs:98:40 [INFO] [stderr] | [INFO] [stderr] 98 | pub unsafe fn use_access(&self) -> &mut R::Mapping { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/mapping.rs:98:30 [INFO] [stderr] | [INFO] [stderr] 98 | pub unsafe fn use_access(&self) -> &mut R::Mapping { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/memory.rs:99:23 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn is_mutable(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `pso::VertexBufferSet` [INFO] [stderr] --> src/pso.rs:223:5 [INFO] [stderr] | [INFO] [stderr] 223 | / pub fn new() -> VertexBufferSet { [INFO] [stderr] 224 | | VertexBufferSet([None; MAX_VERTEX_ATTRIBUTES]) [INFO] [stderr] 225 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 216 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `pso::PixelTargetSet` [INFO] [stderr] --> src/pso.rs:259:5 [INFO] [stderr] | [INFO] [stderr] 259 | / pub fn new() -> PixelTargetSet { [INFO] [stderr] 260 | | PixelTargetSet { [INFO] [stderr] 261 | | colors: [None; MAX_COLOR_TARGETS], [INFO] [stderr] 262 | | depth: None, [INFO] [stderr] ... | [INFO] [stderr] 265 | | } [INFO] [stderr] 266 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 246 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/pso.rs:273:43 [INFO] [stderr] | [INFO] [stderr] 273 | self.colors[slot as usize] = Some(view.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*view` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/shade.rs:77:23 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn can_sample(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/shade.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / match self { [INFO] [stderr] 79 | | &TextureType::Buffer => false, [INFO] [stderr] 80 | | &TextureType::D1(_) => true, [INFO] [stderr] 81 | | &TextureType::D2(_, IsMultiSample::MultiSample) => false, [INFO] [stderr] ... | [INFO] [stderr] 84 | | &TextureType::Cube(_) => true, [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 78 | match *self { [INFO] [stderr] 79 | TextureType::Buffer => false, [INFO] [stderr] 80 | TextureType::D1(_) => true, [INFO] [stderr] 81 | TextureType::D2(_, IsMultiSample::MultiSample) => false, [INFO] [stderr] 82 | TextureType::D2(_, IsMultiSample::NoMultiSample) => true, [INFO] [stderr] 83 | TextureType::D3 => true, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/texture.rs:183:30 [INFO] [stderr] | [INFO] [stderr] 183 | pub fn get_num_fragments(&self) -> NumFragments { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/texture.rs:191:26 [INFO] [stderr] | [INFO] [stderr] 191 | pub fn needs_resolve(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:453:9 [INFO] [stderr] | [INFO] [stderr] 453 | self.0 as f32 / 8.0 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(self.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `out` [INFO] [stderr] --> src/texture.rs:473:18 [INFO] [stderr] | [INFO] [stderr] 473 | for i in 0 .. 4 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 473 | for (i, ) in out.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/texture.rs:564:50 [INFO] [stderr] | [INFO] [stderr] 564 | let format = format::Format(self.format, cty.into()); [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `cty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `gfx_core`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "206e0ab45288f8b255f25cf9d6062a886c18a31e76a7854509b66fb15174e8d6"` [INFO] running `"docker" "rm" "-f" "206e0ab45288f8b255f25cf9d6062a886c18a31e76a7854509b66fb15174e8d6"` [INFO] [stdout] 206e0ab45288f8b255f25cf9d6062a886c18a31e76a7854509b66fb15174e8d6