[INFO] crate gfx_app 0.8.0 is already in cache [INFO] extracting crate gfx_app 0.8.0 into work/ex/clippy-test-run/sources/stable/reg/gfx_app/0.8.0 [INFO] extracting crate gfx_app 0.8.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gfx_app/0.8.0 [INFO] validating manifest of gfx_app-0.8.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gfx_app-0.8.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gfx_app-0.8.0 [INFO] removed 0 missing examples [INFO] finished frobbing gfx_app-0.8.0 [INFO] frobbed toml for gfx_app-0.8.0 written to work/ex/clippy-test-run/sources/stable/reg/gfx_app/0.8.0/Cargo.toml [INFO] started frobbing gfx_app-0.8.0 [INFO] removed 0 missing examples [INFO] finished frobbing gfx_app-0.8.0 [INFO] frobbed toml for gfx_app-0.8.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gfx_app/0.8.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gfx_app-0.8.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gfx_app/0.8.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b404a0fcc1541dc32ebf932b054b52817136b1caaaf0b64cbdfd88704c0a324d [INFO] running `"docker" "start" "-a" "b404a0fcc1541dc32ebf932b054b52817136b1caaaf0b64cbdfd88704c0a324d"` [INFO] [stderr] Compiling gfx_macros v0.2.1 [INFO] [stderr] Compiling glutin v0.19.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking winit v0.18.1 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking gfx_device_gl v0.15.5 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_window_glutin v0.27.0 [INFO] [stderr] Checking gfx_app v0.8.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/shade.rs:37:19 [INFO] [stderr] | [INFO] [stderr] 37 | pub const EMPTY: &'static [u8] = &[]; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/shade.rs:37:19 [INFO] [stderr] | [INFO] [stderr] 37 | pub const EMPTY: &'static [u8] = &[]; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:89:19 [INFO] [stderr] | [INFO] [stderr] 89 | (time_end.subsec_nanos() / 1_000_000) as f64) / self.num_frames); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(time_end.subsec_nanos() / 1_000_000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/lib.rs:89:19 [INFO] [stderr] | [INFO] [stderr] 89 | (time_end.subsec_nanos() / 1_000_000) as f64) / self.num_frames); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `time_end.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/mipmap/main.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/mipmap/main.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/cube/main.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/blend/main.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/flowmap/main.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/terrain/main.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/terrain/main.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:89:19 [INFO] [stderr] | [INFO] [stderr] 89 | (time_end.subsec_nanos() / 1_000_000) as f64) / self.num_frames); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(time_end.subsec_nanos() / 1_000_000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/lib.rs:89:19 [INFO] [stderr] | [INFO] [stderr] 89 | (time_end.subsec_nanos() / 1_000_000) as f64) / self.num_frames); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `time_end.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/performance/main.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/performance/main.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/performance/main.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | dimension: dimension, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimension` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/performance/main.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/performance/main.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | encoder: encoder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `encoder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/performance/main.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/performance/main.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | pso: pso, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pso` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/performance/main.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/performance/main.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/performance/main.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | dimension: dimension, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimension` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/performance/main.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | gl: gl, [INFO] [stderr] | ^^^^^^ help: replace it with: `gl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/performance/main.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | vs: vs, [INFO] [stderr] | ^^^^^^ help: replace it with: `vs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/performance/main.rs:295:13 [INFO] [stderr] | [INFO] [stderr] 295 | fs: fs, [INFO] [stderr] | ^^^^^^ help: replace it with: `fs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/performance/main.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/performance/main.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | vbo: vbo, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vbo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/performance/main.rs:298:13 [INFO] [stderr] | [INFO] [stderr] 298 | vao: vao, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/performance/main.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | trans_uniform: trans_uniform, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `trans_uniform` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> examples/terrain/main.rs:145:79 [INFO] [stderr] | [INFO] [stderr] 145 | let time = elapsed.as_secs() as f32 + elapsed.subsec_nanos() as f32 / 1000_000_000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/blend/main.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | const BLENDS: [&'static str; 9] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/terrain_tessellated/main.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/terrain_tessellated/main.rs:142:17 [INFO] [stderr] | [INFO] [stderr] 142 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/cube/main.rs:54:19 [INFO] [stderr] | [INFO] [stderr] 54 | pos: [p[0] as f32, p[1] as f32, p[2] as f32, 1.0], [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(p[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/cube/main.rs:54:32 [INFO] [stderr] | [INFO] [stderr] 54 | pos: [p[0] as f32, p[1] as f32, p[2] as f32, 1.0], [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(p[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/cube/main.rs:54:45 [INFO] [stderr] | [INFO] [stderr] 54 | pos: [p[0] as f32, p[1] as f32, p[2] as f32, 1.0], [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(p[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/cube/main.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | tex_coord: [t[0] as f32, t[1] as f32], [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(t[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/cube/main.rs:55:38 [INFO] [stderr] | [INFO] [stderr] 55 | tex_coord: [t[0] as f32, t[1] as f32], [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(t[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/deferred/main.rs:297:17 [INFO] [stderr] | [INFO] [stderr] 297 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/deferred/main.rs:337:17 [INFO] [stderr] | [INFO] [stderr] 337 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/deferred/main.rs:461:13 [INFO] [stderr] | [INFO] [stderr] 461 | terrain: terrain, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `terrain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/deferred/main.rs:462:13 [INFO] [stderr] | [INFO] [stderr] 462 | blit: blit, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `blit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/deferred/main.rs:463:13 [INFO] [stderr] | [INFO] [stderr] 463 | light: light, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `light` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/deferred/main.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | emitter: emitter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `emitter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/deferred/main.rs:469:13 [INFO] [stderr] | [INFO] [stderr] 469 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/deferred/main.rs:470:13 [INFO] [stderr] | [INFO] [stderr] 470 | depth_resource: depth_resource, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `depth_resource` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> examples/blend/main.rs:149:34 [INFO] [stderr] | [INFO] [stderr] 149 | self.bundle.data.blend = (self.id as i32).into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(self.id as i32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> examples/blend/main.rs:149:34 [INFO] [stderr] | [INFO] [stderr] 149 | self.bundle.data.blend = (self.id as i32).into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(self.id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> examples/blend/main.rs:150:38 [INFO] [stderr] | [INFO] [stderr] 150 | let locals = Locals { blend: self.id as i32 }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(self.id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> examples/performance/main.rs:305:65 [INFO] [stderr] | [INFO] [stderr] 305 | (dur.as_secs() * 1000) as f64 + dur.subsec_nanos() as f64 / 1000_000.0 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/render_target/main.rs:188:17 [INFO] [stderr] | [INFO] [stderr] 188 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/render_target/main.rs:240:17 [INFO] [stderr] | [INFO] [stderr] 240 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/render_target/main.rs:263:13 [INFO] [stderr] | [INFO] [stderr] 263 | proj_render: proj_render, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proj_render` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/ubo_tilemap/main.rs:99:23 [INFO] [stderr] | [INFO] [stderr] 99 | TileMapData { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/ubo_tilemap/main.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/ubo_tilemap/main.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/ubo_tilemap/main.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/ubo_tilemap/main.rs:433:13 [INFO] [stderr] | [INFO] [stderr] 433 | tiles: tiles, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tiles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/ubo_tilemap/main.rs:443:13 [INFO] [stderr] | [INFO] [stderr] 443 | tilemap_size: tilemap_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tilemap_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/ubo_tilemap/main.rs:444:13 [INFO] [stderr] | [INFO] [stderr] 444 | charmap_size: charmap_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `charmap_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> examples/gamma/main.rs:157:49 [INFO] [stderr] | [INFO] [stderr] 157 | image::save_buffer(path, &data, w as u32, h as u32, image::ColorType::RGBA(8)) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(w)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> examples/gamma/main.rs:157:59 [INFO] [stderr] | [INFO] [stderr] 157 | image::save_buffer(path, &data, w as u32, h as u32, image::ColorType::RGBA(8)) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> examples/flowmap/main.rs:141:76 [INFO] [stderr] | [INFO] [stderr] 141 | let delta = delta.as_secs() as f32 + delta.subsec_nanos() as f32 / 1000_000_000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/shadow/main.rs:269:13 [INFO] [stderr] | [INFO] [stderr] 269 | near: near, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `near` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/shadow/main.rs:270:13 [INFO] [stderr] | [INFO] [stderr] 270 | far: far, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `far` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/shadow/main.rs:325:9 [INFO] [stderr] | [INFO] [stderr] 325 | out_color: out_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/shadow/main.rs:326:9 [INFO] [stderr] | [INFO] [stderr] 326 | out_depth: out_depth, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/shadow/main.rs:378:13 [INFO] [stderr] | [INFO] [stderr] 378 | near: near, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `near` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/shadow/main.rs:379:13 [INFO] [stderr] | [INFO] [stderr] 379 | far: far, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `far` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/shadow/main.rs:384:9 [INFO] [stderr] | [INFO] [stderr] 384 | shadow_pso: shadow_pso, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shadow_pso` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/shadow/main.rs:385:9 [INFO] [stderr] | [INFO] [stderr] 385 | entities: entities, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `entities` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/shadow/main.rs:389:9 [INFO] [stderr] | [INFO] [stderr] 389 | camera: camera, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `camera` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/shadow/main.rs:390:9 [INFO] [stderr] | [INFO] [stderr] 390 | lights: lights, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `lights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/shadow/main.rs:392:9 [INFO] [stderr] | [INFO] [stderr] 392 | light_buf: light_buf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `light_buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/shadow/main.rs:509:13 [INFO] [stderr] | [INFO] [stderr] 509 | window_targets: window_targets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `window_targets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/shadow/main.rs:510:13 [INFO] [stderr] | [INFO] [stderr] 510 | is_parallel: is_parallel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_parallel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/shadow/main.rs:511:13 [INFO] [stderr] | [INFO] [stderr] 511 | forward_pso: forward_pso, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `forward_pso` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/shadow/main.rs:513:13 [INFO] [stderr] | [INFO] [stderr] 513 | scene: scene, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scene` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/performance/main.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | model.w = Vector4::new(x as f32 * 0.10, [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/performance/main.rs:83:28 [INFO] [stderr] | [INFO] [stderr] 83 | y as f32 * 0.10, [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> examples/performance/main.rs:206:34 [INFO] [stderr] | [INFO] [stderr] 206 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> examples/performance/main.rs:210:30 [INFO] [stderr] | [INFO] [stderr] 210 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> examples/performance/main.rs:217:34 [INFO] [stderr] | [INFO] [stderr] 217 | panic!("{}", str::from_utf8(&buf).ok().expect("ShaderInfoLog not valid utf8")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> examples/performance/main.rs:239:30 [INFO] [stderr] | [INFO] [stderr] 239 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> examples/performance/main.rs:243:26 [INFO] [stderr] | [INFO] [stderr] 243 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> examples/performance/main.rs:250:30 [INFO] [stderr] | [INFO] [stderr] 250 | panic!("{}", str::from_utf8(&buf).ok().expect("ProgramInfoLog not valid utf8")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> examples/performance/main.rs:269:27 [INFO] [stderr] | [INFO] [stderr] 269 | mem::transmute(&VERTEX_DATA[0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&VERTEX_DATA[0] as *const Vertex as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/performance/main.rs:305:37 [INFO] [stderr] | [INFO] [stderr] 305 | (dur.as_secs() * 1000) as f64 + dur.subsec_nanos() as f64 / 1000_000.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(dur.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> examples/performance/main.rs:320:40 [INFO] [stderr] | [INFO] [stderr] 320 | let mat:Matrix4 = transform(x, y, proj_view).into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `transform(x, y, proj_view)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/performance/main.rs:359:9 [INFO] [stderr] | [INFO] [stderr] 359 | let ref mut args = env::args(); [INFO] [stderr] | ----^^^^^^^^^^^^--------------- help: try: `let args = &mut env::args();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/performance/main.rs:380:18 [INFO] [stderr] | [INFO] [stderr] 380 | let count = ((count as f64).sqrt() / 2.) as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/instancing/main.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | translate: translate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `translate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/instancing/main.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/instancing/main.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | upload: upload, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `upload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/particle/main.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/particle/main.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | particles: particles, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `particles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/particle/main.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | aspect: aspect, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `aspect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/skybox/main.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/deferred/main.rs:156:5 [INFO] [stderr] | [INFO] [stderr] 156 | return normal.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `normal.into()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> examples/deferred/main.rs:478:79 [INFO] [stderr] | [INFO] [stderr] 478 | let time = elapsed.as_secs() as f32 + elapsed.subsec_nanos() as f32 / 1000_000_000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> examples/terrain_tessellated/main.rs:159:79 [INFO] [stderr] | [INFO] [stderr] 159 | let time = elapsed.as_secs() as f32 + elapsed.subsec_nanos() as f32 / 1000_000_000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> examples/render_target/main.rs:313:84 [INFO] [stderr] | [INFO] [stderr] 313 | let time = (elapsed.as_secs() as f32 + elapsed.subsec_nanos() as f32 / 1000_000_000.0) * [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> examples/shadow/main.rs:260:19 [INFO] [stderr] | [INFO] [stderr] 260 | position: desc.pos.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `desc.pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> examples/shadow/main.rs:272:16 [INFO] [stderr] | [INFO] [stderr] 272 | color: desc.color.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `desc.color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> examples/shadow/main.rs:340:19 [INFO] [stderr] | [INFO] [stderr] 340 | disp: desc.offset.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `desc.offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> examples/render_target/main.rs:100:6 [INFO] [stderr] | [INFO] [stderr] 100 | ) -> Result< [INFO] [stderr] | ______^ [INFO] [stderr] 101 | | (handle::ShaderResourceView, handle::DepthStencilView), [INFO] [stderr] 102 | | gfx::CombinedError, [INFO] [stderr] 103 | | > [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> examples/deferred/main.rs:195:23 [INFO] [stderr] | [INFO] [stderr] 195 | -> (ViewPair, ViewPair, ViewPair, [INFO] [stderr] | _______________________^ [INFO] [stderr] 196 | | gfx::handle::ShaderResourceView, gfx::handle::DepthStencilView) [INFO] [stderr] | |_____________________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/deferred/main.rs:493:22 [INFO] [stderr] | [INFO] [stderr] 493 | let aspect = width as f32 / height as f32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/deferred/main.rs:493:37 [INFO] [stderr] | [INFO] [stderr] 493 | let aspect = width as f32 / height as f32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> examples/particle/main.rs:154:76 [INFO] [stderr] | [INFO] [stderr] 154 | let delta = delta.as_secs() as f32 + delta.subsec_nanos() as f32 / 1000_000_000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/particle/main.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | let aspect = (height as f32)/(width as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(height)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/particle/main.rs:85:38 [INFO] [stderr] | [INFO] [stderr] 85 | let aspect = (height as f32)/(width as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> examples/skybox/main.rs:154:84 [INFO] [stderr] | [INFO] [stderr] 154 | let time = (elapsed.as_secs() as f32 + elapsed.subsec_nanos() as f32 / 1000_000_000.0) * 0.25; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: the variable `charmap_ypos` is used as a loop counter. Consider using `for (charmap_ypos, item) in self.focus_coords[1] .. self.focus_coords[1]+self.charmap_size[1].enumerate()` or similar iterators [INFO] [stderr] --> examples/ubo_tilemap/main.rs:278:25 [INFO] [stderr] | [INFO] [stderr] 278 | for ypos in self.focus_coords[1] .. self.focus_coords[1]+self.charmap_size[1] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `charmap_xpos` is used as a loop counter. Consider using `for (charmap_xpos, item) in self.focus_coords[0] .. self.focus_coords[0]+self.charmap_size[0].enumerate()` or similar iterators [INFO] [stderr] --> examples/ubo_tilemap/main.rs:280:29 [INFO] [stderr] | [INFO] [stderr] 280 | for xpos in self.focus_coords[0] .. self.focus_coords[0]+self.charmap_size[0] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> examples/ubo_tilemap/main.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | new_offset = new_offset - self.tile_size as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_offset -= self.tile_size as f32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> examples/ubo_tilemap/main.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | new_offset = new_offset - self.tile_size as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_offset -= self.tile_size as f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> examples/skybox/main.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | fn as_array(self) -> [&'a [u8]; 6] { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 26s [INFO] running `"docker" "inspect" "b404a0fcc1541dc32ebf932b054b52817136b1caaaf0b64cbdfd88704c0a324d"` [INFO] running `"docker" "rm" "-f" "b404a0fcc1541dc32ebf932b054b52817136b1caaaf0b64cbdfd88704c0a324d"` [INFO] [stdout] b404a0fcc1541dc32ebf932b054b52817136b1caaaf0b64cbdfd88704c0a324d