[INFO] crate gfx 0.17.1 is already in cache [INFO] extracting crate gfx 0.17.1 into work/ex/clippy-test-run/sources/stable/reg/gfx/0.17.1 [INFO] extracting crate gfx 0.17.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gfx/0.17.1 [INFO] validating manifest of gfx-0.17.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gfx-0.17.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gfx-0.17.1 [INFO] finished frobbing gfx-0.17.1 [INFO] frobbed toml for gfx-0.17.1 written to work/ex/clippy-test-run/sources/stable/reg/gfx/0.17.1/Cargo.toml [INFO] started frobbing gfx-0.17.1 [INFO] finished frobbing gfx-0.17.1 [INFO] frobbed toml for gfx-0.17.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gfx/0.17.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gfx-0.17.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gfx/0.17.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3233bc16966fdf2d7840756702a6abc8e86ec450fbb6f1c9c98cc96286c2b93c [INFO] running `"docker" "start" "-a" "3233bc16966fdf2d7840756702a6abc8e86ec450fbb6f1c9c98cc96286c2b93c"` [INFO] [stderr] Checking gfx v0.17.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pso/bundle.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pso/bundle.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | pso: pso, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pso` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pso/bundle.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pso/mod.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | shader_offset: shader_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shader_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pso/mod.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | code_offset: code_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `code_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pso/mod.rs:161:17 [INFO] [stderr] | [INFO] [stderr] 161 | shader_format: shader_format, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shader_format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pso/mod.rs:162:17 [INFO] [stderr] | [INFO] [stderr] 162 | code_format: code_format, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `code_format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pso/bundle.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pso/bundle.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | pso: pso, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pso` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pso/bundle.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pso/mod.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | shader_offset: shader_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shader_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pso/mod.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | code_offset: code_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `code_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pso/mod.rs:161:17 [INFO] [stderr] | [INFO] [stderr] 161 | shader_format: shader_format, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shader_format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pso/mod.rs:162:17 [INFO] [stderr] | [INFO] [stderr] 162 | code_format: code_format, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `code_format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/encoder.rs:513:22 [INFO] [stderr] | [INFO] [stderr] 513 | let target = self.handles.ref_rtv(view.raw()).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.handles.ref_rtv(view.raw())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/encoder.rs:561:19 [INFO] [stderr] | [INFO] [stderr] 561 | let srv = self.handles.ref_srv(view).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.handles.ref_srv(view)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/factory.rs:242:43 [INFO] [stderr] | [INFO] [stderr] 242 | self.create_program(&set).map_err(|e| ProgramError::Link(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ProgramError::Link` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/factory.rs:251:65 [INFO] [stderr] | [INFO] [stderr] 251 | let program = try!(self.create_program(shaders).map_err(|e| ProgramError::Link(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ProgramError::Link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slice.rs:105:39 [INFO] [stderr] | [INFO] [stderr] 105 | p::PatchList(num) => nv / (num as u32), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/encoder.rs:513:22 [INFO] [stderr] | [INFO] [stderr] 513 | let target = self.handles.ref_rtv(view.raw()).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.handles.ref_rtv(view.raw())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/pso/buffer.rs:232:32 [INFO] [stderr] | [INFO] [stderr] 232 | init.0.iter().find(|x| x.0 == &at.name) [INFO] [stderr] | ^^^^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `at.name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/pso/buffer.rs:244:27 [INFO] [stderr] | [INFO] [stderr] 244 | let value = Some((man.ref_buffer(data).clone(), 0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*man.ref_buffer(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/encoder.rs:561:19 [INFO] [stderr] | [INFO] [stderr] 561 | let srv = self.handles.ref_srv(view).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.handles.ref_srv(view)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/pso/buffer.rs:326:23 [INFO] [stderr] | [INFO] [stderr] 326 | let buf = man.ref_buffer(data).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*man.ref_buffer(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/factory.rs:242:43 [INFO] [stderr] | [INFO] [stderr] 242 | self.create_program(&set).map_err(|e| ProgramError::Link(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ProgramError::Link` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/factory.rs:251:65 [INFO] [stderr] | [INFO] [stderr] 251 | let program = try!(self.create_program(shaders).map_err(|e| ProgramError::Link(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ProgramError::Link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/pso/resource.rs:129:24 [INFO] [stderr] | [INFO] [stderr] 129 | let view = man.ref_srv(data).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*man.ref_srv(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/pso/resource.rs:163:25 [INFO] [stderr] | [INFO] [stderr] 163 | let view = man.ref_uav(data.raw()).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*man.ref_uav(data.raw())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/pso/resource.rs:196:22 [INFO] [stderr] | [INFO] [stderr] 196 | let sm = man.ref_sampler(data).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*man.ref_sampler(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slice.rs:105:39 [INFO] [stderr] | [INFO] [stderr] 105 | p::PatchList(num) => nv / (num as u32), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/pso/target.rs:171:35 [INFO] [stderr] | [INFO] [stderr] 171 | if out.name.is_empty() || &out.name == init.0 { [INFO] [stderr] | ---------^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `out.name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/pso/buffer.rs:232:32 [INFO] [stderr] | [INFO] [stderr] 232 | init.0.iter().find(|x| x.0 == &at.name) [INFO] [stderr] | ^^^^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `at.name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/pso/buffer.rs:244:27 [INFO] [stderr] | [INFO] [stderr] 244 | let value = Some((man.ref_buffer(data).clone(), 0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*man.ref_buffer(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/pso/buffer.rs:326:23 [INFO] [stderr] | [INFO] [stderr] 326 | let buf = man.ref_buffer(data).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*man.ref_buffer(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `pso::RawDataSet` [INFO] [stderr] --> src/pso/mod.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / pub fn new() -> RawDataSet { [INFO] [stderr] 76 | | RawDataSet { [INFO] [stderr] 77 | | vertex_buffers: c::pso::VertexBufferSet::new(), [INFO] [stderr] 78 | | constant_buffers: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 73 | impl Default for pso::RawDataSet { [INFO] [stderr] 74 | fn default() -> Self { [INFO] [stderr] 75 | Self::new() [INFO] [stderr] 76 | } [INFO] [stderr] 77 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/pso/resource.rs:129:24 [INFO] [stderr] | [INFO] [stderr] 129 | let view = man.ref_srv(data).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*man.ref_srv(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/pso/resource.rs:163:25 [INFO] [stderr] | [INFO] [stderr] 163 | let view = man.ref_uav(data.raw()).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*man.ref_uav(data.raw())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/pso/resource.rs:196:22 [INFO] [stderr] | [INFO] [stderr] 196 | let sm = man.ref_sampler(data).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*man.ref_sampler(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/pso/target.rs:171:35 [INFO] [stderr] | [INFO] [stderr] 171 | if out.name.is_empty() || &out.name == init.0 { [INFO] [stderr] | ---------^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `out.name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `pso::RawDataSet` [INFO] [stderr] --> src/pso/mod.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / pub fn new() -> RawDataSet { [INFO] [stderr] 76 | | RawDataSet { [INFO] [stderr] 77 | | vertex_buffers: c::pso::VertexBufferSet::new(), [INFO] [stderr] 78 | | constant_buffers: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 73 | impl Default for pso::RawDataSet { [INFO] [stderr] 74 | fn default() -> Self { [INFO] [stderr] 75 | Self::new() [INFO] [stderr] 76 | } [INFO] [stderr] 77 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.21s [INFO] running `"docker" "inspect" "3233bc16966fdf2d7840756702a6abc8e86ec450fbb6f1c9c98cc96286c2b93c"` [INFO] running `"docker" "rm" "-f" "3233bc16966fdf2d7840756702a6abc8e86ec450fbb6f1c9c98cc96286c2b93c"` [INFO] [stdout] 3233bc16966fdf2d7840756702a6abc8e86ec450fbb6f1c9c98cc96286c2b93c