[INFO] crate gfwx 0.1.0 is already in cache [INFO] extracting crate gfwx 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/gfwx/0.1.0 [INFO] extracting crate gfwx 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gfwx/0.1.0 [INFO] validating manifest of gfwx-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gfwx-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gfwx-0.1.0 [INFO] finished frobbing gfwx-0.1.0 [INFO] frobbed toml for gfwx-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/gfwx/0.1.0/Cargo.toml [INFO] started frobbing gfwx-0.1.0 [INFO] finished frobbing gfwx-0.1.0 [INFO] frobbed toml for gfwx-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gfwx/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gfwx-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gfwx/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dc25e1fccbd78cf01b6f69635b02bbc61786a401c4e2c8b53fe370c0440037d3 [INFO] running `"docker" "start" "-a" "dc25e1fccbd78cf01b6f69635b02bbc61786a401c4e2c8b53fe370c0440037d3"` [INFO] [stderr] Checking criterion-plot v0.3.0 [INFO] [stderr] Checking rand_xoshiro v0.1.0 [INFO] [stderr] Checking gfwx v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/color_transform/mod.rs:560:17 [INFO] [stderr] | [INFO] [stderr] 560 | let d = u as i32 - 128; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/color_transform/mod.rs:561:17 [INFO] [stderr] | [INFO] [stderr] 561 | let e = v as i32 - 128; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] Checking criterion v0.2.9 [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return &DEFAULT_MULTITHREADING_FACTORS; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&DEFAULT_MULTITHREADING_FACTORS` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/header/mod.rs:79:38 [INFO] [stderr] | [INFO] [stderr] 79 | let quality = ((tmp >> 13) & 0b1111111111) as u16 + 1; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b11_1111_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lifting/cubic.rs:287:5 [INFO] [stderr] | [INFO] [stderr] 287 | return b; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `color_transform::ChannelTransformBuilder` [INFO] [stderr] --> src/color_transform/mod.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> ChannelTransformBuilder { [INFO] [stderr] 34 | | ChannelTransformBuilder { [INFO] [stderr] 35 | | dest_channel: None, [INFO] [stderr] 36 | | channel_factors: vec![], [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `color_transform::ColorTransformProgram` [INFO] [stderr] --> src/color_transform/mod.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | / pub fn new() -> Self { [INFO] [stderr] 89 | | ColorTransformProgram { [INFO] [stderr] 90 | | channel_transforms: vec![], [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 83 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/color_transform/mod.rs:267:43 [INFO] [stderr] | [INFO] [stderr] 267 | .any(|c| c.denominator > 1 || c.channel_factors.len() != 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!c.channel_factors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/color_transform/mod.rs:270:5 [INFO] [stderr] | [INFO] [stderr] 270 | / pub fn iter<'a>(&'a self) -> impl DoubleEndedIterator { [INFO] [stderr] 271 | | self.channel_transforms.iter() [INFO] [stderr] 272 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/color_transform/mod.rs:327:47 [INFO] [stderr] | [INFO] [stderr] 327 | aux[dest_base + i] += image[layer + i * channels] as i16 * boosted_factor; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(image[layer + i * channels])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/color_transform/mod.rs:336:39 [INFO] [stderr] | [INFO] [stderr] 336 | aux[dest_base + i] += image[layer + i * header.channels as usize] as i16 * boost; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(image[layer + i * header.channels as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/color_transform/mod.rs:347:42 [INFO] [stderr] | [INFO] [stderr] 347 | aux[dest_base + i] = image[layer + i * channels] as i16 * boost; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(image[layer + i * channels])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/color_transform/mod.rs:375:47 [INFO] [stderr] | [INFO] [stderr] 375 | aux[dest_base + i] += image[channel_factor.src_channel * channel_size + i] [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 376 | | as i16 [INFO] [stderr] | |__________________________________^ help: try: `i16::from(image[channel_factor.src_channel * channel_size + i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/color_transform/mod.rs:384:39 [INFO] [stderr] | [INFO] [stderr] 384 | aux[dest_base + i] += image[dest_base + i] as i16 * boost; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(image[dest_base + i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/color_transform/mod.rs:394:42 [INFO] [stderr] | [INFO] [stderr] 394 | aux[dest_base + i] = image[dest_base + i] as i16 * boost; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(image[dest_base + i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/color_transform/mod.rs:436:26 [INFO] [stderr] | [INFO] [stderr] 436 | .min(u8::MAX as i16) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i16::from(u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/color_transform/mod.rs:437:26 [INFO] [stderr] | [INFO] [stderr] 437 | .max(u8::MIN as i16) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i16::from(u8::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/color_transform/mod.rs:474:40 [INFO] [stderr] | [INFO] [stderr] 474 | *dest = (*src / boost).min(u8::MAX as i16).max(u8::MIN as i16) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i16::from(u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/color_transform/mod.rs:474:60 [INFO] [stderr] | [INFO] [stderr] 474 | *dest = (*src / boost).min(u8::MAX as i16).max(u8::MIN as i16) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i16::from(u8::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/color_transform/mod.rs:479:43 [INFO] [stderr] | [INFO] [stderr] 479 | pub fn yuv420_to_sequential_yuv444(image: &Vec, width: usize, height: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/color_transform/mod.rs:504:43 [INFO] [stderr] | [INFO] [stderr] 504 | pub fn sequential_yuv444_to_yuv420(image: &Vec, width: usize, height: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/color_transform/mod.rs:529:32 [INFO] [stderr] | [INFO] [stderr] 529 | pub fn rgba32_to_yuv420(image: &Vec, width: usize, height: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/color_transform/mod.rs:536:21 [INFO] [stderr] | [INFO] [stderr] 536 | let r = image[4 * j * width + 4 * i] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(image[4 * j * width + 4 * i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/color_transform/mod.rs:537:21 [INFO] [stderr] | [INFO] [stderr] 537 | let g = image[4 * j * width + 4 * i + 1] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(image[4 * j * width + 4 * i + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/color_transform/mod.rs:538:21 [INFO] [stderr] | [INFO] [stderr] 538 | let b = image[4 * j * width + 4 * i + 2] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(image[4 * j * width + 4 * i + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/color_transform/mod.rs:551:32 [INFO] [stderr] | [INFO] [stderr] 551 | pub fn yuv420_to_rgba32(image: &Vec, width: usize, height: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/color_transform/mod.rs:559:21 [INFO] [stderr] | [INFO] [stderr] 559 | let c = y as i32 - 16; [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/color_transform/mod.rs:560:21 [INFO] [stderr] | [INFO] [stderr] 560 | let d = u as i32 - 128; [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(u)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/color_transform/mod.rs:561:21 [INFO] [stderr] | [INFO] [stderr] 561 | let e = v as i32 - 128; [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/color_transform/mod.rs:571:28 [INFO] [stderr] | [INFO] [stderr] 571 | fn reduce_chroma(comonent: &Vec, width: usize, height: usize, result: &mut Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/compress/mod.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | buffer.write(metadata)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: The function/method `decompress_image_data` doesn't need a mutable reference [INFO] [stderr] --> src/compress/mod.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | &mut data, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:210:15 [INFO] [stderr] | [INFO] [stderr] 210 | .max((header.quality as i32 + header.chroma_scale as i32 / 2) / header.chroma_scale as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(header.quality)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:210:39 [INFO] [stderr] | [INFO] [stderr] 210 | .max((header.quality as i32 + header.chroma_scale as i32 / 2) / header.chroma_scale as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(header.chroma_scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:210:73 [INFO] [stderr] | [INFO] [stderr] 210 | .max((header.quality as i32 + header.chroma_scale as i32 / 2) / header.chroma_scale as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(header.chroma_scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:225:17 [INFO] [stderr] | [INFO] [stderr] 225 | header.quality as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(header.quality)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:228:48 [INFO] [stderr] | [INFO] [stderr] 228 | quant::quantize(image, quality, 0, header::QUALITY_MAX as i32 * boost as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(header::QUALITY_MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:228:77 [INFO] [stderr] | [INFO] [stderr] 228 | quant::quantize(image, quality, 0, header::QUALITY_MAX as i32 * boost as i32); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(boost)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:241:15 [INFO] [stderr] | [INFO] [stderr] 241 | .max((header.quality as i32 + header.chroma_scale as i32 / 2) / header.chroma_scale as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(header.quality)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:241:39 [INFO] [stderr] | [INFO] [stderr] 241 | .max((header.quality as i32 + header.chroma_scale as i32 / 2) / header.chroma_scale as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(header.chroma_scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:241:73 [INFO] [stderr] | [INFO] [stderr] 241 | .max((header.quality as i32 + header.chroma_scale as i32 / 2) / header.chroma_scale as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(header.chroma_scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:255:17 [INFO] [stderr] | [INFO] [stderr] 255 | header.quality as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(header.quality)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:261:17 [INFO] [stderr] | [INFO] [stderr] 261 | header::QUALITY_MAX as i32 * boost as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(header::QUALITY_MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:261:46 [INFO] [stderr] | [INFO] [stderr] 261 | header::QUALITY_MAX as i32 * boost as i32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(boost)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:278:33 [INFO] [stderr] | [INFO] [stderr] 278 | 1.max((header.quality + (header.chroma_scale / 2) as u16) / header.chroma_scale as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(header.chroma_scale / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:278:69 [INFO] [stderr] | [INFO] [stderr] 278 | 1.max((header.quality + (header.chroma_scale / 2) as u16) / header.chroma_scale as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(header.chroma_scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:336:25 [INFO] [stderr] | [INFO] [stderr] 336 | chroma_quality as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(chroma_quality)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:338:25 [INFO] [stderr] | [INFO] [stderr] 338 | header.quality as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(header.quality)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:407:15 [INFO] [stderr] | [INFO] [stderr] 407 | .max((header.quality as i32 + header.chroma_scale as i32 / 2) / header.chroma_scale as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(header.quality)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:407:39 [INFO] [stderr] | [INFO] [stderr] 407 | .max((header.quality as i32 + header.chroma_scale as i32 / 2) / header.chroma_scale as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(header.chroma_scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:407:73 [INFO] [stderr] | [INFO] [stderr] 407 | .max((header.quality as i32 + header.chroma_scale as i32 / 2) / header.chroma_scale as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(header.chroma_scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:430:46 [INFO] [stderr] | [INFO] [stderr] 430 | (block_count_x * block_count_y * header.layers as u32 * header.channels as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header.layers)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:430:69 [INFO] [stderr] | [INFO] [stderr] 430 | (block_count_x * block_count_y * header.layers as u32 * header.channels as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header.channels)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/compress/mod.rs:501:25 [INFO] [stderr] | [INFO] [stderr] 501 | header.quality as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(header.quality)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_context` doesn't need a mutable reference [INFO] [stderr] --> src/encode/mod.rs:451:51 [INFO] [stderr] | [INFO] [stderr] 451 | context = get_context(&mut image, x as i32, y as i32); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/header/mod.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Clone, Copy, Debug, PartialEq, ToPrimitive, FromPrimitive)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/header/mod.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Clone, Copy, Debug, PartialEq, ToPrimitive, FromPrimitive)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/header/mod.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Clone, Copy, Debug, PartialEq, ToPrimitive, FromPrimitive)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/header/mod.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Clone, Copy, Debug, PartialEq, ToPrimitive, FromPrimitive)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/header/mod.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | #[derive(Clone, Copy, Debug, PartialEq, ToPrimitive, FromPrimitive)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/header/mod.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | #[derive(Clone, Copy, Debug, PartialEq, ToPrimitive, FromPrimitive)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/header/mod.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Clone, Copy, Debug, PartialEq, ToPrimitive, FromPrimitive)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/header/mod.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Clone, Copy, Debug, PartialEq, ToPrimitive, FromPrimitive)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `tmp` [INFO] [stderr] --> src/header/mod.rs:77:27 [INFO] [stderr] | [INFO] [stderr] 77 | let block_size = ((tmp >> 0) & 0b11111) as u8 + 2; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/header/mod.rs:116:20 [INFO] [stderr] | [INFO] [stderr] 116 | let tmp = (self.block_size as u32 - 2) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.block_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/header/mod.rs:117:17 [INFO] [stderr] | [INFO] [stderr] 117 | | ((self.chroma_scale as u32 - 1) << 5) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chroma_scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/header/mod.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | | ((self.quality as u32 - 1) << 13) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.quality)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/header/mod.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | let part1 = self.width as f64 * self.height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/header/mod.rs:132:41 [INFO] [stderr] | [INFO] [stderr] 132 | let part1 = self.width as f64 * self.height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/header/mod.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | let part2 = self.channels as f64 * self.layers as f64 * ((self.bit_depth + 7) / 8) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.channels)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/header/mod.rs:133:44 [INFO] [stderr] | [INFO] [stderr] 133 | let part2 = self.channels as f64 * self.layers as f64 * ((self.bit_depth + 7) / 8) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.layers)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/header/mod.rs:133:65 [INFO] [stderr] | [INFO] [stderr] 133 | let part2 = self.channels as f64 * self.layers as f64 * ((self.bit_depth + 7) / 8) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((self.bit_depth + 7) / 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/processing/double_overlapping_chunks_iterator.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | type Item = (&'a [T], &'a [T], &'a mut [T], &'a [T], &'a [T]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/processing/double_overlapping_chunks_iterator.rs:69:12 [INFO] [stderr] | [INFO] [stderr] 69 | if self.middle.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.middle.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/processing/double_overlapping_chunks_iterator.rs:76:12 [INFO] [stderr] | [INFO] [stderr] 76 | if self.remainder.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.remainder.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/processing/overlapping_chunks_iterator.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | if self.remainder.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.remainder.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/processing/image.rs:56:37 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn next_chunk(&mut self) -> Option<((usize, usize), (usize, usize), usize)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/lifting/cubic.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | image.into_iter().step_by(step), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/lifting/cubic.rs:42:23 [INFO] [stderr] | [INFO] [stderr] 42 | image.into_iter().step_by(step), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lifting/cubic.rs:299:16 [INFO] [stderr] | [INFO] [stderr] 299 | let num = -(c0 as i32) + 9 * (c1 as i32 + c2 as i32) - c3 as i32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(c0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lifting/cubic.rs:299:35 [INFO] [stderr] | [INFO] [stderr] 299 | let num = -(c0 as i32) + 9 * (c1 as i32 + c2 as i32) - c3 as i32; [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(c1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lifting/cubic.rs:299:47 [INFO] [stderr] | [INFO] [stderr] 299 | let num = -(c0 as i32) + 9 * (c1 as i32 + c2 as i32) - c3 as i32; [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(c2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lifting/cubic.rs:299:60 [INFO] [stderr] | [INFO] [stderr] 299 | let num = -(c0 as i32) + 9 * (c1 as i32 + c2 as i32) - c3 as i32; [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(c3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/lifting/linear.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | image.into_iter().step_by(step), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/lifting/linear.rs:42:23 [INFO] [stderr] | [INFO] [stderr] 42 | image.into_iter().step_by(step), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/quant/mod.rs:20:19 [INFO] [stderr] | [INFO] [stderr] 20 | image.into_iter().enumerate().step_by(skip), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/quant/mod.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/quant/mod.rs:27:41 [INFO] [stderr] | [INFO] [stderr] 27 | .for_each(|x| *x = ((*x as i32) * q / max_quality) as i16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(*x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/quant/mod.rs:50:19 [INFO] [stderr] | [INFO] [stderr] 50 | image.into_iter().enumerate().step_by(skip), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/quant/mod.rs:54:22 [INFO] [stderr] | [INFO] [stderr] 54 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/quant/mod.rs:59:31 [INFO] [stderr] | [INFO] [stderr] 59 | (((*x as i32) * max_quality - (max_quality / 2)) / q) as i16 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(*x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/quant/mod.rs:61:31 [INFO] [stderr] | [INFO] [stderr] 61 | (((*x as i32) * max_quality + (max_quality / 2)) / q) as i16 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(*x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/quant/mod.rs:63:30 [INFO] [stderr] | [INFO] [stderr] 63 | ((*x as i32) * max_quality / q) as i16 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(*x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 9 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `gfwx`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "dc25e1fccbd78cf01b6f69635b02bbc61786a401c4e2c8b53fe370c0440037d3"` [INFO] running `"docker" "rm" "-f" "dc25e1fccbd78cf01b6f69635b02bbc61786a401c4e2c8b53fe370c0440037d3"` [INFO] [stdout] dc25e1fccbd78cf01b6f69635b02bbc61786a401c4e2c8b53fe370c0440037d3