[INFO] crate getch 0.2.0 is already in cache [INFO] extracting crate getch 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/getch/0.2.0 [INFO] extracting crate getch 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/getch/0.2.0 [INFO] validating manifest of getch-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of getch-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing getch-0.2.0 [INFO] finished frobbing getch-0.2.0 [INFO] frobbed toml for getch-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/getch/0.2.0/Cargo.toml [INFO] started frobbing getch-0.2.0 [INFO] finished frobbing getch-0.2.0 [INFO] frobbed toml for getch-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/getch/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting getch-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/getch/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4f7077c08fd229fea680e1b77e40572523d4abd14234fc370fea8d86dc779092 [INFO] running `"docker" "start" "-a" "4f7077c08fd229fea680e1b77e40572523d4abd14234fc370fea8d86dc779092"` [INFO] [stderr] Checking getch v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:65:18 [INFO] [stderr] | [INFO] [stderr] 65 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 66 | | if r[0]==27 { [INFO] [stderr] 67 | | if try!(stdin.read(&mut r[..])) == 0 { return Ok(0) } [INFO] [stderr] 68 | | else { [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 65 | else if r[0]==27 { [INFO] [stderr] 66 | if try!(stdin.read(&mut r[..])) == 0 { return Ok(0) } [INFO] [stderr] 67 | else { [INFO] [stderr] 68 | if r[0]==91 { [INFO] [stderr] 69 | if try!(stdin.read(&mut r[..])) == 0 { return Ok(0) } [INFO] [stderr] 70 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:68:26 [INFO] [stderr] | [INFO] [stderr] 68 | else { [INFO] [stderr] | __________________________^ [INFO] [stderr] 69 | | if r[0]==91 { [INFO] [stderr] 70 | | if try!(stdin.read(&mut r[..])) == 0 { return Ok(0) } [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 68 | else if r[0]==91 { [INFO] [stderr] 69 | if try!(stdin.read(&mut r[..])) == 0 { return Ok(0) } [INFO] [stderr] 70 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:69:25 [INFO] [stderr] | [INFO] [stderr] 69 | / if r[0]==91 { [INFO] [stderr] 70 | | if try!(stdin.read(&mut r[..])) == 0 { return Ok(0) } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________________________^ help: try: `if r[0]==91 && try!(stdin.read(&mut r[..])) == 0 { return Ok(0) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Getch` [INFO] [stderr] --> src/lib.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new() -> Getch { [INFO] [stderr] 33 | | if let Ok(mut termios) = termios::Termios::from_fd(0) { [INFO] [stderr] 34 | | let c_lflag = termios.c_lflag; [INFO] [stderr] 35 | | termios.c_lflag &= !(ICANON|ECHO); [INFO] [stderr] ... | [INFO] [stderr] 42 | | Getch::None [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | impl Default for Getch { [INFO] [stderr] 27 | fn default() -> Self { [INFO] [stderr] 28 | Self::new() [INFO] [stderr] 29 | } [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:65:18 [INFO] [stderr] | [INFO] [stderr] 65 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 66 | | if r[0]==27 { [INFO] [stderr] 67 | | if try!(stdin.read(&mut r[..])) == 0 { return Ok(0) } [INFO] [stderr] 68 | | else { [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 65 | else if r[0]==27 { [INFO] [stderr] 66 | if try!(stdin.read(&mut r[..])) == 0 { return Ok(0) } [INFO] [stderr] 67 | else { [INFO] [stderr] 68 | if r[0]==91 { [INFO] [stderr] 69 | if try!(stdin.read(&mut r[..])) == 0 { return Ok(0) } [INFO] [stderr] 70 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:68:26 [INFO] [stderr] | [INFO] [stderr] 68 | else { [INFO] [stderr] | __________________________^ [INFO] [stderr] 69 | | if r[0]==91 { [INFO] [stderr] 70 | | if try!(stdin.read(&mut r[..])) == 0 { return Ok(0) } [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 68 | else if r[0]==91 { [INFO] [stderr] 69 | if try!(stdin.read(&mut r[..])) == 0 { return Ok(0) } [INFO] [stderr] 70 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:69:25 [INFO] [stderr] | [INFO] [stderr] 69 | / if r[0]==91 { [INFO] [stderr] 70 | | if try!(stdin.read(&mut r[..])) == 0 { return Ok(0) } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________________________^ help: try: `if r[0]==91 && try!(stdin.read(&mut r[..])) == 0 { return Ok(0) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Getch` [INFO] [stderr] --> src/lib.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new() -> Getch { [INFO] [stderr] 33 | | if let Ok(mut termios) = termios::Termios::from_fd(0) { [INFO] [stderr] 34 | | let c_lflag = termios.c_lflag; [INFO] [stderr] 35 | | termios.c_lflag &= !(ICANON|ECHO); [INFO] [stderr] ... | [INFO] [stderr] 42 | | Getch::None [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | impl Default for Getch { [INFO] [stderr] 27 | fn default() -> Self { [INFO] [stderr] 28 | Self::new() [INFO] [stderr] 29 | } [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.17s [INFO] running `"docker" "inspect" "4f7077c08fd229fea680e1b77e40572523d4abd14234fc370fea8d86dc779092"` [INFO] running `"docker" "rm" "-f" "4f7077c08fd229fea680e1b77e40572523d4abd14234fc370fea8d86dc779092"` [INFO] [stdout] 4f7077c08fd229fea680e1b77e40572523d4abd14234fc370fea8d86dc779092