[INFO] crate gerber-types 0.1.1 is already in cache [INFO] extracting crate gerber-types 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/gerber-types/0.1.1 [INFO] extracting crate gerber-types 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gerber-types/0.1.1 [INFO] validating manifest of gerber-types-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gerber-types-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gerber-types-0.1.1 [INFO] finished frobbing gerber-types-0.1.1 [INFO] frobbed toml for gerber-types-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/gerber-types/0.1.1/Cargo.toml [INFO] started frobbing gerber-types-0.1.1 [INFO] finished frobbing gerber-types-0.1.1 [INFO] frobbed toml for gerber-types-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gerber-types/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gerber-types-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gerber-types/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 64f3f862aa6381ec6c6f3b01fe46cebeed68f806c0066998997fa9e67d16a5a9 [INFO] running `"docker" "start" "-a" "64f3f862aa6381ec6c6f3b01fe46cebeed68f806c0066998997fa9e67d16a5a9"` [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking gerber-types v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:26:61 [INFO] [stderr] | [INFO] [stderr] 26 | Coordinates { x: Some(x.into()), y: Some(y.into()), format: format } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:30:51 [INFO] [stderr] | [INFO] [stderr] 30 | Coordinates { x: Some(x.into()), y: None, format: format } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:34:51 [INFO] [stderr] | [INFO] [stderr] 34 | Coordinates { x: None, y: Some(y.into()), format: format } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:50:66 [INFO] [stderr] | [INFO] [stderr] 50 | CoordinateOffset { x: Some(x.into()), y: Some(y.into()), format: format } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:54:56 [INFO] [stderr] | [INFO] [stderr] 54 | CoordinateOffset { x: Some(x.into()), y: None, format: format } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:58:56 [INFO] [stderr] | [INFO] [stderr] 58 | CoordinateOffset { x: None, y: Some(y.into()), format: format } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/macros.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/codegen.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/coordinates.rs:26:28 [INFO] [stderr] | [INFO] [stderr] 26 | CoordinateFormat { integer: integer, decimal: decimal } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `integer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/coordinates.rs:26:46 [INFO] [stderr] | [INFO] [stderr] 26 | CoordinateFormat { integer: integer, decimal: decimal } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `decimal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:26:61 [INFO] [stderr] | [INFO] [stderr] 26 | Coordinates { x: Some(x.into()), y: Some(y.into()), format: format } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:30:51 [INFO] [stderr] | [INFO] [stderr] 30 | Coordinates { x: Some(x.into()), y: None, format: format } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:34:51 [INFO] [stderr] | [INFO] [stderr] 34 | Coordinates { x: None, y: Some(y.into()), format: format } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:50:66 [INFO] [stderr] | [INFO] [stderr] 50 | CoordinateOffset { x: Some(x.into()), y: Some(y.into()), format: format } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:54:56 [INFO] [stderr] | [INFO] [stderr] 54 | CoordinateOffset { x: Some(x.into()), y: None, format: format } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:58:56 [INFO] [stderr] | [INFO] [stderr] 58 | CoordinateOffset { x: None, y: Some(y.into()), format: format } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/macros.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/codegen.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | write!(writer, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/coordinates.rs:26:28 [INFO] [stderr] | [INFO] [stderr] 26 | CoordinateFormat { integer: integer, decimal: decimal } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `integer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/coordinates.rs:26:46 [INFO] [stderr] | [INFO] [stderr] 26 | CoordinateFormat { integer: integer, decimal: decimal } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `decimal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coordinates.rs:116:42 [INFO] [stderr] | [INFO] [stderr] 116 | let a = CoordinateNumber { nano: 13000000 }; [INFO] [stderr] | ^^^^^^^^ help: consider: `13_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coordinates.rs:120:43 [INFO] [stderr] | [INFO] [stderr] 120 | let c = CoordinateNumber { nano: -99000000 }; [INFO] [stderr] | ^^^^^^^^ help: consider: `99_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coordinates.rs:128:42 [INFO] [stderr] | [INFO] [stderr] 128 | let a = CoordinateNumber { nano: 13000000 }; [INFO] [stderr] | ^^^^^^^^ help: consider: `13_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coordinates.rs:132:43 [INFO] [stderr] | [INFO] [stderr] 132 | let c = CoordinateNumber { nano: -998000000 }; [INFO] [stderr] | ^^^^^^^^^ help: consider: `998_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coordinates.rs:140:42 [INFO] [stderr] | [INFO] [stderr] 140 | let a = CoordinateNumber { nano: 1375000i64 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_375_000i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coordinates.rs:144:42 [INFO] [stderr] | [INFO] [stderr] 144 | let c = CoordinateNumber { nano: 123456888888i64 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `123_456_888_888i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coordinates.rs:145:44 [INFO] [stderr] | [INFO] [stderr] 145 | let d = CoordinateNumber::try_from(123456.888888f64).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `123_456.888_888f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coordinates.rs:152:43 [INFO] [stderr] | [INFO] [stderr] 152 | let g = CoordinateNumber { nano: -12345678 }; [INFO] [stderr] | ^^^^^^^^ help: consider: `12_345_678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coordinates.rs:153:45 [INFO] [stderr] | [INFO] [stderr] 153 | let h = CoordinateNumber::try_from(-12.345678).unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: consider: `12.345_678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coordinates.rs:176:47 [INFO] [stderr] | [INFO] [stderr] 176 | let a: f64 = CoordinateNumber { nano: 1375000i64 }.into(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_375_000i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coordinates.rs:180:47 [INFO] [stderr] | [INFO] [stderr] 180 | let c: f64 = CoordinateNumber { nano: 123456888888i64 }.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `123_456_888_888i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coordinates.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | let d = 123456.888888f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `123_456.888_888f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coordinates.rs:207:42 [INFO] [stderr] | [INFO] [stderr] 207 | let a = CoordinateNumber { nano: 10000000 }.gerber(&cf1).unwrap(); [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coordinates.rs:208:42 [INFO] [stderr] | [INFO] [stderr] 208 | let b = CoordinateNumber { nano: 20000000 }.gerber(&cf2).unwrap(); [INFO] [stderr] | ^^^^^^^^ help: consider: `20_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coordinates.rs:217:42 [INFO] [stderr] | [INFO] [stderr] 217 | let d = CoordinateNumber { nano: 123456789012 }.gerber(&cf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `123_456_789_012` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coordinates.rs:225:42 [INFO] [stderr] | [INFO] [stderr] 225 | let d = CoordinateNumber { nano: 12345678901 }.gerber(&cf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `12_345_678_901` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coordinates.rs:233:42 [INFO] [stderr] | [INFO] [stderr] 233 | let d = CoordinateNumber { nano: 12345000000 }.gerber(&cf); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `12_345_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coordinates.rs:241:43 [INFO] [stderr] | [INFO] [stderr] 241 | let d = CoordinateNumber { nano: -12345000000 }.gerber(&cf); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `12_345_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coordinates.rs:249:42 [INFO] [stderr] | [INFO] [stderr] 249 | let d = CoordinateNumber { nano: 1234432199 }.gerber(&cf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_432_199` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coordinates.rs:257:43 [INFO] [stderr] | [INFO] [stderr] 257 | let d = CoordinateNumber { nano: -123456789099 }.gerber(&cf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `123_456_789_099` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:213:40 [INFO] [stderr] | [INFO] [stderr] 213 | let c2 = DCode::SelectAperture(2147483647); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:71:29 [INFO] [stderr] | [INFO] [stderr] 71 | MacroDecimal::Value(val as f64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/coordinates.rs:77:42 [INFO] [stderr] | [INFO] [stderr] 77 | CoordinateNumber { nano: val as i64 * DECIMAL_PLACES_FACTOR } [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 85 | impl_from_integer!(i8); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/coordinates.rs:77:42 [INFO] [stderr] | [INFO] [stderr] 77 | CoordinateNumber { nano: val as i64 * DECIMAL_PLACES_FACTOR } [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 86 | impl_from_integer!(i16); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/coordinates.rs:77:42 [INFO] [stderr] | [INFO] [stderr] 77 | CoordinateNumber { nano: val as i64 * DECIMAL_PLACES_FACTOR } [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 87 | impl_from_integer!(i32); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/coordinates.rs:77:42 [INFO] [stderr] | [INFO] [stderr] 77 | CoordinateNumber { nano: val as i64 * DECIMAL_PLACES_FACTOR } [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 88 | impl_from_integer!(u8); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/coordinates.rs:77:42 [INFO] [stderr] | [INFO] [stderr] 77 | CoordinateNumber { nano: val as i64 * DECIMAL_PLACES_FACTOR } [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 89 | impl_from_integer!(u16); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coordinates.rs:92:19 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn gerber(&self, format: &CoordinateFormat) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coordinates.rs:92:34 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn gerber(&self, format: &CoordinateFormat) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `CoordinateFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/coordinates.rs:96:42 [INFO] [stderr] | [INFO] [stderr] 96 | if self.nano.abs() >= 10_i64.pow((format.integer + DECIMAL_PLACES_CHARS) as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(format.integer + DECIMAL_PLACES_CHARS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/coordinates.rs:100:39 [INFO] [stderr] | [INFO] [stderr] 100 | let divisor: i64 = 10_i64.pow((DECIMAL_PLACES_CHARS - format.decimal) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(DECIMAL_PLACES_CHARS - format.decimal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> examples/two-boxes.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | write!(stdout, "\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> examples/polarities-apertures.rs:636:5 [INFO] [stderr] | [INFO] [stderr] 636 | write!(stdout, "\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/macros.rs:71:29 [INFO] [stderr] | [INFO] [stderr] 71 | MacroDecimal::Value(val as f64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/coordinates.rs:77:42 [INFO] [stderr] | [INFO] [stderr] 77 | CoordinateNumber { nano: val as i64 * DECIMAL_PLACES_FACTOR } [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 85 | impl_from_integer!(i8); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/coordinates.rs:77:42 [INFO] [stderr] | [INFO] [stderr] 77 | CoordinateNumber { nano: val as i64 * DECIMAL_PLACES_FACTOR } [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 86 | impl_from_integer!(i16); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/coordinates.rs:77:42 [INFO] [stderr] | [INFO] [stderr] 77 | CoordinateNumber { nano: val as i64 * DECIMAL_PLACES_FACTOR } [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 87 | impl_from_integer!(i32); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/coordinates.rs:77:42 [INFO] [stderr] | [INFO] [stderr] 77 | CoordinateNumber { nano: val as i64 * DECIMAL_PLACES_FACTOR } [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 88 | impl_from_integer!(u8); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/coordinates.rs:77:42 [INFO] [stderr] | [INFO] [stderr] 77 | CoordinateNumber { nano: val as i64 * DECIMAL_PLACES_FACTOR } [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 89 | impl_from_integer!(u16); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coordinates.rs:92:19 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn gerber(&self, format: &CoordinateFormat) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/coordinates.rs:92:34 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn gerber(&self, format: &CoordinateFormat) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `CoordinateFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/coordinates.rs:96:42 [INFO] [stderr] | [INFO] [stderr] 96 | if self.nano.abs() >= 10_i64.pow((format.integer + DECIMAL_PLACES_CHARS) as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(format.integer + DECIMAL_PLACES_CHARS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/coordinates.rs:100:39 [INFO] [stderr] | [INFO] [stderr] 100 | let divisor: i64 = 10_i64.pow((DECIMAL_PLACES_CHARS - format.decimal) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(DECIMAL_PLACES_CHARS - format.decimal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/coordinates.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | assert_eq!(a, b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/coordinates.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | assert_eq!(a, b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/coordinates.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | assert_eq!(c, d); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/coordinates.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | assert_eq!(c, d); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/coordinates.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | assert_eq!(e, f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/coordinates.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | assert_eq!(e, f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `gerber-types`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/polarities-apertures.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/two-boxes.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "64f3f862aa6381ec6c6f3b01fe46cebeed68f806c0066998997fa9e67d16a5a9"` [INFO] running `"docker" "rm" "-f" "64f3f862aa6381ec6c6f3b01fe46cebeed68f806c0066998997fa9e67d16a5a9"` [INFO] [stdout] 64f3f862aa6381ec6c6f3b01fe46cebeed68f806c0066998997fa9e67d16a5a9