[INFO] crate ger 0.2.0 is already in cache
[INFO] extracting crate ger 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/ger/0.2.0
[INFO] extracting crate ger 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ger/0.2.0
[INFO] validating manifest of ger-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ger-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ger-0.2.0
[INFO] finished frobbing ger-0.2.0
[INFO] frobbed toml for ger-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/ger/0.2.0/Cargo.toml
[INFO] started frobbing ger-0.2.0
[INFO] finished frobbing ger-0.2.0
[INFO] frobbed toml for ger-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ger/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ger-0.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ger/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a5041dec0d06608056d2e88dad2b2d56dc9d78ea65d7e33beecadfb77b08e336
[INFO] running `"docker" "start" "-a" "a5041dec0d06608056d2e88dad2b2d56dc9d78ea65d7e33beecadfb77b08e336"`
[INFO] [stderr]     Checking ger v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/cmd_open.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             default_behavior: default_behavior,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `default_behavior`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/cmd.rs:38:37
[INFO] [stderr]    |
[INFO] [stderr] 38 |             cmd: Box::new(FuncCmd { func: func })
[INFO] [stderr]    |                                     ^^^^^^^^^^ help: replace it with: `func`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/cmd_open.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             default_behavior: default_behavior,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `default_behavior`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/cmd.rs:38:37
[INFO] [stderr]    |
[INFO] [stderr] 38 |             cmd: Box::new(FuncCmd { func: func })
[INFO] [stderr]    |                                     ^^^^^^^^^^ help: replace it with: `func`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/main.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | #[macro_use] extern crate serde_json;
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/exec.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |             return exec_output
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `exec_output`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `Attr`, `color`
[INFO] [stderr]  --> src/print.rs:3:12
[INFO] [stderr]   |
[INFO] [stderr] 3 | use term::{Attr, color};
[INFO] [stderr]   |            ^^^^  ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `prettytable`
[INFO] [stderr]  --> src/print.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use prettytable;
[INFO] [stderr]   |     ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `prettytable::cell::Cell`
[INFO] [stderr]  --> src/print.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use prettytable::cell::Cell;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `Green`, `Red`
[INFO] [stderr]  --> src/print.rs:6:25
[INFO] [stderr]   |
[INFO] [stderr] 6 | use ansi_term::Colour::{Red, Green};
[INFO] [stderr]   |                         ^^^  ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/main.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | #[macro_use] extern crate serde_json;
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/exec.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |             return exec_output
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `exec_output`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `Attr`, `color`
[INFO] [stderr]  --> src/print.rs:3:12
[INFO] [stderr]   |
[INFO] [stderr] 3 | use term::{Attr, color};
[INFO] [stderr]   |            ^^^^  ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `prettytable`
[INFO] [stderr]  --> src/print.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use prettytable;
[INFO] [stderr]   |     ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `prettytable::cell::Cell`
[INFO] [stderr]  --> src/print.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use prettytable::cell::Cell;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `Green`, `Red`
[INFO] [stderr]  --> src/print.rs:6:25
[INFO] [stderr]   |
[INFO] [stderr] 6 | use ansi_term::Colour::{Red, Green};
[INFO] [stderr]   |                         ^^^  ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/gerrit.rs:115:27
[INFO] [stderr]     |
[INFO] [stderr] 115 |               Ok(output) => match output.is_unauthorized() {
[INFO] [stderr]     |  ___________________________^
[INFO] [stderr] 116 | |                 true => panic!("Unauthorized response from gerrit. is your HTTP password up to date?"),
[INFO] [stderr] 117 | |                 false => match serde_json::from_str(&output.body_for_json()) {
[INFO] [stderr] 118 | |                     Ok(json) => json,
[INFO] [stderr] ...   |
[INFO] [stderr] 125 | |                 },
[INFO] [stderr] 126 | |             },
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 115 |             Ok(output) => if output.is_unauthorized() { panic!("Unauthorized response from gerrit. is your HTTP password up to date?") } else { match serde_json::from_str(&output.body_for_json()) {
[INFO] [stderr] 116 |     Ok(json) => json,
[INFO] [stderr] 117 |     Err(json_err) => {
[INFO] [stderr] 118 |         #[cfg(debug_assertions)]
[INFO] [stderr] 119 |         println!("URL: {0} \nJSON: {1}\n", path, output.body);
[INFO] [stderr] 120 | 
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/gerrit.rs:137:33
[INFO] [stderr]     |
[INFO] [stderr] 137 |         let changes = self.get(&format!("a/changes/?q=owner:self+status:open&o=LABELS&o=DETAILED_ACCOUNTS"));
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"a/changes/?q=owner:self+status:open&o=LABELS&o=DETAILED_ACCOUNTS".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/print.rs:23:21
[INFO] [stderr]    |
[INFO] [stderr] 23 | pub fn trim (input: &String, len: usize) -> &str {
[INFO] [stderr]    |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]   --> src/curl.rs:31:30
[INFO] [stderr]    |
[INFO] [stderr] 31 |     let args = [&params[..], &vec![url]].concat(); // wee bit hackyyy
[INFO] [stderr]    |                              ^^^^^^^^^^ help: you can use a slice directly: `&[url]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]   --> src/main.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     fn new() -> CmdMatch {
[INFO] [stderr] 36 | |         CmdMatch {
[INFO] [stderr] 37 | |             default_behavior: print_help,
[INFO] [stderr] 38 | |             options: vec![
[INFO] [stderr] ...  |
[INFO] [stderr] 43 | |         }
[INFO] [stderr] 44 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/gerrit.rs:115:27
[INFO] [stderr]     |
[INFO] [stderr] 115 |               Ok(output) => match output.is_unauthorized() {
[INFO] [stderr]     |  ___________________________^
[INFO] [stderr] 116 | |                 true => panic!("Unauthorized response from gerrit. is your HTTP password up to date?"),
[INFO] [stderr] 117 | |                 false => match serde_json::from_str(&output.body_for_json()) {
[INFO] [stderr] 118 | |                     Ok(json) => json,
[INFO] [stderr] ...   |
[INFO] [stderr] 125 | |                 },
[INFO] [stderr] 126 | |             },
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 115 |             Ok(output) => if output.is_unauthorized() { panic!("Unauthorized response from gerrit. is your HTTP password up to date?") } else { match serde_json::from_str(&output.body_for_json()) {
[INFO] [stderr] 116 |     Ok(json) => json,
[INFO] [stderr] 117 |     Err(json_err) => {
[INFO] [stderr] 118 |         #[cfg(debug_assertions)]
[INFO] [stderr] 119 |         println!("URL: {0} \nJSON: {1}\n", path, output.body);
[INFO] [stderr] 120 | 
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/gerrit.rs:137:33
[INFO] [stderr]     |
[INFO] [stderr] 137 |         let changes = self.get(&format!("a/changes/?q=owner:self+status:open&o=LABELS&o=DETAILED_ACCOUNTS"));
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"a/changes/?q=owner:self+status:open&o=LABELS&o=DETAILED_ACCOUNTS".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/print.rs:23:21
[INFO] [stderr]    |
[INFO] [stderr] 23 | pub fn trim (input: &String, len: usize) -> &str {
[INFO] [stderr]    |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]   --> src/curl.rs:31:30
[INFO] [stderr]    |
[INFO] [stderr] 31 |     let args = [&params[..], &vec![url]].concat(); // wee bit hackyyy
[INFO] [stderr]    |                              ^^^^^^^^^^ help: you can use a slice directly: `&[url]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]   --> src/main.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     fn new() -> CmdMatch {
[INFO] [stderr] 36 | |         CmdMatch {
[INFO] [stderr] 37 | |             default_behavior: print_help,
[INFO] [stderr] 38 | |             options: vec![
[INFO] [stderr] ...  |
[INFO] [stderr] 43 | |         }
[INFO] [stderr] 44 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.15s
[INFO] running `"docker" "inspect" "a5041dec0d06608056d2e88dad2b2d56dc9d78ea65d7e33beecadfb77b08e336"`
[INFO] running `"docker" "rm" "-f" "a5041dec0d06608056d2e88dad2b2d56dc9d78ea65d7e33beecadfb77b08e336"`
[INFO] [stdout] a5041dec0d06608056d2e88dad2b2d56dc9d78ea65d7e33beecadfb77b08e336