[INFO] crate geojson_d3 0.1.10 is already in cache [INFO] extracting crate geojson_d3 0.1.10 into work/ex/clippy-test-run/sources/stable/reg/geojson_d3/0.1.10 [INFO] extracting crate geojson_d3 0.1.10 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/geojson_d3/0.1.10 [INFO] validating manifest of geojson_d3-0.1.10 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of geojson_d3-0.1.10 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing geojson_d3-0.1.10 [INFO] finished frobbing geojson_d3-0.1.10 [INFO] frobbed toml for geojson_d3-0.1.10 written to work/ex/clippy-test-run/sources/stable/reg/geojson_d3/0.1.10/Cargo.toml [INFO] started frobbing geojson_d3-0.1.10 [INFO] finished frobbing geojson_d3-0.1.10 [INFO] frobbed toml for geojson_d3-0.1.10 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/geojson_d3/0.1.10/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting geojson_d3-0.1.10 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/geojson_d3/0.1.10:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5f54c640b2136ecc8fd975756c6a5e1b431f106e4e556b5b9e6a322e508a432e [INFO] running `"docker" "start" "-a" "5f54c640b2136ecc8fd975756c6a5e1b431f106e4e556b5b9e6a322e508a432e"` [INFO] [stderr] Checking clamp v0.1.0 [INFO] [stderr] Checking pdqselect v0.1.0 [INFO] [stderr] Checking approx v0.2.1 [INFO] [stderr] Checking clicolors-control v0.2.0 [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Checking console v0.7.5 [INFO] [stderr] Checking console v0.6.2 [INFO] [stderr] Checking indicatif v0.10.3 [INFO] [stderr] Checking nalgebra v0.16.13 [INFO] [stderr] Checking spade v1.6.0 [INFO] [stderr] Checking geo-types v0.2.2 [INFO] [stderr] Checking geojson v0.12.0 [INFO] [stderr] Checking geo v0.10.3 [INFO] [stderr] Checking geojson_d3 v0.1.10 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:45:23 [INFO] [stderr] | [INFO] [stderr] 45 | static EPSILON: f64 = 0.000000001; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.000_000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `RADIANS` [INFO] [stderr] --> src/main.rs:42:1 [INFO] [stderr] | [INFO] [stderr] 42 | static RADIANS: f64 = PI / 180.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `PI4` [INFO] [stderr] --> src/main.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | static PI4: f64 = PI / 4.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `EPSILON` [INFO] [stderr] --> src/main.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | static EPSILON: f64 = 0.000000001; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `spherical_ring_area` [INFO] [stderr] --> src/main.rs:173:1 [INFO] [stderr] | [INFO] [stderr] 173 | fn spherical_ring_area(ring: &LineString) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:80:62 [INFO] [stderr] | [INFO] [stderr] 80 | fn process_geojson(gj: &mut GeoJson, ctr: &AtomicIsize, rev: &bool) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:98:66 [INFO] [stderr] | [INFO] [stderr] 98 | fn process_geometry(geom: &mut Geometry, ctr: &AtomicIsize, rev: &bool) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:115:71 [INFO] [stderr] | [INFO] [stderr] 115 | fn reverse_rings(geom: Option<&mut Geometry>, ctr: &AtomicIsize, rev: &bool) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:151:39 [INFO] [stderr] | [INFO] [stderr] 151 | fn wind(poly: &mut Polygon, rev: &bool) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:45:23 [INFO] [stderr] | [INFO] [stderr] 45 | static EPSILON: f64 = 0.000000001; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.000_000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:80:62 [INFO] [stderr] | [INFO] [stderr] 80 | fn process_geojson(gj: &mut GeoJson, ctr: &AtomicIsize, rev: &bool) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:98:66 [INFO] [stderr] | [INFO] [stderr] 98 | fn process_geometry(geom: &mut Geometry, ctr: &AtomicIsize, rev: &bool) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:115:71 [INFO] [stderr] | [INFO] [stderr] 115 | fn reverse_rings(geom: Option<&mut Geometry>, ctr: &AtomicIsize, rev: &bool) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:151:39 [INFO] [stderr] | [INFO] [stderr] 151 | fn wind(poly: &mut Polygon, rev: &bool) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 57.95s [INFO] running `"docker" "inspect" "5f54c640b2136ecc8fd975756c6a5e1b431f106e4e556b5b9e6a322e508a432e"` [INFO] running `"docker" "rm" "-f" "5f54c640b2136ecc8fd975756c6a5e1b431f106e4e556b5b9e6a322e508a432e"` [INFO] [stdout] 5f54c640b2136ecc8fd975756c6a5e1b431f106e4e556b5b9e6a322e508a432e