[INFO] crate geojson 0.13.0 is already in cache [INFO] extracting crate geojson 0.13.0 into work/ex/clippy-test-run/sources/stable/reg/geojson/0.13.0 [INFO] extracting crate geojson 0.13.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/geojson/0.13.0 [INFO] validating manifest of geojson-0.13.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of geojson-0.13.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing geojson-0.13.0 [INFO] finished frobbing geojson-0.13.0 [INFO] frobbed toml for geojson-0.13.0 written to work/ex/clippy-test-run/sources/stable/reg/geojson/0.13.0/Cargo.toml [INFO] started frobbing geojson-0.13.0 [INFO] finished frobbing geojson-0.13.0 [INFO] frobbed toml for geojson-0.13.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/geojson/0.13.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting geojson-0.13.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/geojson/0.13.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5859aa9d3463b260032eda09db8a3f0abfd77b43162a8e2bd468dcc0c42010a5 [INFO] running `"docker" "start" "-a" "5859aa9d3463b260032eda09db8a3f0abfd77b43162a8e2bd468dcc0c42010a5"` [INFO] [stderr] Checking geo-types v0.2.2 [INFO] [stderr] Checking geojson v0.13.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/conversion.rs:86:41 [INFO] [stderr] | [INFO] [stderr] 86 | fn create_geo_coordinate(point_type: &PointType) -> geo_types::Coordinate [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/conversion.rs:96:36 [INFO] [stderr] | [INFO] [stderr] 96 | fn create_geo_point(point_type: &PointType) -> geo_types::Point [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/conversion.rs:106:41 [INFO] [stderr] | [INFO] [stderr] 106 | fn create_geo_line_string(line_type: &LineStringType) -> geo_types::LineString [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/conversion.rs:132:40 [INFO] [stderr] | [INFO] [stderr] 132 | fn create_geo_polygon(polygon_type: &PolygonType) -> geo_types::Polygon [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/conversion.rs:139:10 [INFO] [stderr] | [INFO] [stderr] 139 | .unwrap_or(create_geo_line_string(&vec![])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| create_geo_line_string(&vec![]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/conversion.rs:153:52 [INFO] [stderr] | [INFO] [stderr] 153 | fn create_geo_multi_polygon(multi_polygon_type: &Vec) -> geo_types::MultiPolygon [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[PolygonType]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/conversion.rs:86:41 [INFO] [stderr] | [INFO] [stderr] 86 | fn create_geo_coordinate(point_type: &PointType) -> geo_types::Coordinate [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/conversion.rs:96:36 [INFO] [stderr] | [INFO] [stderr] 96 | fn create_geo_point(point_type: &PointType) -> geo_types::Point [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/conversion.rs:106:41 [INFO] [stderr] | [INFO] [stderr] 106 | fn create_geo_line_string(line_type: &LineStringType) -> geo_types::LineString [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/conversion.rs:132:40 [INFO] [stderr] | [INFO] [stderr] 132 | fn create_geo_polygon(polygon_type: &PolygonType) -> geo_types::Polygon [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/conversion.rs:139:10 [INFO] [stderr] | [INFO] [stderr] 139 | .unwrap_or(create_geo_line_string(&vec![])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| create_geo_line_string(&vec![]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/conversion.rs:153:52 [INFO] [stderr] | [INFO] [stderr] 153 | fn create_geo_multi_polygon(multi_polygon_type: &Vec) -> geo_types::MultiPolygon [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[PolygonType]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/conversion.rs:545:5 [INFO] [stderr] | [INFO] [stderr] 545 | / fn geo_multi_line_string_conversion_test() { [INFO] [stderr] 546 | | let p1 = Point::new(40.02f64, 116.34f64); [INFO] [stderr] 547 | | let p2 = Point::new(13.02f64, 24.34f64); [INFO] [stderr] 548 | | let p3 = Point::new(46.84f64, 160.95f64); [INFO] [stderr] ... | [INFO] [stderr] 568 | | } [INFO] [stderr] 569 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 50 [INFO] [stderr] --> src/conversion.rs:572:5 [INFO] [stderr] | [INFO] [stderr] 572 | / fn geo_polygon_conversion_test() { [INFO] [stderr] 573 | | let p1 = Point::new(100.0f64, 0.0f64); [INFO] [stderr] 574 | | let p2 = Point::new(101.0f64, 0.0f64); [INFO] [stderr] 575 | | let p3 = Point::new(101.0f64, 1.0f64); [INFO] [stderr] ... | [INFO] [stderr] 601 | | } [INFO] [stderr] 602 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 50 [INFO] [stderr] --> src/conversion.rs:605:5 [INFO] [stderr] | [INFO] [stderr] 605 | / fn geo_multi_polygon_conversion_test() { [INFO] [stderr] 606 | | let p1 = Point::new(102.0f64, 2.0f64); [INFO] [stderr] 607 | | let p2 = Point::new(103.0f64, 2.0f64); [INFO] [stderr] 608 | | let p3 = Point::new(103.0f64, 3.0f64); [INFO] [stderr] ... | [INFO] [stderr] 636 | | } [INFO] [stderr] 637 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/conversion.rs:720:5 [INFO] [stderr] | [INFO] [stderr] 720 | / fn geojson_multi_line_string_conversion_test() { [INFO] [stderr] 721 | | let coord1 = vec![100.0, 0.2]; [INFO] [stderr] 722 | | let coord2 = vec![101.0, 1.0]; [INFO] [stderr] 723 | | let coord3 = vec![102.0, 0.8]; [INFO] [stderr] ... | [INFO] [stderr] 741 | | assert_almost_eq!(geo_line_string2.0[1].y, coord3[1], 1e-6); [INFO] [stderr] 742 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/conversion.rs:731:13 [INFO] [stderr] | [INFO] [stderr] 731 | let ref geo_line_string1 = geo_multi_line_string.0[0]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^------------------------------ help: try: `let geo_line_string1 = &geo_multi_line_string.0[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/conversion.rs:737:13 [INFO] [stderr] | [INFO] [stderr] 737 | let ref geo_line_string2 = geo_multi_line_string.0[1]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^------------------------------ help: try: `let geo_line_string2 = &geo_multi_line_string.0[1];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 65 [INFO] [stderr] --> src/conversion.rs:745:5 [INFO] [stderr] | [INFO] [stderr] 745 | / fn geojson_polygon_conversion_test() { [INFO] [stderr] 746 | | let coord1 = vec![100.0, 0.0]; [INFO] [stderr] 747 | | let coord2 = vec![101.0, 1.0]; [INFO] [stderr] 748 | | let coord3 = vec![101.0, 1.0]; [INFO] [stderr] ... | [INFO] [stderr] 788 | | assert_almost_eq!(geo_line_string2.0[3].y, coord4[1], 1e-6); [INFO] [stderr] 789 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/conversion.rs:770:13 [INFO] [stderr] | [INFO] [stderr] 770 | let ref geo_line_string1 = geo_polygon.exterior; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^------------------------ help: try: `let geo_line_string1 = &geo_polygon.exterior;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/conversion.rs:780:13 [INFO] [stderr] | [INFO] [stderr] 780 | let ref geo_line_string2 = geo_polygon.interiors[0]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^---------------------------- help: try: `let geo_line_string2 = &geo_polygon.interiors[0];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/conversion.rs:800:5 [INFO] [stderr] | [INFO] [stderr] 800 | / fn geojson_polygon_without_interiors_conversion_test() { [INFO] [stderr] 801 | | let coord1 = vec![100.0, 0.0]; [INFO] [stderr] 802 | | let coord2 = vec![101.0, 1.0]; [INFO] [stderr] 803 | | let coord3 = vec![101.0, 1.0]; [INFO] [stderr] ... | [INFO] [stderr] 824 | | assert_eq!(0, geo_polygon.interiors.len()); [INFO] [stderr] 825 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/conversion.rs:814:13 [INFO] [stderr] | [INFO] [stderr] 814 | let ref geo_line_string1 = geo_polygon.exterior; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^------------------------ help: try: `let geo_line_string1 = &geo_polygon.exterior;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 65 [INFO] [stderr] --> src/conversion.rs:828:5 [INFO] [stderr] | [INFO] [stderr] 828 | / fn geojson_multi_polygon_conversion_test() { [INFO] [stderr] 829 | | let coord1 = vec![100.0, 0.0]; [INFO] [stderr] 830 | | let coord2 = vec![101.0, 1.0]; [INFO] [stderr] 831 | | let coord3 = vec![101.0, 1.0]; [INFO] [stderr] ... | [INFO] [stderr] 874 | | assert_almost_eq!(geo_line_string2.0[3].y, coord4[1], 1e-6); [INFO] [stderr] 875 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/conversion.rs:856:13 [INFO] [stderr] | [INFO] [stderr] 856 | let ref geo_line_string1 = geo_multi_polygon.0[0].exterior; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^----------------------------------- help: try: `let geo_line_string1 = &geo_multi_polygon.0[0].exterior;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/conversion.rs:866:13 [INFO] [stderr] | [INFO] [stderr] 866 | let ref geo_line_string2 = geo_multi_polygon.0[1].exterior; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^----------------------------------- help: try: `let geo_line_string2 = &geo_multi_polygon.0[1].exterior;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/parse.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `geojson`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5859aa9d3463b260032eda09db8a3f0abfd77b43162a8e2bd468dcc0c42010a5"` [INFO] running `"docker" "rm" "-f" "5859aa9d3463b260032eda09db8a3f0abfd77b43162a8e2bd468dcc0c42010a5"` [INFO] [stdout] 5859aa9d3463b260032eda09db8a3f0abfd77b43162a8e2bd468dcc0c42010a5