[INFO] crate genmesh 0.6.2 is already in cache [INFO] extracting crate genmesh 0.6.2 into work/ex/clippy-test-run/sources/stable/reg/genmesh/0.6.2 [INFO] extracting crate genmesh 0.6.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/genmesh/0.6.2 [INFO] validating manifest of genmesh-0.6.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of genmesh-0.6.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing genmesh-0.6.2 [INFO] finished frobbing genmesh-0.6.2 [INFO] frobbed toml for genmesh-0.6.2 written to work/ex/clippy-test-run/sources/stable/reg/genmesh/0.6.2/Cargo.toml [INFO] started frobbing genmesh-0.6.2 [INFO] finished frobbing genmesh-0.6.2 [INFO] frobbed toml for genmesh-0.6.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/genmesh/0.6.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting genmesh-0.6.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/genmesh/0.6.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 821ef53f49b1701df5ee49a9960e5e88e5c08d4c8df4ff55ee9872987d0dade2 [INFO] running `"docker" "start" "-a" "821ef53f49b1701df5ee49a9960e5e88e5c08d4c8df4ff55ee9872987d0dade2"` [INFO] [stderr] Compiling cgmath v0.16.1 [INFO] [stderr] Checking genmesh v0.6.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/indexer.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | emit: emit, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `emit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neighbors.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neighbors.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | shares_vertex: shares_vertex, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shares_vertex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neighbors.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | shares_edge: shares_edge, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shares_edge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neighbors.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | polygons: polygons, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `polygons` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/neighbors.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | let z = Vector3::from(f(&self.vertices[z])); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/neighbors.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | let a = z - x; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/neighbors.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | let b = z - y; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/poly.rs:311:16 [INFO] [stderr] | [INFO] [stderr] 311 | Line { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/poly.rs:311:22 [INFO] [stderr] | [INFO] [stderr] 311 | Line { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cylinder.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | let z = (hc as f32 / self.sub_h as f32) * 2. - 1.; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cylinder.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | let w = self.vert(u, self.h + 1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sphere.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | let v = self.v; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/indexer.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | emit: emit, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `emit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neighbors.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neighbors.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | shares_vertex: shares_vertex, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shares_vertex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neighbors.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | shares_edge: shares_edge, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shares_edge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/neighbors.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | polygons: polygons, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `polygons` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/neighbors.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | let z = Vector3::from(f(&self.vertices[z])); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/neighbors.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | let a = z - x; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/neighbors.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | let b = z - y; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/poly.rs:311:16 [INFO] [stderr] | [INFO] [stderr] 311 | Line { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/poly.rs:311:22 [INFO] [stderr] | [INFO] [stderr] 311 | Line { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cylinder.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | let z = (hc as f32 / self.sub_h as f32) * 2. - 1.; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cylinder.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | let w = self.vert(u, self.h + 1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sphere.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | let v = self.v; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/icosphere.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | const T: f32 = 0.85065080835204; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0.850_650_808_352_04` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/icosphere.rs:28:16 [INFO] [stderr] | [INFO] [stderr] 28 | const X: f32 = 0.5257311121191336; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.525_731_112_119_133_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/circle.rs:108:23 [INFO] [stderr] | [INFO] [stderr] 108 | pos: [0.707107, -0.70710653, 0.0].into(), [INFO] [stderr] | ^^^^^^^^ help: consider: `0.707_107` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/circle.rs:108:34 [INFO] [stderr] | [INFO] [stderr] 108 | pos: [0.707107, -0.70710653, 0.0].into(), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.707_106_53` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/icosphere.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | const T: f32 = 0.85065080835204; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0.850_650_808_352_04` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/icosphere.rs:28:16 [INFO] [stderr] | [INFO] [stderr] 28 | const X: f32 = 0.5257311121191336; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.525_731_112_119_133_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/generator.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / fn shared_vertex_iter<'a>(&'a self) -> SharedVertexIterator<'a, Self, V> { [INFO] [stderr] 17 | | SharedVertexIterator { [INFO] [stderr] 18 | | base: self, [INFO] [stderr] 19 | | idx: 0..self.shared_vertex_count(), [INFO] [stderr] 20 | | phantom_v: PhantomData, [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/generator.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / fn indexed_polygon_iter<'a>(&'a self) -> IndexedPolygonIterator<'a, Self, V> { [INFO] [stderr] 57 | | IndexedPolygonIterator { [INFO] [stderr] 58 | | base: self, [INFO] [stderr] 59 | | idx: 0..self.indexed_polygon_count(), [INFO] [stderr] 60 | | phantom_v: PhantomData, [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/neighbors.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/neighbors.rs:30:28 [INFO] [stderr] | [INFO] [stderr] 30 | .entry(line.x.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `line.x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/neighbors.rs:35:22 [INFO] [stderr] | [INFO] [stderr] 35 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/neighbors.rs:34:28 [INFO] [stderr] | [INFO] [stderr] 34 | .entry(line.y.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `line.y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/neighbors.rs:37:41 [INFO] [stderr] | [INFO] [stderr] 37 | shares_edge.entry(line).or_insert(Vec::new()).push(i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/neighbors.rs:56:39 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn vertex_neighbors(&self, t: &usize) -> Option<&[usize]> { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/neighbors.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | self.shares_edge.get(&line).map(|x| { [INFO] [stderr] | _________________^ [INFO] [stderr] | |_________________| [INFO] [stderr] | || [INFO] [stderr] 68 | || for &i in x { [INFO] [stderr] 69 | || v.insert(i); [INFO] [stderr] 70 | || } [INFO] [stderr] 71 | || }); [INFO] [stderr] | ||__________________^- help: try this: `if let Some(x) = self.shares_edge.get(&line) { ... }` [INFO] [stderr] | |___________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/poly.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | / match self.buffer.pop_front() { [INFO] [stderr] 152 | | Some(v) => return Some(v), [INFO] [stderr] 153 | | None => (), [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(v) = self.buffer.pop_front() { return Some(v) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/poly.rs:295:46 [INFO] [stderr] | [INFO] [stderr] 295 | self.src.next().map(|x| x.map_vertex(|x| (self.f)(x))) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `(self.f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/poly.rs:413:13 [INFO] [stderr] | [INFO] [stderr] 413 | / match self.buffer.pop_front() { [INFO] [stderr] 414 | | Some(v) => return Some(v), [INFO] [stderr] 415 | | None => (), [INFO] [stderr] 416 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(v) = self.buffer.pop_front() { return Some(v) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/triangulate.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / match self { [INFO] [stderr] 55 | | &PolyTri(ref t) => t.emit_triangles(emit), [INFO] [stderr] 56 | | &PolyQuad(ref q) => q.emit_triangles(emit), [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | match *self { [INFO] [stderr] 55 | PolyTri(ref t) => t.emit_triangles(emit), [INFO] [stderr] 56 | PolyQuad(ref q) => q.emit_triangles(emit), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/triangulate.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / match self.buffer.pop_front() { [INFO] [stderr] 103 | | Some(v) => return Some(v), [INFO] [stderr] 104 | | None => (), [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(v) = self.buffer.pop_front() { return Some(v) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `cube::Cube` [INFO] [stderr] --> src/cube.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | Cube { range: 0..6 } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for cube::Cube { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `idx * 4` [INFO] [stderr] --> src/cube.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | Quad::new(idx * 4 + 0, idx * 4 + 1, idx * 4 + 2, idx * 4 + 3) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/icosphere.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | const T: f32 = 0.85065080835204; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.850_650_8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/icosphere.rs:28:16 [INFO] [stderr] | [INFO] [stderr] 28 | const X: f32 = 0.5257311121191336; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.525_731_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `icosphere::IcoSphere` [INFO] [stderr] --> src/icosphere.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / pub fn new() -> Self { [INFO] [stderr] 78 | | Self { [INFO] [stderr] 79 | | i: 0, [INFO] [stderr] 80 | | vertices: VERTICES.to_vec(), [INFO] [stderr] 81 | | faces: FACES.to_vec(), [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `plane::Plane` [INFO] [stderr] --> src/plane.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Plane { [INFO] [stderr] 17 | | Plane { [INFO] [stderr] 18 | | subdivide_x: 1, [INFO] [stderr] 19 | | subdivide_y: 1, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/generator.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / fn shared_vertex_iter<'a>(&'a self) -> SharedVertexIterator<'a, Self, V> { [INFO] [stderr] 17 | | SharedVertexIterator { [INFO] [stderr] 18 | | base: self, [INFO] [stderr] 19 | | idx: 0..self.shared_vertex_count(), [INFO] [stderr] 20 | | phantom_v: PhantomData, [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/generator.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / fn indexed_polygon_iter<'a>(&'a self) -> IndexedPolygonIterator<'a, Self, V> { [INFO] [stderr] 57 | | IndexedPolygonIterator { [INFO] [stderr] 58 | | base: self, [INFO] [stderr] 59 | | idx: 0..self.indexed_polygon_count(), [INFO] [stderr] 60 | | phantom_v: PhantomData, [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/neighbors.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/neighbors.rs:30:28 [INFO] [stderr] | [INFO] [stderr] 30 | .entry(line.x.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `line.x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/neighbors.rs:35:22 [INFO] [stderr] | [INFO] [stderr] 35 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/neighbors.rs:34:28 [INFO] [stderr] | [INFO] [stderr] 34 | .entry(line.y.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `line.y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/neighbors.rs:37:41 [INFO] [stderr] | [INFO] [stderr] 37 | shares_edge.entry(line).or_insert(Vec::new()).push(i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/neighbors.rs:56:39 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn vertex_neighbors(&self, t: &usize) -> Option<&[usize]> { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/neighbors.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | self.shares_edge.get(&line).map(|x| { [INFO] [stderr] | _________________^ [INFO] [stderr] | |_________________| [INFO] [stderr] | || [INFO] [stderr] 68 | || for &i in x { [INFO] [stderr] 69 | || v.insert(i); [INFO] [stderr] 70 | || } [INFO] [stderr] 71 | || }); [INFO] [stderr] | ||__________________^- help: try this: `if let Some(x) = self.shares_edge.get(&line) { ... }` [INFO] [stderr] | |___________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/poly.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | / match self.buffer.pop_front() { [INFO] [stderr] 152 | | Some(v) => return Some(v), [INFO] [stderr] 153 | | None => (), [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(v) = self.buffer.pop_front() { return Some(v) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/poly.rs:295:46 [INFO] [stderr] | [INFO] [stderr] 295 | self.src.next().map(|x| x.map_vertex(|x| (self.f)(x))) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `(self.f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/poly.rs:413:13 [INFO] [stderr] | [INFO] [stderr] 413 | / match self.buffer.pop_front() { [INFO] [stderr] 414 | | Some(v) => return Some(v), [INFO] [stderr] 415 | | None => (), [INFO] [stderr] 416 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(v) = self.buffer.pop_front() { return Some(v) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/triangulate.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / match self { [INFO] [stderr] 55 | | &PolyTri(ref t) => t.emit_triangles(emit), [INFO] [stderr] 56 | | &PolyQuad(ref q) => q.emit_triangles(emit), [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | match *self { [INFO] [stderr] 55 | PolyTri(ref t) => t.emit_triangles(emit), [INFO] [stderr] 56 | PolyQuad(ref q) => q.emit_triangles(emit), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/triangulate.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / match self.buffer.pop_front() { [INFO] [stderr] 103 | | Some(v) => return Some(v), [INFO] [stderr] 104 | | None => (), [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(v) = self.buffer.pop_front() { return Some(v) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::FRAC_1_SQRT_2` found. Consider using it directly [INFO] [stderr] --> src/circle.rs:108:23 [INFO] [stderr] | [INFO] [stderr] 108 | pos: [0.707107, -0.70710653, 0.0].into(), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `cube::Cube` [INFO] [stderr] --> src/cube.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | Cube { range: 0..6 } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for cube::Cube { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `idx * 4` [INFO] [stderr] --> src/cube.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | Quad::new(idx * 4 + 0, idx * 4 + 1, idx * 4 + 2, idx * 4 + 3) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/icosphere.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | const T: f32 = 0.85065080835204; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.850_650_8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/icosphere.rs:28:16 [INFO] [stderr] | [INFO] [stderr] 28 | const X: f32 = 0.5257311121191336; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.525_731_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `icosphere::IcoSphere` [INFO] [stderr] --> src/icosphere.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / pub fn new() -> Self { [INFO] [stderr] 78 | | Self { [INFO] [stderr] 79 | | i: 0, [INFO] [stderr] 80 | | vertices: VERTICES.to_vec(), [INFO] [stderr] 81 | | faces: FACES.to_vec(), [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `plane::Plane` [INFO] [stderr] --> src/plane.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Plane { [INFO] [stderr] 17 | | Plane { [INFO] [stderr] 18 | | subdivide_x: 1, [INFO] [stderr] 19 | | subdivide_y: 1, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `genmesh`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/winding.rs:77:29 [INFO] [stderr] | [INFO] [stderr] 77 | (vertex.pos.x * 1000000.) as i32, [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000.` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/winding.rs:78:29 [INFO] [stderr] | [INFO] [stderr] 78 | (vertex.pos.y * 1000000.) as i32, [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000.` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/winding.rs:79:29 [INFO] [stderr] | [INFO] [stderr] 79 | (vertex.pos.z * 1000000.) as i32, [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000.` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/winding.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | assert!(lines.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lines.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error[E0432]: unresolved import `genmesh::generators::SphereUV` [INFO] [stderr] --> benches/bench.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | use genmesh::generators::{Plane, SphereUV}; [INFO] [stderr] | ^^^^^^^^ no `SphereUV` in `generators`. Did you mean to use `SphereUv`? [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] Some errors occurred: E0432, E0554. [INFO] [stderr] For more information about an error, try `rustc --explain E0432`. [INFO] [stderr] error: Could not compile `genmesh`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> tests/test.rs:17:23 [INFO] [stderr] | [INFO] [stderr] 17 | let transformed = input.iter().map(|x| x.clone()).vertex(|v| v % 2 != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `input.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/test.rs:17:44 [INFO] [stderr] | [INFO] [stderr] 17 | let transformed = input.iter().map(|x| x.clone()).vertex(|v| v % 2 != 0); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> tests/test.rs:19:35 [INFO] [stderr] | [INFO] [stderr] 19 | for (x, y) in transformed.zip(output.iter().map(|x| x.clone())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `output.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/test.rs:19:57 [INFO] [stderr] | [INFO] [stderr] 19 | for (x, y) in transformed.zip(output.iter().map(|x| x.clone())) { [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> tests/test.rs:33:23 [INFO] [stderr] | [INFO] [stderr] 33 | let transformed = input [INFO] [stderr] | _______________________^ [INFO] [stderr] 34 | | .iter() [INFO] [stderr] 35 | | .map(|x| x.clone()) [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 33 | let transformed = input [INFO] [stderr] 34 | .iter().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/test.rs:35:18 [INFO] [stderr] | [INFO] [stderr] 35 | .map(|x| x.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> tests/test.rs:39:35 [INFO] [stderr] | [INFO] [stderr] 39 | for (x, y) in transformed.zip(output.iter().map(|x| x.clone())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `output.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/test.rs:39:57 [INFO] [stderr] | [INFO] [stderr] 39 | for (x, y) in transformed.zip(output.iter().map(|x| x.clone())) { [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> tests/test.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | let transformed = input [INFO] [stderr] | _______________________^ [INFO] [stderr] 51 | | .iter() [INFO] [stderr] 52 | | .map(|x| x.clone()) [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 50 | let transformed = input [INFO] [stderr] 51 | .iter().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/test.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | .map(|x| x.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> tests/test.rs:55:35 [INFO] [stderr] | [INFO] [stderr] 55 | for (x, y) in transformed.zip(output.iter().map(|x| x.clone())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `output.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/test.rs:55:57 [INFO] [stderr] | [INFO] [stderr] 55 | for (x, y) in transformed.zip(output.iter().map(|x| x.clone())) { [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> tests/test.rs:69:23 [INFO] [stderr] | [INFO] [stderr] 69 | let transformed = input.iter().map(|x| x.clone()).vertex(|v| v % 2 != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `input.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/test.rs:69:44 [INFO] [stderr] | [INFO] [stderr] 69 | let transformed = input.iter().map(|x| x.clone()).vertex(|v| v % 2 != 0); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> tests/test.rs:71:35 [INFO] [stderr] | [INFO] [stderr] 71 | for (x, y) in transformed.zip(output.iter().map(|x| x.clone())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `output.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/test.rs:71:57 [INFO] [stderr] | [INFO] [stderr] 71 | for (x, y) in transformed.zip(output.iter().map(|x| x.clone())) { [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> tests/test.rs:85:23 [INFO] [stderr] | [INFO] [stderr] 85 | let transformed = input [INFO] [stderr] | _______________________^ [INFO] [stderr] 86 | | .iter() [INFO] [stderr] 87 | | .map(|x| x.clone()) [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 85 | let transformed = input [INFO] [stderr] 86 | .iter().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/test.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | .map(|x| x.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> tests/test.rs:91:35 [INFO] [stderr] | [INFO] [stderr] 91 | for (x, y) in transformed.zip(output.iter().map(|x| x.clone())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `output.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/test.rs:91:57 [INFO] [stderr] | [INFO] [stderr] 91 | for (x, y) in transformed.zip(output.iter().map(|x| x.clone())) { [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> tests/test.rs:102:23 [INFO] [stderr] | [INFO] [stderr] 102 | let transformed = input [INFO] [stderr] | _______________________^ [INFO] [stderr] 103 | | .iter() [INFO] [stderr] 104 | | .map(|x| x.clone()) [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 102 | let transformed = input [INFO] [stderr] 103 | .iter().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/test.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | .map(|x| x.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> tests/test.rs:107:35 [INFO] [stderr] | [INFO] [stderr] 107 | for (x, y) in transformed.zip(output.iter().map(|x| x.clone())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `output.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/test.rs:107:57 [INFO] [stderr] | [INFO] [stderr] 107 | for (x, y) in transformed.zip(output.iter().map(|x| x.clone())) { [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> tests/test.rs:197:32 [INFO] [stderr] | [INFO] [stderr] 197 | let lines: Vec> = quads.iter().map(|&x| x).lines().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `quads.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "821ef53f49b1701df5ee49a9960e5e88e5c08d4c8df4ff55ee9872987d0dade2"` [INFO] running `"docker" "rm" "-f" "821ef53f49b1701df5ee49a9960e5e88e5c08d4c8df4ff55ee9872987d0dade2"` [INFO] [stdout] 821ef53f49b1701df5ee49a9960e5e88e5c08d4c8df4ff55ee9872987d0dade2