[INFO] crate generate-nix-pkg 0.3.0 is already in cache
[INFO] extracting crate generate-nix-pkg 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/generate-nix-pkg/0.3.0
[INFO] extracting crate generate-nix-pkg 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/generate-nix-pkg/0.3.0
[INFO] validating manifest of generate-nix-pkg-0.3.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of generate-nix-pkg-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing generate-nix-pkg-0.3.0
[INFO] finished frobbing generate-nix-pkg-0.3.0
[INFO] frobbed toml for generate-nix-pkg-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/generate-nix-pkg/0.3.0/Cargo.toml
[INFO] started frobbing generate-nix-pkg-0.3.0
[INFO] finished frobbing generate-nix-pkg-0.3.0
[INFO] frobbed toml for generate-nix-pkg-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/generate-nix-pkg/0.3.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting generate-nix-pkg-0.3.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/generate-nix-pkg/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ae0115674dbb02f46fac6176b89f622833b239b5e1c1e7fbe48605cda29215ea
[INFO] running `"docker" "start" "-a" "ae0115674dbb02f46fac6176b89f622833b239b5e1c1e7fbe48605cda29215ea"`
[INFO] [stderr]    Compiling libsqlite3-sys v0.8.1
[INFO] [stderr]     Checking rusqlite v0.12.0
[INFO] [stderr]     Checking generate-nix-pkg v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/krate/mod.rs:182:9
[INFO] [stderr]     |
[INFO] [stderr] 182 |         write!(w, "{}{}_{}_{}_{}_ = {{ dependencies?[], buildDependencies?[], features?[] }}: mkRustCrate {{\n", indent, nix_name(&self.name), self.major, self.minor, self.patch)?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/krate/mod.rs:283:30
[INFO] [stderr]     |
[INFO] [stderr] 283 |         let pre = Prefetch { sha256: sha256, path: path.to_string() };
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^ help: replace it with: `sha256`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:137:17
[INFO] [stderr]     |
[INFO] [stderr] 137 |                 name: name
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:203:9
[INFO] [stderr]     |
[INFO] [stderr] 203 |         name: name
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/krate/mod.rs:182:9
[INFO] [stderr]     |
[INFO] [stderr] 182 |         write!(w, "{}{}_{}_{}_{}_ = {{ dependencies?[], buildDependencies?[], features?[] }}: mkRustCrate {{\n", indent, nix_name(&self.name), self.major, self.minor, self.patch)?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/krate/mod.rs:283:30
[INFO] [stderr]     |
[INFO] [stderr] 283 |         let pre = Prefetch { sha256: sha256, path: path.to_string() };
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^ help: replace it with: `sha256`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:137:17
[INFO] [stderr]     |
[INFO] [stderr] 137 |                 name: name
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:203:9
[INFO] [stderr]     |
[INFO] [stderr] 203 |         name: name
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/main.rs:174:20
[INFO] [stderr]     |
[INFO] [stderr] 174 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 175 | |                 if all_packages.get(&cra).is_none() {
[INFO] [stderr] 176 | |                     unknown_packages.push(package)
[INFO] [stderr] 177 | |                 } else {
[INFO] [stderr] 178 | |                     error!("Several packages with the same name and version number {:?}", cra)
[INFO] [stderr] 179 | |                 }
[INFO] [stderr] 180 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 174 |             } else if all_packages.get(&cra).is_none() {
[INFO] [stderr] 175 |     unknown_packages.push(package)
[INFO] [stderr] 176 | } else {
[INFO] [stderr] 177 |     error!("Several packages with the same name and version number {:?}", cra)
[INFO] [stderr] 178 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:98:26
[INFO] [stderr]    |
[INFO] [stderr] 98 |     let mut cache_path = std::env::home_dir().unwrap();
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/main.rs:174:20
[INFO] [stderr]     |
[INFO] [stderr] 174 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 175 | |                 if all_packages.get(&cra).is_none() {
[INFO] [stderr] 176 | |                     unknown_packages.push(package)
[INFO] [stderr] 177 | |                 } else {
[INFO] [stderr] 178 | |                     error!("Several packages with the same name and version number {:?}", cra)
[INFO] [stderr] 179 | |                 }
[INFO] [stderr] 180 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 174 |             } else if all_packages.get(&cra).is_none() {
[INFO] [stderr] 175 |     unknown_packages.push(package)
[INFO] [stderr] 176 | } else {
[INFO] [stderr] 177 |     error!("Several packages with the same name and version number {:?}", cra)
[INFO] [stderr] 178 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:98:26
[INFO] [stderr]    |
[INFO] [stderr] 98 |     let mut cache_path = std::env::home_dir().unwrap();
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `cond`
[INFO] [stderr]   --> src/main.rs:83:20
[INFO] [stderr]    |
[INFO] [stderr] 83 |     let (mut deps, cond) = {
[INFO] [stderr]    |                    ^^^^ help: consider using `_cond` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `build_implied`
[INFO] [stderr]   --> src/krate/prefetch.rs:28:34
[INFO] [stderr]    |
[INFO] [stderr] 28 |         let (build_dependencies, build_implied) = make_dependencies(&crate_path, v.get("build-dependencies"), v.get("features"));
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^ help: consider using `_build_implied` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `implied`
[INFO] [stderr]   --> src/krate/prefetch.rs:41:36
[INFO] [stderr]    |
[INFO] [stderr] 41 |                 let (dependencies, implied) = make_dependencies(&crate_path, b.get("dependencies"), b.get("features"));
[INFO] [stderr]    |                                    ^^^^^^^ help: consider using `_implied` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `is_first` is never read
[INFO] [stderr]    --> src/krate/mod.rs:156:13
[INFO] [stderr]     |
[INFO] [stderr] 156 |             is_first = false;
[INFO] [stderr]     |             ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `cond`
[INFO] [stderr]   --> src/main.rs:83:20
[INFO] [stderr]    |
[INFO] [stderr] 83 |     let (mut deps, cond) = {
[INFO] [stderr]    |                    ^^^^ help: consider using `_cond` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `i`
[INFO] [stderr]    --> src/cfg.rs:121:30
[INFO] [stderr]     |
[INFO] [stderr] 121 |     if let IResult::Done(ref i, ref o) = x {
[INFO] [stderr]     |                              ^ help: consider using `_i` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `build_implied`
[INFO] [stderr]   --> src/krate/prefetch.rs:28:34
[INFO] [stderr]    |
[INFO] [stderr] 28 |         let (build_dependencies, build_implied) = make_dependencies(&crate_path, v.get("build-dependencies"), v.get("features"));
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^ help: consider using `_build_implied` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `implied`
[INFO] [stderr]   --> src/krate/prefetch.rs:41:36
[INFO] [stderr]    |
[INFO] [stderr] 41 |                 let (dependencies, implied) = make_dependencies(&crate_path, b.get("dependencies"), b.get("features"));
[INFO] [stderr]    |                                    ^^^^^^^ help: consider using `_implied` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `is_first` is never read
[INFO] [stderr]    --> src/krate/mod.rs:156:13
[INFO] [stderr]     |
[INFO] [stderr] 156 |             is_first = false;
[INFO] [stderr]     |             ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/krate/prefetch.rs:32:21
[INFO] [stderr]    |
[INFO] [stderr] 32 |         if let Some(mut target) = v.remove("target") {
[INFO] [stderr]    |                     ----^^^^^^
[INFO] [stderr]    |                     |
[INFO] [stderr]    |                     help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/cfg.rs:40:14
[INFO] [stderr]    |
[INFO] [stderr] 40 | fn to_nix_op(mut w: &mut Write, op: CfgOp, target: &[Cfg]) -> Result<(), Error> {
[INFO] [stderr]    |              ----^
[INFO] [stderr]    |              |
[INFO] [stderr]    |              help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/krate/prefetch.rs:32:21
[INFO] [stderr]    |
[INFO] [stderr] 32 |         if let Some(mut target) = v.remove("target") {
[INFO] [stderr]    |                     ----^^^^^^
[INFO] [stderr]    |                     |
[INFO] [stderr]    |                     help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/cfg.rs:40:14
[INFO] [stderr]    |
[INFO] [stderr] 40 | fn to_nix_op(mut w: &mut Write, op: CfgOp, target: &[Cfg]) -> Result<(), Error> {
[INFO] [stderr]    |              ----^
[INFO] [stderr]    |              |
[INFO] [stderr]    |              help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/krate/prefetch.rs:150:45
[INFO] [stderr]     |
[INFO] [stderr] 150 |                 default.as_array().unwrap().into_iter().map(|x| x.as_str().unwrap().to_string())
[INFO] [stderr]     |                                             ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/krate/mod.rs:81:23
[INFO] [stderr]    |
[INFO] [stderr] 81 |             subpatch: cap.get(6).map(|x| x.as_str().to_string()).unwrap_or(String::new())
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `cap.get(6).map(|x| x.as_str().to_string()).unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/krate/mod.rs:129:42
[INFO] [stderr]     |
[INFO] [stderr] 129 |                        .filter(|&(_, c)| c.cr.name.len() > 0 && all_packages.contains(&c.cr.name))
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!c.cr.name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/krate/mod.rs:145:46
[INFO] [stderr]     |
[INFO] [stderr] 145 |                            .filter(|&(_, c)| c.cr.name.len() > 0 && all_packages.contains(&c.cr.name))
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!c.cr.name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/krate/mod.rs:159:42
[INFO] [stderr]     |
[INFO] [stderr] 159 |                        .filter(|&(_, c)| c.cr.name.len() > 0 && all_packages.contains(&c.cr.name))
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!c.cr.name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/krate/mod.rs:185:26
[INFO] [stderr]     |
[INFO] [stderr] 185 |         let version = if self.subpatch.len() > 0 {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.subpatch.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/krate/mod.rs:208:12
[INFO] [stderr]     |
[INFO] [stderr] 208 |         if meta.crate_file.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!meta.crate_file.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/krate/mod.rs:211:12
[INFO] [stderr]     |
[INFO] [stderr] 211 |         if meta.lib_name.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!meta.lib_name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/krate/mod.rs:220:12
[INFO] [stderr]     |
[INFO] [stderr] 220 |         if meta.bins.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!meta.bins.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/krate/mod.rs:234:12
[INFO] [stderr]     |
[INFO] [stderr] 234 |         if meta.build.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!meta.build.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/krate/mod.rs:251:26
[INFO] [stderr]     |
[INFO] [stderr] 251 |         let version = if self.subpatch.len() > 0 {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.subpatch.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/krate/prefetch.rs:150:45
[INFO] [stderr]     |
[INFO] [stderr] 150 |                 default.as_array().unwrap().into_iter().map(|x| x.as_str().unwrap().to_string())
[INFO] [stderr]     |                                             ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/krate/mod.rs:300:26
[INFO] [stderr]     |
[INFO] [stderr] 300 |                         .into_iter()
[INFO] [stderr]     |                          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/krate/mod.rs:81:23
[INFO] [stderr]    |
[INFO] [stderr] 81 |             subpatch: cap.get(6).map(|x| x.as_str().to_string()).unwrap_or(String::new())
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `cap.get(6).map(|x| x.as_str().to_string()).unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/krate/mod.rs:129:42
[INFO] [stderr]     |
[INFO] [stderr] 129 |                        .filter(|&(_, c)| c.cr.name.len() > 0 && all_packages.contains(&c.cr.name))
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!c.cr.name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/krate/mod.rs:145:46
[INFO] [stderr]     |
[INFO] [stderr] 145 |                            .filter(|&(_, c)| c.cr.name.len() > 0 && all_packages.contains(&c.cr.name))
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!c.cr.name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/krate/mod.rs:159:42
[INFO] [stderr]     |
[INFO] [stderr] 159 |                        .filter(|&(_, c)| c.cr.name.len() > 0 && all_packages.contains(&c.cr.name))
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!c.cr.name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/krate/mod.rs:185:26
[INFO] [stderr]     |
[INFO] [stderr] 185 |         let version = if self.subpatch.len() > 0 {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.subpatch.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/krate/mod.rs:208:12
[INFO] [stderr]     |
[INFO] [stderr] 208 |         if meta.crate_file.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!meta.crate_file.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/krate/mod.rs:211:12
[INFO] [stderr]     |
[INFO] [stderr] 211 |         if meta.lib_name.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!meta.lib_name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/krate/mod.rs:220:12
[INFO] [stderr]     |
[INFO] [stderr] 220 |         if meta.bins.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!meta.bins.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/krate/mod.rs:234:12
[INFO] [stderr]     |
[INFO] [stderr] 234 |         if meta.build.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!meta.build.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/krate/mod.rs:251:26
[INFO] [stderr]     |
[INFO] [stderr] 251 |         let version = if self.subpatch.len() > 0 {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.subpatch.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/cfg.rs:100:1
[INFO] [stderr]     |
[INFO] [stderr] 100 | / named!(equal<Cfg>, ws!(do_parse!(
[INFO] [stderr] 101 | |     k: ident >>
[INFO] [stderr] 102 | |         eq: tag!("=") >>
[INFO] [stderr] 103 | |         v: delimited!(tag!("\""), take_till!(|c| c == b'"'), tag!("\"")) >>
[INFO] [stderr] 104 | |         (Cfg::Equal(from_utf8(k).unwrap().to_string(),
[INFO] [stderr] 105 | |                     from_utf8(v).unwrap().to_string()))
[INFO] [stderr] 106 | | )));
[INFO] [stderr]     | |____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/krate/mod.rs:300:26
[INFO] [stderr]     |
[INFO] [stderr] 300 |                         .into_iter()
[INFO] [stderr]     |                          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 28
[INFO] [stderr]    --> src/main.rs:43:1
[INFO] [stderr]     |
[INFO] [stderr] 43  | / fn main() {
[INFO] [stderr] 44  | |     env_logger::init().unwrap_or(());
[INFO] [stderr] 45  | |     let matches = App::new("generate-nix-pkg")
[INFO] [stderr] 46  | |         .version("0.1")
[INFO] [stderr] ...   |
[INFO] [stderr] 247 | |     nix_file.write_all(b"}\n").unwrap();
[INFO] [stderr] 248 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/cfg.rs:100:1
[INFO] [stderr]     |
[INFO] [stderr] 100 | / named!(equal<Cfg>, ws!(do_parse!(
[INFO] [stderr] 101 | |     k: ident >>
[INFO] [stderr] 102 | |         eq: tag!("=") >>
[INFO] [stderr] 103 | |         v: delimited!(tag!("\""), take_till!(|c| c == b'"'), tag!("\"")) >>
[INFO] [stderr] 104 | |         (Cfg::Equal(from_utf8(k).unwrap().to_string(),
[INFO] [stderr] 105 | |                     from_utf8(v).unwrap().to_string()))
[INFO] [stderr] 106 | | )));
[INFO] [stderr]     | |____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:118:11
[INFO] [stderr]     |
[INFO] [stderr] 118 |     while packages_fixpoint.len() > 0 {
[INFO] [stderr]     |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!packages_fixpoint.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:127:18
[INFO] [stderr]     |
[INFO] [stderr] 127 |                  cap.get(5).map(|x| x.as_str().to_string()).unwrap_or(String::new()))
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `cap.get(5).map(|x| x.as_str().to_string()).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:194:10
[INFO] [stderr]     |
[INFO] [stderr] 194 |          cap.get(5).map(|x| x.as_str().to_string()).unwrap_or(String::new()))
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `cap.get(5).map(|x| x.as_str().to_string()).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:262:18
[INFO] [stderr]     |
[INFO] [stderr] 262 |                  cap.get(6).map(|x| x.as_str().to_string()).unwrap_or(String::new()))
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `cap.get(6).map(|x| x.as_str().to_string()).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 27
[INFO] [stderr]    --> src/main.rs:295:1
[INFO] [stderr]     |
[INFO] [stderr] 295 | / fn resolve_features(cr: &Crate, packages: &mut BTreeMap<Crate, Meta>) {
[INFO] [stderr] 296 | |     debug!("cr: {:?}", cr);
[INFO] [stderr] 297 | |     if cr.name.len() == 0 {
[INFO] [stderr] 298 | |         return
[INFO] [stderr] ...   |
[INFO] [stderr] 389 | |
[INFO] [stderr] 390 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:297:8
[INFO] [stderr]     |
[INFO] [stderr] 297 |     if cr.name.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cr.name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 28
[INFO] [stderr]    --> src/main.rs:43:1
[INFO] [stderr]     |
[INFO] [stderr] 43  | / fn main() {
[INFO] [stderr] 44  | |     env_logger::init().unwrap_or(());
[INFO] [stderr] 45  | |     let matches = App::new("generate-nix-pkg")
[INFO] [stderr] 46  | |         .version("0.1")
[INFO] [stderr] ...   |
[INFO] [stderr] 247 | |     nix_file.write_all(b"}\n").unwrap();
[INFO] [stderr] 248 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:118:11
[INFO] [stderr]     |
[INFO] [stderr] 118 |     while packages_fixpoint.len() > 0 {
[INFO] [stderr]     |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!packages_fixpoint.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:127:18
[INFO] [stderr]     |
[INFO] [stderr] 127 |                  cap.get(5).map(|x| x.as_str().to_string()).unwrap_or(String::new()))
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `cap.get(5).map(|x| x.as_str().to_string()).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:194:10
[INFO] [stderr]     |
[INFO] [stderr] 194 |          cap.get(5).map(|x| x.as_str().to_string()).unwrap_or(String::new()))
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `cap.get(5).map(|x| x.as_str().to_string()).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:262:18
[INFO] [stderr]     |
[INFO] [stderr] 262 |                  cap.get(6).map(|x| x.as_str().to_string()).unwrap_or(String::new()))
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `cap.get(6).map(|x| x.as_str().to_string()).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 27
[INFO] [stderr]    --> src/main.rs:295:1
[INFO] [stderr]     |
[INFO] [stderr] 295 | / fn resolve_features(cr: &Crate, packages: &mut BTreeMap<Crate, Meta>) {
[INFO] [stderr] 296 | |     debug!("cr: {:?}", cr);
[INFO] [stderr] 297 | |     if cr.name.len() == 0 {
[INFO] [stderr] 298 | |         return
[INFO] [stderr] ...   |
[INFO] [stderr] 389 | |
[INFO] [stderr] 390 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:297:8
[INFO] [stderr]     |
[INFO] [stderr] 297 |     if cr.name.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cr.name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 10.35s
[INFO] running `"docker" "inspect" "ae0115674dbb02f46fac6176b89f622833b239b5e1c1e7fbe48605cda29215ea"`
[INFO] running `"docker" "rm" "-f" "ae0115674dbb02f46fac6176b89f622833b239b5e1c1e7fbe48605cda29215ea"`
[INFO] [stdout] ae0115674dbb02f46fac6176b89f622833b239b5e1c1e7fbe48605cda29215ea