[INFO] crate gelf 0.3.1 is already in cache
[INFO] extracting crate gelf 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/gelf/0.3.1
[INFO] extracting crate gelf 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gelf/0.3.1
[INFO] validating manifest of gelf-0.3.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of gelf-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing gelf-0.3.1
[INFO] finished frobbing gelf-0.3.1
[INFO] frobbed toml for gelf-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/gelf/0.3.1/Cargo.toml
[INFO] started frobbing gelf-0.3.1
[INFO] finished frobbing gelf-0.3.1
[INFO] frobbed toml for gelf-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gelf/0.3.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting gelf-0.3.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gelf/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3fb6068d0f48b4f91ec35b9865a107b036d4d8bcb05e259fe51993ce794e8c2e
[INFO] running `"docker" "start" "-a" "3fb6068d0f48b4f91ec35b9865a107b036d4d8bcb05e259fe51993ce794e8c2e"`
[INFO] [stderr]     Checking gelf v0.3.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/backends/udp.rs:65:13
[INFO] [stderr]    |
[INFO] [stderr] 65 |             socket: socket,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/backends/udp.rs:67:13
[INFO] [stderr]    |
[INFO] [stderr] 67 |             chunk_size: chunk_size,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunk_size`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/logger.rs:49:13
[INFO] [stderr]    |
[INFO] [stderr] 49 |             backend: backend,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `backend`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/chunked_message.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             chunk_size: chunk_size,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunk_size`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/backends/udp.rs:65:13
[INFO] [stderr]    |
[INFO] [stderr] 65 |             socket: socket,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/backends/udp.rs:67:13
[INFO] [stderr]    |
[INFO] [stderr] 67 |             chunk_size: chunk_size,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunk_size`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/logger.rs:49:13
[INFO] [stderr]    |
[INFO] [stderr] 49 |             backend: backend,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `backend`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/chunked_message.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             chunk_size: chunk_size,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunk_size`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/logger.rs:162:13
[INFO] [stderr]     |
[INFO] [stderr] 162 |             ()
[INFO] [stderr]     |             ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/message/chunked_message.rs:168:9
[INFO] [stderr]     |
[INFO] [stderr] 168 |         return ChunkedMessageId::from_bytes(bytes);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ChunkedMessageId::from_bytes(bytes)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/message/chunked_message.rs:224:13
[INFO] [stderr]     |
[INFO] [stderr] 224 |             0xffffffffffffffff,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/message/chunked_message.rs:225:13
[INFO] [stderr]     |
[INFO] [stderr] 225 |             0x0000000000000000,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/message/chunked_message.rs:226:13
[INFO] [stderr]     |
[INFO] [stderr] 226 |             0xaaaaaaaaaaaaaaaa,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: consider: `0xaaaa_aaaa_aaaa_aaaa`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/message/chunked_message.rs:227:13
[INFO] [stderr]     |
[INFO] [stderr] 227 |             0x5555555555555555,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: consider: `0x5555_5555_5555_5555`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/message/chunked_message.rs:228:13
[INFO] [stderr]     |
[INFO] [stderr] 228 |             0x0001020304050607,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: consider: `0x0001_0203_0405_0607`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/message/chunked_message.rs:229:13
[INFO] [stderr]     |
[INFO] [stderr] 229 |             0x0706050403020100,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: consider: `0x0706_0504_0302_0100`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/message/chunked_message.rs:230:13
[INFO] [stderr]     |
[INFO] [stderr] 230 |             0x0010203040506070,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: consider: `0x0010_2030_4050_6070`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/message/chunked_message.rs:231:13
[INFO] [stderr]     |
[INFO] [stderr] 231 |             0x7060504030201000,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: consider: `0x7060_5040_3020_1000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/message/chunked_message.rs:311:34
[INFO] [stderr]     |
[INFO] [stderr] 311 |         chunking(CHUNK_SIZE_WAN, 100000);
[INFO] [stderr]     |                                  ^^^^^^ help: consider: `100_000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/logger.rs:162:13
[INFO] [stderr]     |
[INFO] [stderr] 162 |             ()
[INFO] [stderr]     |             ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/message/chunked_message.rs:168:9
[INFO] [stderr]     |
[INFO] [stderr] 168 |         return ChunkedMessageId::from_bytes(bytes);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ChunkedMessageId::from_bytes(bytes)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `backends::null::NullBackend`
[INFO] [stderr]   --> src/backends/null.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | /     pub fn new() -> NullBackend {
[INFO] [stderr] 11 | |         NullBackend {}
[INFO] [stderr] 12 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 6  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/backends/udp.rs:43:14
[INFO] [stderr]    |
[INFO] [stderr] 43 |               .ok_or(
[INFO] [stderr]    |  ______________^
[INFO] [stderr] 44 | |                 format_err!("Invalid destination server address",)
[INFO] [stderr] 45 | |                     .context(Error::BackendCreationFailed),
[INFO] [stderr] 46 | |             )?;
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 43 |             .ok_or_else(|| format_err!("Invalid destination server address",)
[INFO] [stderr] 44 |                     .context(Error::BackendCreationFailed))?;
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/level.rs:36:29
[INFO] [stderr]    |
[INFO] [stderr] 36 |     pub fn from_rust(level: &LogLevel) -> Level {
[INFO] [stderr]    |                             ^^^^^^^^^ help: consider passing by value instead: `LogLevel`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/level.rs:46:20
[INFO] [stderr]    |
[INFO] [stderr] 46 |     pub fn to_rust(&self) -> LogLevel {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/logger.rs:35:14
[INFO] [stderr]    |
[INFO] [stderr] 35 |               .ok_or(
[INFO] [stderr]    |  ______________^
[INFO] [stderr] 36 | |                 format_err!("Failed to determine local hostname")
[INFO] [stderr] 37 | |                     .context(Error::LoggerCreateFailed)
[INFO] [stderr] 38 | |                     .into(),
[INFO] [stderr] 39 | |             )
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 35 |             .ok_or_else(|| format_err!("Failed to determine local hostname")
[INFO] [stderr] 36 |                     .context(Error::LoggerCreateFailed)
[INFO] [stderr] 37 |                     .into())
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/message/chunked_message.rs:31:17
[INFO] [stderr]    |
[INFO] [stderr] 31 |     pub fn size(&self) -> u16 {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/message/chunked_message.rs:63:20
[INFO] [stderr]    |
[INFO] [stderr] 63 |         let size = chunk_size.size() as u64;
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(chunk_size.size())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/message/chunked_message.rs:81:41
[INFO] [stderr]    |
[INFO] [stderr] 81 |             self.payload.len() as u64 + self.num_chunks as u64 * CHUNK_OVERHEAD as u64
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.num_chunks)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/message/chunked_message.rs:81:66
[INFO] [stderr]    |
[INFO] [stderr] 81 |             self.payload.len() as u64 + self.num_chunks as u64 * CHUNK_OVERHEAD as u64
[INFO] [stderr]    |                                                                  ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(CHUNK_OVERHEAD)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/message/chunked_message.rs:124:28
[INFO] [stderr]     |
[INFO] [stderr] 124 |         let slice_start = (self.chunk_num as u32 * chunk_size as u32) as usize;
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chunk_num)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/message/chunked_message.rs:124:52
[INFO] [stderr]     |
[INFO] [stderr] 124 |         let slice_start = (self.chunk_num as u32 * chunk_size as u32) as usize;
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^ help: try: `u32::from(chunk_size)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `b` is only used to index `bytes`.
[INFO] [stderr]    --> src/message/chunked_message.rs:164:18
[INFO] [stderr]     |
[INFO] [stderr] 164 |         for b in 0..8 {
[INFO] [stderr]     |                  ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 164 |         for <item> in &mut bytes {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/message/chunked_message.rs:194:54
[INFO] [stderr]     |
[INFO] [stderr] 194 |         self.0.iter().fold(0_u64, |id, &i| id << 8 | i as u64)
[INFO] [stderr]     |                                                      ^^^^^^^^ help: try: `u64::from(i)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/message/chunked_message.rs:216:51
[INFO] [stderr]     |
[INFO] [stderr] 216 |             let id = ChunkedMessageId::from_bytes(raw_id.clone());
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^^ help: try dereferencing it: `*raw_id`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/message/chunked_message.rs:253:55
[INFO] [stderr]     |
[INFO] [stderr] 253 |         assert_eq!(msg_2_chunks.len() as u32, 2 + 2 * CHUNK_OVERHEAD as u32);
[INFO] [stderr]     |                                                       ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(CHUNK_OVERHEAD)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/message/chunked_message.rs:256:25
[INFO] [stderr]     |
[INFO] [stderr] 256 |             128 + 128 * (CHUNK_OVERHEAD as u64)
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(CHUNK_OVERHEAD)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/message/chunked_message.rs:318:25
[INFO] [stderr]     |
[INFO] [stderr] 318 |             (msg_size / chunk_size as u32) as u8 + 1,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^ help: try: `u32::from(chunk_size)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/message/chunked_message.rs:357:32
[INFO] [stderr]     |
[INFO] [stderr] 357 |             let first_index = (counter as u32 * chunk_size as u32) as usize;
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^ help: try: `u32::from(counter)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/message/chunked_message.rs:357:49
[INFO] [stderr]     |
[INFO] [stderr] 357 |             let first_index = (counter as u32 * chunk_size as u32) as usize;
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^ help: try: `u32::from(chunk_size)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/message/chunked_message.rs:359:35
[INFO] [stderr]     |
[INFO] [stderr] 359 |                 (::std::cmp::min((counter as u32 + 1) * chunk_size as u32, msg_size) - 1) as usize;
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^ help: try: `u32::from(counter)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/message/chunked_message.rs:359:57
[INFO] [stderr]     |
[INFO] [stderr] 359 |                 (::std::cmp::min((counter as u32 + 1) * chunk_size as u32, msg_size) - 1) as usize;
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^^^^^ help: try: `u32::from(chunk_size)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/message/compression.rs:24:21
[INFO] [stderr]    |
[INFO] [stderr] 24 |     pub fn compress(&self, message: &WireMessage) -> Result<Vec<u8>> {
[INFO] [stderr]    |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/message/mod.rs:162:30
[INFO] [stderr]     |
[INFO] [stderr] 162 |         self.metadata.insert(key.into(), value.into());
[INFO] [stderr]     |                              ^^^^^^^^^^ help: consider removing `.into()`: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/message/mod.rs:184:79
[INFO] [stderr]     |
[INFO] [stderr] 184 |         let _ = msg.set_metadata("line", record.line().map(|v| v.to_string()).unwrap_or("(none)".into()));
[INFO] [stderr]     |                                                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "(none)".into())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `backends::null::NullBackend`
[INFO] [stderr]   --> src/backends/null.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | /     pub fn new() -> NullBackend {
[INFO] [stderr] 11 | |         NullBackend {}
[INFO] [stderr] 12 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 6  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/backends/udp.rs:43:14
[INFO] [stderr]    |
[INFO] [stderr] 43 |               .ok_or(
[INFO] [stderr]    |  ______________^
[INFO] [stderr] 44 | |                 format_err!("Invalid destination server address",)
[INFO] [stderr] 45 | |                     .context(Error::BackendCreationFailed),
[INFO] [stderr] 46 | |             )?;
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 43 |             .ok_or_else(|| format_err!("Invalid destination server address",)
[INFO] [stderr] 44 |                     .context(Error::BackendCreationFailed))?;
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/level.rs:36:29
[INFO] [stderr]    |
[INFO] [stderr] 36 |     pub fn from_rust(level: &LogLevel) -> Level {
[INFO] [stderr]    |                             ^^^^^^^^^ help: consider passing by value instead: `LogLevel`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/level.rs:46:20
[INFO] [stderr]    |
[INFO] [stderr] 46 |     pub fn to_rust(&self) -> LogLevel {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/logger.rs:35:14
[INFO] [stderr]    |
[INFO] [stderr] 35 |               .ok_or(
[INFO] [stderr]    |  ______________^
[INFO] [stderr] 36 | |                 format_err!("Failed to determine local hostname")
[INFO] [stderr] 37 | |                     .context(Error::LoggerCreateFailed)
[INFO] [stderr] 38 | |                     .into(),
[INFO] [stderr] 39 | |             )
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 35 |             .ok_or_else(|| format_err!("Failed to determine local hostname")
[INFO] [stderr] 36 |                     .context(Error::LoggerCreateFailed)
[INFO] [stderr] 37 |                     .into())
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/message/chunked_message.rs:31:17
[INFO] [stderr]    |
[INFO] [stderr] 31 |     pub fn size(&self) -> u16 {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/message/chunked_message.rs:63:20
[INFO] [stderr]    |
[INFO] [stderr] 63 |         let size = chunk_size.size() as u64;
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(chunk_size.size())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/message/chunked_message.rs:81:41
[INFO] [stderr]    |
[INFO] [stderr] 81 |             self.payload.len() as u64 + self.num_chunks as u64 * CHUNK_OVERHEAD as u64
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.num_chunks)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/message/chunked_message.rs:81:66
[INFO] [stderr]    |
[INFO] [stderr] 81 |             self.payload.len() as u64 + self.num_chunks as u64 * CHUNK_OVERHEAD as u64
[INFO] [stderr]    |                                                                  ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(CHUNK_OVERHEAD)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/message/chunked_message.rs:124:28
[INFO] [stderr]     |
[INFO] [stderr] 124 |         let slice_start = (self.chunk_num as u32 * chunk_size as u32) as usize;
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chunk_num)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/message/chunked_message.rs:124:52
[INFO] [stderr]     |
[INFO] [stderr] 124 |         let slice_start = (self.chunk_num as u32 * chunk_size as u32) as usize;
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^ help: try: `u32::from(chunk_size)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `b` is only used to index `bytes`.
[INFO] [stderr]    --> src/message/chunked_message.rs:164:18
[INFO] [stderr]     |
[INFO] [stderr] 164 |         for b in 0..8 {
[INFO] [stderr]     |                  ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 164 |         for <item> in &mut bytes {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/message/chunked_message.rs:194:54
[INFO] [stderr]     |
[INFO] [stderr] 194 |         self.0.iter().fold(0_u64, |id, &i| id << 8 | i as u64)
[INFO] [stderr]     |                                                      ^^^^^^^^ help: try: `u64::from(i)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/message/compression.rs:24:21
[INFO] [stderr]    |
[INFO] [stderr] 24 |     pub fn compress(&self, message: &WireMessage) -> Result<Vec<u8>> {
[INFO] [stderr]    |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/message/mod.rs:162:30
[INFO] [stderr]     |
[INFO] [stderr] 162 |         self.metadata.insert(key.into(), value.into());
[INFO] [stderr]     |                              ^^^^^^^^^^ help: consider removing `.into()`: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/message/mod.rs:184:79
[INFO] [stderr]     |
[INFO] [stderr] 184 |         let _ = msg.set_metadata("line", record.line().map(|v| v.to_string()).unwrap_or("(none)".into()));
[INFO] [stderr]     |                                                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "(none)".into())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> examples/shared/mod.rs:27:70
[INFO] [stderr]    |
[INFO] [stderr] 27 |             let id: u64 = buf[2..10].iter().fold(0, |x, &i| x << 8 | i as u64);
[INFO] [stderr]    |                                                                      ^^^^^^^^ help: try: `u64::from(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> examples/shared/mod.rs:27:70
[INFO] [stderr]    |
[INFO] [stderr] 27 |             let id: u64 = buf[2..10].iter().fold(0, |x, &i| x << 8 | i as u64);
[INFO] [stderr]    |                                                                      ^^^^^^^^ help: try: `u64::from(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.87s
[INFO] running `"docker" "inspect" "3fb6068d0f48b4f91ec35b9865a107b036d4d8bcb05e259fe51993ce794e8c2e"`
[INFO] running `"docker" "rm" "-f" "3fb6068d0f48b4f91ec35b9865a107b036d4d8bcb05e259fe51993ce794e8c2e"`
[INFO] [stdout] 3fb6068d0f48b4f91ec35b9865a107b036d4d8bcb05e259fe51993ce794e8c2e