[INFO] crate gedcomx_date 0.0.1 is already in cache [INFO] extracting crate gedcomx_date 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/gedcomx_date/0.0.1 [INFO] extracting crate gedcomx_date 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gedcomx_date/0.0.1 [INFO] validating manifest of gedcomx_date-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gedcomx_date-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gedcomx_date-0.0.1 [INFO] finished frobbing gedcomx_date-0.0.1 [INFO] frobbed toml for gedcomx_date-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/gedcomx_date/0.0.1/Cargo.toml [INFO] started frobbing gedcomx_date-0.0.1 [INFO] finished frobbing gedcomx_date-0.0.1 [INFO] frobbed toml for gedcomx_date-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gedcomx_date/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gedcomx_date-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gedcomx_date/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 97f922b9fde5dc577b7fc813f8226cd842c2bb362f24710944efe0c372036fb0 [INFO] running `"docker" "start" "-a" "97f922b9fde5dc577b7fc813f8226cd842c2bb362f24710944efe0c372036fb0"` [INFO] [stderr] Checking gedcomx_date v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/parsers/range.rs:17:81 [INFO] [stderr] | [INFO] [stderr] 17 | || GedcomxDate::Range(Range {start: dates.0, end: dates.1, approximate: match a { Some(_) => true, None => false} }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `a.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/parsers/simple.rs:118:26 [INFO] [stderr] | [INFO] [stderr] 118 | approximate: match a { Some(_) => true, None => false} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `a.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:178:25 [INFO] [stderr] | [INFO] [stderr] 178 | Error(_) => Err(format!("Parsing error")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Parsing error".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:179:30 [INFO] [stderr] | [INFO] [stderr] 179 | Incomplete(_) => Err(format!("Parsing error")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Parsing error".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/parsers/range.rs:17:81 [INFO] [stderr] | [INFO] [stderr] 17 | || GedcomxDate::Range(Range {start: dates.0, end: dates.1, approximate: match a { Some(_) => true, None => false} }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `a.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/parsers/simple.rs:118:26 [INFO] [stderr] | [INFO] [stderr] 118 | approximate: match a { Some(_) => true, None => false} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `a.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:178:25 [INFO] [stderr] | [INFO] [stderr] 178 | Error(_) => Err(format!("Parsing error")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Parsing error".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:179:30 [INFO] [stderr] | [INFO] [stderr] 179 | Incomplete(_) => Err(format!("Parsing error")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Parsing error".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/simple_date.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / match parse("+1000").unwrap() { [INFO] [stderr] 18 | | GedcomxDate::Simple(date) => { [INFO] [stderr] 19 | | assert_eq!(date.date.year, 1000); [INFO] [stderr] 20 | | assert_eq!(date.date.month, None); [INFO] [stderr] ... | [INFO] [stderr] 24 | | _ => {} [INFO] [stderr] 25 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | if let GedcomxDate::Simple(date) = parse("+1000").unwrap() { [INFO] [stderr] 18 | assert_eq!(date.date.year, 1000); [INFO] [stderr] 19 | assert_eq!(date.date.month, None); [INFO] [stderr] 20 | assert_eq!(date.date.day, None); [INFO] [stderr] 21 | assert_eq!(date.time, None); [INFO] [stderr] 22 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.66s [INFO] running `"docker" "inspect" "97f922b9fde5dc577b7fc813f8226cd842c2bb362f24710944efe0c372036fb0"` [INFO] running `"docker" "rm" "-f" "97f922b9fde5dc577b7fc813f8226cd842c2bb362f24710944efe0c372036fb0"` [INFO] [stdout] 97f922b9fde5dc577b7fc813f8226cd842c2bb362f24710944efe0c372036fb0