[INFO] crate gdpr_consent 0.4.0 is already in cache [INFO] extracting crate gdpr_consent 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/gdpr_consent/0.4.0 [INFO] extracting crate gdpr_consent 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gdpr_consent/0.4.0 [INFO] validating manifest of gdpr_consent-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gdpr_consent-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gdpr_consent-0.4.0 [INFO] finished frobbing gdpr_consent-0.4.0 [INFO] frobbed toml for gdpr_consent-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/gdpr_consent/0.4.0/Cargo.toml [INFO] started frobbing gdpr_consent-0.4.0 [INFO] finished frobbing gdpr_consent-0.4.0 [INFO] frobbed toml for gdpr_consent-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gdpr_consent/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gdpr_consent-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gdpr_consent/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8323fa999575df8db788de19dfcda2efc74856a043c66e390f3076e0cacbaf26 [INFO] running `"docker" "start" "-a" "8323fa999575df8db788de19dfcda2efc74856a043c66e390f3076e0cacbaf26"` [INFO] [stderr] Checking bitstream-io v0.8.2 [INFO] [stderr] Checking gdpr_consent v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | created: created, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `created` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | last_updated: last_updated, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_updated` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | cmp_id: cmp_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cmp_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | cmp_version: cmp_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cmp_version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | consent_screen: consent_screen, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `consent_screen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | consent_language: consent_language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `consent_language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | vendor_list_version: vendor_list_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vendor_list_version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | purposes_allowed: purposes_allowed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `purposes_allowed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | max_vendor_id: max_vendor_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_vendor_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | vendor_consent: vendor_consent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vendor_consent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:419:13 [INFO] [stderr] | [INFO] [stderr] 419 | vendor_consent: vendor_consent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vendor_consent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | created: created, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `created` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | last_updated: last_updated, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_updated` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | cmp_id: cmp_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cmp_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | cmp_version: cmp_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cmp_version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | consent_screen: consent_screen, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `consent_screen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | consent_language: consent_language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `consent_language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | vendor_list_version: vendor_list_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vendor_list_version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | purposes_allowed: purposes_allowed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `purposes_allowed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | max_vendor_id: max_vendor_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_vendor_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | vendor_consent: vendor_consent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vendor_consent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vendor_consent.rs:419:13 [INFO] [stderr] | [INFO] [stderr] 419 | vendor_consent: vendor_consent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vendor_consent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vendor_consent.rs:417:52 [INFO] [stderr] | [INFO] [stderr] 417 | purposes_allowed: BitSet::from_bytes(&[0b11100000, 0b00000000, 0b00000000]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vendor_consent.rs:417:64 [INFO] [stderr] | [INFO] [stderr] 417 | purposes_allowed: BitSet::from_bytes(&[0b11100000, 0b00000000, 0b00000000]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vendor_consent.rs:417:76 [INFO] [stderr] | [INFO] [stderr] 417 | purposes_allowed: BitSet::from_bytes(&[0b11100000, 0b00000000, 0b00000000]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vendor_consent.rs:431:62 [INFO] [stderr] | [INFO] [stderr] 431 | let expected_purposes_allowed = BitSet::from_bytes(&[0b11100000, 0b00000000, 0b00000000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vendor_consent.rs:431:74 [INFO] [stderr] | [INFO] [stderr] 431 | let expected_purposes_allowed = BitSet::from_bytes(&[0b11100000, 0b00000000, 0b00000000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vendor_consent.rs:431:86 [INFO] [stderr] | [INFO] [stderr] 431 | let expected_purposes_allowed = BitSet::from_bytes(&[0b11100000, 0b00000000, 0b00000000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/vendor_consent.rs:209:42 [INFO] [stderr] | [INFO] [stderr] 209 | buf.push(reader.read::(6)? + 'a' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `language_bytes` [INFO] [stderr] --> src/vendor_consent.rs:265:14 [INFO] [stderr] | [INFO] [stderr] 265 | for i in 0..=1 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 265 | for (i, ) in language_bytes.iter().enumerate().take(1 + 1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/vendor_consent.rs:266:32 [INFO] [stderr] | [INFO] [stderr] 266 | if language_bytes[i] < ('a' as u8) || language_bytes[i] > ('z' as u8) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/vendor_consent.rs:266:67 [INFO] [stderr] | [INFO] [stderr] 266 | if language_bytes[i] < ('a' as u8) || language_bytes[i] > ('z' as u8) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'z' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/vendor_consent.rs:276:38 [INFO] [stderr] | [INFO] [stderr] 276 | let (range, range_encoded_len) = match default_consent { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 277 | | false => create_true_range(&v.vendor_consent), [INFO] [stderr] 278 | | true => create_false_range(&v.vendor_consent, v.max_vendor_id), [INFO] [stderr] 279 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if default_consent { create_false_range(&v.vendor_consent, v.max_vendor_id) } else { create_true_range(&v.vendor_consent) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/vendor_consent.rs:295:19 [INFO] [stderr] | [INFO] [stderr] 295 | + (v.created.timestamp_subsec_millis() / MILLISECS_IN_DECISEC) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(v.created.timestamp_subsec_millis() / MILLISECS_IN_DECISEC)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/vendor_consent.rs:300:19 [INFO] [stderr] | [INFO] [stderr] 300 | + (v.last_updated.timestamp_subsec_millis() / MILLISECS_IN_DECISEC) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(v.last_updated.timestamp_subsec_millis() / MILLISECS_IN_DECISEC)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/vendor_consent.rs:306:33 [INFO] [stderr] | [INFO] [stderr] 306 | writer.write(6, b - ('a' as u8))?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/vendor_consent.rs:351:8 [INFO] [stderr] | [INFO] [stderr] 351 | if !start.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `start.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/vendor_consent.rs:209:42 [INFO] [stderr] | [INFO] [stderr] 209 | buf.push(reader.read::(6)? + 'a' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `language_bytes` [INFO] [stderr] --> src/vendor_consent.rs:265:14 [INFO] [stderr] | [INFO] [stderr] 265 | for i in 0..=1 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 265 | for (i, ) in language_bytes.iter().enumerate().take(1 + 1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/vendor_consent.rs:266:32 [INFO] [stderr] | [INFO] [stderr] 266 | if language_bytes[i] < ('a' as u8) || language_bytes[i] > ('z' as u8) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/vendor_consent.rs:266:67 [INFO] [stderr] | [INFO] [stderr] 266 | if language_bytes[i] < ('a' as u8) || language_bytes[i] > ('z' as u8) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'z' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/vendor_consent.rs:276:38 [INFO] [stderr] | [INFO] [stderr] 276 | let (range, range_encoded_len) = match default_consent { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 277 | | false => create_true_range(&v.vendor_consent), [INFO] [stderr] 278 | | true => create_false_range(&v.vendor_consent, v.max_vendor_id), [INFO] [stderr] 279 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if default_consent { create_false_range(&v.vendor_consent, v.max_vendor_id) } else { create_true_range(&v.vendor_consent) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/vendor_consent.rs:295:19 [INFO] [stderr] | [INFO] [stderr] 295 | + (v.created.timestamp_subsec_millis() / MILLISECS_IN_DECISEC) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(v.created.timestamp_subsec_millis() / MILLISECS_IN_DECISEC)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/vendor_consent.rs:300:19 [INFO] [stderr] | [INFO] [stderr] 300 | + (v.last_updated.timestamp_subsec_millis() / MILLISECS_IN_DECISEC) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(v.last_updated.timestamp_subsec_millis() / MILLISECS_IN_DECISEC)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/vendor_consent.rs:306:33 [INFO] [stderr] | [INFO] [stderr] 306 | writer.write(6, b - ('a' as u8))?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/vendor_consent.rs:351:8 [INFO] [stderr] | [INFO] [stderr] 351 | if !start.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `start.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.46s [INFO] running `"docker" "inspect" "8323fa999575df8db788de19dfcda2efc74856a043c66e390f3076e0cacbaf26"` [INFO] running `"docker" "rm" "-f" "8323fa999575df8db788de19dfcda2efc74856a043c66e390f3076e0cacbaf26"` [INFO] [stdout] 8323fa999575df8db788de19dfcda2efc74856a043c66e390f3076e0cacbaf26