[INFO] crate gdnative_bindings_generator 0.2.0 is already in cache [INFO] extracting crate gdnative_bindings_generator 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/gdnative_bindings_generator/0.2.0 [INFO] extracting crate gdnative_bindings_generator 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gdnative_bindings_generator/0.2.0 [INFO] validating manifest of gdnative_bindings_generator-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gdnative_bindings_generator-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gdnative_bindings_generator-0.2.0 [INFO] finished frobbing gdnative_bindings_generator-0.2.0 [INFO] frobbed toml for gdnative_bindings_generator-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/gdnative_bindings_generator/0.2.0/Cargo.toml [INFO] started frobbing gdnative_bindings_generator-0.2.0 [INFO] finished frobbing gdnative_bindings_generator-0.2.0 [INFO] frobbed toml for gdnative_bindings_generator-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gdnative_bindings_generator/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gdnative_bindings_generator-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gdnative_bindings_generator/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9440ed1a043d47006e141c207d5d3a6fa0a6c89c35148631af9bedb02d31788e [INFO] running `"docker" "start" "-a" "9440ed1a043d47006e141c207d5d3a6fa0a6c89c35148631af9bedb02d31788e"` [INFO] [stderr] Checking gdnative_bindings_generator v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/api.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/api.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/api.rs:45:16 [INFO] [stderr] | [INFO] [stderr] 45 | if &class.name == name { [INFO] [stderr] | -----------^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `class.name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/api.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | / match self { [INFO] [stderr] 239 | | &Ty::Void => Some(String::from("()")), [INFO] [stderr] 240 | | &Ty::String => Some(String::from("GodotString")), [INFO] [stderr] 241 | | &Ty::F64 => Some(String::from("f64")), [INFO] [stderr] ... | [INFO] [stderr] 269 | | &Ty::Object(ref name) => Some(format!("Option<{}>", name)), [INFO] [stderr] 270 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 238 | match *self { [INFO] [stderr] 239 | Ty::Void => Some(String::from("()")), [INFO] [stderr] 240 | Ty::String => Some(String::from("GodotString")), [INFO] [stderr] 241 | Ty::F64 => Some(String::from("f64")), [INFO] [stderr] 242 | Ty::I64 => Some(String::from("i64")), [INFO] [stderr] 243 | Ty::Bool => Some(String::from("bool")), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/api.rs:268:41 [INFO] [stderr] | [INFO] [stderr] 268 | &Ty::Enum(ref name) => Some(String::from(name.clone())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `name.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/api.rs:274:9 [INFO] [stderr] | [INFO] [stderr] 274 | / match self { [INFO] [stderr] 275 | | &Ty::Void => None, [INFO] [stderr] 276 | | &Ty::String => Some(String::from("sys::godot_string")), [INFO] [stderr] 277 | | &Ty::F64 => Some(String::from("sys::godot_real")), [INFO] [stderr] ... | [INFO] [stderr] 305 | | &Ty::Object(_) => Some(String::from("sys::godot_object")), [INFO] [stderr] 306 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 274 | match *self { [INFO] [stderr] 275 | Ty::Void => None, [INFO] [stderr] 276 | Ty::String => Some(String::from("sys::godot_string")), [INFO] [stderr] 277 | Ty::F64 => Some(String::from("sys::godot_real")), [INFO] [stderr] 278 | Ty::I64 => Some(String::from("sys::godot_int")), [INFO] [stderr] 279 | Ty::Bool => Some(String::from("sys::godot_bool")), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/api.rs:45:16 [INFO] [stderr] | [INFO] [stderr] 45 | if &class.name == name { [INFO] [stderr] | -----------^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `class.name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/methods.rs:323:5 [INFO] [stderr] | [INFO] [stderr] 323 | / match ty { [INFO] [stderr] 324 | | &Ty::Bool [INFO] [stderr] 325 | | | &Ty::F64 [INFO] [stderr] 326 | | | &Ty::I64 [INFO] [stderr] ... | [INFO] [stderr] 361 | | _ => {} [INFO] [stderr] 362 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 323 | match *ty { [INFO] [stderr] 324 | Ty::Bool [INFO] [stderr] 325 | | Ty::F64 [INFO] [stderr] 326 | | Ty::I64 [INFO] [stderr] 327 | | Ty::Vector2 [INFO] [stderr] 328 | | Ty::Vector3 [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/methods.rs:368:5 [INFO] [stderr] | [INFO] [stderr] 368 | / match ty { [INFO] [stderr] 369 | | &Ty::Void => { [INFO] [stderr] 370 | | writeln!(w, r#" [INFO] [stderr] 371 | | let ret_ptr = ptr::null_mut();"#)?; [INFO] [stderr] ... | [INFO] [stderr] 445 | | } [INFO] [stderr] 446 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 368 | match *ty { [INFO] [stderr] 369 | Ty::Void => { [INFO] [stderr] 370 | writeln!(w, r#" [INFO] [stderr] 371 | let ret_ptr = ptr::null_mut();"#)?; [INFO] [stderr] 372 | }, [INFO] [stderr] 373 | Ty::F64 => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/methods.rs:452:5 [INFO] [stderr] | [INFO] [stderr] 452 | / match ty { [INFO] [stderr] 453 | | &Ty::Void => {}, [INFO] [stderr] 454 | | &Ty::F64 [INFO] [stderr] 455 | | | &Ty::I64 [INFO] [stderr] ... | [INFO] [stderr] 524 | | } [INFO] [stderr] 525 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 452 | match *ty { [INFO] [stderr] 453 | Ty::Void => {}, [INFO] [stderr] 454 | Ty::F64 [INFO] [stderr] 455 | | Ty::I64 [INFO] [stderr] 456 | | Ty::Bool [INFO] [stderr] 457 | => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/special_methods.rs:135:44 [INFO] [stderr] | [INFO] [stderr] 135 | let s_name = if class.name.starts_with("_") { [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/api.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | / match self { [INFO] [stderr] 239 | | &Ty::Void => Some(String::from("()")), [INFO] [stderr] 240 | | &Ty::String => Some(String::from("GodotString")), [INFO] [stderr] 241 | | &Ty::F64 => Some(String::from("f64")), [INFO] [stderr] ... | [INFO] [stderr] 269 | | &Ty::Object(ref name) => Some(format!("Option<{}>", name)), [INFO] [stderr] 270 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 238 | match *self { [INFO] [stderr] 239 | Ty::Void => Some(String::from("()")), [INFO] [stderr] 240 | Ty::String => Some(String::from("GodotString")), [INFO] [stderr] 241 | Ty::F64 => Some(String::from("f64")), [INFO] [stderr] 242 | Ty::I64 => Some(String::from("i64")), [INFO] [stderr] 243 | Ty::Bool => Some(String::from("bool")), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/api.rs:268:41 [INFO] [stderr] | [INFO] [stderr] 268 | &Ty::Enum(ref name) => Some(String::from(name.clone())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `name.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/api.rs:274:9 [INFO] [stderr] | [INFO] [stderr] 274 | / match self { [INFO] [stderr] 275 | | &Ty::Void => None, [INFO] [stderr] 276 | | &Ty::String => Some(String::from("sys::godot_string")), [INFO] [stderr] 277 | | &Ty::F64 => Some(String::from("sys::godot_real")), [INFO] [stderr] ... | [INFO] [stderr] 305 | | &Ty::Object(_) => Some(String::from("sys::godot_object")), [INFO] [stderr] 306 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 274 | match *self { [INFO] [stderr] 275 | Ty::Void => None, [INFO] [stderr] 276 | Ty::String => Some(String::from("sys::godot_string")), [INFO] [stderr] 277 | Ty::F64 => Some(String::from("sys::godot_real")), [INFO] [stderr] 278 | Ty::I64 => Some(String::from("sys::godot_int")), [INFO] [stderr] 279 | Ty::Bool => Some(String::from("sys::godot_bool")), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/methods.rs:323:5 [INFO] [stderr] | [INFO] [stderr] 323 | / match ty { [INFO] [stderr] 324 | | &Ty::Bool [INFO] [stderr] 325 | | | &Ty::F64 [INFO] [stderr] 326 | | | &Ty::I64 [INFO] [stderr] ... | [INFO] [stderr] 361 | | _ => {} [INFO] [stderr] 362 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 323 | match *ty { [INFO] [stderr] 324 | Ty::Bool [INFO] [stderr] 325 | | Ty::F64 [INFO] [stderr] 326 | | Ty::I64 [INFO] [stderr] 327 | | Ty::Vector2 [INFO] [stderr] 328 | | Ty::Vector3 [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/methods.rs:368:5 [INFO] [stderr] | [INFO] [stderr] 368 | / match ty { [INFO] [stderr] 369 | | &Ty::Void => { [INFO] [stderr] 370 | | writeln!(w, r#" [INFO] [stderr] 371 | | let ret_ptr = ptr::null_mut();"#)?; [INFO] [stderr] ... | [INFO] [stderr] 445 | | } [INFO] [stderr] 446 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 368 | match *ty { [INFO] [stderr] 369 | Ty::Void => { [INFO] [stderr] 370 | writeln!(w, r#" [INFO] [stderr] 371 | let ret_ptr = ptr::null_mut();"#)?; [INFO] [stderr] 372 | }, [INFO] [stderr] 373 | Ty::F64 => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/methods.rs:452:5 [INFO] [stderr] | [INFO] [stderr] 452 | / match ty { [INFO] [stderr] 453 | | &Ty::Void => {}, [INFO] [stderr] 454 | | &Ty::F64 [INFO] [stderr] 455 | | | &Ty::I64 [INFO] [stderr] ... | [INFO] [stderr] 524 | | } [INFO] [stderr] 525 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 452 | match *ty { [INFO] [stderr] 453 | Ty::Void => {}, [INFO] [stderr] 454 | Ty::F64 [INFO] [stderr] 455 | | Ty::I64 [INFO] [stderr] 456 | | Ty::Bool [INFO] [stderr] 457 | => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/special_methods.rs:135:44 [INFO] [stderr] | [INFO] [stderr] 135 | let s_name = if class.name.starts_with("_") { [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/bin/dependencies.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/bin/dependencies.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.71s [INFO] running `"docker" "inspect" "9440ed1a043d47006e141c207d5d3a6fa0a6c89c35148631af9bedb02d31788e"` [INFO] running `"docker" "rm" "-f" "9440ed1a043d47006e141c207d5d3a6fa0a6c89c35148631af9bedb02d31788e"` [INFO] [stdout] 9440ed1a043d47006e141c207d5d3a6fa0a6c89c35148631af9bedb02d31788e